Re: [PATCH] ARM: S5P: Dynamicly numbered GPIO interrupt support

2010-05-14 Thread Ben Dooks
On Fri, May 14, 2010 at 11:10:19AM +0200, Marek Szyprowski wrote: > Hello, > > On Friday, May 14, 2010 10:40 AM Ben Dooks wrote: > > > Add support for GPIO interrupts where the interrupt number > > is dynamically allocated at first request from gpiolib. > > > > This method is employed as the new

RE: [PATCH v2] ARM: S5P: Add System Timer

2010-05-14 Thread Lukasz Majewski
Hello, I've following comments: > -Original Message- > From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung- > soc-ow...@vger.kernel.org] On Behalf Of Kukjin Kim > Sent: Friday, May 14, 2010 10:52 AM > To: linux-arm-ker...@lists.infradead.org; linux-samsung- > s...@vger.ker

Re: [PATCH v2 11/11] Input: s3c24xx_ts - Uses Feature field instead TYPE for Samsung SoCs

2010-05-14 Thread Kyungmin Park
On Fri, May 14, 2010 at 4:25 PM, Kukjin Kim wrote: > From: Naveen Krishna > > This patch removes teh TYPE from touchscreen driver for Samsung SoCs > and uses a Feature bit field instead. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Kukjin Kim > --- >  drivers/input/touchscreen/s3c2410_

RE: [PATCH v4] ARM: S5PV210: Add Ext interrupt support.

2010-05-14 Thread Kukjin Kim
Marek Szyprowski wrote: > > Hello, > > On Friday, May 14, 2010 10:36 AM Kukjin Kim wrote: > > > From: Jongpill Lee > > > > Add support for external interrupts on v210. > > > > Signed-off-by: Jongpill Lee > > Signed-off-by: Pannaga Bhushan > > Signed-off-by: Kukjin Kim > > --- > > arch/arm/m

RE: [PATCH v4] ARM: S5PV210: Add Ext interrupt support.

2010-05-14 Thread Marek Szyprowski
Hello, On Friday, May 14, 2010 10:36 AM Kukjin Kim wrote: > From: Jongpill Lee > > Add support for external interrupts on v210. > > Signed-off-by: Jongpill Lee > Signed-off-by: Pannaga Bhushan > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-s5pv210/Kconfig |1 + > ar

Re: [PATCH] ARM: S5P: Dynamicly numbered GPIO interrupt support

2010-05-14 Thread Jassi Brar
On Fri, May 14, 2010 at 5:40 PM, Ben Dooks wrote: > Add support for GPIO interrupts where the interrupt number > is dynamically allocated at first request from gpiolib. > > This method is employed as the newer SoCs have a large number > of possible interrupt numbers which are very rarely heavily >

Re: Re: Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature

2010-05-14 Thread NAVEEN KRISHNA CHATRADHI
Hi Ben, --- Original Message --- Sender : Ben Dooks Date : May 14, 2010 14:00 (GMT+05:00) Title : Re: Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature On Fri, May 14, 2010 at 08:17:41AM +, NAVEEN KRISHNA CHATRADHI wrote: > Hi Ben, > --- O

RE: [PATCH] ARM: S5P: Dynamicly numbered GPIO interrupt support

2010-05-14 Thread Marek Szyprowski
Hello, On Friday, May 14, 2010 10:40 AM Ben Dooks wrote: > Add support for GPIO interrupts where the interrupt number > is dynamically allocated at first request from gpiolib. > > This method is employed as the newer SoCs have a large number > of possible interrupt numbers which are very rarely

Re: [PATCH v2] ARM: S5P: Add System Timer

2010-05-14 Thread Russell King - ARM Linux
On Fri, May 14, 2010 at 05:51:30PM +0900, Kukjin Kim wrote: > From: Jongpill Lee > > This patch addes system timer for Samsung S5P series SoCs You really should be using the clockevents/clocksource code rather than trying to implement the old gettimeoffset stuff. -- To unsubscribe from this list

RE: [PATCH v2] ARM: S5P: Add System Timer

2010-05-14 Thread Kukjin Kim
Kukjin Kim wrote: > > From: Jongpill Lee Jongpill Lee's e-mail was wrong. boyko@samsung.com is right. > > This patch addes system timer for Samsung S5P series SoCs Regarding using clksrc_src structure in system timer driver, is it ok if we sent separate patch for this. > Signed-off-by: J

Re: Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature

2010-05-14 Thread Ben Dooks
On Fri, May 14, 2010 at 08:17:41AM +, NAVEEN KRISHNA CHATRADHI wrote: > Hi Ben, > --- Original Message --- > Sender : Ben Dooks > Date : May 14, 2010 12:38 (GMT+05:00) > Title : Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it > with > a Feature > > On Fri, M

[PATCH v2] ARM: S5P: Add System Timer

2010-05-14 Thread Kukjin Kim
From: Jongpill Lee This patch addes system timer for Samsung S5P series SoCs Signed-off-by: Jongpill Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p6442/include/mach/tick.h |6 + arch/arm/mach-s5p6442/mach-smdk6442.c |2 +- arch/arm/mach-s5pv210/include/mach/tick.h

[PATCH v4] ARM: S5PV210: Add Ext interrupt support.

2010-05-14 Thread Kukjin Kim
From: Jongpill Lee Add support for external interrupts on v210. Signed-off-by: Jongpill Lee Signed-off-by: Pannaga Bhushan Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pv210/Kconfig |1 + arch/arm/mach-s5pv210/include/mach/irqs.h | 26 +-- arch/arm/mach-s5pv210/i

[PATCH] ARM: S5P: Dynamicly numbered GPIO interrupt support

2010-05-14 Thread Ben Dooks
Add support for GPIO interrupts where the interrupt number is dynamically allocated at first request from gpiolib. This method is employed as the newer SoCs have a large number of possible interrupt numbers which are very rarely heavily used. However, the classic code has always registered all pos

Re: Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature

2010-05-14 Thread NAVEEN KRISHNA CHATRADHI
Hi Ben, --- Original Message --- Sender : Ben Dooks Date : May 14, 2010 12:38 (GMT+05:00) Title : Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature On Fri, May 14, 2010 at 04:25:23PM +0900, Kukjin Kim wrote: > From: Naveen Krishna > > This patch

Re: [PATCH v3 2/2] ARM: S5PV210: Add Ext interrupt support

2010-05-14 Thread Russell King - ARM Linux
On Thu, May 13, 2010 at 08:13:29PM +0900, Kukjin Kim wrote: > +static int s5p_irq_eint_set_type(unsigned int irq, unsigned int type) > +{ > + default: > + printk(KERN_ERR "No such irq type %d", type); > + return -1; Is this really "Operation not permitted" aka -EPERM ?

RE: [PATCH v4] ARM: S5PC100: Pre-requisite clock patch for plat-s5pc1xx to plat-s5p move

2010-05-14 Thread Marek Szyprowski
Hello, On Friday, May 14, 2010 9:27 AM Kukjin Kim wrote: > From: Thomas Abraham > > This is a pre-requisite clock patch for the plat-s5pc1xx to plat-s5p > movement. The patches that perform the movement of the code from > plat-s5pc1xx to plat-s5p (and mach-s5pc100) should also enable the > buil

Re: [PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature

2010-05-14 Thread Ben Dooks
On Fri, May 14, 2010 at 04:25:23PM +0900, Kukjin Kim wrote: > From: Naveen Krishna > > This patch makes changes in the core files to remove the TYPE > and replace it with a Feature bit field instead. not quite what I had in mind, I was just considering replacing the TYPE_S3C in the device_id_tab

[PATCH v4] ARM: S5PC100: Pre-requisite clock patch for plat-s5pc1xx to plat-s5p move

2010-05-14 Thread Kukjin Kim
From: Thomas Abraham This is a pre-requisite clock patch for the plat-s5pc1xx to plat-s5p movement. The patches that perform the movement of the code from plat-s5pc1xx to plat-s5p (and mach-s5pc100) should also enable the build for the mach-s5pc100/clock.c code. Signed-off-by: Thomas Abraham Si

[PATCH v2 10/11] ARM: SAMSUNG: Remove the TYPE and replace it with a Feature

2010-05-14 Thread Kukjin Kim
From: Naveen Krishna This patch makes changes in the core files to remove the TYPE and replace it with a Feature bit field instead. Signed-off-by: Naveen Krishna Ch Signed-off-by: Kukjin Kim --- This 2 new patches which require the previous 9 patches to be applied. (0010 & 0011) This patch s

[PATCH v2 11/11] Input: s3c24xx_ts - Uses Feature field instead TYPE for Samsung SoCs

2010-05-14 Thread Kukjin Kim
From: Naveen Krishna This patch removes teh TYPE from touchscreen driver for Samsung SoCs and uses a Feature bit field instead. Signed-off-by: Naveen Krishna Ch Signed-off-by: Kukjin Kim --- drivers/input/touchscreen/s3c2410_ts.c | 23 +-- 1 files changed, 5 insertions(+

RE: [PATCH v2 8/9] Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver

2010-05-14 Thread Kukjin Kim
Ben Dooks wrote: > > On Thu, May 13, 2010 at 10:07:28PM +0900, Kukjin Kim wrote: > > From: Naveen Krishna > > > > This patch adds TYPE_S5PV210 to the ID table in Samsung touchscreen driver. > > So, we can configure the driver based on the IP level changes. > > Hmm, what changes are those? Would