Re: [PATCH] ARM: S3C64XX: Add s3c64xx support to touchscreen driver

2010-06-28 Thread Maurus Cuelenaere
Op 28-06-10 20:30, Dmitry Torokhov schreef: > On Fri, May 07, 2010 at 01:40:30AM +0100, Ben Dooks wrote: >> On Thu, May 06, 2010 at 11:50:29AM +0200, Maurus Cuelenaere wrote: >>> Add support for the s3c64xx touchscreen to the s3c2410_ts driver, >>> ensuring it compiles and supports the extra featu

Re: [PATCH] ARM: S3C64XX: Add s3c64xx support to touchscreen driver

2010-06-28 Thread Dmitry Torokhov
On Fri, May 07, 2010 at 01:40:30AM +0100, Ben Dooks wrote: > On Thu, May 06, 2010 at 11:50:29AM +0200, Maurus Cuelenaere wrote: > > Add support for the s3c64xx touchscreen to the s3c2410_ts driver, > > ensuring it compiles and supports the extra features such as the > > interrupt generation. > > >

Re: [PATCH 4/8] ARM: S5PV310: Add IRQ support

2010-06-28 Thread Rabin Vincent
On Fri, Jun 25, 2010 at 11:27:13PM +0900, Kukjin Kim wrote: > +static DEFINE_SPINLOCK(irq_controller_lock); Hmm, why is this lock needed? The uses below don't seem like they need locking: > +static void combiner_mask_irq(unsigned int irq) > +{ > + u32 mask = 1 << (irq % 32); > + > + spin

Re: [PATCH 5/8] ARM: S5PV310: Add Timer support

2010-06-28 Thread Rabin Vincent
On Fri, Jun 25, 2010 at 11:27:14PM +0900, Kukjin Kim wrote: > +static void s5pv310_pwm_init(unsigned int pwm_id, unsigned long tcnt) > +{ > + unsigned long tcon; > + > + tcon = __raw_readl(S3C2410_TCON); > + > + /* timers reload after counting zero, so reduce the count by 1 */ > + t

Re: SMDK6440: I2C writes fails

2010-06-28 Thread Mark Brown
On Mon, Jun 28, 2010 at 10:53:18AM +0530, Naveen Krishna Ch wrote: > On 24 June 2010 22:05, Mark Brown wrote: > > That smells rather like a compiler bug to me - the two versions > > ought to be equivalent apart from the ordering of the comparisons. > I'm not sure, I'm using arm-2009q3 toolchain.

[PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-06-28 Thread Joonyoung Shim
This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 +

[PATCH v6 2/3] ARM: S5PV210: Add keypad device helpers

2010-06-28 Thread Joonyoung Shim
This patch adds the keypad device platform helpers for S5PV210 cpu. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- arch/arm/mach-s5pv210/Kconfig|5 +++ arch/arm/mach-s5pv210/Makefile |1 + arch/arm/mach-s5pv210/cpu.c

[PATCH v6 1/3] ARM: SAMSUNG: Add keypad device support

2010-06-28 Thread Joonyoung Shim
This patch adds samsung keypad device definition for samsung cpus. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/Kconfig |5 ++ arch/arm/plat-samsung/Makefile |1 + arch/arm/plat-samsung/dev-keypad.c | 58 +

[PATCH v6 0/3] Add samsung keypad

2010-06-28 Thread Joonyoung Shim
This is patch v6 series to add Samsung keypad. Changes since v1: - Include linux/gpio.h instead of mach/gpio.h - Switch to dev_pm_ops in the samsung keypad driver Changes since v2: - Add keypad device types to remove platform specific #ifdef - Remove unnecessary include and checking codes. - Rena

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

2010-06-28 Thread Maurus Cuelenaere
Op 28-06-10 10:08, Pawel Osciak schreef: > Supports all bpp modes. > > The PRTCON register is used to disable in-hardware updates of registers > that store start and end addresses of framebuffer memory. This prevents > display corruption in case we do not make it before VSYNC with updating > them

Re: [PATCH v4] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-28 Thread Sergei Shtylyov
Hello. Kukjin Kim wrote: From: Abhilash Kesavan Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the earlier patches sent for IDE subsystem. Signed-off-by: Abhilash Kesavan Signed-off-by: Kukjin Kim [...] diff --git a/drivers

Re: [PATCH v4] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-28 Thread Sergei Shtylyov
Hello. Russell King - ARM Linux wrote: How do you think? May I send this to your patch tracking system? Or...how should I handle this? If Jeff is happy, then I'm happy. However, shouldn't it also have Ben's ack? I for one still have comments to be addressed, will post in a jiffy... MB

Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver

2010-06-28 Thread Dmitry Torokhov
On Mon, Jun 28, 2010 at 05:39:39PM +0900, Joonyoung Shim wrote: > Hi, Dmitry. > > On 6/25/2010 5:30 PM, Dmitry Torokhov wrote: > > Hi Joonyoung, > > > > On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote: > >> This patch adds support for keypad driver running on Samsung cpus. This > >

Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver

2010-06-28 Thread Joonyoung Shim
Hi, Dmitry. On 6/25/2010 5:30 PM, Dmitry Torokhov wrote: > Hi Joonyoung, > > On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote: >> This patch adds support for keypad driver running on Samsung cpus. This >> driver is tested on GONI and Aquila board using S5PC110 cpu. >> >> Signed-off-

[PATCH v3 11/12] s3c-fb: fix section mismatch

2010-06-28 Thread Pawel Osciak
From: Marek Szyprowski This patch fixes the following section mismatch errors: WARNING: vmlinux.o(.data+0x20b40): Section mismatch in reference from the variable s3c_fb_driver_ids to the (unknown reference) .devinit.data:(unknown) The variable s3c_fb_driver_ids references the (unknown reference

[PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl

2010-06-28 Thread Pawel Osciak
Add VSYNC interrupt support and an ioctl that allows waiting for it. Interrupts are turned on only when needed. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/include/plat/regs-fb.h |1 + drivers/video/s3c-fb.c | 167 +++

[PATCH v3 12/12] s3c-fb: Add support for DMA channel control on S5PV210

2010-06-28 Thread Pawel Osciak
S5PV210 SoCs allow enabling/disabling DMA channels per window. For a window to display data from framebuffer memory, its channel has to be enabled. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/include/plat/regs-fb.h |4 +

[PATCH v3 04/12] s3c-fb: Add device name initialization

2010-06-28 Thread Pawel Osciak
Add framebuffer device name initialization calls for S3C2443, S3C64xx and S5P machines. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- arch/arm/mach-s3c2416/s3c2416.c |3 +- arch/arm/mach-s3c2443/s3c2443.c |2 + arch/arm/mach-s5pc100/cpu.c

[PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210

2010-06-28 Thread Pawel Osciak
S5PV210 allows per-window locking of register value updates from shadow registers. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/include/plat/regs-fb.h |3 ++ drivers/video/s3c-fb.c | 39 +++-- 2 files changed,

[PATCH v3 0/12] Various s3c-fb updates

2010-06-28 Thread Pawel Osciak
Hello, this series is rebased onto Ben Dook's framebuffer branch available at: git://git.fluff.org/bjdooks/linux.git dev/s3c-fb The main changes are the addition of an ability to wait for VSYNC and display panning and a better support for S5PV210 SoCs. A number of bugs has also been fixed. The f

[PATCH v3 10/12] s3c-fb: Protect window-specific registers during updates

2010-06-28 Thread Pawel Osciak
Newer hardware (S3C6410, S5P) have the ability to block updates from shadow registers during reconfiguration. Add protect calls for set_par and clear protection when resetting. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/video/s3c-fb.c |7 +++ 1 files changed, 7

[PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register

2010-06-28 Thread Pawel Osciak
FRAMESEL1 bitfield starts on 13th bit, not on 14th. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/include/plat/regs-fb.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/ar

[PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling

2010-06-28 Thread Pawel Osciak
S3C64xx and S5P OSD registers for OSD size and alpha are as follows: VIDOSDC: win 0 - size, win 1-4: alpha VIDOSDD: win 1-2 - size; not present for windows 0, 3 and 4 Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/video/s3c-fb.c | 58 +

[PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d register

2010-06-28 Thread Pawel Osciak
Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/video/s3c-fb.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 6131ebb..0a93fca 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@

[PATCH v3 05/12] s3c-fb: Add support for display panning

2010-06-28 Thread Pawel Osciak
Supports all bpp modes. The PRTCON register is used to disable in-hardware updates of registers that store start and end addresses of framebuffer memory. This prevents display corruption in case we do not make it before VSYNC with updating them atomically. With this feature there is no need to wai

[PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures

2010-06-28 Thread Pawel Osciak
S5PC100 and S5PV210 framebuffer devices differ slightly in terms of available registers and their driver data structures have to be separate. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/video/s3c-fb.c | 37 ++--- 1 files changed, 34 ins

[PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure

2010-06-28 Thread Pawel Osciak
The following problems were found in the above situation: sfb->windows[win] was being assigned at the end of s3c_fb_probe_win only. This resulted in passing a NULL to s3c_fb_release_win if probe_win returned early and a memory leak. dma_free_writecombine does not allow its third argument to be NU