Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 03:32:17PM +0200, Marek Szyprowski wrote: > One more question - should I enable the regulators in the driver itself > or in the platform callback (like a "poweron()" callback)? I don't understand what you mean by "platform callback". Normally the driver would unconditiona

RE: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Marek Szyprowski
Hello, On Thursday, July 01, 2010 2:25 PM Mark Brown wrote: > On Thu, Jul 01, 2010 at 08:07:45AM +0200, Marek Szyprowski wrote: > > > +static struct regulator_consumer_supply aquila_ldo3_consumers[] = { > > + { .supply = "VMIPI_1.1V", }, > > +}; > > > +static struct regulator_consumer_s

Re: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:46AM +0200, Marek Szyprowski wrote: > +static struct regulator_consumer_supply goni_ldo3_consumers[] = { > + { .supply = "VMIPI_1.1V", }, > +}; A similar issue to the previous patch applies here - you should be defining consumers using struct device based l

Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:45AM +0200, Marek Szyprowski wrote: > +static struct regulator_consumer_supply aquila_ldo3_consumers[] = { > + { .supply = "VMIPI_1.1V", }, > +}; > +static struct regulator_consumer_supply aquila_ldo8_consumers[] = { > + { .supply = "VADC_3.3V", }

[PATCH]Framebuffer fix for SmartQ5

2010-07-01 Thread Patrick Georgi
Hi, the following change makes the framebuffer work on SmartQ5. There are still some problems with ADC, so this patch alone won't make the device run (or even give a working fb), but it's one issue less to think about. Signed-off-by: Patrick Georgi diff --git a/arch/arm/mach-s3c64xx/mach-smartq

Re: [PATCH 8/8] ARM: S5PV310: Add serial port support

2010-07-01 Thread Kyungmin Park
Hi, As previous description. it's also same except the udivslot calculation and clock selection. How about to just modify current v210 serial codes by just adding the V310 or C210 type? Thank you, Kyungmin Park On Fri, Jun 25, 2010 at 11:27 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This

Re: [PATCH 0/8] ARM: S5PV310: Add support for Samsung S5PV310 SoC

2010-07-01 Thread Kyungmin Park
Hi, How about to start the single kernel preparation from this patch? Instead of create the new machine directory, we just put the mach-s5pv210 or create the new one. and don't you think it's confusing of names. s5pc110 (same as s5pv210), vs. s5pc210 (same as s5pv310). maybe someone don't read th