RE: [PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3

Maurus Cuelenaere wrote: > > Op 03-07-10 02:07, Kukjin Kim schreef: > > From: Hyuk Lee > > > > This patch adds hsmmc3 device definition in plat-samsung. Because now > > S5PV210 can support 4 hsmmc such as hsmmc0, hsmmc1, hsmmc2 and > hsmmc3 > > and that can be used in further Samsung SoCs. > > >

RE: [PATCH 1/3] ARM: SAMSUNG: Add the member of platdata to implement SDMMC Write Protection

Ben Dooks wrote: > > On Tue, Jun 15, 2010 at 08:27:46PM +0900, Kukjin Kim wrote: > > From: Lee Hyuk > > > > This patch adds the members of platdata which are cfg_wp and get_ro. > > The cfg_wp is the function for setting the specific GPIO for WP pin > > and get_ro is the function for getting data

RE: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

Ben Dooks wrote: > > On Tue, Jun 15, 2010 at 08:27:47PM +0900, Kukjin Kim wrote: > > From: Lee Hyuk > > > > S5PV210 HSMMC host controller doesn't have the Write Protection pin which > > should be connnected with SDMMC card WP pin. So allocated a GPIO in order > to > > get the data from SDMMC card

RE: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

Maurus Cuelenaere wrote: > > Op 15-06-10 13:27, Kukjin Kim schreef: > > From: Lee Hyuk > > > > S5PV210 HSMMC host controller doesn't have the Write Protection pin which > > should be connnected with SDMMC card WP pin. So allocated a GPIO in order > to > > get the data from SDMMC card WP pin with

[PATCH v2 1/3] ARM: SAMSUNG: Add the member of platdata to implement SDMMC Write Protection

From: Hyuk Lee This patch adds the members of platdata which is wp_gpio. The wp_gpio is a gpio_number which is connected with WP pin of SD Slot. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/dev-hsmmc.c |2 ++ arch/arm/plat-samsung/dev-hsmmc1.c

[PATCH v2 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk

From: Hyuk Lee If host controller doesn't have WP pin which should be connnected with SDMMC card WP pin, can implement get_ro function with using the allocated gpio. In order to use this quirk wp_gpio in the platform data must be set. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin Kim --- driv

[PATCH v2 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

From: Hyuk Lee S5PV210 HSMMC host controller doesn't have the Write Protection pin which should be connnected with SDMMC card WP pin. So send the allocated GPIO number which is connected with WP pin of SD slot in order to implement get_ro function in sdhci-s3c. Signed-off-by: Hyuk Lee Signed-of

[PATCH v2] Add support WP on SMDKV210 and SDHCI_QUIRK_NO_WP_BIT quirk

This patch adds support SDMMC write protection pin on SMDKV210. Changes since v1: Addressed comments from Ben Dooks, Maurus Cuelenaere and Kyungmin Park - just pass gpio numbers for support WP as Ben's suggestion - use the gpio layer for specific machine - use s3c_sdhcix_set_platdata() in machine

RE: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

Kyungmin Park wrote: > > On Tue, Jun 15, 2010 at 8:27 PM, Kukjin Kim wrote: > > From: Lee Hyuk > > > > S5PV210 HSMMC host controller doesn't have the Write Protection pin which > > should be connnected with SDMMC card WP pin. So allocated a GPIO in order > to > > get the data from SDMMC card WP

[PATCH 2/3] ASoC: Add SmartQ sound driver

This adds sound support for the SmartQ board. The hardware consists of a S3C6410 coupled with a WM8987 over I²S. The WM8750 driver is used for driving the WM8987, as they are register compatible. Signed-off-by: Maurus Cuelenaere --- sound/soc/s3c24xx/Kconfig |6 + sound/soc/s3c24xx/

[PATCH 3/3] ARM: S3C64XX: Add audio support to SmartQ

This adds the I²C board information for the WM8987 used in the SmartQ as audio codec and adds the I²C/I²S platform drivers. Signed-off-by: Maurus Cuelenaere --- arch/arm/mach-s3c64xx/mach-smartq.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64x

Re: [alsa-devel] [PATCH 1/2] ASoC: Add SmartQ sound driver

Op 03-07-10 02:15, Mark Brown schreef: > On Sat, Jan 30, 2010 at 06:23:14PM +0100, Maurus Cuelenaere wrote: > > Might want to check your mail setup - the date looks wrong. Looks like it picked the date I first started this commit, will correct it next time. >> This adds sound support for the Sm

[PATCH RE-SEND] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk

From: Hyuk Lee On Samsung's SDMMC hosts the timeout clock is derivied from the SD Clock which is set dynamically. So checked SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk and removed 'sdhci_s3c_get_timeout_clk' callback which doesn't need any more. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin Kim

Re: [alsa-devel] [PATCH 2/2] ARM: S3C64XX: Add audio support to SmartQ

On Sat, Jul 03, 2010 at 01:40:24AM +0200, Maurus Cuelenaere wrote: > +static struct i2c_board_info smartq_i2c_devs[] __initdata = { > + { I2C_BOARD_INFO("wm8750", 0x1a), }, > +}; It'd be slightly nicer to register with the actual chip ID and make sure the driver can handle it - it'll avoid th

Re: [PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3

Op 03-07-10 02:07, Kukjin Kim schreef: > From: Hyuk Lee > > This patch adds hsmmc3 device definition in plat-samsung. Because now > S5PV210 can support 4 hsmmc such as hsmmc0, hsmmc1, hsmmc2 and hsmmc3 > and that can be used in further Samsung SoCs. > > Signed-off-by: Hyuk Lee > Signed-off-by: K

Re: [alsa-devel] [PATCH 1/2] ASoC: Add SmartQ sound driver

On Sat, Jan 30, 2010 at 06:23:14PM +0100, Maurus Cuelenaere wrote: Might want to check your mail setup - the date looks wrong. > This adds sound support for the SmartQ board. > > The hardware consists of a S3C6410 coupled with a WM8987 over I²S. As there's > no driver for the WM8987 currently, t

[PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3

From: Hyuk Lee This patch adds hsmmc3 device definition in plat-samsung. Because now S5PV210 can support 4 hsmmc such as hsmmc0, hsmmc1, hsmmc2 and hsmmc3 and that can be used in further Samsung SoCs. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin Kim --- Changes since previous patch: - coding

[PATCH v2 2/2] ARM: S5PV210: Add support HSMMC on SMDKV210

From: Hyuk Lee This patch adds support HSMMC on SMDKV210, and gpio configuration for S5PV210 hsmmc3. Signed-off-by: Hyuk Lee Signed-off-by: Kukjin Kim --- Changes since previous patch: - Fixed wrong pin name - Adding missed call s5pv210_default_sdhci3() in s5pv210_map_io() arch/arm/mach-s5

[PATCH v2] Add support HSMMC on Samsung SMDKV210

This patch adds support hsmmc on SMDKV210. Changes since v1: - Fixed wrong pin name in comments - Adding missed call s5pv210_default_sdhci3() in s5pv210_map_io() - Minor coding style fixes [PATCH v2 1/2] ARM: SAMSUNG: Add device definition for HSMMC3 [PATCH v2 2/2] ARM: S5PV210: Add support HSMM

[PATCH 2/2] ARM: S3C64XX: Add audio support to SmartQ

This adds the I²C board information for the WM8987 used in the SmartQ as audio codec and adds the I²C/I²S platform drivers. Signed-off-by: Maurus Cuelenaere --- arch/arm/mach-s3c64xx/mach-smartq.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64x

[PATCH 1/2] ASoC: Add SmartQ sound driver

This adds sound support for the SmartQ board. The hardware consists of a S3C6410 coupled with a WM8987 over I²S. As there's no driver for the WM8987 currently, this uses the WM8750 driver (which should be register compatible). Signed-off-by: Maurus Cuelenaere --- sound/soc/s3c24xx/Kconfig

RE: [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling

>Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> S3C64xx and S5P OSD registers for OSD size and alpha are as follows: >> VIDOSDC: win 0 - size, win 1-4: alpha >> VIDOSDD: win 1-2 - size; not present for windows 0, 3 and 4 >> >> Signed-off-by: Pawel Osciak >> Signed-off-by: Kyungmin Pa

RE: [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210

>Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> @@ -218,6 +218,9 @@ >> #define WINCON1_BPPMODE_25BPP_A1888 (0xd << 2) >> #define WINCON1_BPPMODE_28BPP_A4888 (0xd << 2) >> >> +/* S5PV210 */ >> +#define SHADOWCON (0x34) >> +#define SHADOWCON_W

RE: [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl

>Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> @@ -801,6 +825,124 @@ static int s3c_fb_pan_display(struct fb_var_screeninfo >> *var, >> return 0; >> } >> >> +/** >> + * s3c_fb_enable_irq() - enable framebuffer interrupts >> + * @sfb: main hardware sta

RE: [PATCH v3 05/12] s3c-fb: Add support for display panning

>Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat- >samsung/include/plat/regs-fb.h >> index ac10013..f454e32 100644 >> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h >> +++ b/arch/arm/plat-samsung/include/pla

Re: [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling

On 28/06/10 09:08, Pawel Osciak wrote: > S3C64xx and S5P OSD registers for OSD size and alpha are as follows: > VIDOSDC: win 0 - size, win 1-4: alpha > VIDOSDD: win 1-2 - size; not present for windows 0, 3 and 4 > > Signed-off-by: Pawel Osciak > Signed-off-by: Kyungmin Park > --- > drivers/vide

Re: [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210

On 28/06/10 09:08, Pawel Osciak wrote: > S5PV210 allows per-window locking of register value updates from shadow > registers. > > Signed-off-by: Pawel Osciak > Signed-off-by: Kyungmin Park > --- > arch/arm/plat-samsung/include/plat/regs-fb.h |3 ++ > drivers/video/s3c-fb.c

RE: [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures

> Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> S5PC100 and S5PV210 framebuffer devices differ slightly in terms of >> available registers and their driver data structures have to be separate. > >Would have been nice to note which ones changes, otherwise ok. For this series, the dif

RE: [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure

>Ben Dooks wrote: >On 28/06/10 09:08, Pawel Osciak wrote: >> @@ -819,7 +820,8 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, >struct s3c_fb_win *win) >> { >> if (win->fbinfo) { >> unregister_framebuffer(win->fbinfo); >> -fb_dealloc_cmap(&win->fbinfo->cmap); >>

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

On Fri, Jul 02, 2010 at 12:25:33PM +0100, Ben Dooks wrote: > On 28/06/10 12:28, Maurus Cuelenaere wrote: > > No need for the '? 1 : 0' > I tihnk there is, IIRC there is no neccessity for a compiler to produce > one for true, just that the result be !0 The compiler will *produce* 1 for true, but

Re: [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl

On 28/06/10 09:08, Pawel Osciak wrote: > Add VSYNC interrupt support and an ioctl that allows waiting for it. > Interrupts are turned on only when needed. > > Signed-off-by: Pawel Osciak > Signed-off-by: Kyungmin Park > --- > arch/arm/plat-samsung/include/plat/regs-fb.h |1 + > drivers/vide

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

Op 02-07-10 13:25, Ben Dooks schreef: > On 28/06/10 12:28, Maurus Cuelenaere wrote: >> Op 28-06-10 10:08, Pawel Osciak schreef: >>> Supports all bpp modes. >>> >>> The PRTCON register is used to disable in-hardware updates of registers >>> that store start and end addresses of framebuffer memory.

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

On 28/06/10 12:28, Maurus Cuelenaere wrote: > Op 28-06-10 10:08, Pawel Osciak schreef: >> Supports all bpp modes. >> >> The PRTCON register is used to disable in-hardware updates of registers >> that store start and end addresses of framebuffer memory. This prevents >> display corruption in case w

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

On 28/06/10 09:08, Pawel Osciak wrote: > Supports all bpp modes. > > The PRTCON register is used to disable in-hardware updates of registers > that store start and end addresses of framebuffer memory. This prevents > display corruption in case we do not make it before VSYNC with updating > them at

Re: [PATCH v3 04/12] s3c-fb: Add device name initialization

On 28/06/10 09:08, Pawel Osciak wrote: > Add framebuffer device name initialization calls for S3C2443, S3C64xx > and S5P machines. ok, if we don't sort out a better system before the next window then this should be ok. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc

Re: [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures

On 28/06/10 09:08, Pawel Osciak wrote: > S5PC100 and S5PV210 framebuffer devices differ slightly in terms of > available registers and their driver data structures have to be separate. Would have been nice to note which ones changes, otherwise ok. -- To unsubscribe from this list: send the line "

Re: [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register

On 28/06/10 09:08, Pawel Osciak wrote: > FRAMESEL1 bitfield starts on 13th bit, not on 14th. > > Signed-off-by: Pawel Osciak > Signed-off-by: Kyungmin Park Acked-by: Ben Dooks -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@v

Re: [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure

On 28/06/10 09:08, Pawel Osciak wrote: > The following problems were found in the above situation: > > sfb->windows[win] was being assigned at the end of s3c_fb_probe_win only. > This resulted in passing a NULL to s3c_fb_release_win if probe_win returned > early and a memory leak. > > dma_free_wr