Re: [rtc-linux] [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

2010-07-21 Thread Wan ZongShun
2010/7/21 Kukjin Kim : > From: Atul Dahiya > > This Patch updates existing Samsung RTC driver for clock enabling support. > > Signed-off-by: Atul Dahiya > Signed-off-by: Kukjin Kim > --- >  drivers/rtc/rtc-s3c.c |   22 ++ >  1 files changed, 22 insertions(+), 0 deletions(-) >

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 10:29 PM, Kyungmin Park wrote: > On Wed, Jul 21, 2010 at 9:55 PM, Kukjin Kim wrote: >> Kyungmin Park wrote: >>> >>> On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: >>> > From: Changhwan Youn >>> > >>> > This patch adds Samsung S5PV310/S5PC210 CPU support. >>> > The S5

Re: [rtc-linux] [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Wan ZongShun
2010/7/21 Kukjin Kim : > From: Taekgyun Ko > > RTC needs to be initialized when BCD registers have invalid value. Do you mean that the hardware register does not have default value? Any results if no initialized value here? > > Signed-off-by: Taekgyun Ko > Signed-off-by: Kukjin Kim > --- >  dr

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND"

2010-07-21 Thread MyungJoo Ham
On Wed, Jul 21, 2010 at 8:47 PM, Ben Dooks wrote: > On 21/07/10 02:13, MyungJoo Ham wrote: >> On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks wrote: >>> On 07/19/10 06:31, MyungJoo Ham wrote: Early S5PC110 (EVT0) chip had some issues required workaround from a kernel. We can add such wo

Re: [PATCH v3] Samsung: sdhci-s3c: add support for new card detection methods

2010-07-21 Thread Andrew Morton
On Fri, 16 Jul 2010 08:24:26 +0200 Marek Szyprowski wrote: > > > arch/arm/mach-s3c64xx/setup-sdhci-gpio.c | 14 +--- > > > arch/arm/mach-s5pc100/setup-sdhci-gpio.c | 21 ++- > > > arch/arm/mach-s5pv210/setup-sdhci-gpio.c | 22 +++- > > > arch/a

Re: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Sergei Shtylyov
Hello. Kukjin Kim wrote: From: Taekgyun Ko RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko Signed-off-by: Kukjin Kim [...] diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 2040017..e96e109 100644 --- a/drivers/rtc/rtc-s3c.

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 10:55 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> I don't want to modify Kconfig anymore. it's simple to modify driver > itself. >> > Yeah, I think so. > >> Think the usage of I2c. I think there's no case don't use it. >> >> At this time modify Kconfig once, and just

RE: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: > > I don't want to modify Kconfig anymore. it's simple to modify driver itself. > Yeah, I think so. > Think the usage of I2c. I think there's no case don't use it. > > At this time modify Kconfig once, and just fix the driver if new SoCs > are arrives. > Of course we can m

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND"

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 8:47 PM, Ben Dooks wrote: > On 21/07/10 02:13, MyungJoo Ham wrote: >> On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks wrote: >>> On 07/19/10 06:31, MyungJoo Ham wrote: Early S5PC110 (EVT0) chip had some issues required workaround from a kernel. We can add such wo

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
I don't want to modify Kconfig anymore. it's simple to modify driver itself. Think the usage of I2c. I think there's no case don't use it. At this time modify Kconfig once, and just fix the driver if new SoCs are arrives. Of course we can modify Kconfig one more, If there's really new IPs of I2C

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:29 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> I don't see the Samsung SoCs don't have RTC feature. >> > Yes, you're right... > But it doesn't mean the RTC driver can support every Samsung SoCs now. Vice versa, if there's problem, we can fix it easily. No need to

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:55 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: >> > From: Changhwan Youn >> > >> > This patch adds Samsung S5PV310/S5PC210 CPU support. >> > The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. >> > >> > Si

Re: [PATCH v2 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-21 Thread Kyungmin Park
which tree do you use? If not fix the s5pv210_IIC2_IRQ correcly, it can't compile it. but I'm not see related patch at mailing list. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:58 PM, Kukjin Kim wrote: > From: Naveen Krishna Ch > > This patch adds support I2C-0/1/2 devices to the SMDKV21

[PATCH v2 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-21 Thread Kukjin Kim
From: Naveen Krishna Ch This patch adds support I2C-0/1/2 devices to the SMDKV210/SMDKC110. Signed-off-by: Naveen Krishna Ch Signed-off-by: Kukjin Kim --- Changes since v1: - Fixed the wrong name as per Kyungmin Park's comments arch/arm/mach-s5pv210/Kconfig |8 arch/arm/

[PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kukjin Kim
From: Naveen Krishna Ch This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440. Signed-off-by: Naveen Krishna Ch Signed-off-by: Kukjin Kim --- Changes since v1: - Modifed the Kconfig help comments. drivers/i2c/busses/Kconfig |6 +++--- 1 files changed, 3 insertio

RE: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: > > On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: > > From: Changhwan Youn > > > > This patch adds Samsung S5PV310/S5PC210 CPU support. > > The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. > > > > Signed-off-by: Changhwan Youn > > Signed-off-by: Jongpill Lee

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-07-21 Thread Kukjin Kim
Joonyoung Shim wrote: > > On 7/21/2010 5:07 PM, Dmitry Torokhov wrote: > > Hi Joonyoung, > > > > On Wed, Jul 21, 2010 at 02:42:22PM +0900, Joonyoung Shim wrote: > >> Hi, Dmitry. > >> > >> On 7/9/2010 4:39 PM, Joonyoung Shim wrote: > >>> On 7/9/2010 4:07 PM, Kukjin Kim wrote: > Joonyoung Shim

RE: [PATCH v2 7/8] ARM: S5PV310: Add Board support file

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: > > On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim wrote: > > From: Changhwan Youn > > > > This patch adds Samsung SMDKV310 board support file. > > > > Signed-off-by: Changhwan Youn > > Signed-off-by: Kukjin Kim > > --- > >  arch/arm/mach-s5pv310/Makefile        |    4 ++ > >

RE: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: > > I don't see the Samsung SoCs don't have RTC feature. > Yes, you're right... But it doesn't mean the RTC driver can support every Samsung SoCs now. > I think S3C_RTC only depends on PLAT_SAMSUNG so PLAT_SAMSUNG select > HAVE_S3C_RTC is enough. So I think, this is not bad

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND"

2010-07-21 Thread Ben Dooks
On 21/07/10 02:13, MyungJoo Ham wrote: > On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks wrote: >> On 07/19/10 06:31, MyungJoo Ham wrote: >>> >>> Early S5PC110 (EVT0) chip had some issues required workaround from a >>> kernel. We can add such workaround codes with this Kconfig entry. >>> >>> Signed-off

RE: [PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: > > On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim wrote: > > From: Naveen Krishna Ch > > > > This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and > S5P6440. > > > > Signed-off-by: Naveen Krishna Ch > > Signed-off-by: Kukjin Kim > > --- > >  drivers/i2c/bu

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
I don't see the Samsung SoCs don't have RTC feature. I think S3C_RTC only depends on PLAT_SAMSUNG so PLAT_SAMSUNG select HAVE_S3C_RTC is enough. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 6:00 PM, Kukjin Kim wrote: > From: Atul Dahiya > > This patch moves the dependency of RTC driver fro

RE: [PATCH] serial: samsung.c: Add FRACVAL support for newer UART

2010-07-21 Thread Kukjin Kim
Sergei Shtylyov wrote: > > Hello. > Hi ;-) > Kukjin Kim wrote: > > > From: Changhwan Youn > > > FRACVAL register provides the same function as UDIVSLOT register which is > > the 1/16ths adjustment to the baud rate but the implementaiton is easier. > > To support UDIVSLOT register, UDIVSLOT ta

Re: [PATCH] serial: samsung.c: Add FRACVAL support for newer UART

2010-07-21 Thread Sergei Shtylyov
Hello. Kukjin Kim wrote: From: Changhwan Youn FRACVAL register provides the same function as UDIVSLOT register which is the 1/16ths adjustment to the baud rate but the implementaiton is easier. To support UDIVSLOT register, UDIVSLOT table search is necessary though supporting FRACVAL only n

[PATCH 0/5] Add RTC support SMDK6410, SMDKC100, SMDKC110 and SMDKV210

2010-07-21 Thread Kukjin Kim
This patch adds RTC support for Samsung SoCs such as S5P6440, S5PC100, S5PV210, and S5PC110. NOTE: depends on previous Samsung RTC patches. [PATCH 1/5] ARM: S3C64XX: Add RTC support for S3C64XX [PATCH 2/5] rtc: rtc-s3c: Add extra option to include RTC for Samsung SoCs [PATCH 3/5] ARM: S5P6440: Ad

[PATCH 3/5] ARM: S5P6440: Add RTC support for S5P6440

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch adds support RTC driver for Samsung S5P6440. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p6440/Kconfig|2 ++ arch/arm/mach-s5p6440/include/mach/map.h |2 +- arch/arm/mach-s5p6440/mach-smdk6440.c|1 + 3 files

[PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch moves the dependency of RTC driver from MACH_XXX(board) to ARCH_XXX(SoC). This will enable all machines using Samsung S5P6440, S5PC100 and S5PV210 SoCs to use RTC driver by default. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/Kconfig

[PATCH 4/5] ARM: S5PC100: Add RTC support for S5PC100

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch adds support RTC driver for Samsung S5PC100. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pc100/Kconfig|2 ++ arch/arm/mach-s5pc100/include/mach/map.h |3 +++ arch/arm/mach-s5pc100/mach-smdkc100.c|1 + 3 file

[PATCH 5/5] ARM: S5PV210: Add RTC support for S5PV210 and S5PC110

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch adds support RTC driver for Samsung S5PV210/S5PC110. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pv210/Kconfig|4 arch/arm/mach-s5pv210/include/mach/map.h |2 ++ arch/arm/mach-s5pv210/mach-smdkc110.c|1

[PATCH 1/5] ARM: S3C64XX: Add RTC support for S3C64XX

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch adds support for RTC for SMDK6410. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c64xx/Kconfig |1 + arch/arm/mach-s3c64xx/mach-smdk6410.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

[PATCH 2/5] rtc: rtc-s3c: Add extra option to include RTC for Samsung SoCs

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch adds HAVE_S3C_RTC to control inclusion of RTC driver for Samsung SoCs. This option will help to include the driver only for the necessary machines and not for any given arch. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- drivers/rtc/Kconfig |9 +

[PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Kukjin Kim
From: Taekgyun Ko RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko Signed-off-by: Kukjin Kim --- drivers/rtc/rtc-s3c.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3

[PATCH 0/2] Updates Samsung RTC driver for clock enabling support

2010-07-21 Thread Kukjin Kim
This patch updates RTC driver for clock enabling support. [PATCH 1/2] ARM: S3C64XX: Move RTC clock from init_clocks to init_clocks_disable [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the

[PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This Patch updates existing Samsung RTC driver for clock enabling support. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- drivers/rtc/rtc-s3c.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/dr

[PATCH 0/3] Updates RTC driver for Samsung S3C64XX and newer SoCs

2010-07-21 Thread Kukjin Kim
This patch updates RTC driver for Samsung S3C64XX and newer SoCs. NOTE: depends on previous RTC patch for clock enabling. [PATCH 1/3] ARM: SAMSUNG: Updates RTC register for support Alarm IRQ and Time Tick. [PATCH 2/3] rtc: rtc-s3c: Updates driver for S3C64XX and newer SoCs [PATCH 3/3] rtc: rtc-s

[PATCH 1/3] ARM: SAMSUNG: Updates RTC register for support Alarm IRQ and Time Tick.

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This patch updates RTC registers for support Alarm IRQ and Time Tick. Signed-off-by: Atul Dahiya Signed-off-by: Taekgyun Ko Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/include/plat/regs-rtc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a

[PATCH 1/2] ARM: S3C64XX: Move RTC clock from init_clocks to init_clocks_disable

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya RTC clock does not require to be enabled at boot time. Signed-off-by: Atul Dahiya Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c64xx/clock.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c

[PATCH 2/3] rtc: rtc-s3c: Updates driver for S3C64XX and newer SoCs

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya This Patch does followings. 1) Enables support for alarm and time tick pending register for periodic interrupt generation. 2) Changes writeb to writew beacuse the macro S3C64XX_RTCCON_TICEN (Tick Timer Enable) is 9th bit of register. 3) Changes writeb to writel as max_user

Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-07-21 Thread Joonyoung Shim
On 7/21/2010 5:07 PM, Dmitry Torokhov wrote: > Hi Joonyoung, > > On Wed, Jul 21, 2010 at 02:42:22PM +0900, Joonyoung Shim wrote: >> Hi, Dmitry. >> >> On 7/9/2010 4:39 PM, Joonyoung Shim wrote: >>> On 7/9/2010 4:07 PM, Kukjin Kim wrote: Joonyoung Shim wrote: > On 7/7/2010 8:52 AM, Kukjin K

Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-07-21 Thread Dmitry Torokhov
Hi Joonyoung, On Wed, Jul 21, 2010 at 02:42:22PM +0900, Joonyoung Shim wrote: > Hi, Dmitry. > > On 7/9/2010 4:39 PM, Joonyoung Shim wrote: > > On 7/9/2010 4:07 PM, Kukjin Kim wrote: > >> Joonyoung Shim wrote: > >>> On 7/7/2010 8:52 AM, Kukjin Kim wrote: > Joonyoung Shim wrote: > > Hi, Na

[PATCH] ARM: S5P: Changes the definition name of default UART registers

2010-07-21 Thread Kukjin Kim
This patch changes the definition name of default UCON, ULCON, and UFCON UART registers from ARCH(SoC) to Machine(Board). Because it is board specific UART configuration. Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p6440/mach-smdk6440.c | 30 +++--- arch/arm/mach-s5p6442/mach