Re: [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature

2010-09-07 Thread Vasily Khoruzhick
В сообщении от 8 сентября 2010 02:37:00 автор Ben Dooks написал: > On 08/09/10 00:23, Vasily Khoruzhick wrote: > > Some integrated DMA-capable hardware doesn't like autoreload > > feature of s3c24xx DMA-engine, that's why s3cmci driver > > didn't work with DMA transfers enabled. > > > > I rewrote

RE: [PATCH v3] regulators: add support max8952 regulator

2010-09-07 Thread Kyungmin Park
Do you check the DVS feature? It can support the DVS by GPIOs and platform can set the each voltages at each mode. As quick review of max8649. It can't support it. Thank you, Kyungmin Park -Original Message- From: Kukjin Kim [mailto:kgene@samsung.com] Sent: Wednesday, September 08,

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Wan ZongShun
2010/9/8 Ben Dooks : > On 07/09/10 06:29, Kukjin Kim wrote: >> From: Changhwan Youn >> >> This patch changes RTC initialization method on probe() as >> per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can >> check whether RTC BCD is valid or not. >> Hi Kukjin, I think you misunderstood my m

[PATCH v3] regulators: add support max8952 regulator

2010-09-07 Thread Kukjin Kim
From: Changhwan Youn The operation of max8952 is almost similar to max8649 except the output voltage range. This patch adds support the max8952 regulator using current max8649 implementation. And removes separate max8952.[ch] files since the functionality is now merged into this driver. Signed-o

RE: [PATCH v2] regulators: add support max8952 regulator

2010-09-07 Thread Kukjin Kim
Mark Brown wrote: > > On Tue, Sep 07, 2010 at 04:23:22PM +0900, Kukjin Kim wrote: > > From: Changhwan Youn > > > > The operation of max8952 is almost similar to max8649 except > > the output voltage range. This patch adds support the max8952 > > regulator using current max8649 implementation. > >

Re: [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature

2010-09-07 Thread Ben Dooks
On 08/09/10 00:23, Vasily Khoruzhick wrote: > Some integrated DMA-capable hardware doesn't like autoreload > feature of s3c24xx DMA-engine, that's why s3cmci driver > didn't work with DMA transfers enabled. > > I rewrote DMA driver not to use autoreload feature and removed > all pre-loading featur

Re: [PATCH 5/5] rtc: rtc-s3c: Fix debug message format on RTC

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > This patch fixes debug message format on rtc-s3c. > > Signed-off-by: Kukjin Kim > Cc: Ben Dooks > --- > drivers/rtc/rtc-s3c.c | 18 +- > 1 files changed, 9 insertions(+), 9 deletions(-) > how long has this lot been broken for? Acked-by

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > From: Changhwan Youn > > This patch changes RTC initialization method on probe() as > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > check whether RTC BCD is valid or not. > > And should be changed the method of check because previous > method

[PATCH 1/2] s3c24xx: DMA: don't use autoreload feature

2010-09-07 Thread Vasily Khoruzhick
Some integrated DMA-capable hardware doesn't like autoreload feature of s3c24xx DMA-engine, that's why s3cmci driver didn't work with DMA transfers enabled. I rewrote DMA driver not to use autoreload feature and removed all pre-loading features. Buffer re-load is fast enought to perform it in IRQ

Re: [PATCH 3/5] rtc: rtc-s3c: Fix on support RTC Alarm

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > From: Changhwan Youn > > The alarm_irq_enable function should be implemented to support RTC alarm. > And fixes tab instead of white space abound proc field. > > Signed-off-by: Changhwan Youn > Signed-off-by: Kukjin Kim > Cc: Ben Dooks oops. wonder how l

Re: [PATCH 2/5] rtc: rtc-s3c: Fix setting missing field of getalarm

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > From: Changhwan Youn > > Current s3c_rtc_getalarm() sets missing field of alarm time with 0xff. > But this value should be -1 according to drivers/rtc/interface.c. Never noticed a problem, but then this call isn't the most used call. > Signed-off-by: Chang

Re: [PATCH 1/5] rtc: rtc-s3c: Fix access unit from byte to word on RTCCON

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: > From: Changhwan Youn > > S3C2410_RTCCON of TYPE_S3C64XX RTC should be read/written by readw and writew, > because TYPE_S3C64XX RTC uses bit8 and bit9. > > Signed-off-by: Changhwan Youn > Signed-off-by: Kukjin Kim > Cc: Ben Dooks Anyone else tried this o

Re: [PATCH 2/2] s3cmci: minor fixups

2010-09-07 Thread Ben Dooks
On 07/09/10 16:16, Vasily Khoruzhick wrote: > - It's not necessary to start DMA op manually, as we have > autostart feature enabled > - Restore prescaler before DMA operation, otherwise it > takes ages to complete DMA op. > > Signed-off-by: Vasily Khoruzhick > --- > drivers/mmc/host/s3cmci.c |

Re: [PATCH 0/2] s3c24xx: fix s3cmci DMA support

2010-09-07 Thread Ben Dooks
On 07/09/10 16:09, Vasily Khoruzhick wrote: > This series fixes DMA support for s3c24xx SoCs, now it's > possible to use DMA with s3cmci driver. It was tested on > rx1950 (s3c2442), h1940 (s3c2410) and freerunner (s3c2442), > unfortunately s3cmci doesn't work with SDIO cards when DMA > is enabled,

Re: [PATCH 0/5] h1940 series

2010-09-07 Thread Ben Dooks
On 07/09/10 16:00, Vasily Khoruzhick wrote: > This series converts latch API to generic gpiolib API, > improves power management and adds sound codec device > for h1940. few minor bits with the gpiolib. otherwise looks ok. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung

Re: [PATCH 1/5] h1940: use gpiolib for latch access

2010-09-07 Thread Ben Dooks
On 07/09/10 16:00, Vasily Khoruzhick wrote: > This patch adds gpiolib support for h1940 latch. > With this patch it's possible to use leds-gpio and uda1380 > drivers (they require gpiolib support for appropriate pins). > And now it's possible to drop leds-h1940 driver. > > Signed-off-by: Vasily Kh

Re: [PATCH 1/3] rx1950: add battery device

2010-09-07 Thread Vasily Khoruzhick
В сообщении от 8 сентября 2010 02:06:19 автор Ben Dooks написал: > On 07/09/10 15:32, Vasily Khoruzhick wrote: > > Signed-off-by: Vasily Khoruzhick > > --- > > > > arch/arm/mach-s3c2440/Kconfig |3 + > > arch/arm/mach-s3c2440/mach-rx1950.c | 160 > > ++

Re: [PATCH 0/3] rx1950: add rest of devices

2010-09-07 Thread Ben Dooks
On 07/09/10 15:32, Vasily Khoruzhick wrote: > This series adds battery device, LEDs device and sound codec > device to mach-rx1950.c the first one has a few issues, the others look fine. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to maj

Re: [PATCH 1/3] rx1950: add battery device

2010-09-07 Thread Ben Dooks
On 07/09/10 15:32, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick > --- > arch/arm/mach-s3c2440/Kconfig |3 + > arch/arm/mach-s3c2440/mach-rx1950.c | 160 > +++ > 2 files changed, 163 insertions(+), 0 deletions(-) > > diff --git a/arch/arm

[PATCH 2/2] s3cmci: minor fixups

2010-09-07 Thread Vasily Khoruzhick
- It's not necessary to start DMA op manually, as we have autostart feature enabled - Restore prescaler before DMA operation, otherwise it takes ages to complete DMA op. Signed-off-by: Vasily Khoruzhick --- drivers/mmc/host/s3cmci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 0/2] s3c24xx: fix s3cmci DMA support

2010-09-07 Thread Vasily Khoruzhick
This series fixes DMA support for s3c24xx SoCs, now it's possible to use DMA with s3cmci driver. It was tested on rx1950 (s3c2442), h1940 (s3c2410) and freerunner (s3c2442), unfortunately s3cmci doesn't work with SDIO cards when DMA is enabled, but at least patch breaks nothing - sound works OK on

[PATCH 4/5] h1940: Fix backlight and LCD power functions

2010-09-07 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2410/include/mach/h1940-latch.h |2 +- arch/arm/mach-s3c2410/mach-h1940.c | 68 ++ 2 files changed, 58 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-s3c2410/include/mach/h1940-latch.h b/arc

[PATCH 2/5] h1940: fix h1940-bluetooth compilation

2010-09-07 Thread Vasily Khoruzhick
h1940-bluetooth.c doesn't compile after s3c gpio API changes, this patch fixes issue. Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2410/h1940-bluetooth.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-s3c2410/h1940-bluetooth.c b/arch/arm/m

[PATCH 3/5] h1940: implement mmc_power function

2010-09-07 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2410/include/mach/h1940-latch.h |2 +- arch/arm/mach-s3c2410/mach-h1940.c | 23 +++-- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-s3c2410/include/mach/h1940-latch.h b/arch/

[PATCH 1/5] h1940: use gpiolib for latch access

2010-09-07 Thread Vasily Khoruzhick
This patch adds gpiolib support for h1940 latch. With this patch it's possible to use leds-gpio and uda1380 drivers (they require gpiolib support for appropriate pins). And now it's possible to drop leds-h1940 driver. Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2410/h1940-bluetooth.c

[PATCH 0/5] h1940 series

2010-09-07 Thread Vasily Khoruzhick
This series converts latch API to generic gpiolib API, improves power management and adds sound codec device for h1940. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

[PATCH 2/3] rx1950: add LEDs support

2010-09-07 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2440/mach-rx1950.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2440/mach-rx1950.c b/arch/arm/mach-s3c2440/mach-rx1950.c index 1197ab4..3328c86 100644 --- a/arch/ar

[PATCH 1/3] rx1950: add battery device

2010-09-07 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2440/Kconfig |3 + arch/arm/mach-s3c2440/mach-rx1950.c | 160 +++ 2 files changed, 163 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig index c

[PATCH 3/3] rx1950: add UDA1380 to i2c devices list

2010-09-07 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-s3c2440/mach-rx1950.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-s3c2440/mach-rx1950.c b/arch/arm/mach-s3c2440/mach-rx1950.c index 3328c86..d971aa9 100644 --- a/arch/arm/mach-s

Re: [PATCH v2] regulators: add support max8952 regulator

2010-09-07 Thread Mark Brown
On Tue, Sep 07, 2010 at 04:23:22PM +0900, Kukjin Kim wrote: > From: Changhwan Youn > > The operation of max8952 is almost similar to max8649 except > the output voltage range. This patch adds support the max8952 > regulator using current max8649 implementation. > > Signed-off-by: Changhwan Youn

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Kyungmin Park
On Tue, Sep 7, 2010 at 2:29 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch changes RTC initialization method on probe() as > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > check whether RTC BCD is valid or not. > > And should be changed the method of check because previo

[PATCH v2] regulators: add support max8952 regulator

2010-09-07 Thread Kukjin Kim
From: Changhwan Youn The operation of max8952 is almost similar to max8649 except the output voltage range. This patch adds support the max8952 regulator using current max8649 implementation. Signed-off-by: Changhwan Youn Signed-off-by: Kukjin Kim Cc: Mark Brown --- Changes since v1: Followin