RE: [PATCHv2 7/7] ARM: S5PC110: add support for MMC regulators on Goni board

2010-09-27 Thread Kukjin Kim
Marek Szyprowski wrote: > > Add required platform definitions for MMC power regulators on Samsung > Goni board. GPIO pin GONI_EXT_FLASH_EN has been transferred from machine > startup code to fixed voltage regulator. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > CC: Mark B

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-27 Thread Kyungmin Park
On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim wrote: > 최규호 wrote: > Hi, > > Welcome to Linux mainline ;-) > I have some comments about your patches. > > Firstly could you please use English character in the representing name in > e-mail client not Korean character :-) > And make sure it's text type

[PATCH] ARM: S5P: Remove the unused clk_arm clock from plat-s5p

2010-09-27 Thread Kukjin Kim
From: Thomas Abraham All the S5P series SoCs use the 'struct clksrc_clk' type to represent the armclk. So the clk_arm clock instance available in the plat-s5p clock code is not used in any of the S5P series SoCs. This patch removes the unused clk_arm instance from plat-s5p clock code. Reported-b

RE: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-27 Thread Kukjin Kim
최규호 wrote: Hi, Welcome to Linux mainline ;-) I have some comments about your patches. Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure it's text type. >Hi, >Thank you for your interesting. >On Mon, Sep 27, 2010 at 1

RE: [PATCH v2 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-27 Thread Kukjin Kim
Jeongbae Seo wrote: > > Ben Dooks worte: > > On 17/09/10 10:45, Kukjin Kim wrote: > > > From: Hyuk Lee > > > > > > This patch adds to support no internal clock divider in SDHCI. > > > The external clock divider can be used to make a proper clock > > > because SDHCI doesn't support internal clock

[PATCH v2] ARM: S5PV310: Optimize interrupt source searching code

2010-09-27 Thread Kukjin Kim
From: Changhwan Youn It is reported by Junseok Jung that using clz instruction is better instead of using for-loop to find the interrupt source. This patch modifies interrupt source searching code using __ffs(). The __ffs() is implemented using clz instruction. Suggested-by: Junseok Jung Signed

RE: [PATCH v2 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-27 Thread Jeongbae Seo
Ben Dooks worte: > On 17/09/10 10:45, Kukjin Kim wrote: > > From: Hyuk Lee > > > > This patch adds to support no internal clock divider in SDHCI. > > The external clock divider can be used to make a proper clock > > because SDHCI doesn't support internal clock divider by itself. > > > > Signed-off

[PATCH] ARM: S5PV310: Optimize interrupt source searching code

2010-09-27 Thread Kukjin Kim
From: Changhwan Youn It is reported by Junseok Jung that using clz instruction is better instead of using for-loop to find the interrupt source. This patch modifies interrupt source searching code using __fls(). The __fls() is implemented using clz instruction. Suggested-by: Junseok Jung Signed

RE: Came back from Korean thanksginving holidays

2010-09-27 Thread Kukjin Kim
Ben Dooks wrote: > > On Tue, Sep 28, 2010 at 07:34:07AM +0900, Kukjin Kim wrote: > > Hi all, > > > > I came back from Korean thanksgiving holidays, 'Chu-Seok' just now. > > So I couldn't check your patches in the last 1-week...sorry :-) > > Hope you had a good time. > Hi Ben, Yeah, thanks ;-) A

Re: Came back from Korean thanksginving holidays

2010-09-27 Thread Ben Dooks
On Tue, Sep 28, 2010 at 07:34:07AM +0900, Kukjin Kim wrote: > Hi all, > > I came back from Korean thanksgiving holidays, 'Chu-Seok' just now. > So I couldn't check your patches in the last 1-week...sorry :-) Hope you had a good time. > Anyway, will review them in my e-mail box as soon as possibl

Came back from Korean thanksginving holidays

2010-09-27 Thread Kukjin Kim
Hi all, I came back from Korean thanksgiving holidays, 'Chu-Seok' just now. So I couldn't check your patches in the last 1-week...sorry :-) Anyway, will review them in my e-mail box as soon as possible. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team,

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-27 Thread Kyungmin Park
On Mon, Sep 27, 2010 at 7:10 PM, 최규호 wrote: > Hi, > Thank you for your interesting. > > On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park > wrote: >> >> Hi, >> >> Looks good to me except minor fixup. >> >> Acked-by: Kyungmin Park >> >> On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi wrote: >> > This