RE: [PATCH 1/5] ARM: S5PV310: Add HSMMC support and SDHCI configuration

2010-10-04 Thread Jeongbae Seo
Marek Szyprowski wrote: > Hello, > > On Thursday, September 16, 2010 10:37 AM Jeongbae Seo wrote: > > > From: Hyuk Lee > > > > This patch adds to support HSMMC for S5PV310 and S5PC210 and setup for > > HSMMC host controller and also related GPIO. > > At most 4 channel can be used at the same tim

RE: [PATCH 2/5] ARM: S5PV310: Add HSMMC support into S5PV310 and S5PC210

2010-10-04 Thread Jeongbae Seo
Marek Szyprowski wrote: > Hello, > > I'm sorry for a late replay, I've just noticed this patch and have some > comments. > > On Thursday, September 16, 2010 10:37 AM Jeongbae Seo wrote: > > > From: Hyuk Lee > > > > This patch adds to use of HSMMC on S5PV310 and S5PC210. > > The HSMMC platform d

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Mark Brown
On Tue, Oct 05, 2010 at 02:39:00PM +0900, Jassi Brar wrote: > Yes we can have a kconfig entry for 'Controllable EPLL' but that seems > orthogonal to ASoC because, for SMDKs, we choose to produce > accurate signals hence need to manipulate EPLL. The only point is > where to do it. Well, there's tw

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 1:43 PM, Mark Brown wrote: > On Tue, Oct 05, 2010 at 11:19:35AM +0900, Jassi Brar wrote: >> On Tue, Oct 5, 2010 at 10:10 AM, Jassi Brar wrote: >> > On Tue, Oct 5, 2010 at 7:42 AM, Mark Brown > The reason I'm concerned about this is that I've had actual problems > with user

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Mark Brown
On Tue, Oct 05, 2010 at 11:19:35AM +0900, Jassi Brar wrote: > On Tue, Oct 5, 2010 at 10:10 AM, Jassi Brar wrote: > > On Tue, Oct 5, 2010 at 7:42 AM, Mark Brown > >> I'd expect this to be with the other clock configuration code under > >> arch/arm, especially as it's involving the EPLL which can h

Re: [PATCH 1/4] ARM: SAMSUNG: Move the start address of Samsung SoCs' VA space

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 11:06 AM, Kukjin Kim wrote: > This patch moves the start address of Samsung SoCs' VA space so that > can use more vmalloc()/ioremap() space. Of course need to change the > VMALLOC_END for it. > Actually Samsung SoCs' VA space (free for platform use area) becomes > 80MiB with

[PATCH 1/4] ARM: SAMSUNG: Move the start address of Samsung SoCs' VA space

2010-10-04 Thread Kukjin Kim
This patch moves the start address of Samsung SoCs' VA space so that can use more vmalloc()/ioremap() space. Of course need to change the VMALLOC_END for it. Actually Samsung SoCs' VA space (free for platform use area) becomes 80MiB with this patch, it's enough. Signed-off-by: Kukjin Kim Cc: Ben

[PATCH 4/4] ARM: S5P: Cleanup the S5P SoCs' VA address mapping

2010-10-04 Thread Kukjin Kim
Basically S5P SoCs use the Samsung common VA address mapping where plat-samsung and use plat-s5p's mapping also. The later is a little mess. So this patch cleans it up. Signed-off-by: Kukjin Kim Cc: Ben Dooks --- arch/arm/plat-s5p/include/plat/map-s5p.h | 40 +++-- 1 f

[PATCH 3/4] ARM: S5P: Change VMALLOC_END to use more vmalloc()/ioremap() area

2010-10-04 Thread Kukjin Kim
This patch changes VMALLOC_END from 0xE000 to 0xFA00, because some systems want to use more vmalloc()/ioremap() area and now don't use from at 0xE000 to 0xFA00 (the start of Samsung SoCs' VA space) Signed-off-by: Kukjin Kim Cc: Ben Dooks --- arch/arm/mach-s5p6442/include/mach/vm

[PATCH 2/4] ARM: S3C: Change VMALLOC_END to use more vmalloc()/ioremap() area

2010-10-04 Thread Kukjin Kim
This patch changes VMALLOC_END from 0xE000 to 0xFA00, because some systems want to use more vmalloc()/ioremap() area and now don't use from at 0xE000 to 0xFA00 (the start of Samsung SoCs' VA space) Signed-off-by: Kukjin Kim Cc: Ben Dooks --- arch/arm/mach-s3c2410/include/mach/vm

[PATCH 0/4] ARM: SAMSUNG: Change VMALLOC_END and Samsung SoCs' VA space

2010-10-04 Thread Kukjin Kim
This patch changes Samsung SoCs' VA space and VMALLOC_END this can help to use more vmalloc() / ioremap() area with reducing useless area. [PATCH 1/4] ARM: SAMSUNG: Move the start address of Samsung SoCs' VA space [PATCH 2/4] ARM: S3C: Change VMALLOC_END to use more vmalloc()/ioremap() area [PATCH

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 10:10 AM, Jassi Brar wrote: > On Tue, Oct 5, 2010 at 7:42 AM, Mark Brown > wrote: >> On Mon, Oct 04, 2010 at 09:16:23PM +0900, Seungwhan Youn wrote: >> >>> +/* Audio clock settings are belonged to board specific part. Every >>> + * board can set audio source clock setting w

Re: [PATCH 9/10] ASoC: SAMSUNG: Add S/PDIF CPU driver

2010-10-04 Thread Seungwhan Youn
Hi, On Tue, Oct 5, 2010 at 7:02 AM, Mark Brown wrote: > On Mon, Oct 04, 2010 at 09:13:17PM +0900, Seungwhan Youn wrote: > >> +static int spdif_set_sysclk(struct snd_soc_dai *cpu_dai, >> +                             int clk_id, unsigned int freq, int dir) >> +{ > > If you save the clock rate here

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 7:42 AM, Mark Brown wrote: > On Mon, Oct 04, 2010 at 09:16:23PM +0900, Seungwhan Youn wrote: > >> +/* Audio clock settings are belonged to board specific part. Every >> + * board can set audio source clock setting which is matched with H/W >> + * like this function-'set_audi

Re: [alsa-devel] [PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 3:39 AM, Mark Brown wrote: > On Mon, Oct 04, 2010 at 08:52:34PM +0900, Seungwhan Youn wrote: >> This patch add SCLK_SPDIF clock to support source clock of S/PDIF >> on S5PV210. >> >> Signed-off-by: Seungwhan Youn > > Acked-by: Mark Brown > > but this looks like an example

Re: [alsa-devel] [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock

2010-10-04 Thread Jassi Brar
On Tue, Oct 5, 2010 at 3:30 AM, Mark Brown wrote: > On Mon, Oct 04, 2010 at 08:42:25PM +0900, Seungwhan Youn wrote: >> This patch add SCLK_SPDIF clock to support source clock of S/PDIF >> on S5PC100. >> >> Signed-off-by: Seungwhan Youn > > Acked-by: Mark Brown > > but... > >> +static int s5pc100

Re: [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 09:16:23PM +0900, Seungwhan Youn wrote: > +/* Audio clock settings are belonged to board specific part. Every > + * board can set audio source clock setting which is matched with H/W > + * like this function-'set_audio_clock_heirachy'. > + */ > +static int set_audio_clock_h

Re: [PATCH 4/10] ARM: S5PV210: Add S/PDIF platform device

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:46:40PM +0900, Seungwhan Youn wrote: > This patch add S/PDIF platform device to support S/PDIF PCM audio > on S5PV210. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of

Re: [PATCH 2/10] ARM: S5PC100: Modify SCLK_AUDIO{0,1,2} clock as sysclks

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:39:16PM +0900, Seungwhan Youn wrote: > This patch modify SCLK_AUDIO{0,1,2} to be initial as sysclks > on boot-time. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a

Re: [PATCH 6/10] ARM: S5PV210: Add audio clocks as sysclk

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:57:48PM +0900, Seungwhan Youn wrote: > This patch adds audio clocks(SCLK_AUDIO{0,1,2} and SCLK_AUDIO) to be > initial as a sysclk on boot-time. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-sa

Re: [PATCH 1/10] ARM: S5PC100: Add S/PDIF platform device

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:31:59PM +0900, Seungwhan Youn wrote: > This patch add S/PDIF platform device to support S/PDIF PCM audio > on S5PC100. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of

Re: [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:42:25PM +0900, Seungwhan Youn wrote: > This patch add SCLK_SPDIF clock to support source clock of S/PDIF > on S5PC100. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown but... > +static int s5pc100_spdif_set_rate(struct clk *clk, unsigned long rate) > +{ > +

Re: [PATCH 9/10] ASoC: SAMSUNG: Add S/PDIF CPU driver

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 09:13:17PM +0900, Seungwhan Youn wrote: > +static int spdif_set_sysclk(struct snd_soc_dai *cpu_dai, > + int clk_id, unsigned int freq, int dir) > +{ If you save the clock rate here... > + case SND_SOC_SPDIF_MAIN_AUDIO_CLK: > + s

Re: [PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:52:34PM +0900, Seungwhan Youn wrote: > This patch add SCLK_SPDIF clock to support source clock of S/PDIF > on S5PV210. > > Signed-off-by: Seungwhan Youn Acked-by: Mark Brown but this looks like an example of where the get and set rate operations could readily be shar

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 09:50:04PM +0900, Chanwoo Choi wrote: > Do you have additional comment on this patch? No, just what I said already. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock

2010-10-04 Thread Seungwhan Youn
This patch add SCLK_SPDIF clock to support source clock of S/PDIF on S5PV210. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pv210/clock.c | 62 +++-- 1 files changed, 53 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm

RE: [PATCH 1/5] ARM: S5PV310: Add HSMMC support and SDHCI configuration

2010-10-04 Thread Marek Szyprowski
Hello, On Thursday, September 16, 2010 10:37 AM Jeongbae Seo wrote: > From: Hyuk Lee > > This patch adds to support HSMMC for S5PV310 and S5PC210 and setup for > HSMMC host controller and also related GPIO. > At most 4 channel can be used at the same time. > A user can configure SDHCI data bus

RE: [PATCH 2/5] ARM: S5PV310: Add HSMMC support into S5PV310 and S5PC210

2010-10-04 Thread Marek Szyprowski
Hello, I'm sorry for a late replay, I've just noticed this patch and have some comments. On Thursday, September 16, 2010 10:37 AM Jeongbae Seo wrote: > From: Hyuk Lee > > This patch adds to use of HSMMC on S5PV310 and S5PC210. > The HSMMC platform data like card detect, data bus width > and c

[PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock

2010-10-04 Thread Seungwhan Youn
This patch add SCLK_SPDIF clock to support source clock of S/PDIF on S5PC100. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pc100/clock.c | 59 + 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm

[PATCH 0/10] Add S/PDIF common driver for Samsung SoCs

2010-10-04 Thread Seungwhan Youn
Hi, This patch-set is for new S/PDIF common driver that supports S/PDIF PCM audio on S5PC100, S5PC110 and S5PV210. This patch-set is based on two different branches that :- o ASoC patches are based on Mark Brown's git branch 'for-next' (commit id - 135e44aaa47c22b66c8d2acb54da1106a6c17598) o

[PATCH 1/10] ARM: S5PC100: Add S/PDIF platform device

2010-10-04 Thread Seungwhan Youn
This patch add S/PDIF platform device to support S/PDIF PCM audio on S5PC100. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pc100/dev-audio.c | 54 arch/arm/mach-s5pc100/include/mach/map.h |2 + arch/arm/mach-s5pc100/mach-smdkc100.c |4 +

[PATCH 2/10] ARM: S5PC100: Modify SCLK_AUDIO{0,1,2} clock as sysclks

2010-10-04 Thread Seungwhan Youn
This patch modify SCLK_AUDIO{0,1,2} to be initial as sysclks on boot-time. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pc100/clock.c | 72 ++--- 1 files changed, 39 insertions(+), 33 deletions(-) diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/m

[PATCH 4/10] ARM: S5PV210: Add S/PDIF platform device

2010-10-04 Thread Seungwhan Youn
This patch add S/PDIF platform device to support S/PDIF PCM audio on S5PV210. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pv210/dev-audio.c | 40 + arch/arm/mach-s5pv210/include/mach/map.h |3 ++ arch/arm/mach-s5pv210/mach-smdkc110.c |1 +

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-10-04 Thread Chanwoo Choi
Mark Brown wrote: > On Fri, Oct 01, 2010 at 05:25:43PM +0900, Kyungmin Park wrote: >> On Fri, Oct 1, 2010 at 4:24 PM, Mark Brown > >>> It's still good to show the actual connection on the board for clarity - >>> like I say, the regulator API can handle always on regulators and >>> keeping the regu

[PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Seungwhan Youn
This patch add S/PDIF machine driver to support S/PDIF PCM audio on SMDKC100, SMDKC110 and SMDKV210 boards. Signed-off-by: Seungwhan Youn Acked-by: Jassi Brar --- sound/soc/s3c24xx/Kconfig |7 ++ sound/soc/s3c24xx/Makefile |2 + sound/soc/s3c24xx/smdk_spdif.c | 228 +++

[PATCH 8/10] ARM: S5PV210: Add EPLL clock operations

2010-10-04 Thread Seungwhan Youn
This patch adds EPLL specific clock get_rate/set_rate operations on S5PV210. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pv210/clock.c| 95 ++ arch/arm/plat-s5p/include/plat/pll.h |2 + 2 files changed, 97 insertions(+), 0 deletions(-) diff --

[PATCH 6/10] ARM: S5PV210: Add audio clocks as sysclk

2010-10-04 Thread Seungwhan Youn
This patch adds audio clocks(SCLK_AUDIO{0,1,2} and SCLK_AUDIO) to be initial as a sysclk on boot-time. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pv210/clock.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210

[PATCH 7/10] ARM: S5PV210: Fix wrong EPLL rate getting on setup clocks

2010-10-04 Thread Seungwhan Youn
This patch fix wrong EPLL getting on setup clocks on S5PV210. Signed-off-by: Seungwhan Youn --- arch/arm/mach-s5pv210/clock.c |3 ++- arch/arm/mach-s5pv210/include/mach/regs-clock.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5p

RE: [PATCH RESEND] ARM: S5PC110: GONI: Add support for QT602240 TS driver

2010-10-04 Thread Kukjin Kim
Marek Szyprowski wrote: > > Add required platform definitions for QT602240 touchscreen on I2C2 bus. > > Signed-off-by: Kyungmin Park > Signed-off-by: Marek Szyprowski > --- > > Hello, > > This is just a resend of the previous version rebased onto the latest > kgene/for-next branch. > > Best

[PATCH 9/10] ASoC: SAMSUNG: Add S/PDIF CPU driver

2010-10-04 Thread Seungwhan Youn
This patch adds S/PDIF CPU driver for various Samsung SoCs. Signed-off-by: Seungwhan Youn Acked-by: Jassi Brar --- sound/soc/s3c24xx/Kconfig |4 + sound/soc/s3c24xx/Makefile |2 + sound/soc/s3c24xx/spdif.c | 435 sound/soc/s3c24xx/spdif.h

RE: [PATCH v3] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board

2010-10-04 Thread Marek Szyprowski
Hello, On Saturday, October 02, 2010 12:41 PM Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Add required platform definitions for S6E63M0 LCD controller on Samsung > > Goni board. > > > > Signed-off-by: Marek Szyprowski > > Signed-off-by: Kyungmin Park > > --- > > > > Changes since v2: >

[PATCH RESEND] ARM: S5PC110: GONI: Add support for QT602240 TS driver

2010-10-04 Thread Marek Szyprowski
Add required platform definitions for QT602240 touchscreen on I2C2 bus. Signed-off-by: Kyungmin Park Signed-off-by: Marek Szyprowski --- Hello, This is just a resend of the previous version rebased onto the latest kgene/for-next branch. Best regards -- Marek Szyprowski Samsung Poland R&D Cent

Re: [alsa-devel] [PATCH 0/10] Add S/PDIF common driver for Samsung SoCs

2010-10-04 Thread Jassi Brar
On Mon, Oct 4, 2010 at 8:25 PM, Seungwhan Youn wrote: > Hi, > > This patch-set is for new S/PDIF common driver that supports S/PDIF > PCM audio on S5PC100, S5PC110 and S5PV210. > > This patch-set is based on two different branches that :- >  o ASoC patches are based on Mark Brown's git branch 'for