RE: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-05 Thread Kukjin Kim
Seungwhan Youn wrote: > > >>> I hope you noticed that this clock hierarchy is a _very_ board specific > >>> thing. > >>> We can easily place SoCs' shared stuff in arch/arm/plat-samsung (or > >>> similar) > >>> Any suggestions, where do we place code shared by SMDK-boards ? > >> > >> plat-samsung

[PATCH V2 0/3] ARM: S5PV310: Add support HSMMC

2010-10-05 Thread Jeongbae Seo
This patch support HSMMC for S5PV310 and S5PC210. And addressed comments from Marek. Changes since v1: - Added drive strength handling in each SDMMC channel - Separated to board specific and common changes [PATCH V2 1/3] ARM: S5PV310: Add support HSMMC and SDHCI configuration [PATCH V2 2/3] ARM:

[PATCH V2 1/3] ARM: S5PV310: Add support HSMMC and SDHCI configuration

2010-10-05 Thread Jeongbae Seo
From: Hyuk Lee This patch adds support HSMMC for S5PV310 and S5PC210 and setup for HSMMC host controller and also related GPIO. At most 4 channel can be used at the same time. A user can configure SDHCI data bus as 8bit or 4bit. Signed-off-by: Hyuk Lee Signed-off-by: Jeongbae Seo --- Changes s

[PATCH V2 3/3] ARM: S5PV310: Add support HSMMC on SMDKV310 and SMDKC210

2010-10-05 Thread Jeongbae Seo
From: Hyuk Lee This patch adds support HSMMC for S5PV310(SMDKV310) and S5PC210(SMDKC210). Signed-off-by: Hyuk Lee Signed-off-by: Jeongbae Seo --- Changes since v1: - Separated to board specific and common changes (This is for board specific part) arch/arm/mach-s5pv310/mach-smdkc210.c | 4

[PATCH V2 2/3] ARM: S5PV310: Add HSMMC platform data

2010-10-05 Thread Jeongbae Seo
From: Hyuk Lee This patch adds initialization HSMMC device information. And HSMMC platform data like card detect, data bus width and capability is configured. Signed-off-by: Hyuk Lee Signed-off-by: Jeongbae Seo --- Changes since v1: - Separated to board specific and common changes (This is f

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Kyungmin Park
On Wed, Oct 6, 2010 at 8:27 AM, Maurus Cuelenaere wrote: >  Op 06-10-10 01:23, Kyungmin Park schreef: >> Hi, >> >> I agree your approach, put the common features in common place. >> but Samsung maintainers insist put these at each machine file at current >> time. >> >> So move this to the each ma

[PATCH] ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used

2010-10-05 Thread Maurus Cuelenaere
s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs() implementations, which get included through mach/pm-core.h. Add __maybe_unused to silence warnings when it isn't used (e.g. on S3C64XX platforms). Signed-off-by: Maurus Cuelenaere --- arch/arm/plat-samsung/pm.c |5 +++--

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Maurus Cuelenaere
Op 06-10-10 01:23, Kyungmin Park schreef: > Hi, > > I agree your approach, put the common features in common place. > but Samsung maintainers insist put these at each machine file at current time. > > So move this to the each machines for their tastes. I did it that way first, but then wondered wh

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Kyungmin Park
Hi, I agree your approach, put the common features in common place. but Samsung maintainers insist put these at each machine file at current time. So move this to the each machines for their tastes. Thank you, Kyungmin Park On Wed, Oct 6, 2010 at 8:09 AM, Maurus Cuelenaere wrote: > The only mi

[PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards

2010-10-05 Thread Maurus Cuelenaere
This patch adds the power on/off button on both SmartQ boards as suspend wakeup sources. Signed-off-by: Maurus Cuelenaere --- arch/arm/mach-s3c64xx/mach-smartq5.c |1 + arch/arm/mach-s3c64xx/mach-smartq7.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

[PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Maurus Cuelenaere
The only missing thing for SoC-wide suspend support, is a call to s3c_pm_init, so add that. This was tested on a S3C6410 SmartQ 7. Signed-off-by: Maurus Cuelenaere --- arch/arm/mach-s3c64xx/pm.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/pm.c

[PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support

2010-10-05 Thread Maurus Cuelenaere
These patches add suspend support to the SmartQ (and other S3C64XX) boards. Currently the LCD needs re-initializing when waking up, otherwise it'll just display a WSOD. This was tested on a SmartQ 7. Maurus Cuelenaere (2): ARM: S3C64XX: Add suspend support ARM: S3C64XX: Add wakeup sources to

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-05 Thread Mark Brown
On Tue, Oct 05, 2010 at 04:09:47PM +0900, Jassi Brar wrote: > On Tue, Oct 5, 2010 at 2:59 PM, Mark Brown > > Well, there's two approaches the driver can take: one is to change the > > EPLL to deliver the clock rates which allow maximum flexibility, the > > other is to constrain the clock rates off

RE: [PATCH] ARM: SAMSUNG: Fix on default of s3c24xx_uart_devs

2010-10-05 Thread Marek Szyprowski
Hello, On Tuesday, October 05, 2010 2:29 PM Jaecheol Lee wrote: > This patch adds default dev->bus, platform_bus_type of s3c24xx_uart_devs. > If there is no default dev->bus, we cannot get the proper clock 'id' from > clk_get() in the console_initcall(). > This problem occurs when only defined 'u

[PATCH] ARM: S5P64X0: FIX typo in the ADC device name

2010-10-05 Thread Kukjin Kim
From: Naveen Krishna Ch Fix the touch screen device name from s3c64x0-adc to s3c64xx-adc. Signed-off-by: Naveen Krishna Ch Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p64x0/cpu.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5p64x0/cpu.c b/arch/a

[PATCH] ARM: SAMSUNG: Fix on default of s3c24xx_uart_devs

2010-10-05 Thread Jaecheol Lee
This patch adds default dev->bus, platform_bus_type of s3c24xx_uart_devs. If there is no default dev->bus, we cannot get the proper clock 'id' from clk_get() in the console_initcall(). This problem occurs when only defined 'uclk1' as uart clock. Reported-by: Jongpill Lee Signed-off-by: Jaecheol L

RE: [PATCH 5/7] ARM: S5PC210: I2C0/1 devices support on Universal board

2010-10-05 Thread Kukjin Kim
Kyungmin Park wrote: > > From: Kyungmin Park > > Camera devices use the I2C0 and Gyro uese the I2C1 on universal board. > > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv310/Kconfig |2 ++ > arch/arm/mach-s5pv310/mach-universal_c210.c | 14 ++ > 2 file

RE: [PATCH 1/7] ARM: S5PC210: Universal OneNAND support

2010-10-05 Thread Kukjin Kim
Kyungmin Park wrote: > > From: Kyungmin Park > > OneNAND device support for Universal board. > > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv310/Kconfig |1 + > arch/arm/mach-s5pv310/mach-universal_c210.c |2 ++ > 2 files changed, 3 insertions(+), 0 deletions(

Re: [PATCH v2 3/3] ARM: S5PC210: Set the common L2 cache configurations

2010-10-05 Thread Kyungmin Park
On Tue, Oct 5, 2010 at 5:47 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> From: Kyungmin Park >> >> S5PC210 has PL310 1MiB L2 cache. >> It uses the optimized data & tag latency and also enable the prefetch. >> >> Signed-off-by: Kyungmin Park >> --- >>  arch/arm/mach-s5pv310/cpu.c |   19 +++

RE: [PATCH 0/7] ARM: S5PC210: I2C devices support and Universal board updates

2010-10-05 Thread Marek Szyprowski
Hello, On Tuesday, October 05, 2010 10:40 AM Kukjin Kim wrote: > > I think we made some conclusion. first apply the current style and > > improve it later for consistency. > > > Yeah, we should decide for this. > > However, it's expected following problem with current I2C style. > > Suppose A b

Re: [PATCH 0/7] ARM: S5PC210: I2C devices support and Universal board updates

2010-10-05 Thread Kyungmin Park
On Tue, Oct 5, 2010 at 5:40 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> Hi, >> > Hi, > >> I think we made some conclusion. first apply the current style and >> improve it later for consistency. >> > Yeah, we should decide for this. > > However, it's expected following problem with current I

RE: [PATCH v2 3/3] ARM: S5PC210: Set the common L2 cache configurations

2010-10-05 Thread Kukjin Kim
Kyungmin Park wrote: > > From: Kyungmin Park > > S5PC210 has PL310 1MiB L2 cache. > It uses the optimized data & tag latency and also enable the prefetch. > > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv310/cpu.c | 19 +++ > 1 files changed, 19 insertions(+), 0 de

RE: [PATCH 0/7] ARM: S5PC210: I2C devices support and Universal board updates

2010-10-05 Thread Kukjin Kim
Kyungmin Park wrote: > > Hi, > Hi, > I think we made some conclusion. first apply the current style and > improve it later for consistency. > Yeah, we should decide for this. However, it's expected following problem with current I2C style. Suppose A board want to use only I2C0, 1, 2, 3, 4, 7

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-05 Thread Seungwhan Youn
>>> I hope you noticed that this clock hierarchy is a _very_ board specific >>> thing. >>> We can easily place SoCs' shared stuff in arch/arm/plat-samsung (or similar) >>> Any suggestions, where do we place code shared by SMDK-boards ? >> >> plat-samsung would probably be fine for that also - crea

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-05 Thread Jassi Brar
On Tue, Oct 5, 2010 at 2:59 PM, Mark Brown wrote: > On Tue, Oct 05, 2010 at 02:39:00PM +0900, Jassi Brar wrote: > >> Yes we can have a kconfig entry for 'Controllable EPLL' but that seems >> orthogonal to ASoC because, for SMDKs, we choose to produce >> accurate signals hence need to manipulate EP