RE: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kukjin Kim
Chris Ball wrote: > > Hi Kyungmin, > > On Tue, Oct 12, 2010 at 11:53:35AM +0900, Kyungmin Park wrote: > > Hi Chris, > > > > we make a conclusion use this patch. Can you merge it for 2.6.37? > > > > Acked-by: Kyungmin Park > > I don't feel that I can, because Ben Dooks is listed as the maintaine

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-11 Thread Seungwhan Youn
>> I'm OK with having the code in the driver, I just want something there >> that makes it more discoverable that it's there like a config option. >> Having the driver log loudly when it reconfigures the EPLL would >> probably also cover it. > > Thanks. Yes, we should print warning upon changing EP

Re: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Chris Ball
Hi Kyungmin, On Tue, Oct 12, 2010 at 11:53:35AM +0900, Kyungmin Park wrote: > Hi Chris, > > we make a conclusion use this patch. Can you merge it for 2.6.37? > > Acked-by: Kyungmin Park I don't feel that I can, because Ben Dooks is listed as the maintainer for this driver and the patch does no

Re: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kyungmin Park
Hi Chris, we make a conclusion use this patch. Can you merge it for 2.6.37? Acked-by: Kyungmin Park On Mon, Oct 11, 2010 at 4:50 PM, Kukjin Kim wrote: > From: Jeongbae Seo > > This patch adds to support no internal clock divider in SDHCI. > The external clock divider can be used to make a pro

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-11 Thread Jassi Brar
On Mon, Oct 11, 2010 at 7:47 PM, Mark Brown wrote: > On Sat, Oct 09, 2010 at 10:52:26AM +0900, Jassi Brar wrote: >> On Fri, Oct 8, 2010 at 6:07 PM, Seungwhan Youn wrote: > >> > Now, I'm almost finished 2nd patch for submit except this audio clock >> > setting. For now, I can only think that remov

[PATCH] ARM: SAMSUNG: Bug fix spin_lock recursion in clk_enable() and clk_disable()

2010-10-11 Thread Jaecheol Lee
From: Minho Ban The clk_enable() and clk_disable() can be used process and ISR either. So spin_lock_irqsave should be used instead. Signed-off-by: Minho Ban Signed-off-by: Jaecheol Lee --- arch/arm/plat-samsung/clock.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) dif

Re: [PATCH v2 0/6] ARM: S5PV210: Add support S5PV210/S5PC110 CPUFREQ

2010-10-11 Thread MyungJoo Ham
On Tue, Oct 12, 2010 at 9:15 AM, Kukjin Kim wrote: > MyungJoo Ham wrote: >> >> On Mon, Oct 11, 2010 at 5:04 PM, Sangbeom Kim >> wrote: >> > On Monday, Oct 11, 2010 9:12 AM, MyungJoo Ham >> wrote: >> >> >> >> Hello, >> >> >> >> On Fri, Oct 8, 2010 at 6:52 PM, Kukjin Kim > wrote: >> >> > Sangbeom

RE: [PATCH v2 0/6] ARM: S5PV210: Add support S5PV210/S5PC110 CPUFREQ

2010-10-11 Thread Kukjin Kim
MyungJoo Ham wrote: > > On Mon, Oct 11, 2010 at 5:04 PM, Sangbeom Kim > wrote: > > On Monday, Oct 11, 2010 9:12 AM, MyungJoo Ham > wrote: > >> > >> Hello, > >> > >> On Fri, Oct 8, 2010 at 6:52 PM, Kukjin Kim wrote: > >> > Sangbeom Kim wrote: > >> >> > >> >> Hi all, > >> >> I know that there is

RE: [PATCH 0/3] ARM: S5PV310: Add I2C support

2010-10-11 Thread Kukjin Kim
Jongsun Han wrote: > > This patch adds the I2C support for S5PV310 > > [PATCH 1/3] ARM: SAMSUNG: Add a helper function for I2C(3,4,5,6,7) platform > devices > [PATCH 2/3] ARM: S5PV310: Add address and IRQ definitions for I2C(1,2,3,4,5,6,7) > [PATCH 3/3] ARM: S5PV310: Add I2C(0,1,3,4,5,6,7) suppor

RE: [PATCH V3] ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support

2010-10-11 Thread Kukjin Kim
Marek Szyprowski wrote: > > S5PV310 and S5PC210 support more I2C devices than previous SoCs. > Add the device support code for them. > > Signed-off-by: Kyungmin Park > Signed-off-by: Marek Szyprowski > Signed-off-by: Kukjin Kim > --- > > Changes since V2: > - removed some s5p reference leftov

[PATCH V2] ARM: S5PV310: Change to using s3c_gpio_cfgall_range()

2010-10-11 Thread Kukjin Kim
Change the code setting a range of GPIO pins' configuration and pull state to use the recently introduced s3c_gpio_cfgall_range(). Signed-off-by: Kukjin Kim --- Changes since v1: - Fix wrong s3c_gpio_cfgall_range arch/arm/mach-s5pv310/setup-i2c0.c |5 ++--- arch/arm/mach-s5pv310/setup-i2c1

[PATCH 2/6 v5] V4L/DVB: s5p-fimc: mem2mem driver refactoring and cleanup

2010-10-11 Thread Sylwester Nawrocki
Register access functions refactored for camera capture interface control. Removed the workqueue since it was only useful for FIFO output mode which is not supported at this time. Fixed errors on module unload. Comments and whitespace cleanup. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyun

[PATCH 6/6 v5] V4L/DVB: s5p-fimc: Add suport for FIMC on S5PC210 SoCs

2010-10-11 Thread Sylwester Nawrocki
Enable FIMC operation on S5PC210 (S5PV310) SoCs. This a minimal adaptation to obtain functionality of older FIMC IP revisions (S5PC100, S5PC110) on S5PC210 SOcs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c | 157 ++

[PATCH 1/6 v5] V4L/DVB: s5p-fimc: Register definition cleanup

2010-10-11 Thread Sylwester Nawrocki
Add MIPI CSI format definitions, prepare DMA address definitions for interlaced input frame mode. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-reg.c |6 +- drivers/media/video/s5p-fimc/regs-fimc.h | 61 -

[PATCH 3/6 v5] V4L/DVB: s5p-fimc: Fix 90/270 deg rotation errors

2010-10-11 Thread Sylwester Nawrocki
Due to errorneous swapping of image dimensions the rotation control was not handled properly in subsequent calls. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c | 15 ++--- drivers/media/video/s5p-fimc/fimc-reg.c | 101 +++

[PATCH 4/6 v5] V4L/DVB: s5p-fimc: Do not lock both buffer queues in s_fmt

2010-10-11 Thread Sylwester Nawrocki
It is not necessary to lock both capture and output buffer queue while setting format for single queue. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c | 69 + 1 files changed, 31 insertions(+), 38 deletio

[PATCH v5 0/6] Add support for camera capture in s5p-fimc driver

2010-10-11 Thread Sylwester Nawrocki
Hi all, this is a fifth version of patches adding camera capture capability to the s5p-fimc driver. It incorporates minor fixes that I tracked just after sending v4, my apologies for spaming the list.. Hopefully that is the last version to be merged. Changes since v1: - entirely removed plat-sam

Re: [PATCH 1/5 v4] V4L/DVB: s5p-fimc: Register definition cleanup

2010-10-11 Thread Sylwester Nawrocki
Hi Seuni, thanks for you review! On 10/11/2010 07:09 AM, 박세운 wrote: > Sewoon Park wrote: > >> Add MIPI CSI format definitions, prepare DMA address >> definitions for interlaced input frame mode. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> --- >> drivers/media/vi

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-11 Thread Mark Brown
On Sat, Oct 09, 2010 at 10:52:26AM +0900, Jassi Brar wrote: > On Fri, Oct 8, 2010 at 6:07 PM, Seungwhan Youn wrote: > > Now, I'm almost finished 2nd patch for submit except this audio clock > > setting. For now, I can only think that remove audio clock setting > > from this machine code, and add

Re: [PATCH v2 0/6] ARM: S5PV210: Add support S5PV210/S5PC110 CPUFREQ

2010-10-11 Thread MyungJoo Ham
On Mon, Oct 11, 2010 at 5:04 PM, Sangbeom Kim wrote: > On Monday, Oct 11, 2010 9:12 AM, MyungJoo Ham > wrote: >> >> Hello, >> >> On Fri, Oct 8, 2010 at 6:52 PM, Kukjin Kim wrote: >> > Sangbeom Kim wrote: >> >> >> >> Hi all, >> >> I know that there is another S5PV210 CPUFREQ patch from Mr. Ham.

[PATCH V3] ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support

2010-10-11 Thread Marek Szyprowski
S5PV310 and S5PC210 support more I2C devices than previous SoCs. Add the device support code for them. Signed-off-by: Kyungmin Park Signed-off-by: Marek Szyprowski Signed-off-by: Kukjin Kim --- Changes since V2: - removed some s5p reference leftovers from V1 - adapted setup-i2cX.c to use s3c_g

RE: [PATCH v2 0/6] ARM: S5PV210: Add support S5PV210/S5PC110 CPUFREQ

2010-10-11 Thread Sangbeom Kim
On Monday, Oct 11, 2010 9:12 AM, MyungJoo Ham wrote: > > Hello, > > On Fri, Oct 8, 2010 at 6:52 PM, Kukjin Kim wrote: > > Sangbeom Kim wrote: > >> > >> Hi all, > >> I know that there is another S5PV210 CPUFREQ patch from Mr. Ham. > >> But, That patchset seems to have unclear part. > >> > > http

[PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kukjin Kim
From: Jeongbae Seo This patch adds to support no internal clock divider in SDHCI. The external clock divider can be used to make a proper clock because SDHCI doesn't support internal clock divider by itself. If external clock divider type is selected, some functions related with clock control wi

[PATCH] ARM: S5PC100: Change I2C2 and I2C3 IRQ names

2010-10-11 Thread Kukjin Kim
This patch changes I2C2 and I2C3 interrupt name from IRQ_CANX to IRQ_IICX according other SoCs' I2C interrupt naming rule. Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pc100/include/mach/irqs.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pc100/inc

RE: [PATCH v2] ARM: S5PC210: I2C devices updates

2010-10-11 Thread Kukjin Kim
Marek Szyprowski wrote: > > Hello, > > This is an updated version of I2C patches posted by Kyungmin Park in > '[PATCH 0/7] ARM: S5PC210: I2C devices support and Universal board > updates' thread. > > All issues related to i2c device definitions reported by Kukjin Kim have > been fixed. We also m