Re: [PATCH] [CPUFREQ] Move ARM Samsung cpufreq drivers to drivers/cpufreq/

2011-06-01 Thread Kyungmin Park
Hi, I think you already saw the same patchs[1] at mailing list and even worse you commented it[2] One different is kconfig handling. and these can be handled easily as you did. Please respect others works. Thank you, Kyungmin Park 1. http://www.gossamer-threads.com/lists/linux/kernel/1385739?pa

[PATCH] ARM: S5P: Should be S3C_VA_USB_HSPHY instead of S5P_VA_XX

2011-06-01 Thread Kukjin Kim
Basically, other S3C SoCs and S5PC100 use 'S3C_VA_USB_HSPHY' commonly. It should be changed to 'S3C_VA_USB_HSPHY' for common usage and others. Now happens build error on S5PC100. Cc: Greg Kroah-Hartman Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/cpu.c |2 +- ar

Re: [PATCH 5/10] arch/arm/mach-s5pv210/cpufreq.c: add missing clk_put

2011-06-01 Thread Kukjin Kim
On 06/01/11 10:10, Julia Lawall wrote: From: Julia Lawall The successive calls to clk_get each call clk_put in the case of failure, but this is not done for subsequent error handling code. The calls to clk_get are moved to the end of the function, and appropriate gotos are added. A simplified

[PATCH] [CPUFREQ] Move ARM Samsung cpufreq drivers to drivers/cpufreq/

2011-06-01 Thread Kukjin Kim
According to discussion of the ARM arch subsystem migration, ARM cpufreq drivers move to drivers/cpufreq. So this patch adds Kconfig.arm for ARM like x86 and adds Samsung S5PV210 and EXYNOS4210 cpufreq driver compile in there. As a note, otherw will be moved. Cc: Dave Jones Signed-off-by: Kukjin

[PATCH 5/10] arch/arm/mach-s5pv210/cpufreq.c: add missing clk_put

2011-06-01 Thread Julia Lawall
From: Julia Lawall The successive calls to clk_get each call clk_put in the case of failure, but this is not done for subsequent error handling code. The calls to clk_get are moved to the end of the function, and appropriate gotos are added. A simplified version of the semantic match that finds

Re: [PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011, 18:01:34 schrieben Sie: > Hello. > > Heiko Stübner wrote: > > s3c2410_dma_chan is not a type itself, so struct is required. > > Your signoffs are missing, so your patches can't be applied... *grml* ... I seem to have bad luck with my patches these days will resend

[PATCH v2 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git a/arch/arm/mach-s3c2410/Makefile b/arch/a

[PATCH v2 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/

[PATCH v2 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966 100644 --- a/arch

[PATCH v2 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Changes since v1: add missing Signed-off-by lines Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops

Re: [PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Sergei Shtylyov
Hello. Heiko Stübner wrote: s3c2410_dma_chan is not a type itself, so struct is required. Your signoffs are missing, so your patches can't be applied... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.k

Re: [PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011 schrieb Abdoulaye Walsimou GAYE: > Heiko Stübner wrote: > > The syscore_ops patch from Rafael J. Wysocki introduced some small > > glitches for the S3C24XX cpus resulting in compile errors. > > I submitted same patches days ago [1], > [1] > http://thread.gmane.org/gmane.li

Re: [PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Abdoulaye Walsimou GAYE
Heiko Stübner wrote: The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c r

Re: [PATCH] Fix compile failures by syscore_ops change on s3c2416

2011-06-01 Thread Heiko Stübner
Am Dienstag 31 Mai 2011 schrieb Sergei Shtylyov: > On 31-05-2011 0:34, Heiko Stübner wrote: > > s3c24xx_irq_syscore_ops is only defined in mach-s3c2410/irq.c which is > > not used by s3c2416. > > Also s3c2410_dma_chan needs a struct prefix > > Saying "also" seems a good sign that you should do

[PATCH 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
--- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git a/arch/arm/mach-s3c2410/Makefile b/arch/arm/mach-s3c2410/Makefile index 0d

[PATCH 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-s3c2410/irq.c b/ar

[PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/ar

[PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c remove the now empty mach-s