Re: [PATCH] ARM: S5P: Fix compilation error for exynos4_defconfig

2011-06-02 Thread Tushar Behera
Hi Marek, Thanks for your review. On Friday 03 June 2011 11:23 AM, Marek Szyprowski wrote: Hello, On Friday, June 03, 2011 7:07 AM Tushar Behera wrote: EHCI requires that USB support be enabled in kernel config. Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. Signed-off-by: T

RE: [PATCH] ARM: S5P: Fix compilation error for exynos4_defconfig

2011-06-02 Thread Marek Szyprowski
Hello, On Friday, June 03, 2011 7:07 AM Tushar Behera wrote: > EHCI requires that USB support be enabled in kernel config. > Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. > > Signed-off-by: Tushar Behera > --- > arch/arm/plat-s5p/Kconfig |1 + > 1 files changed, 1 insertio

[PATCH] ARM: S5P: Fix compilation error for exynos4_defconfig

2011-06-02 Thread Tushar Behera
EHCI requires that USB support be enabled in kernel config. Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. Signed-off-by: Tushar Behera --- arch/arm/plat-s5p/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat

Can't compile with exynos4_defconfig

2011-06-02 Thread Sangbeom Kim
Hi, By default exynos4_defconfig, 3.0-rc1 can't compile the code. It seem to have dependency on usb configuration. Error message: arch/arm/plat-s5p/built-in.o: In function `s5p_ehci_set_platdata': /home/cornus/tmp/linux-3.0-rc1/arch/arm/plat-s5p/dev-ehci.c:54: undefined reference to `s5p_usb_phy_

[PATCH 1/7] s5p-fimc: Fix possible memory leak during capture devnode registration

2011-06-02 Thread Sylwester Nawrocki
Add missing kfree on the error path. Reported-by: Tomasz Stanislawski Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-captur

[PATCH v3 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-02 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git a/arch/arm/mach-s3c2410/Makefile b/arch/ar

[PATCH v3 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-02 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/

[PATCH v3 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-02 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966 100644 --- a/arch

[PATCH v3 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-02 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Changes since v1: add missing Signed-off-by lines Changes since v2: fix mangled tabs Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_c

[PATCH 4/7] s5p-fimc: Fix wrong buffer size in queue_setup

2011-06-02 Thread Sylwester Nawrocki
Avoid dereferencing of NULL f->fmt. Correct size of the allocated buffer in case the crop rectangle is smaller than the bounds rectangle (configured with S_FMT). Also remove redundant check for *num_buffer == 0 as this case is handled in videobuf2. Signed-off-by: Sylwester Nawrocki Signed-off-by:

[PATCH 6/7] s5p-fimc: Use pix_mp for the color format lookup

2011-06-02 Thread Sylwester Nawrocki
With multi-planar formats fmt.pix_mp member of struct v4l2_format should be used rather than fmt.pix. Fix find_fmt() function to do the right thing. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c |2 +- 1 files changed, 1 insertio

[PATCH 7/7] s5p-fimc: Update copyright notices

2011-06-02 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |4 ++-- drivers/media/video/s5p-fimc/fimc-core.c|7 +++ drivers/media/video/s5p-fimc/fimc-core.h|4 +--- 3 files changed, 6 insertions(+), 9 deletions(-) diff

[PATCH 5/7] s5p-fimc: Remove empty buf_init operation

2011-06-02 Thread Sylwester Nawrocki
The buf_init buffer queue operation is optional and buffer_init() does nothing, remove it. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/media/

[PATCH 2/7] s5p-fimc: Fix V4L2_PIX_FMT_RGB565X description

2011-06-02 Thread Sylwester Nawrocki
Remove V4L2_MBUS_FMT_RGB565_2X8_BE media code entry as camera interface supports only packed YUYV formats. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH 3/7] s5p-fimc: Fix data structures documentation and cleanup debug trace

2011-06-02 Thread Sylwester Nawrocki
Correct inconsistencies in data structures' documentation. Remove meaningless debug traces. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |9 - drivers/media/video/s5p-fimc/fimc-core.c|6 -- drivers/media/v

[PATCH 0/7] s5p-fimc driver fixes for 3.0

2011-06-02 Thread Sylwester Nawrocki
Hello, the following are a few bugfix patches for s5p-fimc driver. Except the kernel-doc comments corrections, debug trace cleanup and the copyright update they fix the buffer allocation issue and possible memory leak on error path. drivers/media/video/s5p-fimc/fimc-capture.c | 21 ++-

Re: [PATCH] ARM: exynos4: fix secondary CPU boot

2011-06-02 Thread Marc Zyngier
On Thu, 2011-06-02 at 17:39 +0900, Kyungmin Park wrote: > On Thu, Jun 2, 2011 at 5:34 PM, Marc Zyngier wrote: > > On Thu, 2011-06-02 at 16:01 +0900, Kyungmin Park wrote: > >> On Fri, May 27, 2011 at 12:11 AM, Marc Zyngier > >> wrote: > >> > On Wed, 2011-05-25 at 12:06 -0700, Kukjin Kim wrote: >

Re: [PATCH] ARM: exynos4: fix secondary CPU boot

2011-06-02 Thread Kyungmin Park
On Thu, Jun 2, 2011 at 5:34 PM, Marc Zyngier wrote: > On Thu, 2011-06-02 at 16:01 +0900, Kyungmin Park wrote: >> On Fri, May 27, 2011 at 12:11 AM, Marc Zyngier wrote: >> > On Wed, 2011-05-25 at 12:06 -0700, Kukjin Kim wrote: >> >> On 05/25/11 11:04, Marc Zyngier wrote: >> >> > On Wed, 2011-05-25

Re: [PATCH] ARM: exynos4: fix secondary CPU boot

2011-06-02 Thread Marc Zyngier
On Thu, 2011-06-02 at 16:01 +0900, Kyungmin Park wrote: > On Fri, May 27, 2011 at 12:11 AM, Marc Zyngier wrote: > > On Wed, 2011-05-25 at 12:06 -0700, Kukjin Kim wrote: > >> On 05/25/11 11:04, Marc Zyngier wrote: > >> > On Wed, 2011-05-25 at 10:28 -0700, Kukjin Kim wrote: > >> >> On 05/20/11 06:46

Re: [PATCH] ARM: exynos4: fix secondary CPU boot

2011-06-02 Thread Kyungmin Park
On Fri, May 27, 2011 at 12:11 AM, Marc Zyngier wrote: > On Wed, 2011-05-25 at 12:06 -0700, Kukjin Kim wrote: >> On 05/25/11 11:04, Marc Zyngier wrote: >> > On Wed, 2011-05-25 at 10:28 -0700, Kukjin Kim wrote: >> >> On 05/20/11 06:46, Marc Zyngier wrote: >> >> (snip) >> >> > So that address has cha