Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 3:58 AM, Russell King - ARM Linux wrote: >> > >> >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). >> > >> >> However, 2 is not really a requirement for audio - you can queue several >> >> single slave transfers (one per period) initially, and then

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 3:11 AM, Mark Brown wrote: > On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: >> On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > >> > Circular buffers are nice from the point of view of allowing you to >> > (providing the hardware supports it) totally disable the pe

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Wed, Jun 08, 2011 at 01:16:40AM +0530, Jassi Brar wrote: > IMHO Samsung SoC team (not his majesty Mr Kyungmin Park) are justified > if they are not so eager right now. Since I no more would have to spend > sleepless nights over > SPDIF underruns, I can side with what Kukjin Kim(Samsung maintaine

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: > On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > wrote: > > On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > > > >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > > > >> However, 2 is

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Mark Brown
On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: > On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > > Circular buffers are nice from the point of view of allowing you to > > (providing the hardware supports it) totally disable the periodic audio > > interrupts and leave the system to run f

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 11:59 PM, Russell King - ARM Linux wrote: >> The discussion did take off a few months ago, but we didn't reach anywhere. >> Being able to queue request from the 'done' callback, the need of >> circular buffer >> API (possibly a free-running one too) and callbacks in irq-cont

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown wrote: > On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > >> However, 2 is not really a requirement for audio - you can queue several >> single slav

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Mark Brown
On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > However, 2 is not really a requirement for audio - you can queue several > single slave transfers (one per period) initially, and then you get >

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Tue, Jun 07, 2011 at 03:45:18PM +0530, Jassi Brar wrote: > On Tue, Jun 7, 2011 at 1:45 PM, Russell King - ARM Linux > wrote: > > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: > >> Unfortunately, no. There are some features of Samsung's DMA API that > >> the drivers have come to re

Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Grant Likely
On Tue, Jun 07, 2011 at 05:42:47PM +0900, Kyungmin Park wrote: > On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham wrote: > > The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of > > GPIO > > pull up/down registers on Exynos4 platform. Fix this incorrect mapping by > > adding

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Tushar Behera
Hi Alim, On 7 June 2011 13:18, root wrote: > Signed-off-by: alim.akhtar > --- >  arch/arm/configs/exynos4_defconfig |    1 + >  arch/arm/configs/s5p64x0_defconfig |    1 + >  arch/arm/configs/s5pc100_defconfig |    1 + >  arch/arm/configs/s5pv210_defconfig |    1 + >  arch/arm/plat-samsung/Kconf

Kernel crash on smdk2416 board with linux-3.0.0-rc2.

2011-06-07 Thread Thomas Abraham
Hi, In linux-3.0.0-rc2, for smdk2416 board, the kernel crashes while booting up. The boot log is listed below. By turning of usb support, the kernel boots up. This issue was not observed in linux-2.6.39 stable. Starting kernel ... Uncompressing Linux... done, booting the kernel. Linux version 3.

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Koul, Vinod
On Tue, 2011-06-07 at 15:45 +0530, Linus Walleij wrote: > On Tue, Jun 7, 2011 at 10:09 AM, Jassi Brar wrote: > > > There are some features of Samsung's DMA API that > > the drivers have come to rely upon. > > Can we get an overview of what these features are? > > When I look at this specific co

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Linus Walleij
On Tue, Jun 7, 2011 at 10:09 AM, Jassi Brar wrote: > There are some features of Samsung's DMA API that > the drivers have come to rely upon. Can we get an overview of what these features are? When I look at this specific code I cannot see anything that the dmaengine does not already support or

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:45 PM, Russell King - ARM Linux wrote: > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: >> Unfortunately, no. There are some features of Samsung's DMA API that >> the drivers have come to rely upon. >> Besides, I am not particularly a fan of the generic API. A

Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Kyungmin Park
On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham wrote: > The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of > GPIO > pull up/down registers on Exynos4 platform. Fix this incorrect mapping by > adding > wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown fun

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Kyungmin Park
On Tue, Jun 7, 2011 at 5:15 PM, Russell King - ARM Linux wrote: > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: >> Unfortunately, no. There are some features of Samsung's DMA API that >> the drivers have come to rely upon. >> Besides, I am not particularly a fan of the generic API. A

[PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Thomas Abraham
The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of GPIO pull up/down registers on Exynos4 platform. Fix this incorrect mapping by adding wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown functions. Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-exyn

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: > Unfortunately, no. There are some features of Samsung's DMA API that > the drivers have come to rely upon. > Besides, I am not particularly a fan of the generic API. And IIRC, > neither is Ben Dooks, the designer of the > Samsung's DMA A

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:30 PM, Kyungmin Park wrote: > > As I know there's are PL330 DMA implementation by > MODULE_AUTHOR("Jaswinder Singh "); Thanks for CC'ing me, though my current contact is jaswinder.si...@linaro.org or jassisinghb...@gmail.com Perhaps I need to change the email in all locati

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:18 PM, root wrote: > Signed-off-by: alim.akhtar > --- >  arch/arm/configs/exynos4_defconfig |    1 + >  arch/arm/configs/s5p64x0_defconfig |    1 + >  arch/arm/configs/s5pc100_defconfig |    1 + >  arch/arm/configs/s5pv210_defconfig |    1 + >  arch/arm/plat-samsung/Kconf

[PATCH] ARM: Exynos4: fix compilation break

2011-06-07 Thread Marek Szyprowski
The patch "ARM: SAMSUNG: Add support for pre-sleep/post-restore gpio control" broke compilation on Exynos4 platform with power management enabled. This patch adds missing stubs that fixes this issue. Signed-off-by: Marek Szyprowski --- arch/arm/mach-exynos4/include/mach/pm-core.h | 10

[PATCH 2/3] ARM: Exynos4: Universal_C210: add MCS Touchkey device

2011-06-07 Thread Marek Szyprowski
This patch adds definitions to enable support for MCS Touchkey driver for Universal C210 board. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/Kconfig |1 + arch/arm/mach-exynos4/mach-universal_c210.c | 57 +++

[PATCH 3/3] ARM: Exynos4: Universal_C210: add qt602240 touch screen device

2011-06-07 Thread Marek Szyprowski
This patch adds definitions to enable support for qt602240 touch screen driver for Universal C210 board. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/Kconfig |2 + arch/arm/mach-exynos4/mach-universal_c210.c | 47 +++

[PATCH 0/3] ARM: Exynos4: Universal C210 machine update

2011-06-07 Thread Marek Szyprowski
Hello, This is a short patch series that updates device definitions for Universal C210 board. The series is based on kgene/for-next kernel tree. Best regards -- Marek Szyprowski Samsung Poland R&D Center Marek Szyprowski (3): ARM: Exynos4: Universal_C210: add FIMC device ARM: Exynos4: Univ

[PATCH 1/3] ARM: Exynos4: Universal_C210: add FIMC device

2011-06-07 Thread Marek Szyprowski
This patch adds definitions to enable support for s5p-fimc driver for Universal C210 board. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/Kconfig |4 arch/arm/mach-exynos4/mach-universal_c210.c |4 2 files changed, 8 inse