Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 6:08 PM, Padmavathi Venna wrote: > Fixed the bug in transmission status check for 64 bytes FIFO > level. > > Signed-off-by: Padmavathi Venna > --- >  drivers/spi/spi_s3c64xx.c |    4 +--- >  1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi_

Re: [PATCH v2 3/3] ARM: EXYNOS4: Add EPLL clock operations

2011-06-30 Thread Seungwhan Youn
> So far i was not lucky in finding out a generic way of deriving the > epll_div values. > And it doesn't seem to > 1. Save lines of code or > 2. Consolidate the PLL code. > > Any suggestions for a simpler implementation are welcome. No, I mean that 'epll_div' values are _not_always_correct_ on Sa

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 5:55 PM, Padmavathi Venna wrote: > This patchset does the following: > > 1. Move duplicated code to common place > [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung > SPI platform devices are defined in respective machine folder of > Samsung S3C64XX and

[PATCH v3 0/6] Update Samsung-SoC ADC to support recent CPUs

2011-06-30 Thread MyungJoo Ham
Patch 1/6: Add regulator support in ADC driver. If CONFIG_REGULATOR is enabled, "vdd" regulator for the ADC driver (e.g., "s5p-adc") should exist for the adc driver. Patch 2/6: Channel selection method for S5PC110 and Exynos4 Recent Samsung SoCs have different register addr

[PATCH v3 2/6] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4

2011-06-30 Thread MyungJoo Ham
In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX register, not ADCCON register. This patch corrects the behavior of Samsung-ADC for such cpus. Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park -- updates from v2 - Renamed internal device names. --- arch/arm/plat-samsung/a

[PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-06-30 Thread MyungJoo Ham
This patch allows the Samsung ADC driver to enable VDD regulator at probe and resume and to disable at exit and suspend. In a platform where ADC's VDD regulator is not "always-on", this control is required although this patch does not provide fine-grained power control (turning on the regulator onl

[PATCH v3 4/6] ARM: EXYNOS4: Support ADC

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park -- Updates from v2 - Based on EXT_GIC patches from Changhwan Youn (ARM: EXYNOS4: Adds External GIC) --- arch/arm/mach-exynos4/Kconfig |1 + arch/arm/mach-exynos4/cpu.c |4 arch/arm/mach-exynos4/incl

[PATCH v3 3/6] Samsung SoC ADC: Revise PM for 12-bit ADC operations

2011-06-30 Thread MyungJoo Ham
- Fixed: 12bit precision is lost at suspend/resume - Updated: use pm_dev_ops Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/adc.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/arch/arm/plat-samsung/adc.c b/ar

[PATCH v3 5/6] ARM: S5PC110/S5PV210: Support ADC

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-s5pv210/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c index 61e6c24..79907ec 100644 --- a/arch/arm/mach-s5pv210/cpu.c +++ b/arch/

[PATCH v3 6/6] Samsung SoC: header file revised to prevent declaring duplicated.

2011-06-30 Thread MyungJoo Ham
There has been no #ifndef - #define - #endif protection for this header file. The patch adds it for Exynos4-ADC support Signed-off-by: MyungJoo Ham --- arch/arm/plat-samsung/include/plat/devs.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/inc

Re: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4

2011-06-30 Thread MyungJoo Ham
On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim wrote: > MyungJoo Ham wrote: >> >> In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX >> register, not ADCCON register. This patch corrects the behavior of >> Samsung-ADC for such cpus. >> >> Signed-off-by: MyungJoo Ham >> Signed-off-by:

[PATCH v3 6/6] Exynos4 NURI: configure rtc-s3c.

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/mach-nuri.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index 0c9401c..bdf7a5c 100644 --- a/arch/arm/mach-exynos4

[PATCH v3 0/6] ARM: EXYNOS4: NURI Board Configuration Update

2011-06-30 Thread MyungJoo Ham
1/6: Increase NR_IRQS for MAX8997 2/6: Add MAX8997 PMIC 3/6: Add MAX17042 Fuel Gauge 4/6: Add ADC 5/6: Add MAX8903 Secondary Charger 6/6: Add RTC-S3C ps. Tushar, I didn't seperated MAX8997 support code out of mach-nuri.c, yet because I still have no idea about how similar the Origen board is with

[PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs

2011-06-30 Thread MyungJoo Ham
MAX8997/17042, which are used by Exynos4-NURI, use additional IRQ numbers after GPIO's IRQs. The patch creates some room for those devices. Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/include/mach/irqs.h |2 +- 1 files changed, 1 insertions(+), 1 delet

[PATCH v3 2/6] Exynos4 NURI: configure regulators and PMIC (MAX8997)

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park -- Changes from v3 - Updated init function name to include other power related devices. Changes from v2 - Add more __initdata entries - Moved and renamed pmic init function - Rearranged init point of PMIC Changes from v1 - Removed unnecess

[PATCH v3 4/6] Exynos4 NURI: configure ADC.

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/mach-nuri.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index 2467a2a..e81e8ca 100644 --- a/arch/arm/mach-exynos

[PATCH v3 5/6] Exynos4 NURI: configure MAX8903 secondary charger

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/mach-nuri.c | 78 + 1 files changed, 78 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index e81e8ca..0c940

[PATCH v3 3/6] Exynos4 NURI: configure MAX17042 fuel gauge

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park -- changed from v2 - Moved locations --- arch/arm/mach-exynos4/mach-nuri.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4

Re: [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-06-30 Thread Vasily Khoruzhick
On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote: > This patch allows the Samsung ADC driver to enable VDD regulator at > probe and resume and to disable at exit and suspend. > In a platform where ADC's VDD regulator is not "always-on", this control > is required although this patch does not pr

[PATCH 2/3] Samsung SoC: ready to use NTC value inside kernel

2011-06-30 Thread MyungJoo Ham
This patch allows kernel codes to use values from NTC LM-Sensor driver, which allows SYSFS access only. Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/dev-adc.c | 62 ++ arch/arm/plat-samsung/include/plat/adc-ntc.h | 1

[PATCH 0/3] ARM: EXYNOS4: NURI Support NTC

2011-06-30 Thread MyungJoo Ham
This series of patches require NTC thermistor support. NTC thermistor support patch is submitted and told to be applied (lm-sensors) although it is not being found in -next branches just yet. You can find the patch at: http://comments.gmane.org/gmane.linux.drivers.sensors/26475 MyungJoo Ham (3):

[PATCH 3/3] Exynos4 NURI: support for NTC thermistor

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos4/mach-nuri.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index bdf7a5c..cd8bc06 100644 --- a/arch/arm/mach-exyn

[PATCH 1/3] Samsung SoC: NTC Thermistor attached to S3C-ADC.

2011-06-30 Thread MyungJoo Ham
This patch allows platform configurations to share information about the NTC thermistor device attached to ADC port of S3C. A platform configuration is required to initialize the ADC port for NTC thermistor by calling "s3c_adc_ntc_init(portnum);" before registering the NTC thermistor device. Then,

Re: [PATCH 2/3] Samsung SoC: ready to use NTC value inside kernel

2011-06-30 Thread Russell King - ARM Linux
On Thu, Jun 30, 2011 at 05:26:26PM +0900, MyungJoo Ham wrote: > diff --git a/arch/arm/plat-samsung/dev-adc.c b/arch/arm/plat-samsung/dev-adc.c > index 622972c..526097a 100644 > --- a/arch/arm/plat-samsung/dev-adc.c > +++ b/arch/arm/plat-samsung/dev-adc.c > @@ -22,6 +22,8 @@ > #include > #include

Re: [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-06-30 Thread MyungJoo Ham
On Thu, Jun 30, 2011 at 5:22 PM, Vasily Khoruzhick wrote: > On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote: >> This patch allows the Samsung ADC driver to enable VDD regulator at >> probe and resume and to disable at exit and suspend. >> In a platform where ADC's VDD regulator is not "always

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread padma venkat
Hi, On Thu, Jun 30, 2011 at 12:38 PM, Jassi Brar wrote: > On Thu, Jun 30, 2011 at 6:08 PM, Padmavathi Venna wrote: >> Fixed the bug in transmission status check for 64 bytes FIFO >> level. >> >> Signed-off-by: Padmavathi Venna >> --- >>  drivers/spi/spi_s3c64xx.c |    4 +--- >>  1 files changed

RE: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread Marek Szyprowski
Hello, On Thursday, June 30, 2011 2:25 PM Padmavathi Venna wrote: > This patchset does the following: > > 1. Move duplicated code to common place > [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung > SPI platform devices are defined in respective machine folder of > Samsung S

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread padma venkat
Hi, On Thu, Jun 30, 2011 at 1:01 PM, Jassi Brar wrote: > On Thu, Jun 30, 2011 at 5:55 PM, Padmavathi Venna wrote: >> This patchset does the following: >> >> 1. Move duplicated code to common place >> [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung >> SPI platform devices ar

Re: [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs

2011-06-30 Thread Russell King - ARM Linux
On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote: > SPI Clocks were defined in dev-spi.c of machine specific folder. > To make SPI devices common across all SoCs,dev-spi.c is moved > from machine specific folder to plat-samsung. So SPI clock > definitions has been moved from dev-spi

Re: [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 3:00 PM, Russell King - ARM Linux wrote: > On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote: >> SPI Clocks were defined in dev-spi.c of machine specific folder. >> To make SPI devices common across all SoCs,dev-spi.c is moved >> from machine specific folder

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 2:35 PM, padma venkat wrote: > Hi, > > On Thu, Jun 30, 2011 at 12:38 PM, Jassi Brar wrote: >> On Thu, Jun 30, 2011 at 6:08 PM, Padmavathi Venna >> wrote: >>> Fixed the bug in transmission status check for 64 bytes FIFO >>> level. >>> >>> Signed-off-by: Padmavathi Venna

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 2:57 PM, padma venkat wrote: > Hi, > > On Thu, Jun 30, 2011 at 1:01 PM, Jassi Brar wrote: >> On Thu, Jun 30, 2011 at 5:55 PM, Padmavathi Venna >> wrote: >>> This patchset does the following: >>> >>> 1. Move duplicated code to common place >>> [PATCH 1/7] ARM: SAMSUNG: Mo

[PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

2011-06-30 Thread Sangwook Lee
Function declaration differs between file:s3c-pl330.c and file:dma.h and SPARSE (Documentation/sparse.txt) gives error messages Signed-off-by: Sangwook Lee --- arch/arm/plat-samsung/include/plat/dma.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/ar

Re: [PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 3:46 PM, Sangwook Lee wrote: > Function declaration differs between file:s3c-pl330.c and file:dma.h > and SPARSE (Documentation/sparse.txt) gives error messages > > Signed-off-by: Sangwook Lee Acked-by: Jassi Brar > --- >  arch/arm/plat-samsung/include/plat/dma.h |   16

Re: [PATCH] arm: platsmp: Allow secondary cpu hotplug with maxcpus=1

2011-06-30 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 11:31:39AM -0700, Stephen Boyd wrote: > void __init platform_smp_prepare_cpus(unsigned int max_cpus) > { > - int i; > - > /* >* Initialise the present map, which describes the set of CPUs >* actually populated at the present time. >*/ > -

Re: [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-06-30 Thread Mark Brown
On Thu, Jun 30, 2011 at 11:22:50AM +0300, Vasily Khoruzhick wrote: > On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote: > > + adc->vdd = regulator_get(dev, "vdd"); > > + if (IS_ERR(adc->vdd)) { > > + dev_err(dev, "operating without regulator \"vdd\" .\n"); > > + ret = PT

Re: [PATCH] arm: platsmp: Allow secondary cpu hotplug with maxcpus=1

2011-06-30 Thread Stephen Boyd
On 6/30/2011 6:11 AM, Russell King - ARM Linux wrote: > On Wed, Jun 29, 2011 at 11:31:39AM -0700, Stephen Boyd wrote: >> void __init platform_smp_prepare_cpus(unsigned int max_cpus) >> { >> -int i; >> - >> /* >> * Initialise the present map, which describes the set of CPUs >>

Re: [PATCH 2/3] Samsung SoC: ready to use NTC value inside kernel

2011-06-30 Thread MyungJoo Ham
On Thu, Jun 30, 2011 at 6:00 PM, Russell King - ARM Linux wrote: > On Thu, Jun 30, 2011 at 05:26:26PM +0900, MyungJoo Ham wrote: >> diff --git a/arch/arm/plat-samsung/dev-adc.c >> b/arch/arm/plat-samsung/dev-adc.c >> index 622972c..526097a 100644 >> --- a/arch/arm/plat-samsung/dev-adc.c >> +++ b/

RE: [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode

2011-06-30 Thread Kukjin Kim
Russell King - ARM Linux wrote: > > On Fri, Jun 24, 2011 at 10:37:50AM +0100, Russell King - ARM Linux wrote: > > On Fri, Jun 24, 2011 at 04:42:26PM +0900, Kukjin Kim wrote: > > > Russell King - ARM Linux wrote: > > > (snip) > > Here's an updated patch for it against the v3 set of patches. > >

[PATCH V2 0/8] ARM: EXYNOS4: Update PM

2011-06-30 Thread Kukjin Kim
This patch updates EXYNOS4 PM based on Russell's suspend consolidation patches. NOTE: Depends on external GIC patches which are from Changhwan Youn. Changes since V1: - address comments from Russell King [PATCH V2 1/8] ARM: EXYNOS4: Support system level power down configuration [PATCH V2 2/8] AR

[PATCH V2 4/8] ARM: SAMSUNG: Add support for failure of sleep mode

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/pm.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c index 69d6b04..df12645 100644 --- a/arch/arm/plat-samsu

[PATCH V2 1/8] ARM: EXYNOS4: Support system level power down configuration

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee EXYNOS4 supports 3 different system level power down mode by PMU (Power Management Unit). Each power down mode need to configure many PMU registers with different value. This patch supports function to configure PMU registers with pre-defined values in PMU code. This function m

[PATCH V2 7/8] ARM: EXYNOS4: Add save/restore for other ARM registers

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee This patch adds save/restore values for Power Control Register and Diagnostic Register for PM. Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/pm.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git

[PATCH V2 5/8] ARM: EXYNOS4: Support early wakeup entering sleep mode

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee Since early wakeup can be handled in pm so we don't need masking interrupts of external GIC. When the early wakeup interrupt happens, PMU(Power Management Unit) ignores WFI instruction. This means that PC(Program Counter) passed without any changes. This patch can handle that c

[PATCH V2 3/8] ARM: EXYNOS4: Add support PM with external GIC

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/pm.c | 43 +-- 1 files changed, 37 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-exynos4/pm.c b/arch/arm/mach-exynos4/pm.c index 4d9ee97..9b5

[PATCH V2 6/8] ARM: EXYNOS4: Move S5P_CENTRAL_SEQ_CONFIGURATION setting for PM

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee We need to balance between set and check S5P_CENTRAL_SEQ_CONFIGURATION register in syscore_ops suspend/resume function when failure in enter suspend mode. Moved this register setting for PM for the purpose of balancing. Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim -

[PATCH V2 2/8] ARM: EXYNOS4: Remove PMU configuration for S2RAM

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee PMU(Power Management Unit) configuraion for S2RAM(SLEEP) is removed and using function which provided by PMU support code to configure PMU register. Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/pm.c | 77 +

[PATCH V2 8/8] ARM: EXYNOS4: Add save/restore function for PLL

2011-06-30 Thread Kukjin Kim
From: Jaecheol Lee The PLL restore routine supports waiting pll locking. If PLL is enabled in restoring sequence, it should wait until PLL is locked. Signed-off-by: Jaecheol Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/include/mach/regs-clock.h |9 ++ arch/arm/mach-exynos4/pm.c

Re: [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs

2011-06-30 Thread padma venkat
Hi Russell,Jassi On Thu, Jun 30, 2011 at 3:13 PM, Jassi Brar wrote: > On Thu, Jun 30, 2011 at 3:00 PM, Russell King - ARM Linux > wrote: >> On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote: >>> SPI Clocks were defined in dev-spi.c of machine specific folder. >>> To make SPI devic

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread padma venkat
Hi Marek, On Thu, Jun 30, 2011 at 2:55 PM, Marek Szyprowski wrote: > Hello, > > On Thursday, June 30, 2011 2:25 PM Padmavathi Venna wrote: > >> This patchset does the following: >> >> 1. Move duplicated code to common place >> [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung

[PATCH] ARM: EXYNOS4: Add support Core1 Power On/Off with hotplug in/out

2011-06-30 Thread JungHi Min
To insert the code for power on/off with pmu control to support hotplug in/out core1 As for hotplug.c, the codes for core1 to be hotplug in/out is inserted. As for regs-pmu.h, S5P_CORE_LOCAL_PWR_EN is defined. As for platsmp.c, the codes for core1 to be powered on is inserted. Signed-off-by: Jung

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread padma venkat
Hi Tony, On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal wrote: > Hi Padma, > With regards to your patch, even though one can check the tx done status > using the TX_DONE bit, the present macro itself would work perfectly fine if > the 'fifo_lvl_mask' is set properly. > For example in 6450 channel

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Fri, Jul 1, 2011 at 11:16 AM, padma venkat wrote: > Hi Tony, > > On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal wrote: >> Hi Padma, >> With regards to your patch, even though one can check the tx done status >> using the TX_DONE bit, the present macro itself would work perfectly fine if >> the

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread padma venkat
Hi Jassi, On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar wrote: > On Fri, Jul 1, 2011 at 11:16 AM, padma venkat wrote: >> Hi Tony, >> >> On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal wrote: >>> Hi Padma, >>> With regards to your patch, even though one can check the tx done status >>> using the TX

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Fri, Jul 1, 2011 at 11:29 AM, padma venkat wrote: > Hi Jassi, > > On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar wrote: >> On Fri, Jul 1, 2011 at 11:16 AM, padma venkat wrote: >>> Hi Tony, >>> >>> On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal wrote: Hi Padma, With regards to your pat