Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-04 Thread Chanho Park
Kukjin Kim samsung.com> writes: (snip) > + if (slave_config->direction == DMA_TO_DEVICE) { > + if (slave_config->dst_addr) > + peri->fifo_addr = slave_config->dst_addr; > + if (slave_config->dst_addr_width) { > +

Re: [PATCH 1/7] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-04 Thread Alim Akhtar
Hi, On Mon, Jul 4, 2011 at 5:48 PM, Kukjin Kim wrote: > From: Boojin Kim > > Signed-off-by: Boojin Kim > Cc: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim > --- >  drivers/dma/pl330.c |   61 > +++ >  1 files changed, 61 insertions(

Re: [PATCH 5/7] ARM: EXYNOS4: Use generic DMA PL330 driver

2011-07-04 Thread Alim Akhtar
On Mon, Jul 4, 2011 at 5:48 PM, Kukjin Kim wrote: > > From: Boojin Kim > > This patch makes EXYNOS4 use DMA PL330 driver on DMADEVICE. > EXYNOS4 uses DMA generic API instead of SAMSUNG specific S3C-PL330 API. > > Signed-off-by: Boojin Kim > Signed-off-by: Kukjin Kim > --- >  arch/arm/mach-exyno

RE: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Kukjin Kim
Grant Likely wrote: > > On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote: > > Kukjin Kim wrote: > > > > > > Thanks Grant, Jassi and all, > > > > > > I will apply these 1 and 2 in my -fix tree for 3.0 with your acks. > > > > > Oops, this needs previous 'cleanup spi platform specific code'

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-04 Thread Chanho Park
Kukjin Kim samsung.com> writes: (snip) > + if (slave_config->direction == DMA_TO_DEVICE) { > + if (slave_config->dst_addr) > + peri->fifo_addr = slave_config->dst_addr; > + if (slave_config->dst_addr_width) { > +

Re: [PATCH 5/7] ARM: EXYNOS4: Use generic DMA PL330 driver

2011-07-04 Thread Chanho Park
Kukjin Kim samsung.com> writes: > +struct dma_pl330_platdata exynos4_pdma0_pdata = { > + .nr_valid_peri = 32, > + .peri = pdma0_peri, > }; (snip) > +struct dma_pl330_platdata exynos4_pdma1_pdata = { > + .nr_valid_peri = 32, > + .peri = pdma1_peri, > }; > I think you'd better

Re: [PATCH 0/6+1] ARM: EXYNOS4: SYSMMU: Improvements on SYSMMU driver

2011-07-04 Thread KyongHo Cho
Hi. On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski wrote: > Hello, > > I really don't get why do You persist in creating one monster platform > device with resources for ALL SYSMMU/IOMMU controllers that are available > on Exynos4 CPU. We (SPRC, see Andrzej's SYSMMU patches) already proposed > a

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Grant Likely
On Mon, Jul 04, 2011 at 09:51:43PM +0200, Heiko Stübner wrote: > Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: > > On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: > > > Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: > > > > On Mon, Jul 04, 2011 at 09:18:34PM +0900, K

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: > On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: > > Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: > > > On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: > > > > +#if defined(CONFIG_DMADEV_PL330) > > > > +

[PATCH v3 06/19] s5p-fimc: Remove sensor management code from FIMC capture driver

2011-07-04 Thread Sylwester Nawrocki
The sensor subdevs need to be shared between all available FIMC instances. Remove their registration from FIMC capture driver so they can then be registered to the media device driver. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c

[PATCH v3 09/19] s5p-fimc: Conversion to use struct v4l2_fh

2011-07-04 Thread Sylwester Nawrocki
This is a prerequisite for the patch converting the driver to use the control framework. As the capture driver does not use per file handle contexts, two separate ioctl handlers are created for it (vidioc_try_fmt_mplane, and vidioc_g_fmt_mplane) so there is no handlers shared between the memory-to-

[PATCH v3 05/19] s5p-fimc: Limit number of available inputs to one

2011-07-04 Thread Sylwester Nawrocki
Camera sensors at FIMC input are no longer selected with S_INPUT ioctl. They will be attached to required FIMC entity through pipeline re-configuration at the media device level. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 4

[PATCH v3 01/19] s5p-fimc: Add support for runtime PM in the mem-to-mem driver

2011-07-04 Thread Sylwester Nawrocki
Only the FIMC entity memory-to-memory operation is fully covered, for the camera capture suspend/resume only stubs are provided. It's all what is needed to enable the driver on EXYNOS4 series with power domain driver enabled. Camera capture pipeline suspend/resume is covered by a separate patch. S

[PATCH v3 11/19] s5p-fimc: Add media operations in the capture entity driver

2011-07-04 Thread Sylwester Nawrocki
Add the link_setup handler for the camera capture video node. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 32 +++ drivers/media/video/s5p-fimc/fimc-core.h|2 + 2 files changed, 34 insertions(+

[PATCH v3 07/19] s5p-fimc: Remove v4l2_device from video capture and m2m driver

2011-07-04 Thread Sylwester Nawrocki
Currently there is a v4l2_device instance being registered per each (capture and memory-to-memory) video node created per FIMC H/W instance. This patch is a prerequisite for using the top level v4l2_device instantiated by the media device driver. To retain current debug trace semantic (so it's poss

[PATCH v3 02/19] s5p-fimc: Add media entity initialization

2011-07-04 Thread Sylwester Nawrocki
Add intialization of the media entities for video capture and mem-to-mem video nodes. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 28 -- drivers/media/video/s5p-fimc/fimc-core.c| 27

[PATCH v3 08/19] s5p-fimc: Add the media device driver

2011-07-04 Thread Sylwester Nawrocki
The fimc media device driver is hooked onto "s5p-fimc-md" platform device. Such a platform device need to be added in a board initialization code and then camera sensors need to be specified as it's platform data. The "s5p-fimc-md" device is a top level entity for all FIMC, mipi-csis and sensor dev

[PATCH v3 03/19] s5p-fimc: Remove registration of video nodes from probe()

2011-07-04 Thread Sylwester Nawrocki
Do not register video nodes during FIMC device probe. Also make fimc_register_m2m_device() public for use by the media device driver. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |1 + drivers/media/video/s5p-fimc/fimc-core.c

[PATCH v3 14/19] s5p-fimc: Convert to use media pipeline operations

2011-07-04 Thread Sylwester Nawrocki
Add format negotiation routine for sensor subdevs not exposing a device node. TRY_FMT ioctl is completed by a subsequent patch adding the capture subdev. This way the try_fmt routines can be common for the subdev and the video node. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park

[PATCH v3 12/19] s5p-fimc: Add PM helper function for streaming control

2011-07-04 Thread Sylwester Nawrocki
Create a helper function for (re)starting streaming in PM resume calls. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 80 --- drivers/media/video/s5p-fimc/fimc-core.c|4 +- drivers/media/video/s

[PATCH v3 18/19] s5p-fimc: Use consistent names for the buffer list functions

2011-07-04 Thread Sylwester Nawrocki
Also correct and improve *_queue_add/pop functions description. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c |6 ++-- drivers/media/video/s5p-fimc/fimc-core.c|6 ++-- drivers/media/video/s5p-fimc/fimc-core.h| 38

[PATCH v3 17/19] s5p-fimc: Add v4l2_device notification support for single frame capture

2011-07-04 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 47 +++ drivers/media/video/s5p-fimc/fimc-core.h|2 + drivers/media/video/s5p-fimc/fimc-mdevice.c |1 + include/media/s5p_fimc.h

[PATCH v3 16/19] s5p-fimc: Add support for camera capture in JPEG format

2011-07-04 Thread Sylwester Nawrocki
Add support for transparent DMA transfer of JPEG data with MIPI-CSI2 USER1 format. In JPEG mode the color effect, scaling and cropping is not supported. Same applies to image rotation and flip thus those controls are marked as inactive when V4L2_PIX_FMT_JPEG pixelformat is selected. Signed-off-by:

[PATCH v3 13/19] s5p-fimc: Correct color format enumeration

2011-07-04 Thread Sylwester Nawrocki
Create separate VIDIOC_ENUM_FMT ioctl handlers for video capture and mem-to-mem video node. This is needed as some formats are valid only for the video capture and some only for the mem-to-mem video node. Create single function for pixel format lookup out of find_mbus_format() and find_format(). S

[PATCH v3 15/19] s5p-fimc: Add subdev for the FIMC processing block

2011-07-04 Thread Sylwester Nawrocki
This subdev interface exposes the internal scaler and color converter functionality to user space. Resolution and media bus format can now be configured explicitly by applications. Camera frame composition onto the output buffer can be configured through set/get_crop at FIMC.{n} source pad. Additio

[PATCH v3 10/19] s5p-fimc: Conversion to the control framework

2011-07-04 Thread Sylwester Nawrocki
The FIMC entity supports rotation, horizontal and vertical flip in camera capture and memory-to-memory operation mode. Due to atomic contexts used in mem-to-mem driver the control values need to be cached in drivers internal data structure. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmi

[PATCH v3 19/19] s5p-fimc: Add runtime PM support in the camera capture driver

2011-07-04 Thread Sylwester Nawrocki
Add support for whole pipeline suspend/resume. Sensors must support suspend/resume through s_power subdev operation. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-capture.c | 77 --- drivers/media/video/s5p-fimc/fi

[PATCH v3 0/19] s5p-fimc driver conversion to media controller and control framework

2011-07-04 Thread Sylwester Nawrocki
Hello, following is a third version of a patchset converting s5p-fimc driver to the media controller API and control framework. Except fixing minor bugs in the sensor registration code, the first patch adding power management support has been significantly reworked. There is no yet support for

[PATCH v3 04/19] s5p-fimc: Remove sclk_cam clock handling

2011-07-04 Thread Sylwester Nawrocki
The external sclk_cam clocks will be handled at the media device driver level. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c | 12 ++-- drivers/media/video/s5p-fimc/fimc-core.h |3 +-- 2 files changed, 3 insertions(+),

Re: [PATCH 7/7] ASoC: Samsung: Update DMA interface

2011-07-04 Thread Mark Brown
On Mon, Jul 04, 2011 at 09:18:35PM +0900, Kukjin Kim wrote: > +static void audio_buffdone(void *data) > +{ > + struct snd_pcm_substream *substream = data; > + struct runtime_data *prtd; > + struct dma_chan *chan; > + > + prtd = substream->runtime->private_data; > + > + chan = p

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Grant Likely
On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: > Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: > > On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: > > > +#if defined(CONFIG_DMADEV_PL330) > > > + memset(&slave_config, 0, sizeof(slave_config)); > >

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: > On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: > > +#if defined(CONFIG_DMADEV_PL330) > > + memset(&slave_config, 0, sizeof(slave_config)); > > + slave_config.direction = DMA_TO_DEVICE; > > +

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Mark Brown
On Mon, Jul 04, 2011 at 10:42:51AM -0600, Grant Likely wrote: > Wow. A lot of #ifdefs here. It does not look multiplatform friendly > at all. Are the s3c2410_dma functions obsolete when DMADEV_PL330 is > selected? If so, can they be removed entirely, or are they required > to support certain h

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Grant Likely
On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: > From: Boojin Kim > > This patch adds to support DMA generic API to transfer raw > SPI data. Basiclly the spi driver uses DMA generic API if > architecture supports it. Otherwise, uses Samsung specific > S3C-PL330 APIs. > > Signed-off-

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Grant Likely
On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote: > Kukjin Kim wrote: > > > > Grant Likely wrote: > > > > > > On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely > > > wrote: > > > > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: > > > >> On Fri, Jul 1, 2011 at 11:29 AM, padma ve

RE: [PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

2011-07-04 Thread Kukjin Kim
Sangwook Lee wrote: > > Function declaration differs between file:s3c-pl330.c and file:dma.h > and SPARSE (Documentation/sparse.txt) gives error messages > > Signed-off-by: Sangwook Lee > --- > arch/arm/plat-samsung/include/plat/dma.h | 16 > 1 files changed, 8 insertions(+),

[PATCH 5/7] ARM: EXYNOS4: Use generic DMA PL330 driver

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch makes EXYNOS4 use DMA PL330 driver on DMADEVICE. EXYNOS4 uses DMA generic API instead of SAMSUNG specific S3C-PL330 API. Signed-off-by: Boojin Kim Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/Kconfig |2 +- arch/arm/mach-exynos4/clock.c | 16 +- arch/a

[PATCH 2/7] DMA: PL330: Update PL330 DMA API driver

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch updates following 3 items. 1. Removes unneccessary code. 2. Add AMBA, PL330 configuration 3. Change the meaning of 'peri_id' variable from PL330 event number to specific dma id by user. Signed-off-by: Boojin Kim Cc: Vinod Koul Cc: Dan Williams Signed-off-by: Kuk

[PATCH 7/7] ASoC: Samsung: Update DMA interface

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch adds to support the DMA PL330 driver that uses DMA generic API. Samsung sound driver uses DMA generic API if architecture supports it. Otherwise, use samsung specific S3C-PL330 API driver to transfer PCM data. Signed-off-by: Boojin Kim Cc: Jassi Brar Cc: Liam Girdwo

[PATCH 4/7] ARM: SAMSUNG: Update to use PL330-DMA driver

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch adds to support PL330-DMA driver on DMADEVICE. Currently S3C-DMA(PL080) is used for S3C24XX and S3C64XX and S3C-PL330-DMA has been used for S5P SoCs. So this patch changes S3C-PL330-DMA to just PL330-DMA for use generic DMA driver for S5P SoCs. Signed-off-by: Boojin K

[PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch adds to support DMA generic API to transfer raw SPI data. Basiclly the spi driver uses DMA generic API if architecture supports it. Otherwise, uses Samsung specific S3C-PL330 APIs. Signed-off-by: Boojin Kim Cc: Grant Likely Signed-off-by: Kukjin Kim --- drivers/sp

[PATCH 1/7] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-04 Thread Kukjin Kim
From: Boojin Kim Signed-off-by: Boojin Kim Cc: Vinod Koul Cc: Dan Williams Signed-off-by: Kukjin Kim --- drivers/dma/pl330.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c i

[PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-04 Thread Kukjin Kim
From: Boojin Kim This patch adds DMA_CYCLIC capability that is used for audio driver and SLAVE_CONFIG capability for transmit between device and memory. Signed-off-by: Boojin Kim Cc: Vinod Koul Cc: Dan Williams Signed-off-by: Kukjin Kim --- drivers/dma/pl330.c | 114 +++

[PATCH 0/7] ARM: S5P: Use generic DMA APIs

2011-07-04 Thread Kukjin Kim
This patch makes EXYNOS4210 SoC use generic DMA APIs instead of Samsung specific DMA APIs. The DMA client drivers such as spi and sound are requried to change the usage for it. NOTE: We will also apply this on other S5P SoCs soon so we can remove s3c-pl330 specific driver at the same time. [PATCH

[PATCH 2/2] SPI: S5PV210: Enable the SPI driver for S5PV210

2011-07-04 Thread Padmavathi Venna
The SPI module on S5PV210 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PV210. Signed-off-by: Padmavathi Venna --- drivers/spi/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/K

[PATCH 1/2] SPI: S5PC100: Enable the SPI driver for S5PC100

2011-07-04 Thread Padmavathi Venna
From: padmavathi venna The SPI module on S5PC100 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PC100. Signed-off-by: padmavathi venna --- drivers/spi/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi

[PATCH] ARM: SAMSUNG: Added SPI machine support

2011-07-04 Thread Padmavathi Venna
Added SPI machine support in SMDK6410,SMDKC100,SMDKV210 Signed-off-by: Padmavathi Venna --- arch/arm/mach-s3c64xx/Kconfig |1 + arch/arm/mach-s5pc100/Kconfig |1 + arch/arm/mach-s5pv210/Kconfig |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx

[PATCH] ARM: S5PC100: Fix for compilation error

2011-07-04 Thread Padmavathi Venna
From: padmavathi venna S5PC100 Compilation fails without this patch Signed-off-by: padmavathi venna --- arch/arm/mach-s5pc100/dev-spi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pc100/dev-spi.c b/arch/arm/mach-s5pc100/dev-spi.c index 2b58c9a..e5d6

[PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Padmavathi Venna
The existing macro fails for following scenarios. 1) S5P64X0 channel 1 2) S5PV210 channel 1 The FIFO data level supported in the above SoCs either 64 or 256 bytes depending on the channel. Because of this the TX_DONE is the 25 bit in the status register. The existing macro works for the following

[PATCH 1/2] ARM: SAMSUNG: Add tx_st_done variable in the

2011-07-04 Thread Padmavathi Venna
tx_st_done is required for checking the transmission status of SPI channels with different fifo levels Signed-off-by: Padmavathi Venna Acked-by: Jassi Brar --- arch/arm/mach-s3c64xx/dev-spi.c |2 ++ arch/arm/mach-s5p64x0/dev-spi.c |4 arch/arm/mach

[PATCH] GPIO: SAMSUNG: Consolidate GPIO library for SAMSUNG SoC

2011-07-04 Thread Chanwoo Choi
This patch consolidates duplicate GPIO library for SAMSUNG SoC to control GPIO on the whole SAMSUNG SoC(S3C series, S5P series) through consolidated GPIO library file. Signed-off-by: Chanwoo Choi Signed-off-by: Kyungmin Park --- arch/arm/mach-s3c64xx/gpiolib.c| 27 +--- arch/a

RE: [PATCH] ARM: EXYNOS4: Enable SATA on SMDKV310

2011-07-04 Thread Kukjin Kim
Inderpal Singh wrote: > > Adds device definition to enable SATA on SMDKV310 > > Signed-off-by: Inderpal Singh > --- > arch/arm/mach-exynos4/Kconfig |1 + > arch/arm/mach-exynos4/mach-smdkv310.c |1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/m

RE: [PATCH 1/7] ARM: EXYNOS4: Add external GIC io memory mapping

2011-07-04 Thread Kukjin Kim
MyungJoo Ham wrote: > > >  #define EXYNOS4_PA_COMBINER            0x10448000 > > Isn't this 0x1044 if we are going to use External GIC? > Oops, you're right, thanks for your pointing out. Yes, should be 0x1044. When I apply this, I will fix it. Thanks. Best regards, Kgene. -- Kukjin K

RE: [PATCH] arm: exynos4: address a section mismatch w/ suspend issue.

2011-07-04 Thread Kukjin Kim
MyungJoo Ham wrote: > > The section mismatch in headsmp.S made hotplug stop working after the > first instance of suspend-to-RAM and its wakeup. > > Signed-off-by: MyungJoo Ham > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos4/headsmp.S |2 +- > 1 files changed, 1 insertions(+),

RE: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Kukjin Kim
Kukjin Kim wrote: > > Grant Likely wrote: > > > > On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely > wrote: > > > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: > > >> On Fri, Jul 1, 2011 at 11:29 AM, padma venkat > wrote: > > >> > Hi Jassi, > > >> > > > >> > On Fri, Jul 1, 2011 at 11:

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread padma venkat
Hi Kukjin, On Mon, Jul 4, 2011 at 3:24 PM, Kukjin Kim wrote: > Grant Likely wrote: >> >> On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely > wrote: >> > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: >> >> On Fri, Jul 1, 2011 at 11:29 AM, padma venkat > wrote: >> >> > Hi Jassi, >> >>

RE: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-04 Thread Kukjin Kim
Grant Likely wrote: > > On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely wrote: > > On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote: > >> On Fri, Jul 1, 2011 at 11:29 AM, padma venkat wrote: > >> > Hi Jassi, > >> > > >> > On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar wrote: > >> >> On Fri

Re: [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode

2011-07-04 Thread Russell King - ARM Linux
On Mon, Jul 04, 2011 at 06:42:08PM +0900, Kukjin Kim wrote: > Russell King - ARM Linux wrote: > > > > On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote: > > > Russell thanks. > > > > > > How do you think to add following for handling failure of cpu_suspend? > > > > > > + mov r0, #-1 >

RE: [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode

2011-07-04 Thread Kukjin Kim
Russell King - ARM Linux wrote: > > On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote: > > Russell thanks. > > > > How do you think to add following for handling failure of cpu_suspend? > > > > + mov r0, #-1 > > No. -1 is not an error code, and I refuse to create functions which >

RE: [PATCH 4/7] ARM: GIC: move gic_chip_data structure declaration to header

2011-07-04 Thread Kukjin Kim
Changhwan Youn wrote: > > Since Samsung EXYNOS4210 cannot support register banking in GIC, > so needs to update CPU interface base address. > The 'gic_chip_data' is used for it, this patch moves gic_chip_data > structure declaraton to arch/arm/include/asm/hardware/gic.h to use > it. > > Cc: Russe

RE: [PATCH V2 3/8] ARM: EXYNOS4: Add support PM with external GIC

2011-07-04 Thread Kukjin Kim
Russell King - ARM Linux wrote: > > Why not fix arch/arm/common/gic.c to save and restore the GIC state > itself? > Sorry I missed that. I saw "ARM: gic: Use cpu pm notifiers to save gic state" by Colin Cross just now so will follow that up for supporting Samsung SoCs which use GIC. Thanks. Bes