On Wed, Jul 6, 2011 at 11:38 AM, Kukjin Kim wrote:
> Kukjin Kim wrote:
>>
>> Sangwook Lee wrote:
>> >
>> > Function declaration differs between file:s3c-pl330.c and file:dma.h
>> > and SPARSE (Documentation/sparse.txt) gives error messages
>> >
>> > Signed-off-by: Sangwook Lee
>> > ---
>> > arch
Padmavathi Venna wrote:
>
> From: padmavathi venna
>
> S5PC100 Compilation fails without this patch
>
> Signed-off-by: padmavathi venna
> ---
> arch/arm/mach-s5pc100/dev-spi.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pc100/dev-spi.c
b/arch
On Wed, Jul 06, 2011 at 03:22:08PM +0900, Kukjin Kim wrote:
> Kukjin Kim wrote:
> >
> > Grant Likely wrote:
> > >
> > > On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote:
> > > > Kukjin Kim wrote:
> > > > >
> > > > > Thanks Grant, Jassi and all,
> > > > >
> > > > > I will apply these 1 an
Kukjin Kim wrote:
>
> Grant Likely wrote:
> >
> > On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote:
> > > Kukjin Kim wrote:
> > > >
> > > > Thanks Grant, Jassi and all,
> > > >
> > > > I will apply these 1 and 2 in my -fix tree for 3.0 with your acks.
> > > >
> > > Oops, this needs previ
Kukjin Kim wrote:
>
> Sangwook Lee wrote:
> >
> > Function declaration differs between file:s3c-pl330.c and file:dma.h
> > and SPARSE (Documentation/sparse.txt) gives error messages
> >
> > Signed-off-by: Sangwook Lee
> > ---
> > arch/arm/plat-samsung/include/plat/dma.h | 16
>
Hi Felipe,
Sorry for a delayed response to your comment. I have been addressing
all the comment given
by you, following two points remain where I need your suggestion.
On Wed, Jun 22, 2011 at 3:19 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Jun 22, 2011 at 01:56:25PM +0530, Praveen Paneri wrote:
>
Hi,
Patch 1/2 looks redundant as both changes can be very well accommodated
in a single patch.
On Monday 04 July 2011 11:14 PM, Padmavathi Venna wrote:
The SPI module on S5PV210 is similar to the earlier Samsung SoCs like
S3C64XX. Enable the existing SPI driver for use on S5PV210.
Signed-off
On Tue, Jul 5, 2011 at 8:14 PM, Marek Szyprowski
wrote:
> Hello,
>
> On Tuesday, July 05, 2011 1:38 AM KyongHo Cho wrote:
>
>> On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski
>> wrote:
>> > Hello,
>> >
>> > I really don't get why do You persist in creating one monster platform
>> > device with r
On Tue, Jul 05, 2011 at 04:19:05PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:
> >
> Hi Mark,
>
> Please refer to my other comment which includes block diagram, it can help
> our understanding about current Samsung DMA usage.
>
> > Two questions here:
> >
> > - It looks like a lot of this code
If an ARM system has multiple cpus in the same socket and the
kernel is booted with maxcpus=1, secondary cpus are possible but
not present due to how platform_smp_prepare_cpus() is called.
Since most typical ARM processors don't actually support physical
hotplug, initialize the present map to be eq
On Tue, Jul 5, 2011 at 4:57 PM, Russell King - ARM Linux
wrote:
> On Tue, Jul 05, 2011 at 04:46:47PM +0530, Jassi Brar wrote:
>> Ideally, like PL330 for S5P, drivers/dma/pl080 should be enabled
>> for s3c64xx And new generic dma api drivers written for S3C24xx in
>> drivers/dma/
>
> Another so
Am Dienstag, 5. Juli 2011, 09:05:32 schrieb Kukjin Kim:
[...]
> As a note, S3C24XX and S3C64XX include PL080 DMAC not PL330.
Are you sure the S3C24xx also uses a PL080?
At least for the 2416, the manual does not tell the type of DMA controller
used. Also according to it it's a 6 channel controlle
On Tue, Jul 05, 2011 at 04:46:47PM +0530, Jassi Brar wrote:
> Ideally, like PL330 for S5P, drivers/dma/pl080 should be enabled
> for s3c64xx And new generic dma api drivers written for S3C24xx in
> drivers/dma/
Another solution would be to write a DMA engine driver which massages
the Samsung D
Hi Kukjin,
Can you kindly, review the following patchset and let me know the comments.
On 1 July 2011 17:03, Naveen Krishna Chatradhi wrote:
> Does the same job, while saving few lines of code.
>
> o To Kukjin Kim, Sangbeom Kim and Ben Dooks
>
> Naveen Krishna Chatradhi (2):
> ARM: Samsung: Us
On Tue, Jul 5, 2011 at 12:35 PM, Kukjin Kim wrote:
> Grant Likely wrote:
>>
>> On Mon, Jul 04, 2011 at 09:51:43PM +0200, Heiko Stübner wrote:
>> > Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely:
>> > > On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote:
>> > > > Am Montag 04 Juli
Hello,
On Tuesday, July 05, 2011 1:38 AM KyongHo Cho wrote:
> On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski
> wrote:
> > Hello,
> >
> > I really don't get why do You persist in creating one monster platform
> > device with resources for ALL SYSMMU/IOMMU controllers that are available
> > on E
On Mon, Jul 04, 2011 at 01:44:35PM -0400, Padmavathi Venna wrote:
> config SPI_S3C64XX
> tristate "Samsung S3C64XX series type SPI"
> - depends on (ARCH_S3C64XX || ARCH_S5P64X0)
> + depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)
Just get rid of the unnecessary parens here
On Tue, Jul 5, 2011 at 5:06 PM, Kukjin Kim wrote:
> From: Jongpill Lee
>
> Signed-off-by: Jongpill Lee
> Signed-off-by: SangWook Ju
> Signed-off-by: Jonghwan Choi
> Signed-off-by: Kukjin Kim
> ---
> arch/arm/mach-exynos4/include/mach/cpufreq.h | 39 ++
> drivers/cpufreq/exynos4210-cpuf
> static int acquire_dma(struct s3c64xx_spi_driver_data *sdd)
> {
> +#if defined(CONFIG_DMADEV_PL330)
> + dma_cap_mask_t mask;
> + dma_cap_zero(mask);
> + dma_cap_set(DMA_SLAVE, mask);
> + sdd->rx_chan =
> + dma_request_channel(mask, rxfilter, (void *)sdd);
>
>> @@ -47,6 +47,11 @@ static struct clk clk_sclk_usbphy1 = {
>> .id = -1,
>> };
>>
>> +static struct clk dummy_apb_pclk = {
>> + .name = "apb_pclk",
>> + .id = -1,
>> +};
>> +
> What is the need to creating "dummy_apb_pclk" ?
I guess this is ri
From: Jongpill Lee
Signed-off-by: Jongpill Lee
Signed-off-by: SangWook Ju
Signed-off-by: Jonghwan Choi
Signed-off-by: Kukjin Kim
---
arch/arm/mach-exynos4/include/mach/cpufreq.h | 39 ++
drivers/cpufreq/exynos4210-cpufreq.c | 167 +-
2 files changed, 20
From: Jongpill Lee
This patch adds support 1.2GHz CPU frequency and changes
CPU table and divider for stable working.
Signed-off-by: Jongpill Lee
Signed-off-by: SangWook Ju
Signed-off-by: Kukjin Kim
---
drivers/cpufreq/exynos4210-cpufreq.c | 69 --
1 files c
From: Jongpill Lee
Since busfreq codes can be handlend on busfreq driver,
this patch removes regarding busfreq codes on cpufreq.
Signed-off-by: Jongpill Lee
Signed-off-by: SangWook Ju
Signed-off-by: Kukjin Kim
---
drivers/cpufreq/exynos4210-cpufreq.c | 180 +-
From: Jongpill Lee
This patch modifies following.
1. Remove unused register access
2. Change sequence of changing frequency
3. Minor optimization
Signed-off-by: Jongpill Lee
Signed-off-by: SangWook Ju
Signed-off-by: Jonghwan Choi
Signed-off-by: Kukjin Kim
---
drivers/cpufreq/exynos4210-cpuf
This patch updates CPU table and divider to support 1.2GHz in stable and
removes unused codes like regarding bus freq codes.
[PATCH 1/4] [CPUFREQ] EXYNOS4210: Remove regarding busfreq codes
[PATCH 2/4] [CPUFREQ] EXYNOS4210: Change CPU table and divider
[PATCH 3/4] [CPUFREQ] EXYNOS4210: Cleanup seq
>
> Basically, src_addr_width is defined as a 'enum dma_slave_buswidth' so I
> think we don't need to consider it.
>
Client D/D normally uses 'enum dma_slave_buswidth' type.
However, dmaengine driver cannot guarantee all client D/D uses it.
See below your spi driver. Thus, the dmaengine driver che
On Mon, Jul 04, 2011 at 09:18:29PM +0900, Kukjin Kim wrote:
> @@ -666,6 +667,7 @@ pl330_probe(struct amba_device *adev, const struct
> amba_id *id)
> struct dma_device *pd;
> struct resource *res;
> int i, ret, irq;
> + struct clk* clk;
Please use checkpatch. 'struct clk *c
On Tue, Jul 05, 2011 at 04:05:32PM +0900, Kukjin Kim wrote:
> Of course, if we can remove every S3C_DMA_API, that can be the best solution
> but it needs more time. I'd like to go to our goal step by step.
Surely one of the preconditions then is to improve the existing PL080
dmaengine driver to do
On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote:
> static void enable_datapath(struct s3c64xx_spi_driver_data *sdd,
> struct spi_device *spi,
> struct spi_transfer *xfer, int dma_mode)
> @@ -236,6 +322,11 @@ static void enable_
> Two questions here:
>
> - It looks like a lot of this code can be shared between all the drivers
> using the dmaengine API. Is there any reason not to factor it out?
> - Should this not be adding a new driver for dmaengine based Samsung
> CPUs? The ifdefs are very big.
I think that dma code
On Mon, Jul 04, 2011 at 09:18:30PM +0900, Kukjin Kim wrote:
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 25cf327..9b7f15a 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -193,7 +193,8 @@ config ARCH_HAS_ASYNC_TX_FIND_CHANNEL
> config PL330_DMA
> trista
Alim Akhtar wrote:
> > + /* enable dma clk */
> > + clk = clk_get(&adev->dev, "dma");
>
> Does this really needed here?
> AFAIR, amba_get_enable_pclk() does the same thing, provided clock name
> as "apb_pclk"
> please have a look at drivers/amba/bus.c
>
As I know, you can access Samsu
Mark Brown wrote:
>
Hi Mark,
Please refer to my other comment which includes block diagram, it can help
our understanding about current Samsung DMA usage.
> Two questions here:
>
> - It looks like a lot of this code can be shared between all the drivers
> using the dmaengine API. Is there an
Chanho Park wrote:
>
> Kukjin Kim samsung.com> writes:
>
> (snip)
>
> > + if (slave_config->direction == DMA_TO_DEVICE) {
> > + if (slave_config->dst_addr)
> > + peri->fifo_addr = slave_config->dst_addr;
> > + if (s
Grant Likely wrote:
>
> On Mon, Jul 04, 2011 at 09:51:43PM +0200, Heiko Stübner wrote:
> > Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely:
> > > On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote:
> > > > Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely:
> > > > >
> > > > >
35 matches
Mail list logo
