RE: [PATCH] ARM: Exynos4: don't change sclk_audio0 parent in core clocks code

2011-07-15 Thread Kukjin Kim
Marek Szyprowski wrote: > > Core clock API code should not change parent clocks set initially by > the boot-loader. This patch removes implicit sclk_audio0 clock change > introduced in commit "ARM: EXYNOS4: Add PCM audio support for WM8994" Since it happens problem on suspend-to-resume with above

RE: [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-07-15 Thread Kukjin Kim
Mark Brown wrote: > > On Thu, Jun 30, 2011 at 11:22:50AM +0300, Vasily Khoruzhick wrote: > > On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote: > > > > + adc->vdd = regulator_get(dev, "vdd"); > > > + if (IS_ERR(adc->vdd)) { > > > + dev_err(dev, "operating without regulator \"vdd\" .\n"

RE: [PATCH] ARM: EXYNOS4: Add support Core1 Power On/Off with hotplug in/out

2011-07-15 Thread Kukjin Kim
JungHi Min wrote: > > To insert the code for power on/off with pmu control to support hotplug in/out > core1 > As for hotplug.c, the codes for core1 to be hotplug in/out is inserted. > As for regs-pmu.h, S5P_CORE_LOCAL_PWR_EN is defined. > As for platsmp.c, the codes for core1 to be powered on is

RE: [PATCH 0/2] ARM: Samsung: I2C code cleanup

2011-07-15 Thread Kukjin Kim
Naveen Krishna Chatradhi wrote: > > Does the same job, while saving few lines of code. > > o To Kukjin Kim, Sangbeom Kim and Ben Dooks > > Naveen Krishna Chatradhi (2): > ARM: Samsung: Use generic set_plat_data function > ARM: Samsung: Cleanup I2C code in plat-samsung > > arch/arm/plat-sa

Re: [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210

2011-07-15 Thread Chanwoo Choi
Kukjin Kim wrote: > Chanwoo Choi wrote: >> Kukjin Kim wrote: > > (snip) > @@ -183,6 +183,7 @@ config MACH_NURI select EXYNOS4_SETUP_SDHCI select EXYNOS4_SETUP_USB_PHY select SAMSUNG_DEV_PWM + select PM_GENERIC_DOMAINS if PM >>> Do you _really_ think this should

RE: [PATCH] ARM: S5P: Remove sysmmu driver from arch tree

2011-07-15 Thread Kukjin Kim
KyongHo Cho wrote: > > This patch remove the System MMU driver from arch/arm/plat-s5p > because it will be merged with IOMMU API implementation and moved to > drivers/iommu directory. > Since the System MMU driver defines custom API and thus is not referred > by any device drivers in the mainline

RE: [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210

2011-07-15 Thread Kukjin Kim
Chanwoo Choi wrote: > > Kukjin Kim wrote: (snip) > >> @@ -183,6 +183,7 @@ config MACH_NURI > >>select EXYNOS4_SETUP_SDHCI > >>select EXYNOS4_SETUP_USB_PHY > >>select SAMSUNG_DEV_PWM > >> + select PM_GENERIC_DOMAINS if PM > > > > Do you _really_ think this should be under MACH_NURI?

RE: [PATCH V2 03/12] DMA: PL330: Add DMA capabilities

2011-07-15 Thread Boojin Kim
Chanho Park wrote: > 2011/7/13 Kukjin Kim : > > From: Boojin Kim > > > > This patch adds DMA_CYCLIC capability that is used for audio driver > > and SLAVE_CONFIG capability for transmit between device and memory. > > > > Signed-off-by: Boojin Kim > > Cc: Vinod Koul > > Cc: Dan Williams > > S

Re: [PATCH V2 05/12] ARM: SAMSUNG: Add common DMA operations

2011-07-15 Thread Grant Likely
On Sat, Jul 16, 2011 at 09:39:31AM +0900, Boojin Kim wrote: > Grant Likely wrote: > > > +void *samsung_dma_get_ops(void) > > > +{ > > > + return (void *)&dmaeng_ops; > > > +} > > > +EXPORT_SYMBOL(samsung_dma_get_ops); > > > > If all that is needed is a reference to the dma ops, then you could > >

RE: [PATCH V2 05/12] ARM: SAMSUNG: Add common DMA operations

2011-07-15 Thread Boojin Kim
Grant Likely wrote: > On Wed, Jul 13, 2011 at 05:47:30PM +0900, Kukjin Kim wrote: > > From: Boojin Kim > > > > This patch adds common DMA operations which are used for Samsung DMA > > drivers. Currently there are two types of DMA driver for Samsung SoCs. > > The one is S3C-DMA for S3C SoCs and th

RE: [PATCH V2 12/12] ASoC: Samsung: Update DMA interface

2011-07-15 Thread Kukjin Kim
Mark Brown wrote: > > On Wed, Jul 13, 2011 at 05:47:37PM +0900, Kukjin Kim wrote: > > > -static inline bool s3c_dma_has_circular(void) > > +static inline bool dma_has_circular(void) > > { > > return false; > > } > > The namespacing here doesn't look great, this is still a Samsung > specifi

[PATCH 6/8] ARM: S5P64X0: Add PWM backlight support on Samsung SMDK6440 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDK6440 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-s5p64x0/Kconfig |1 + arch/arm/mach-s5p64x0/mach-smdk6440.c | 54 - 2 files changed, 14 insertions(+), 41 deletions

[PATCH 8/8] ARM: S3C64XX: Add PWM backlight support on Samsung SMDK6410 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDK6410 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-s3c64xx/Kconfig |1 + arch/arm/mach-s3c64xx/mach-smdk6410.c | 15 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/a

[PATCH 5/8] ARM: S5PC100: Add PWM backlight support on Samsung SMDKC100 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDKC100 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-s5pc100/Kconfig |1 + arch/arm/mach-s5pc100/mach-smdkc100.c | 55 2 files changed, 15 insertions(+), 41 deletions(

[PATCH 7/8] ARM: S5P64X0: Add PWM backlight support on Samsung SMDK6450 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDK6450 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-s5p64x0/Kconfig |1 + arch/arm/mach-s5p64x0/mach-smdk6450.c | 54 - 2 files changed, 14 insertions(+), 41 deletions

[PATCH 4/8] ARM: S5PV210: Add PWM backlight support on Samsung SMDKV210 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDKV210 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-s5pv210/Kconfig |1 + arch/arm/mach-s5pv210/mach-smdkv210.c | 54 - 2 files changed, 14 insertions(+), 41 deletions

[PATCH 3/8] ARM: EXYNOS4: Add PWM backlight support on Samsung SMDKC210 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDKC210 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-exynos4/Kconfig |2 ++ arch/arm/mach-exynos4/mach-smdkc210.c | 16 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a

[PATCH 2/8] ARM: EXYNOS4: Add PWM backlight support on Samsung SMDKV310 board

2011-07-15 Thread Banajit Goswami
This patch adds support for LCD backlight using PWM timer for Samsung SMDKV310 board. Signed-off-by: Banajit Goswami --- arch/arm/mach-exynos4/Kconfig |2 ++ arch/arm/mach-exynos4/mach-smdkv310.c | 16 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a

[PATCH 1/8] ARM: SAMSUNG: Create a common infrastructure for PWM backlight support

2011-07-15 Thread Banajit Goswami
This patch creates a common structure for LCD backlight using PWM timer to be used by various Samsung boards. Signed-off-by: Banajit Goswami --- arch/arm/plat-samsung/Kconfig |6 + arch/arm/plat-samsung/Makefile |1 + arch/arm/plat-samsung/dev-backlight.c

[PATCH 0/8] ARM: SAMSUNG: Add common PWM Backlight support

2011-07-15 Thread Banajit Goswami
The patches are created against "for-next" branch of Kukjin Kim's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git Patch [1/8] -- add a common infrastructure to support PWM backlight for various Samsung boards. Patch [2/8] -- Add support for PWM backlig

Re: [PATCH] ARM: S5P64X0: External Interrupt Support

2011-07-15 Thread Russell King - ARM Linux
On Fri, Jul 15, 2011 at 05:23:33PM +0530, padma venkat wrote: > Hi Russell, > > On Fri, Jul 15, 2011 at 2:30 PM, Russell King - ARM Linux > wrote: > > On Fri, Jul 15, 2011 at 12:11:34PM +0530, Padmavathi Venna wrote: > >> +#define eint_offset(irq)     ((irq) - IRQ_EINT(0)) > >> +#define eint_irq_

Re: [PATCH] ARM: S5P64X0: External Interrupt Support

2011-07-15 Thread padma venkat
Hi Russell, On Fri, Jul 15, 2011 at 2:30 PM, Russell King - ARM Linux wrote: > On Fri, Jul 15, 2011 at 12:11:34PM +0530, Padmavathi Venna wrote: >> +#define eint_offset(irq)     ((irq) - IRQ_EINT(0)) >> +#define eint_irq_to_bit(irq) ((u32)(1 << eint_offset(irq))) >> + >> +static inline void s5p64

Re: [PATCH 0/6] ARM: S5P64X0: Add Framebuffer support

2011-07-15 Thread Tushar Behera
On Friday 15 July 2011 11:57 AM, Ajay kumar wrote: Hi Tushar, On Fri, Jul 15, 2011 at 11:42 AM, Tushar Behera wrote: On Thursday 14 July 2011 06:57 PM, Ajay Kumar wrote: The patches are created against "for-next" branch of Kukjin Kim's tree at: git://git.kernel.org/pub/scm/linux/

RE: [PATCH v2] ARM: EXYNOS4: Add platform device for dwmci driver.

2011-07-15 Thread Seungwon Jeon
Hi Kyungmin Park wrote: > On Fri, Jul 15, 2011 at 3:58 PM, Seungwon Jeon > wrote: > > Hi, > > > > Kyungmin Park wrote: > >> On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon > >> wrote: > >> > This patch add platform devices for Synopsys DesignWare Multimedia > Card > >> > Interface driver. > >> >

Re: [PATCH] ARM: S5P64X0: External Interrupt Support

2011-07-15 Thread Russell King - ARM Linux
On Fri, Jul 15, 2011 at 12:11:34PM +0530, Padmavathi Venna wrote: > +#define eint_offset(irq) ((irq) - IRQ_EINT(0)) > +#define eint_irq_to_bit(irq) ((u32)(1 << eint_offset(irq))) > + > +static inline void s5p64x0_irq_eint_mask(struct irq_data *data) > +{ > + u32 mask; > + > + mask = __r

[PATCH] ARM: S5P: Remove sysmmu driver from arch tree

2011-07-15 Thread KyongHo Cho
This patch remove the System MMU driver from arch/arm/plat-s5p because it will be merged with IOMMU API implementation and moved to drivers/iommu directory. Since the System MMU driver defines custom API and thus is not referred by any device drivers in the mainline kernel, this patch will not caus

Re: [PATCH v2] ARM: EXYNOS4: Add platform device for dwmci driver.

2011-07-15 Thread Kyungmin Park
On Fri, Jul 15, 2011 at 3:58 PM, Seungwon Jeon wrote: > Hi, > > Kyungmin Park wrote: >> On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon >> wrote: >> > This patch add platform devices for Synopsys DesignWare Multimedia Card >> > Interface driver. >> > >> > Signed-off-by: Seungwon Jeon >> > --- >>