Re: [PATCH] ARM: EXYNOS4: Setup consistent dma size at boot time

2011-09-12 Thread Subash Patel
My bad. I am still referring to drivers/video/samsung/s3cfb_main.c in Linaro-3.0 kernel. Thanks for the pointer. This makes sense now. Also, we will not be able to use CMA directly, even after it gets mainlined. It needs to be called from the dma_alloc_*() with appropriate attributes. Regard

[PATCH v3 2/2] i2c: s3c2410: Add device tree support

2011-09-12 Thread Thomas Abraham
Add device tree probe support for Samsung's s3c2410 i2c driver. Cc: Ben Dooks Signed-off-by: Thomas Abraham Acked-by: Grant Likely --- .../devicetree/bindings/i2c/samsung-i2c.txt| 39 +++ drivers/i2c/busses/i2c-s3c2410.c | 110 +++- 2 files chan

[PATCH v3 1/2] i2c: s3c2410: Keep a copy of platform data and use it

2011-09-12 Thread Thomas Abraham
The platform data is copied into driver's private data and the copy is used for all access to the platform data. This simpifies the addition of device tree support for the i2c-s3c2410 driver. Cc: Ben Dooks Signed-off-by: Thomas Abraham Acked-by: Grant Likely --- drivers/i2c/busses/i2c-s3c2410.

[PATCH v3 0/2] Add device tree support for Samsung's I2C driver

2011-09-12 Thread Thomas Abraham
This patchset adds device tree support for Samsung's I2C driver. Changes since v2: - Addressed all comments from Grant Likely - Used dev_kzalloc to allocate memory for platform data. - Removed redundant check while adding i2c adapter. - Added support to retrieve gpio pin information from d

Re: [PATCH] ARM: EXYNOS4: Setup consistent dma size at boot time

2011-09-12 Thread Tushar Behera
Hi Subash, On Monday 12 September 2011 08:32 PM, Subash Patel wrote: Hi Tushar, On 09/12/2011 11:25 AM, Tushar Behera wrote: Some of the boards under mach-exynos4 initialize frame-buffers for which the memory requirement is more than 2MB (Nuri board requires around 4MB, Origen requires around

Re: [PATCH v3 4/6] DMA: PL330: Add device tree support

2011-09-12 Thread Jassi Brar
On Mon, Sep 12, 2011 at 11:59 PM, Thomas Abraham wrote: > For PL330 dma controllers instantiated from device tree, the channel > lookup is based on phandle of the dma controller and dma request id > specified by the client node. During probe, the private data of each > channel of the controller is

Re: [PATCH v3 1/6] DMA: PL330: move filter function into driver

2011-09-12 Thread Jassi Brar
On Mon, Sep 12, 2011 at 11:59 PM, Thomas Abraham wrote: > The dma channel selection filter function is moved from plat-samsung > into the pl330 driver. In additon to that, a check is added in the > filter function to ensure that the channel on which the filter has > been invoked is pl330 channel i

[PATCH v3 6/6] ARM: EXYNOS4: Limit usage of pl330 device instance to non-dt build

2011-09-12 Thread Thomas Abraham
The pl330 device instances and associated platform data is required only for non-device-tree builds. With device tree enabled, the data about the platform is obtained from the device tree. For images that include both dt and non-dt platforms, an addditional check is added to ensure that static amba

[PATCH v3 5/6] ARM: SAMSUNG: Add device tree support for pl330 dma engine wrappers

2011-09-12 Thread Thomas Abraham
A new dma request id 'DMACH_DT_PROP' is introduced for client drivers requesting a dma channel. This request indicates that a device tree node property represting the dma channel is available in 'struct samsung_dma_info'. The dma channel request wrapper uses the node property value as the value for

[PATCH v3 4/6] DMA: PL330: Add device tree support

2011-09-12 Thread Thomas Abraham
For PL330 dma controllers instantiated from device tree, the channel lookup is based on phandle of the dma controller and dma request id specified by the client node. During probe, the private data of each channel of the controller is set to point to the device node of the dma controller. The 'chan

[PATCH v3 3/6] ARM: EXYNOS4: Modify platform data for pl330 driver

2011-09-12 Thread Thomas Abraham
With the 'struct dma_pl330_peri' removed, the platfrom data for dma driver can be simplified to a simple list of peripheral request ids. Cc: Jassi Brar Cc: Boojin Kim Signed-off-by: Thomas Abraham Acked-by: Kukjin Kim --- arch/arm/mach-exynos4/dma.c | 223

[PATCH v3 2/6] DMA: PL330: Infer transfer direction from transfer request instead of platform data

2011-09-12 Thread Thomas Abraham
The transfer direction for a channel can be inferred from the transfer request and the need for specifying transfer direction in platfrom data can be eliminated. So the structure definition 'struct dma_pl330_peri' is no longer required. The channel's private data is set to point to a channel id sp

[PATCH v3 1/6] DMA: PL330: move filter function into driver

2011-09-12 Thread Thomas Abraham
The dma channel selection filter function is moved from plat-samsung into the pl330 driver. In additon to that, a check is added in the filter function to ensure that the channel on which the filter has been invoked is pl330 channel instance (and avoid any incorrect access of chan->private in a sys

[PATCH v3 0/6] Add device tree support for PL330 dma controller driver

2011-09-12 Thread Thomas Abraham
Changes since v2: - Only the sixth patch is changed, to make dma platform data conditionally selectable. - Tested with v8 version of pl330 dma driver update patches from Boojin Kim. Changes since v1: - Removed "arm,pl330-pdma" and "arm,pl330-mdma" compatible values. - Removed "arm,primecell-peri

Re: [PATCH] ARM: EXYNOS4: Setup consistent dma size at boot time

2011-09-12 Thread Subash Patel
Hi Tushar, On 09/12/2011 11:25 AM, Tushar Behera wrote: Some of the boards under mach-exynos4 initialize frame-buffers for which the memory requirement is more than 2MB (Nuri board requires around 4MB, Origen requires around 2.6MB), hence the default dma pool allocation size of 2MB is not suffic

Re: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option

2011-09-12 Thread Thomas Abraham
Hi Dmitry, On 8 September 2011 22:03, Dmitry Torokhov wrote: > On Thu, Sep 08, 2011 at 09:16:46AM +0530, Thomas Abraham wrote: >> Hi Dmitry, >> >> On 7 September 2011 23:52, Dmitry Torokhov wrote: >> > Hi Thomas, >> > >> > On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: >> >> Sam