[PATCH] GPIO: Samsung: correct pin configuration for S5PC100/S5PC110/Exynos4

2011-09-23 Thread Marek Szyprowski
Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO SoCs. The new driver use wrong configuration setup for all gpio pins on S5PC100 and S5PV210 SoCs and external interrupt lines on Exynos4 SoCs. This patch fixes this issue. Signed-off-by: Marek Szyprowski Signed-off-by: Kyung

[PATCH 0/7]: ARM: SAMSUNG: Add SPI clkdev support

2011-09-23 Thread Padmavathi Venna
This patchset modifies the existing clkdev to make SPI driver independent of the clock names send from platform data. This patches enables the SPI driver to request SPI bus clocks using generic connection ID. The patches are created against "for-next" branch of Kukjin Kim's tree at: git://github.c

[PATCH 1/7] SPI: S3C64XX: Use bus clocks created using clkdev

2011-09-23 Thread Padmavathi Venna
This patch modifies the driver to stop depending on the clock names being passed from platform and switch over to lookup clocks generic names using clkdev Signed-off-by: Padmavathi Venna --- drivers/spi/spi-s3c64xx.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff -

[PATCH 2/7] ARM: SAMSUNG: Add CLK Macro for clkdev support

2011-09-23 Thread Padmavathi Venna
Signed-off-by: Padmavathi Venna --- arch/arm/plat-samsung/include/plat/clock.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/include/plat/clock.h b/arch/arm/plat-samsung/include/plat/clock.h index 73c66d4..c864825 100644 --- a/arch/arm/plat-

[PATCH 3/7] ARM: S3C64XX: Add SPI clkdev support

2011-09-23 Thread Padmavathi Venna
Registered the SPI bus clocks with clkdev using generic connection id. Signed-off-by: Padmavathi Venna --- arch/arm/mach-s3c64xx/clock.c | 98 +++- 1 files changed, 66 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach

[PATCH 4/7] ARM: S5PC100: Add SPI clkdev support

2011-09-23 Thread Padmavathi Venna
Registered the SPI bus clocks with clkdev using generic connection id. Signed-off-by: Padmavathi Venna --- arch/arm/mach-s5pc100/clock.c | 132 + 1 files changed, 81 insertions(+), 51 deletions(-) diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/mac

[PATCH 5/7] ARM: S5P64X0: Add SPI clkdev support

2011-09-23 Thread Padmavathi Venna
Registered the SPI bus clocks with clkdev using generic connection id. Signed-off-by: Padmavathi Venna --- arch/arm/mach-s5p64x0/clock-s5p6440.c | 57 +--- arch/arm/mach-s5p64x0/clock-s5p6450.c | 57 +--- 2 files changed, 74 insertions(

[PATCH 6/7] ARM: S5PV210: Add SPI clkdev support

2011-09-23 Thread Padmavathi Venna
Registered the SPI bus clocks with clkdev using generic connection id. Signed-off-by: Padmavathi Venna --- arch/arm/mach-s5pv210/clock.c | 58 ++-- 1 files changed, 38 insertions(+), 20 deletions(-) diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach

[PATCH 7/7] ARM: SAMSUNG: Remove SPI bus clocks from platform data

2011-09-23 Thread Padmavathi Venna
SPI bus clocks can be avoided passing through platform data as spi driver is getting the bus clock using the generic clock connection id registered via clkdev. Signed-off-by: Padmavathi Venna --- arch/arm/mach-s3c64xx/dev-spi.c |7 --- arch/arm/mach-s5p64x0/dev-spi.c

[PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
Hi Girish, On Fri, Sep 23 2011, Girish K S wrote: > + default: > + pr_warning("%s: Voltage range not supported " > +"for power class.\n", mmc_hostname(host)); > + break; > + } I suggested replacing your BUG(); here with a return, but you jus

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Girish K S
Hi Chris, On 23 September 2011 20:09, Chris Ball wrote: > Hi Girish, > > On Fri, Sep 23 2011, Girish K S wrote: >> +     default: >> +             pr_warning("%s: Voltage range not supported " >> +                        "for power class.\n", mmc_hostname(host)); >> +             break; >> +    

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
Hi Girish, On Fri, Sep 23 2011, Girish K S wrote: >> I suggested replacing your BUG(); here with a return, but you just have >> a break here. Is having the function continue in this case intentional? > > sorry for that. > will update with a return -EBADMSG Thanks; let's go with -EINVAL, though.

[PATCH V5] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

Re: [PATCH V5] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
Hi Girish, On Fri, Sep 23 2011, Girish K S wrote: > This patch adds the power class selection feature available > for mmc versions 4.0 and above. > During the enumeration stage before switching to the lower > data bus, check if the power class is supported for the > current bus width. If the power

Re: [PATCH 2/7] ARM: SAMSUNG: Add CLK Macro for clkdev support

2011-09-23 Thread Russell King - ARM Linux
On Fri, Sep 23, 2011 at 05:23:42PM +0530, Padmavathi Venna wrote: > diff --git a/arch/arm/plat-samsung/include/plat/clock.h > b/arch/arm/plat-samsung/include/plat/clock.h > index 73c66d4..c864825 100644 > --- a/arch/arm/plat-samsung/include/plat/clock.h > +++ b/arch/arm/plat-samsung/include/plat/c

Re: [PATCH 1/7] SPI: S3C64XX: Use bus clocks created using clkdev

2011-09-23 Thread Grant Likely
On Fri, Sep 23, 2011 at 05:23:41PM +0530, Padmavathi Venna wrote: > This patch modifies the driver to stop depending on the > clock names being passed from platform and switch over > to lookup clocks generic names using clkdev > > Signed-off-by: Padmavathi Venna Looks okay to me. Acked-by: Gran

Re: [PATCH] GPIO: Samsung: correct pin configuration for S5PC100/S5PC110/Exynos4

2011-09-23 Thread Grant Likely
On Fri, Sep 23, 2011 at 01:38:50PM +0200, Marek Szyprowski wrote: > Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO > SoCs. The new driver use wrong configuration setup for all gpio pins on > S5PC100 and S5PV210 SoCs and external interrupt lines on Exynos4 SoCs. > This patc