Re: [PATCH] ARM: EXYNOS: Add ARCH_EXYNOS and reorganize arch/arm/mach-exynos

2011-10-02 Thread Kyungmin Park
Hi, I'm afraid to change machine directory name again. mach-s5pv310 -> mach-exynos4 -> mach-exynos. As I remember linus blamed the renaming the file names are happened frequently at ARM Thank you, Kyungmin Park 2011/10/2 Kukjin Kim : > The arch/arm/mach-exynos4 directory (CONFIG_ARCH_EXYNOS4) ha

Re: [PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kyungmin Park
On Mon, Oct 3, 2011 at 12:41 PM, Kukjin Kim wrote: > This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ > and so on to cleanup regarding 'struct resource' by using > defined helpers at . > > Cc: Ben Dooks > Signed-off-by: Kukjin Kim > --- > Changes since v1: > - Address comments from Russell

[PATCH V2 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kukjin Kim
This patch adds macro SAMSUNG_RES_MEM, SAMSUNG_RES_IRQ and so on to cleanup regarding 'struct resource' by using defined helpers at . Cc: Ben Dooks Signed-off-by: Kukjin Kim --- Changes since v1: - Address comments from Russell King Using defined helpers to define resource arch/arm/mach-s3c24

[PATCH] gpio/samsung: Move SoC specific codes within macro

2011-10-02 Thread Tushar Behera
In drivers/gpio/gpio-samsung.c, there are certain structures and functions which are not getting used if the particular CPU is not selected. These code segments are moved under CPU specific macros to remove compilation warnings. Signed-off-by: Tushar Behera --- It has been build tested with s3c24

RE: [GIT PULL] Samsung devel-2 for v3.2

2011-10-02 Thread Kukjin Kim
Mark Brown wrote: > > On Sun, Oct 02, 2011 at 06:25:36PM +0900, Kukjin Kim wrote: > > > gpio/samsung: gpio-samsung.c to support Samsung GPIOs > > As I reported the other day this change breaks the boot early on on the > Cragganmore S3C6410 based systems (I've not actually fired up my > SMD

RE: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Kukjin Kim
Rafael J. Wysocki wrote: > > On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > > On Sun, Oct 02, 2011 at 03:08:43PM +0200, Rafael J. Wysocki wrote: > > > On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > > > > How do these misconceptions start? > > > > > > > > The clock A

RE: [PATCH 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kukjin Kim
Russell King - ARM Linux wrote: > > On Sun, Oct 02, 2011 at 06:24:40PM +0900, Kukjin Kim wrote: > > This patch adds macro SAMSUNG_RES_MEM and SAMSUNG_RES_IRQ to > cleanup > > regarding 'struct resource' > > Why not include the braces inside the macro as well? > I thought, if other member such as

RE: [PATCH v2] ARM: EXYNOS4: Configure MAX8997 PMIC for Origen

2011-10-02 Thread Kukjin Kim
Kukjin Kim wrote: > > Inderpal Singh wrote: > > > > From: Inderpal Singh ^^^ > > > > Configure MAX8997 PMIC and provide platform specific data > > for origen. > > > > Signed-off-by: Inderpal Singh

Re: [GIT PULL] Samsung devel-2 for v3.2

2011-10-02 Thread Mark Brown
On Sun, Oct 02, 2011 at 06:25:36PM +0900, Kukjin Kim wrote: > gpio/samsung: gpio-samsung.c to support Samsung GPIOs As I reported the other day this change breaks the boot early on on the Cragganmore S3C6410 based systems (I've not actually fired up my SMDK6410 but I suspect it may have iss

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Rafael J. Wysocki
On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > On Sun, Oct 02, 2011 at 03:08:43PM +0200, Rafael J. Wysocki wrote: > > On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > > > How do these misconceptions start? > > > > > > The clock API. Drivers are supposed to get a cloc

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Rafael J. Wysocki
On Sunday, October 02, 2011, Sylwester Nawrocki wrote: > On 10/02/2011 09:07 AM, Kukjin Kim wrote: > > Rafael J. Wysocki wrote: > >> > >> On Saturday, August 13, 2011, Russell King - ARM Linux wrote: > >>> On Sat, Aug 13, 2011 at 11:24:07PM +0200, Rafael J. Wysocki wrote: > On Thursday, August

Re: [PATCH 1/4] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210

2011-10-02 Thread Sylwester Nawrocki
Hi Chanwoo, a few minor comments below... On 08/11/2011 06:55 AM, Chanwoo Choi wrote: > Use the generic power domains support to implement support for > power domain on EXYNOS4210. > > I refer to the following patch to implement what configure > the clock-gating control register for block to tu

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Sylwester Nawrocki
On 10/02/2011 09:07 AM, Kukjin Kim wrote: > Rafael J. Wysocki wrote: >> >> On Saturday, August 13, 2011, Russell King - ARM Linux wrote: >>> On Sat, Aug 13, 2011 at 11:24:07PM +0200, Rafael J. Wysocki wrote: On Thursday, August 11, 2011, Chanwoo Choi wrote: > The following patch set use th

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Russell King - ARM Linux
On Sun, Oct 02, 2011 at 03:08:43PM +0200, Rafael J. Wysocki wrote: > On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > > How do these misconceptions start? > > > > The clock API. Drivers are supposed to get a clock (source) when they > > initialize. Drivers then enable and disable t

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Rafael J. Wysocki
On Sunday, October 02, 2011, Russell King - ARM Linux wrote: > On Sun, Oct 02, 2011 at 01:47:01PM +0200, Rafael J. Wysocki wrote: > > On Sunday, October 02, 2011, Kukjin Kim wrote: > > > Hmm... Even though each driver cannot know the given situation, the driver > > > can know each own clock should

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Russell King - ARM Linux
On Sun, Oct 02, 2011 at 01:47:01PM +0200, Rafael J. Wysocki wrote: > On Sunday, October 02, 2011, Kukjin Kim wrote: > > Hmm... Even though each driver cannot know the given situation, the driver > > can know each own clock should be alive or not. I think, if clock gating > > (enable, disable clock)

Re: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Rafael J. Wysocki
On Sunday, October 02, 2011, Kukjin Kim wrote: > Rafael J. Wysocki wrote: > > > > On Saturday, August 13, 2011, Russell King - ARM Linux wrote: > > > On Sat, Aug 13, 2011 at 11:24:07PM +0200, Rafael J. Wysocki wrote: > > > > On Thursday, August 11, 2011, Chanwoo Choi wrote: > > > > > The following

Re: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-10-02 Thread Heiko Stübner
Hi Kgene, Am Sonntag 02 Oktober 2011, 09:38:18 schrieb Kukjin Kim: > How about following? I think following is also not bad... ok, I don't claim to have the right solution, so if keeping the TYPE_xxx enum is better, I will do a rework of the series according to your solution and resend it. Coul

Re: [PATCH 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Russell King - ARM Linux
On Sun, Oct 02, 2011 at 06:24:40PM +0900, Kukjin Kim wrote: > This patch adds macro SAMSUNG_RES_MEM and SAMSUNG_RES_IRQ to cleanup > regarding 'struct resource' Why not include the braces inside the macro as well? > diff --git a/arch/arm/plat-samsung/include/plat/devs.h > b/arch/arm/plat-samsung

[GIT PULL] Samsung devel-2 for v3.2

2011-10-02 Thread Kukjin Kim
Hi Arnd, This is Samsung devel for v3.2. which includes consolidation work for dma-pl330 and gpio-samsung. Please pull from: git://github.com/kgene/linux-samsung.git next-samsung-devel-2 And the next-samsung-devel-2 is based on v3.1-rc8 plus next-samsung-cleanup and next-samsung-board which

[PATCH] ARM: EXYNOS: Add ARCH_EXYNOS and reorganize arch/arm/mach-exynos

2011-10-02 Thread Kukjin Kim
The arch/arm/mach-exynos4 directory (CONFIG_ARCH_EXYNOS4) has made for plaforms based on EXYNOS4 SoCs. But since upcoming Samsung's SoCs such as EXYNOS5 (ARM Cortex A15) can reuse most codes in current mach-exynos4, one mach-exynos directory will be used for them. This patch changes to CONFIG_ARCH

[PATCH 2/2] ARM: SAMSUNG: Cleanup resources by using macro

2011-10-02 Thread Kukjin Kim
This patch adds macro SAMSUNG_RES_MEM and SAMSUNG_RES_IRQ to cleanup regarding 'struct resource' Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c2410/include/mach/map.h |1 + arch/arm/plat-samsung/devs.c | 670 + arch/arm/plat-samsung/

RE: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-10-02 Thread Kukjin Kim
Heiko Stübner wrote: > > Hi, > > Am Mittwoch, 21. September 2011, 14:32:14 schrieben Sie: > > Heiko Stübner wrote: > > > The adc blocks of S3C2410 through S5P have a multitude of > > > quirks, i.e. moved bits or whole new registers. > > > > > > This patch tries to describe these individual featur

RE: [PATCH 4/4] ARM: EXYNOS4: Add power domain to use generic Power domain Framework

2011-10-02 Thread Kukjin Kim
Chanwoo Choi wrote: > > This patch initializes the power domain of EXYNOS4210. The devices > which suppot runtime-PM have to be added in specific power domain. > > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos4/mach-nuri.c | 18

RE: [PATCH 2/4] ARM: EXYNOS4: Support for generic Clock manipulation PM callbacks

2011-10-02 Thread Kukjin Kim
Chanwoo Choi wrote: > > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos4/Makefile |2 +- > arch/arm/mach-exynos4/pm-runtime.c | 56 > > 2 files changed, 57 insertions(+), 1 deletions(-) > create mode 100644

RE: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-10-02 Thread Kukjin Kim
Rafael J. Wysocki wrote: > > On Saturday, August 13, 2011, Russell King - ARM Linux wrote: > > On Sat, Aug 13, 2011 at 11:24:07PM +0200, Rafael J. Wysocki wrote: > > > On Thursday, August 11, 2011, Chanwoo Choi wrote: > > > > The following patch set use the generic Power domain Framework instead o

RE: [PATCH V2 0/3] S5P64X0 PM Support

2011-10-02 Thread Kukjin Kim
Abhilash Kesavan wrote: > > The patchset adds Power Mangement support for S5P64X0. The first > two patches lay the groundwork for adding PM support, while the > final patch adds the SoC specific PM code. > > Changes since V1: > - Changed register naming as per User Manual. > - Dropped the pm-gpio

RE: [PATCH v2] ARM: EXYNOS4: Configure MAX8997 PMIC for Origen

2011-10-02 Thread Kukjin Kim
Inderpal Singh wrote: > > From: Inderpal Singh > > Configure MAX8997 PMIC and provide platform specific data > for origen. > > Signed-off-by: Inderpal Singh > --- > Changes from v1: > - Removed soc-audio > - Used macro for GPIO pin > - irq assigned statically > - Rectif

RE: [PATCH] ARM: EXYNOS4: Enable MFC on Origen

2011-10-02 Thread Kukjin Kim
Sachin Kamat wrote: > > This patch enables multi-format codec (MFC) support on Origen board. > > Signed-off-by: Sachin Kamat > --- > PD related code in KConfig and header are added only because for-next branch of > Kgene's tree does not have it enabled yet. > > --- > arch/arm/mach-exynos4/Kcon

RE: [PATCH] ARM: EXYNOS4: Add HPD and PD support for HDMI on Origen

2011-10-02 Thread Kukjin Kim
Sachin Kamat wrote: > > This patch adds hot plug detection (HPD) and power domain (PD) support for HDMI > on Origen board. > > Signed-off-by: Sachin Kamat > --- > I have added the KConfig entry and header file required for enabling PD > since the patch [1] is not yet applied on Kgene's tree [2].