Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Russell King - ARM Linux
On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: + release_resource(hsudc-mem_rsrc); + kfree(hsudc-mem_rsrc); release_mem_region() is paired with request_mem_region. Do not go beneath the API by doing the above. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 5/7] s3c-hsudc: move device registration to probe and remove

2011-12-18 Thread Russell King - ARM Linux
On Sat, Dec 17, 2011 at 08:28:34PM +0100, Heiko Stübner wrote: Instead of adding and deleting the gadget device in the start and stop invocations. Use device_register in the probe method to initialize and add the gadget device and unregister it in the remove function. This also requires a

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: As the driver is also buildable as a module it should need a cleanup function for the removal of the module. My guess is that this wasn't implemented

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: As the driver is also buildable as a module it should need a cleanup function for the removal of the module. My guess is that this wasn't implemented

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Russell King - ARM Linux
On Sun, Dec 18, 2011 at 02:44:39PM +0100, Heiko Stübner wrote: Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: As the driver is also buildable as a module it should need a cleanup function for the

Re: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-18 Thread Kukjin Kim
On 12/16/11 17:24, Kyungmin Park wrote: Hi Mr. Kim, It's maybe missing for v3.3 merge at samsung soc. Please give your opinion, how to handle it? Looks ok to me at the moment, and as a note, I'm sorting it out now. If you don't mind it, it can merge it by devfreq. Hmm, I think, it should

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-18 Thread 'Joerg Roedel'
On Mon, Dec 19, 2011 at 01:04:18AM +0900, Kukjin Kim wrote: Hmm, I cannot find the iommu/exynos branch what you said in your iommu tree yet. Maybe you missed or any problem? Problems. I tried to apply the patches and there were conflicts. After solving them I wasn't able to find a

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Russell King - ARM Linux
On Sun, Dec 18, 2011 at 07:50:37PM +0100, Heiko Stübner wrote: I didn't get this far. With your patch the Oopses already happen during the startup of the system / the loading of the modules. A bit of the message spew I got during testing with linux-next-20111216: In some way, this is a good

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 20:45:18 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 08:33:32PM +0100, Heiko Stübner wrote: Am Sonntag 18 Dezember 2011, 20:01:02 schrieben Sie: On Sun, Dec 18, 2011 at 07:50:37PM +0100, Heiko Stübner wrote: I didn't get this far. With your

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 21:39:53 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 09:24:12PM +0100, Heiko Stübner wrote: Am Sonntag 18 Dezember 2011, 20:45:18 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 08:33:32PM +0100, Heiko Stübner wrote: Am Sonntag 18

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Russell King - ARM Linux
On Sun, Dec 18, 2011 at 09:46:08PM +0100, Heiko Stübner wrote: kobject: 'holders' (c7addc80): kobject_cleanup Unable to handle kernel paging request at virtual address bf055504 pgd = c0004000 [bf055504] *pgd=371f9811, *pte=, *ppte= Internal error: Oops: 7 [#1]

[PATCH V6 0/2] HS200 Mode support for device and host

2011-12-18 Thread Girish K S
Changes in v6: split the patch into 2 and classified them as a patch for device and host. Modified to include the review comments. Changes in v5: Reduced the case statements for better code readability. Removed unused macro definitions. Modified the tuning