On Sun, Dec 18, 2011 at 09:37:04PM +, Russell King - ARM Linux wrote:
> On Sun, Dec 18, 2011 at 09:46:08PM +0100, Heiko Stübner wrote:
> > > > kobject: 'holders' (c7addc80): kobject_cleanup
> > > > Unable to handle kernel paging request at virtual address bf055504
> > > > pgd = c0004000
> > > >
On Sun, Dec 18, 2011 at 07:50:37PM +0100, Heiko Stübner wrote:
> Am Sonntag 18 Dezember 2011, 15:43:19 schrieb Russell King - ARM Linux:
> > On Sun, Dec 18, 2011 at 02:44:39PM +0100, Heiko Stübner wrote:
> > > Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux:
> > > > On Sat, D
On 19 December 2011 22:24, Philip Rakity wrote:
>
> HI,
>
> minor comments below.
>
> Philip
>
> On Dec 18, 2011, at 10:36 PM, Girish K S wrote:
>
>> This patch adds support for the HS200 mode on the host side.
>> Also enables the tuning feature required when the HS200 mode
>> is selected.
>>
>> c
On 12/20/11, Mark Brown wrote:
> On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote:
>> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown
>
>> > I'm not sure I understand why we would not be ready to do things like
>> > this? I'd also expect that doing things in a board specific fashion
>> >
On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote:
> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown
> > I'm not sure I understand why we would not be ready to do things like
> > this? I'd also expect that doing things in a board specific fashion
> > might create issues with things being
Instead use container_of to retrieve the s3c_hsudc from the
struct usb_gadget pointer.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc
As the memory region is requested through request_mem_region
use the correct paired method to release it in the error path
and don't go "beneath the API" as pointed out by Russel King.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |4 +---
1 files changed, 1 insertions(+),
The udc has three supplies: vdda (3.3V), vddi (1.2V) and vddosc (1.8-3.3V).
Turn these on and off on start and stop calls.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 41 ---
1 files changed, 37 insertions(+), 4 deletions(-)
diff --gi
udc_start and udc_stop reduce code duplication in comparison to
start and stop generalising calls done by all drivers
(i.e. bind and unbind) and moving these calls to common code.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 44 ---
1 f
Instead of adding and deleting the gadget device in the start and stop
invocations. Use device_register in the probe method to initialize
and add the gadget device.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 17 -
1 files changed, 8 insertions(+), 9 dele
The number of get and put calls should always be equal.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 86e336e..1171efb 100644
--- a/
Fixes possible section mismatch warnings.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 606b20f..86e336e 100644
--- a/drivers/usb/gad
Gadget drivers should be compilable on all architectures.
This patch removes one dependency on architecture-specific code.
Signed-off-by: Heiko Stuebner
---
arch/arm/mach-s3c2416/mach-smdk2416.c|1 +
arch/arm/plat-samsung/devs.c |1 +
arch/arm/plat-samsung/include/plat/ud
In his response to the first submission Felipe Balbi asked to also move
the driver to the new udc_start and udc_stop functions and to make an
effort to reduce dependencies on archictecture code.
v3 of the series does not try to provide a remove function, due to the
possible lifetime problem of gad
On Dec 15, 2011, at 9:06 AM, Subhash Jadavani wrote:
>
>
>> -Original Message-
>> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-
>> ow...@vger.kernel.org] On Behalf Of Girish K S
>> Sent: Thursday, December 15, 2011 5:28 PM
>> To: linux-...@vger.kernel.org
>> Cc: patc...@linar
On Dec 18, 2011, at 10:36 PM, Girish K S wrote:
> This patch adds the support of the HS200 bus speed for eMMC 4.5 devices.
> The eMMC 4.5 devices have support for 200MHz bus speed. The function
> prototype of the tuning function is modified to handle the tuning command
> number which is different
HI,
minor comments below.
Philip
On Dec 18, 2011, at 10:36 PM, Girish K S wrote:
> This patch adds support for the HS200 mode on the host side.
> Also enables the tuning feature required when the HS200 mode
> is selected.
>
> cc: Chris Ball
> Signed-off-by: Girish K S
> ---
> drivers/mmc/ho
On 12/19/11 22:55, Russell King - ARM Linux wrote:
On Mon, Dec 19, 2011 at 08:58:20PM +0900, Kukjin Kim wrote:
Hook these platforms restart code into the new restart hook rather
than using arch_reset().
Cc: Ben Dooks
Cc: Russell King
Signed-off-by: Kukjin Kim
It would be _much_ better if you
On Mon, Dec 19, 2011 at 08:58:20PM +0900, Kukjin Kim wrote:
> Hook these platforms restart code into the new restart hook rather
> than using arch_reset().
>
> Cc: Ben Dooks
> Cc: Russell King
> Signed-off-by: Kukjin Kim
It would be _much_ better if you could prepare a set of patches against
m
On Mon, Dec 19, 2011 at 02:26:20PM +0100, Heiko Stübner wrote:
> udc_start and udc_stop reduce code duplication in comparison to
> start and stop generalising calls done by all drivers
> (i.e. bind and unbind) and moving these calls to common code.
>
> Signed-off-by: Heiko Stuebner
> ---
> drive
On Mon, Dec 19, 2011 at 02:24:57PM +0100, Heiko Stübner wrote:
I need a commit log, even if it's an obvious one. Sorry for the
nit-picking.
> Signed-off-by: Heiko Stuebner
> ---
> drivers/usb/gadget/s3c-hsudc.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/driv
Hi,
On Mon, Dec 19, 2011 at 02:24:24PM +0100, Heiko Stübner wrote:
> diff --git a/include/linux/usb/s3c-hsudc.h b/include/linux/usb/s3c-hsudc.h
> new file mode 100644
> index 000..6fa1093
> --- /dev/null
> +++ b/include/linux/usb/s3c-hsudc.h
> @@ -0,0 +1,34 @@
> +/*
> + * S3C24XX USB 2.0 High-
As the memory region is requested through request_mem_region
use the correct paired method to release it in the error path
and don't go "beneath the API" as pointed out by Russel King.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |4 +---
1 files changed, 1 insertions(+),
The udc has three supplies: vdda (3.3V), vddi (1.2V) and vddosc (1.8-3.3V).
Turn these on and off on start and stop calls.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 41 ---
1 files changed, 37 insertions(+), 4 deletions(-)
diff --gi
udc_start and udc_stop reduce code duplication in comparison to
start and stop generalising calls done by all drivers
(i.e. bind and unbind) and moving these calls to common code.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 44 ---
1 f
Instead of adding and deleting the gadget device in the start and stop
invocations. Use device_register in the probe method to initialize
and add the gadget device.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c | 17 -
1 files changed, 8 insertions(+), 9 dele
The number of get and put calls should always be equal.
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 3e5673d..6c2b2ce 100644
--- a/
Signed-off-by: Heiko Stuebner
---
drivers/usb/gadget/s3c-hsudc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 4c1abb1..3e5673d 100644
--- a/drivers/usb/gadget/s3c-hsudc.c
+++ b/drivers/usb/gadget/s3
Gadget drivers should be compilable on all architectures.
This patch removes one dependency on architecture-specific code.
Signed-off-by: Heiko Stuebner
---
arch/arm/mach-s3c2416/mach-smdk2416.c|1 +
arch/arm/plat-samsung/devs.c |1 +
arch/arm/plat-samsung/include/plat/ud
In his response to the first submission Felipe Balbi asked to also move
the driver to the new udc_start and udc_stop functions and to make an
effort to reduce dependencies on archictecture code.
v3 of the series does not try to provide a remove function, due to the
possible lifetime problem of gad
Am Montag, 19. Dezember 2011, 13:42:24 schrieb Kukjin Kim:
> Heiko Stübner wrote:
> > S3C2412/S3C2416/S3C2443 use a special register to signal the reset to
> > the processor and used therefore the s3c24xx_reset_hook mechanism in the
> > s3c24xx-specific arch reset.
> >
> > This patch introduces re
Heiko Stübner wrote:
>
> S3C2412/S3C2416/S3C2443 use a special register to signal the reset to
> the processor and used therefore the s3c24xx_reset_hook mechanism in the
> s3c24xx-specific arch reset.
>
> This patch introduces restart functions for these architectures,
> moves the board files to
S3C2412/S3C2416/S3C2443 use a special register to signal the reset to
the processor and used therefore the s3c24xx_reset_hook mechanism in the
s3c24xx-specific arch reset.
This patch introduces restart functions for these architectures,
moves the board files to them and removes the s3c24xx_reset_h
Heiko Stübner wrote:
>
> Hi Kgene,
>
> will you also do s3c24xx?
>
> I'm asking, as I'm currently also looking at this for the 24xx arches and
> would like to prevent double work on both our sides.
>
Sure, I'm sorting out all of Samsung stuff and it will be done tomorrow :)
Thanks.
Best regar
Hi Kgene,
will you also do s3c24xx?
I'm asking, as I'm currently also looking at this for the 24xx arches and
would like to prevent double work on both our sides.
Thanks
Heiko
Am Montag, 19. Dezember 2011, 12:58:20 schrieb Kukjin Kim:
> Hook these platforms restart code into the new restart ho
Hook these platforms restart code into the new restart hook rather
than using arch_reset().
Cc: Ben Dooks
Cc: Russell King
Signed-off-by: Kukjin Kim
---
arch/arm/mach-s3c64xx/common.c | 10 ++
arch/arm/mach-s3c64xx/common.h |2 ++
arch/arm/
This patch adds common.c and common.h which are used only
in the arch/arm/mach-s3c64xx directory. The common.c file
includes cpu.c, irq.c and irq-eint.c which are used commonly
on S3C64XX SoCs and the common.h file includes plat/s3c6400.h
and plat/s3c6410.h files.
Cc: Ben Dooks
Cc: Russell King
> -Original Message-
> From: Girish K S [mailto:girish.shivananja...@linaro.org]
> Sent: Monday, December 19, 2011 4:20 PM
> To: Subhash Jadavani
> Cc: linux-...@vger.kernel.org; patc...@linaro.org; linux-samsung-
> s...@vger.kernel.org; Chris Ball
> Subject: Re: [PATCH V6 1/2] mmc: core:
On 19 December 2011 15:40, Subhash Jadavani wrote:
> Hi Girish,
>
> Overall this patch looks good. I have only 2 minor comments inline below.
>
> Regards,
> Subhash
>
>
>> -Original Message-
>> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-
>> ow...@vger.kernel.org] On Behalf Of
Hi Girish,
Overall this patch looks good. I have only 2 minor comments inline below.
Regards,
Subhash
> -Original Message-
> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-
> ow...@vger.kernel.org] On Behalf Of Girish K S
> Sent: Monday, December 19, 2011 12:07 PM
> To: linux-.
40 matches
Mail list logo
