Re: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-01 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 4:01 PM, Kyungmin Park wrote: > Hi, > > Some comments. > 1. It's not same patch series. since it has additional feature, > exynos5 series support which don't covered at previous time. > 2. It assumes that name conversion is based on exynos5 as default. now > you use gsc at

Re: [PATCH v2 1/4] mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC

2012-03-01 Thread Jaehoon Chung
>> sc->clk_bus[ptr] = clk; >> @@ -613,7 +609,10 @@ static int __devinit sdhci_s3c_probe(struct >> platform_device *pdev) >> * save current clock index to know which clock bus >> * is used later in overriding functions. >

RE: [PATCH v2 1/4] mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC

2012-03-01 Thread Seungwon Jeon
Jaehoon Chung wrote: > On 03/02/2012 11:15 AM, Seungwon Jeon wrote: > > > Jaehoon Chung wrote: > >> On 02/29/2012 03:33 PM, Seungwon Jeon wrote: > >> > >>> Hi Jaehoon, > >>> > >>> Thank you for the patch. > >>> Could you check comments below? > >>> > >>> Jaehoon Chung wrote: > This patch i

Re: [PATCH v2 1/4] mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC

2012-03-01 Thread Jaehoon Chung
On 03/02/2012 11:15 AM, Seungwon Jeon wrote: > Jaehoon Chung wrote: >> On 02/29/2012 03:33 PM, Seungwon Jeon wrote: >> >>> Hi Jaehoon, >>> >>> Thank you for the patch. >>> Could you check comments below? >>> >>> Jaehoon Chung wrote: This patch is change to use the sdhci-pltfm.c Si

RE: [PATCH v2 1/4] mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC

2012-03-01 Thread Seungwon Jeon
Jaehoon Chung wrote: > On 02/29/2012 03:33 PM, Seungwon Jeon wrote: > > > Hi Jaehoon, > > > > Thank you for the patch. > > Could you check comments below? > > > > Jaehoon Chung wrote: > >> This patch is change to use the sdhci-pltfm.c > >> > >> Signed-off-by: Jaehoon Chung > >> Signed-off-by: K

Re: [PATCH v2 1/2] ARM: EXYNOS: Add USB HOST register definitions

2012-03-01 Thread Thomas Abraham
On 1 March 2012 21:40, Sangwook Lee wrote: [...] >  I found out some code related to this burst function. > >  the snip from ehci-s5pv210.c, 2.6.35 kernel > >     /* Mark hardware accessible again as we are out of D3 state by now > */ >     set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags); >

Re: [PATCH v2 1/4] mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC

2012-03-01 Thread Jaehoon Chung
On 02/29/2012 03:33 PM, Seungwon Jeon wrote: > Hi Jaehoon, > > Thank you for the patch. > Could you check comments below? > > Jaehoon Chung wrote: >> This patch is change to use the sdhci-pltfm.c >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Kyungmin Park >> --- >> drivers/mmc/host/Kc

Re: [PATCH v2 1/2] ARM: EXYNOS: Add USB HOST register definitions

2012-03-01 Thread Heiko Stübner
Am Donnerstag 01 März 2012, 17:10:52 schrieb Sangwook Lee: > On 1 March 2012 15:24, Heiko Stübner wrote: > > Am Donnerstag, 1. März 2012, 06:38:20 schrieb Jingoo Han: > > > This patch adds USB HOST register definitions. The definition for > > > EHCI INSNREG00 regiser and corresponding bit field de

Re: [PATCH 3/3] [media] s5p-tv: Add initial DT-support for TV mixer

2012-03-01 Thread Karol Lewandowski
On 01.03.2012 04:18, Thomas Abraham wrote: > On 29 February 2012 20:21, Karol Lewandowski wrote: >> --- >> drivers/media/video/s5p-tv/mixer_drv.c |9 + >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/video/s5p-tv/mixer_drv.c >> b/drivers/media/vi

Re: [PATCH v2 1/2] ARM: EXYNOS: Add USB HOST register definitions

2012-03-01 Thread Heiko Stübner
Am Donnerstag, 1. März 2012, 06:38:20 schrieb Jingoo Han: > This patch adds USB HOST register definitions. The definition for > EHCI INSNREG00 regiser and corresponding bit field definitions are > added. > > Signed-off-by: Sangwook Lee > Signed-off-by: Jingoo Han > --- > v2: change the definitio

Re: [PATCH 1/3] [media] s5p-tv: Add initial DT-support for sii9234

2012-03-01 Thread Karol Lewandowski
On 01.03.2012 04:09, Thomas Abraham wrote: > Hi Karol, Hi! > On 29 February 2012 20:21, Karol Lewandowski wrote: >> Make it possible to instantiate sii9234, HDMI's MHL, from regular >> device tree description. >> >> Signed-off-by: Karol Lewandowski >> Signed-off-by: Kyungmin Park >> --- >>

RE: [PATCH v9 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-01 Thread Marek Szyprowski
Hello, On Wednesday, February 29, 2012 1:26 AM KyongHo Cho wrote: > On Tue, Feb 28, 2012 at 4:20 PM, Kyungmin Park > wrote: > > Hi, > > > > On 2/28/12, KyongHo Cho wrote: > >> Handling System MMUs with an identifier is not flexible to manage > >> System MMU platform devices because of the fol

[PATCH v3] ARM: S3C24XX DMA resume regression fix

2012-03-01 Thread Gusakov Andrey
s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented. Signed-off-by: Gusakov Andrey Reviewed-by: Heiko Stuebner --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed

[PATCH RESEND] ARM: Exynos: use s5p-timer for UniversalC210 board

2012-03-01 Thread Marek Szyprowski
Commit 069d4e743 ("ARM: EXYNOS4: Remove clock event timers using ARM private timers") removed support for local timers and forced to use MCT as event source. However MCT is not operating properly on early revision (EVT0) of Exynos4 SoCs. All UniversalC210 boards are based on Exynos4 EVT0, so that c

RE: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-01 Thread Marek Szyprowski
Hi, On Tuesday, February 28, 2012 7:37 AM KyongHo Cho wrote: > Changes since v8: > - exynos_iommu_map/unmap() just works for the page sizes >that System MMU supports. (Joerg's comment) > - 1 platform device for 1 H/W though a multimedia accelerator >with several System MMUs attached. >

Re: [PATCH 2/4] ARM: EXYNOS: Add __init attribute to universal_camera_init()

2012-03-01 Thread Sylwester Nawrocki
On 03/01/2012 10:17 AM, Tushar Behera wrote: > s3c_set_platdata() is defined with __init attribute, hence all functions > referencing this function should also be defined with __init attribute. > > universal_camera_init() is referenced only in '__init > universal_machine_init()', > thus this chan

Re: [PATCH 1/4] ARM: EXYNOS: Add __init attribute to nuri_camera_init()

2012-03-01 Thread Sylwester Nawrocki
On 03/01/2012 10:17 AM, Tushar Behera wrote: > s3c_set_platdata() is defined with __init attribute, hence all functions > referencing this function should also be defined with __init attribute. > > nuri_camera_init() is referenced only in '__init nuri_machine_init()', thus > this change won't put

[PATCH 4/4] ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers

2012-03-01 Thread Tushar Behera
s3c_set_platdata() is defined with __init attribute, hence all functions referencing this function should also be defined with __init attribute. Signed-off-by: Tushar Behera --- arch/arm/plat-samsung/devs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat

[PATCH 3/4] ARM: SAMSUNG: Add __init attribute to samsung_bl_set()

2012-03-01 Thread Tushar Behera
s3c_set_platdata() is defined with __init attribute, hence all functions referencing this function should also be defined with __init attribute. samsung_bl_set() is referenced only in '__init xxx_machine_init()' functions, thus this change won't put any additional constraint on the usage of samsun

[PATCH 2/4] ARM: EXYNOS: Add __init attribute to universal_camera_init()

2012-03-01 Thread Tushar Behera
s3c_set_platdata() is defined with __init attribute, hence all functions referencing this function should also be defined with __init attribute. universal_camera_init() is referenced only in '__init universal_machine_init()', thus this change won't put any additional constraint on the usage of uni

[PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata

2012-03-01 Thread Tushar Behera
The function s3c_set_platdata is defined with __init attribute, hence the functions calling s3c_set_platdata should also be defined with __init attribute. Even though all the modified functions are called from xxx_machine_init() functions, it is still better to define each of them with __init attr

[PATCH 1/4] ARM: EXYNOS: Add __init attribute to nuri_camera_init()

2012-03-01 Thread Tushar Behera
s3c_set_platdata() is defined with __init attribute, hence all functions referencing this function should also be defined with __init attribute. nuri_camera_init() is referenced only in '__init nuri_machine_init()', thus this change won't put any additional constraint on the usage of nuri_camera_i

[PATCH 3/3] ARM: Exynos: fix touchscreen IRQ setup on Universal C210 board

2012-03-01 Thread Marek Szyprowski
From: Bartlomiej Zolnierkiewicz Fixes atmel_mxt_ts freeze on Universal C210. Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park Signed-off-by: Marek Szyprowski --- arch/arm/mach-exynos/mach-universal_c210.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 0/3] Universal C210 and NURI board fixes

2012-03-01 Thread Marek Szyprowski
Hi Kukjin, I've found a few problems with Universal C210 and NURI boards in the current linux-next kernel. The provided patches fix the issues with SDHCI controllers and mysterious touch screen freeze. Best regards, Marek Szyprowski Patch summary: Bartlomiej Zolnierkiewicz (1): ARM: Exynos:

[PATCH 2/3] ARM: Exynos: fix SDHCI device names in regulator definitions

2012-03-01 Thread Marek Szyprowski
Patch 189eb7407 "ARM: EXYNOS: use 'exynos4-sdhci' as device name for sdhci controllers" changed the names of the SDHCI devices, but the author forgot to update the definitions for the regulator subsystem. This patch fixes this issue. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park -

[PATCH 1/3] ARM: Exynos: fix SDHCI caps for UniversalC210 and NURI boards

2012-03-01 Thread Marek Szyprowski
Add a new quirk (introduced in 6e8201f57c935 "mmc: core: add the capability for broken voltage" to indicate that MMC core should ignore voltage change errors reported by the regulators core. This is required to get SDHCI working on these boards again after commit ceb6143b2df81c ("mmc: sdhci: fix vm