Re: [PATCH v2 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-05-18 Thread Russell King - ARM Linux
On Thu, May 17, 2012 at 08:40:08PM +0530, Thomas Abraham wrote: +err_clk: + if (!IS_ERR(host-ciu_clk)) + clk_disable_unprepare(host-ciu_clk); + if (!IS_ERR(host-biu_clk)) + clk_disable_unprepare(host-biu_clk); + clk_put(host-ciu_clk); +

Re: [PATCH 1/2] ARM: EXYYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx

2012-05-18 Thread Sylwester Nawrocki
On 05/18/2012 04:53 AM, Joonyoung Shim wrote: Add to cc Grant Likely and Linus Walleij On 05/18/2012 11:18 AM, Joonyoung Shim wrote: Also use EXYNOS4210_GPIO_Ex instead of EXYNOS4_GPIO_Ex. The GPEx gpios exist only on Exynos4210 and there are no on Exynos4x12. Redefine them to exact SoC

Re: [PATCH 2/2] gpio/exynos: Add support for Exynos4x12 SoC

2012-05-18 Thread Sylwester Nawrocki
On 05/18/2012 04:54 AM, Joonyoung Shim wrote: Add to cc Grant Likely and Linus Walleij On 05/18/2012 11:18 AM, Joonyoung Shim wrote: Exynos4x12 GPIO part1 and part2 layouts are different with that of Exynos4210. So, it needs to support gpios for Exynos4x12 SoC. This doesn't support GPVx

Re: [PATCH 1/2] ARM: EXYYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx

2012-05-18 Thread Sylwester Nawrocki
On 05/18/2012 04:53 AM, Joonyoung Shim wrote: Add to cc Grant Likely and Linus Walleij On 05/18/2012 11:18 AM, Joonyoung Shim wrote: Also use EXYNOS4210_GPIO_Ex instead of EXYNOS4_GPIO_Ex. The GPEx gpios exist only on Exynos4210 and there are no on Exynos4x12. Redefine them to exact SoC

[PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-18 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Jaswinder Singh jaswinder.si...@linaro.org --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git

[PATCH v2 2/6] spi: s3c64xx: move controller information into driver data

2012-05-18 Thread Thomas Abraham
Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data.

[PATCH v2 3/6] ARM: Samsung: Remove pdev pointer paremeter from spi gpio setup functions

2012-05-18 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Jaswinder Singh jaswinder.si...@linaro.org ---

[PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-18 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data

[PATCH v2 6/6] spi: s3c64xx: add device tree support

2012-05-18 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Jaswinder Singh jaswinder.si...@linaro.org --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 277

[PATCH 1/6] ARM: Exynos4: Fix the incorrect hierarchy of spi controller bus clock

2012-05-18 Thread Thomas Abraham
The sclk_spi clock is derived currently from the first level divider (MMCx_RATIO) which is incorrect. The output of the first level clock is divided by a second level divider (MMCx_PRE_RATIO), the output of which is used as the spi bus clock (sclk_spi). Fix the clock hierarchy issues for the

[PATCH 3/6] ARM: Exynos4: Enable platform support for SPI controllers

2012-05-18 Thread Thomas Abraham
Add the platform bits which are required to support SPI controllers. The OF based partition parsing is also enabled to allow usage of SPI nor flash on smdkv310 board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/mach-exynos/Kconfig |1 +

[PATCH 6/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos5 platforms

2012-05-18 Thread Thomas Abraham
Add device nodes for the three instances of spi controllers in Exynos5 platforms and enable instance spi 1 for smdk5250 board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 47 -

RE: [PATCH v2 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-05-18 Thread Seungwon Jeon
Hi Thomas Abraham, How about separating the variant for Samsung Exynos. Like dw_mmc-exynos.c Thanks, Seungwon Jeon. Thomas Abraham wrote: The instantiation of the Synopsis Designware controller on Exynos5250 include extension for SDR and DDR specific tx/rx phase shift timing and CIU internal