Re: [PATCH v3 0/2] regulator: Add initial suport for max77686

2012-05-22 Thread Kyungmin Park
Hi Mark, BTW, do you know that you're reviewing the same device driver patch from different person? One from Mr. Lee and another from Yadwinder. I wonder how to handle it finally. which one is choose? Thank you, Kyungmin Park On 5/22/12, yadi.bra...@gmail.com yadi.bra...@gmail.com wrote:

[PATCH 1/2] ARM: EXYNOS: Update HSOTG PHY clock setting for Exynos4x12

2012-05-22 Thread Sachin Kamat
Adds clock setting entries for Exynos4212 and Exynos4412 platforms. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on Kukjin Kim's v3.5-for-usb-2 branch. --- arch/arm/mach-exynos/include/mach/regs-usb-phy.h |5 ++ arch/arm/mach-exynos/setup-usb-phy.c | 47

[PATCH 2/2] ARM: EXYNOS: Add HSOTG support to SMDK4X12

2012-05-22 Thread Sachin Kamat
S3C-HSOTG support is added to SMDK4212 and SMDK4412 boards. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on Kukjin Kim's v3.5-for-usb-2 branch. --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/mach-smdk4x12.c |8 2 files changed, 10

Re: [PATCH v3 0/2] regulator: Add initial suport for max77686

2012-05-22 Thread Mark Brown
On Tue, May 22, 2012 at 03:53:11PM +0900, Kyungmin Park wrote: BTW, do you know that you're reviewing the same device driver patch from different person? One from Mr. Lee and another from Yadwinder. I wonder how to handle it finally. which one is choose? Yes, I realise there's two different

Re: [PATCH v3 1/2] mfd: Add support for MAX77686.

2012-05-22 Thread Yadwinder Singh Brar
CC' ing to maintainer. (I forget to add maintainer in cc, sorry for noise). On Tue, May 22, 2012 at 11:26 AM, yadi.bra...@gmail.com wrote: From: Yadwinder Singh Brar yadi.b...@samsung.com MAX77686 is a mulitifunction device with PMIC, RTC and Charger on chip. Th driver provides common

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread jonghwa3 . lee
Hi, Yadwinder, As you know, both of us, recently, had competition for one driver whether you intend or not. And now, i think it is time to stop this and to find appropriate goal. From now on, i won't update this driver no more. I recommend you to review my patch and apply feature that you can

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread jonghwa3 . lee
Hi, again. On 2012년 05월 22일 14:57, yadi.bra...@gmail.com wrote: +static __devinit int max77686_pmic_probe(struct platform_device *pdev) +{ + + for (i = 0; i pdata-num_regulators; i++) { + config.dev = max77686-dev; + config.init_data =

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread Yadwinder Singh Brar
(adding Kyungmin Park and Samuel Ortiz) Hi, Yes, It happened unintentionally. I didn't know about your patch before submitting the initial version of my patches. I agree with you, I will review your patches and will try to incorporate extra features from your patches. On Wed, May 23, 2012 at

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread Yadwinder Singh Brar
Hi, On Wed, May 23, 2012 at 7:20 AM, jonghwa3@samsung.com wrote: Hi, again. On 2012년 05월 22일 14:57, yadi.bra...@gmail.com wrote: +static __devinit int max77686_pmic_probe(struct platform_device *pdev) +{ + +     for (i = 0; i pdata-num_regulators; i++) { +             config.dev =

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread jonghwa3 . lee
On 2012년 05월 23일 13:16, Yadwinder Singh Brar wrote: + max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, + max77686-ramp_delay 6, RAMP_MASK); + max77686_update_reg(i2c, MAX77686_REG_BUCK3CTRL1, + max77686-ramp_delay 6, RAMP_MASK); +

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread Yadwinder Singh Brar
On Wed, May 23, 2012 at 10:10 AM, jonghwa3@samsung.com wrote: On 2012년 05월 23일 13:16, Yadwinder Singh Brar wrote: +     max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, +             max77686-ramp_delay 6, RAMP_MASK); +     max77686_update_reg(i2c, MAX77686_REG_BUCK3CTRL1, +          

Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

2012-05-22 Thread jonghwa3 . lee
On 2012년 05월 23일 14:23, Yadwinder Singh Brar wrote: On Wed, May 23, 2012 at 10:10 AM, jonghwa3@samsung.com wrote: On 2012년 05월 23일 13:16, Yadwinder Singh Brar wrote: + max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, + max77686-ramp_delay 6, RAMP_MASK); +