Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 18:13, Mark Brown wrote: > On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote: >> On 30 May 2012 17:34, Mark Brown wrote: > >> > Right, and there's no problem at all with using the name.  The thing is >> > that there's no need to set the name at runtime since the struct

[PATCH 2/2] ARM: S3C64XX: Add WM5102 EVM to Cragganmore modules

2012-05-30 Thread Mark Brown
No platform data yet as driver is not yet merged. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index 985e255..f

[PATCH 1/2] ARM: S3C64XX: Add module identification for Balblair Cragganmore module

2012-05-30 Thread Mark Brown
Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index dbd5771..985e255 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410-mo

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Mark Brown
On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote: > On 30 May 2012 17:34, Mark Brown wrote: > > Right, and there's no problem at all with using the name.  The thing is > > that there's no need to set the name at runtime since the struct device > > being configured is always going to

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 17:34, Mark Brown wrote: > On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote: >> On Sun, May 20, 2012 at 2:21 AM, Mark Brown > >> > This dev_name also isn't equivalent to dev_name() which makes matters >> > more confusing than they need to be. > >> Looks like they use t

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Mark Brown
On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote: > On Sun, May 20, 2012 at 2:21 AM, Mark Brown > > This dev_name also isn't equivalent to dev_name() which makes matters > > more confusing than they need to be. > Looks like they use the name as the magic string to pick initializatio

RE: [PATCH] serial: samsung: protect NULL dereference of clock name

2012-05-30 Thread Kyoungil Kim
Shubhrajyoti Datta wrote: > Hi Kim, > On Wed, May 30, 2012 at 1:59 PM, Kyoungil Kim wrote: > > From: KeyYoung Park > > > > When priting the serial clock source, if clock source name is null, > > kernel reference NULL point. > > > Could you help me understand why is that NULL ? Or the crash that y

Re: [PATCH] serial: samsung: protect NULL dereference of clock name

2012-05-30 Thread Shubhrajyoti Datta
Hi Kim, On Wed, May 30, 2012 at 1:59 PM, Kyoungil Kim wrote: > From: KeyYoung Park > > When priting the serial clock source, if clock source name is null, > kernel reference NULL point. > Could you help me understand why is that NULL ? Or the crash that you saw. -- To unsubscribe from this list:

[PATCH] serial: samsung: protect NULL dereference of clock name

2012-05-30 Thread Kyoungil Kim
From: KeyYoung Park When priting the serial clock source, if clock source name is null, kernel reference NULL point. Signed-off-by: KeyYoung Park Signed-off-by: Huisung Kang Signed-off-by: Kyoungil Kim --- drivers/tty/serial/samsung.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-30 Thread Thomas Abraham
Hi Olof, On 30 May 2012 15:23, Olof Johansson wrote: > Hi, > > Some comments below. > > On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham > wrote: >> Platform data is used to specify controller hardware specific information >> such as the tx/rx fifo level mask and bit offset of rx fifo level. Such

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 15:28, Olof Johansson wrote: > On Sun, May 20, 2012 at 2:21 AM, Mark Brown > wrote: >> On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote: >> >>> -     s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1); >>> +     s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Olof Johansson
On Sun, May 20, 2012 at 2:21 AM, Mark Brown wrote: > On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote: > >> -     s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1); >> +     s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1); > > ... > >> +     pd.src_clk_nr = src_clk_nr; >> +  

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-30 Thread Olof Johansson
Hi, Some comments below. On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Inst