Re: [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip

2012-08-08 Thread Thierry Reding
On Fri, Aug 03, 2012 at 03:45:56PM +0900, Jingoo Han wrote: > This patch adds missing device pointer to struct pwm_chip. If the > device pointer is NULL, pwmchip_add() will return error. > > Signed-off-by: Jingoo Han Thanks, applied to for-next and master. Thierry pgpFlbUlOx1J2.pgp Descriptio

[PATCH] ARM: Exynos: Enable DT support by default for Exynos5 SoC

2012-08-08 Thread Sachin Kamat
Since support for Exynos5 SoC based boards is going to be only device tree (DT) based, it makes no sense to provide DT as a user selectable feature in menuconfig (De-selecting it gives "no machine record defined" linker error). Hence enabling it along with ARCH_EXYNOS5 option. Signed-off-by: Sachi

RE: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Kukjin Kim
Kukjin Kim wrote: > > Sachin Kamat wrote: > > > > On 8 August 2012 17:08, Kukjin Kim wrote: > > > Sachin Kamat wrote: > > >> > > >> Hi Mark, > > >> > > >> On 8 August 2012 16:39, Mark Brown > > > > >> wrote: > > >> > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: > > >> >> Fixes t

RE: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Kukjin Kim
Sachin Kamat wrote: > > On 8 August 2012 17:08, Kukjin Kim wrote: > > Sachin Kamat wrote: > >> > >> Hi Mark, > >> > >> On 8 August 2012 16:39, Mark Brown > > >> wrote: > >> > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: > >> >> Fixes the following build error: > >> >> In file in

Re: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Sachin Kamat
On 8 August 2012 17:08, Kukjin Kim wrote: > Sachin Kamat wrote: >> >> Hi Mark, >> >> On 8 August 2012 16:39, Mark Brown >> wrote: >> > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: >> >> Fixes the following build error: >> >> In file included from arch/arm/mach-exynos/include/mach

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMSUNG > will be selected automatically. Of course, it can be de-selected in kernel > menuconfig. Note that, I think, using 'bool ' and 'depends on ' > is more clear t

RE: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Kukjin Kim
Sachin Kamat wrote: > > Hi Mark, > > On 8 August 2012 16:39, Mark Brown > wrote: > > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: > >> Fixes the following build error: > >> In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, > >> from arch/arm/plat-

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > > Thierry Reding wrote: > > > > > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: > > [...] > He (she?) sent two patches: > He :-) > https://lkml.org/lkml/2012/8/2/108 > https://lk

Re: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Sachin Kamat
Hi Mark, On 8 August 2012 16:39, Mark Brown wrote: > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: >> Fixes the following build error: >> In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, >> from arch/arm/plat-samsung/include/plat/dma-ops.h:17, >>

Re: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Mark Brown
On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: > Fixes the following build error: > In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, > from arch/arm/plat-samsung/include/plat/dma-ops.h:17, > from arch/arm/plat-samsung/include/plat/dma.h:

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > Thierry Reding wrote: > > > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: > > [...] > > > > Yeah, your pointing out is correct, but in this case, it should be > > 'bool' > > > not 'tristate' because the PWM driver cann

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] > > Yeah, your pointing out is correct, but in this case, it should be > 'bool' > > not 'tristate' because the PWM driver cannot support module now. > > Is there any reason why that is so? I mean, curre

[PATCH v3 5/5] ARM: Exynos4210: Enabling samsung-usbphy driver

2012-08-08 Thread Praveen Paneri
Adding usbphy node for Exynos4210 along with the platform data. Signed-off-by: Praveen Paneri --- arch/arm/boot/dts/exynos4210.dtsi |5 + arch/arm/mach-exynos/include/mach/map.h |1 + arch/arm/mach-exynos/mach-exynos4-dt.c |8 arch/arm/mach-exynos/setup-usb-phy.c

[PATCH v3 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver

2012-08-08 Thread Praveen Paneri
Adding platform device for samsung-usbphy driver. Enabling it for s3c64xx based machines using s3c-hsotg. Signed-off-by: Praveen Paneri --- arch/arm/mach-s3c64xx/include/mach/map.h |2 + arch/arm/mach-s3c64xx/mach-crag6410.c|4 +++ arch/arm/mach-s3c64xx/mach-smartq.c

[PATCH v3 3/5] ARM: S3C64XX: Removing old phy setup code

2012-08-08 Thread Praveen Paneri
This patch removes old phy code from platform side. 'setup-usb-phy.c' will be used for providing transceiver platform data in next patch. Not all of the platform data code is removed as there are others making use of platform_data defined for hsotg. That can be removed once all the SoCs start using

[PATCH v3 2/5] usb: s3c-hsotg: Adding phy driver support

2012-08-08 Thread Praveen Paneri
Adding the transceiver to hsotg driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Praveen Paneri --- drivers/usb/gadget/s3c-hsotg.c | 40 ++-- 1 files changed, 30 insertions(+), 10 deletions(-

[PATCH v3 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-08-08 Thread Praveen Paneri
This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable phy. Tested with smdk6410 and smdkv310. More SoCs can be brought under later. Signed-off-by: Praveen Paneri Acked-by: Heiko Stuebner --- .../devicetree/bindings/usb/sams

[PATCH v3 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-08-08 Thread Praveen Paneri
Changes from v2: Changed the driver filenames to samsung-usbphy Changed 's3c' to 'samsung' for platform device as well as platform data Moved platform data structure to a separate file Rectified coding style related errors Changes from v1: Rebased patches to latest usb-next branch Changed the name