Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-17 Thread Thomas Abraham
On 11 September 2012 00:51, Stephen Warren wrote: > On 09/06/2012 05:06 AM, Thomas Abraham wrote: >> On 6 September 2012 15:04, Tomasz Figa wrote: >>> Hi, >>> >>> This patch shows the problem of the need to explicitly migrate all drivers >>> to pinctrl. >>> >>> Maybe we should consider extending

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-17 Thread Thomas Abraham
On 11 September 2012 01:32, Linus Walleij wrote: > On Thu, Sep 6, 2012 at 11:23 AM, Thomas Abraham > wrote: > >> Add optional support for i2c bus pin configuration using pinctrl interface >> >> Cc: Ben Dooks >> Signed-off-by: Thomas Abraham > (...) >> diff --git a/drivers/i2c/busses/i2c-s3c2410

[PATCH V4] ARM: EXYNOS5: Add bus clock and set parent clock for FIMD

2012-09-17 Thread Leela Krishna Amudala
This patch adds the bus clock for FIMD and changes the device name for lcd clock also sets mout_mpll_user as parent clock to fimd Signed-off-by: Leela Krishna Amudala --- arch/arm/mach-exynos/clock-exynos5.c | 35 - arch/arm/mach-exynos/clock-exynos5.h | 17 ++

Re: [PATCH V4] ARM: EXYNOS5: Add bus clock and set parent clock for FIMD

2012-09-17 Thread Jingoo Han
On Monday, September 17, 2012 11:43 PM Leela Krishna Amudala wrote > > This patch adds the bus clock for FIMD and changes the device name for lcd > clock > also sets mout_mpll_user as parent clock to fimd > > Signed-off-by: Leela Krishna Amudala Acked-by: Jingoo Han It looks good. > --- >

RE: [PATCH V4] ARM: EXYNOS5: Add bus clock and set parent clock for FIMD

2012-09-17 Thread Kukjin Kim
Jingoo Han wrote: > > On Monday, September 17, 2012 11:43 PM Leela Krishna Amudala wrote > > > > This patch adds the bus clock for FIMD and changes the device name for > lcd clock > > also sets mout_mpll_user as parent clock to fimd > > > > Signed-off-by: Leela Krishna Amudala > > Acked-by: Jing

RE: [PATCH 0/3] ARM: dts: Exynos4 dts reorganization

2012-09-17 Thread Kukjin Kim
Kukjin Kim wrote: > > Thomas Abraham wrote: > > > > On 3 September 2012 18:04, Tomasz Figa wrote: > > > This patch series prepares existing Exynos4210 DT infrastructure to be > > > further extended for new SoCs from Exynos4 line and new boards. > > > > > > Tomasz Figa (3): > > > ARM: dts: Move

RE: [PATCH] ARM: EXYNOS: Add dp clock support for EXYNOS5

2012-09-17 Thread Kukjin Kim
Jingoo Han wrote: > > Add dp clock instance for EXYNOS5 dp controller. > > Signed-off-by: Jingoo Han > --- > arch/arm/mach-exynos/clock-exynos5.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach- > exynos/clo

[PATCH 0/7] s5p-fimc/mipi-csis drivers cleanup

2012-09-17 Thread Sylwester Nawrocki
This series is a cleanup of s5p-fimc/mipi-csis drivers and changes required for adding device tree support. It depends on Arnd's platform data headers cleanup patch: "ARM: samsung: move platform_data definitions" git.kernel.org/?p=linux/kernel/git/arm/arm-soc.git;a=commit;h=d7243bd51b783ffd2 Sylwe

RE: [PATCH] ARM: EXYNOS: Use non-secure MDMA1

2012-09-17 Thread Kukjin Kim
Kukjin Kim wrote: > > On 08/28/12 04:08, Tomasz Figa wrote: > > Using secure MDMA1 on TrustZone-enabled boards causes early boot crash, > > so use non-secure instead. > > > > Signed-off-by: Tomasz Figa > > Signed-off-by: Kyungmin Park > > --- > > arch/arm/mach-exynos/dma.c | 2 +- >

[PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Sylwester Nawrocki
The MIPI-CSI2 bus data alignment is now being derived from the media bus pixel code, the drivers don't use the corresponding structure fields, so remove them. Also remove the s5p_csis_phy_enable callback which is now used directly by s5p-csis driver. Signed-off-by: Sylwester Nawrocki Signed-off-b

[PATCH 2/7] ARM: samsung: Change __s5p_mipi_phy_control() function signature

2012-09-17 Thread Sylwester Nawrocki
Replace pdev argument __s5p_mipi_phy_control() helper with plain int so MIPI-CSIS hardware instance index can be passed directly making the function usable on platforms instantiated from device tree. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/plat-samsung/setup-

[PATCH 3/7] ARM: EXYNOS: Change MIPI-CSIS device regulator supply names

2012-09-17 Thread Sylwester Nawrocki
Rename MIPI-CSIS regulator supply names to match definitions in the driver after commit "s5p-csis: Change regulator supply names". Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/mach-nuri.c | 4 ++-- arch/arm/mach-exynos/mach-origen.c |

[PATCH 4/7] s5p-csis: Replace phy_enable platform data callback with direct call

2012-09-17 Thread Sylwester Nawrocki
The phy_enable callback is common for all Samsung SoC platforms, replace it with direct function call so the MIPI-CSI2 DPHY control is also possible on device tree instantiated platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/mipi-csis.c

[PATCH 5/7] s5p-fimc: Remove unused platform data structure fields

2012-09-17 Thread Sylwester Nawrocki
alignment, fixed_phy_vdd and phy_enable fields are now unused so removed them. The data alignment is now derived directly from media bus pixel code, phy_enable callback has been replaced with direct function call and fixed_phy_vdd was dropped in commit 438df3ebe5f0ce408490a777a758d5905f0dd58f "[med

[PATCH 6/7] s5p-csis: Allow to specify pixel clock's source through platform data

2012-09-17 Thread Sylwester Nawrocki
Depending on the sensor configuration it might be required to adjust the CSIS's output pixel clock so it is greater than its input pixel clock, in order to avoid the input data FIFO overflow. Use platform data to select SCLK_CSIS clock from CMU as a source, rather than CSI APB clock. Signed-off-b

[PATCH 7/7] s5p-csis: Change regulator supply names

2012-09-17 Thread Sylwester Nawrocki
Rename the regulator supply names to more meaningful ones. It's a prerequisite for adding device tree support. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/mipi-csis.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

RE: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-17 Thread Kukjin Kim
Inderpal Singh wrote: > > Since 0 is not considered as error at dmaengine level, return ENOMEM > from pl330_alloc_chan_resources in case of failure. > > Signed-off-by: Inderpal Singh Acked-by: Kukjin Kim Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Te

RE: [PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > The MIPI-CSI2 bus data alignment is now being derived from the media > bus pixel code, the drivers don't use the corresponding structure > fields, so remove them. Also remove the s5p_csis_phy_enable callback > which is now used directly by s5p-csis driver. > > Signed

RE: [PATCH 2/7] ARM: samsung: Change __s5p_mipi_phy_control() function signature

2012-09-17 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > Replace pdev argument __s5p_mipi_phy_control() helper with plain int > so MIPI-CSIS hardware instance index can be passed directly making > the function usable on platforms instantiated from device tree. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmi

RE: [PATCH 3/7] ARM: EXYNOS: Change MIPI-CSIS device regulator supply names

2012-09-17 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > Rename MIPI-CSIS regulator supply names to match definitions in > the driver after commit "s5p-csis: Change regulator supply names". > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Kukjin Kim Thanks. Best regards, Kgene. -- Kukjin

Re: [PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Sylwester Nawrocki
On 09/17/2012 01:02 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> The MIPI-CSI2 bus data alignment is now being derived from the media >> bus pixel code, the drivers don't use the corresponding structure >> fields, so remove them. Also remove the s5p_csis_phy_enable callback >> which is n

RE: [PATCH] ARM: SAMSUNG: Use spin_lock_{irqsave,irqrestore} in clk_set_rate

2012-09-17 Thread Kukjin Kim
Tushar Behera wrote: > > The spinlock clocks_lock can be held during ISR, hence it is not safe to > hold that lock with disabling interrupts. > > It fixes following potential deadlock. > > = > [ INFO: possible irq lock inversion dependency

[PATCH] ARM: dts: use uart2 for console on smdkv310 and smdk5250

2012-09-17 Thread Kukjin Kim
Cc: Thomas Abraham Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +- arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smd

[PATCH v6 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-09-17 Thread Praveen Paneri
Changes from v5: Moved clk_get() to driver's probe function. Now reference clock frequency selection value is stored in samsung_usbphy structure for later use. Used IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). Changes from v4: Moved header file contents to driver's source fi

[PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-17 Thread Praveen Paneri
This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable phy. Tested with smdk6410 and smdkv310. More SoCs can be brought under later. Signed-off-by: Praveen Paneri Acked-by: Heiko Stuebner --- .../devicetree/bindings/usb/sams

[PATCH v6 2/5] usb: s3c-hsotg: Adding phy driver support

2012-09-17 Thread Praveen Paneri
Adding the transceiver to hsotg driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Praveen Paneri --- drivers/usb/gadget/s3c-hsotg.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deletions(-)

[PATCH v6 3/5] ARM: S3C64XX: Removing old phy setup code

2012-09-17 Thread Praveen Paneri
This patch removes old phy code from platform side. 'setup-usb-phy.c' will be used for providing transceiver platform data in next patch. Not all of the platform data code is removed as there are others making use of platform_data defined for hsotg. That can be removed once all the SoCs start using

[PATCH v6 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver

2012-09-17 Thread Praveen Paneri
Adding platform device for samsung-usbphy driver. Enabling it for s3c64xx based machines using s3c-hsotg. Signed-off-by: Praveen Paneri --- arch/arm/mach-s3c64xx/include/mach/map.h |2 + arch/arm/mach-s3c64xx/mach-crag6410.c|7 ++ arch/arm/mach-s3c64xx/mach-smartq.c

[PATCH v6 5/5] ARM: Exynos4210: Enabling samsung-usbphy driver

2012-09-17 Thread Praveen Paneri
Adding usbphy node for Exynos4210 along with the platform data. Signed-off-by: Praveen Paneri --- arch/arm/boot/dts/exynos4210.dtsi |5 + arch/arm/mach-exynos/include/mach/map.h |1 + arch/arm/mach-exynos/mach-exynos4-dt.c |8 arch/arm/mach-exynos/setup-usb-phy.c

[PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-17 Thread Thomas Abraham
This series add device tree support for Synopsis Designware IP - Mobile Storage Host Controller (MSHC). I had addressed all comments for the v5 version of this patch series and had reposted only those patches that were modified. The version number of those reposted patches was maintained as v5 as t

[PATCH v6 1/9] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference

2012-09-17 Thread Thomas Abraham
The 'struct dw_mci' maintains a copy of the pdev->dev instance instead of maintaining a reference to that 'struct device' instance. Any resource allocated using the device resource management kernel API with the instance of 'struct device' in 'struct dw_mci' is then incorrect. Fix this by convertin

[PATCH v6 2/9] mmc: dw_mmc: Use devm_* functions in dw_mmc platform driver

2012-09-17 Thread Thomas Abraham
Use devm_* managed functions for simpler error handling. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- drivers/mmc/host/dw_mmc-pltfm.c | 29 - 1 files changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/ho

[PATCH v6 3/9] mmc: dw_mmc: allow probe to succeed even if one slot is initialized

2012-09-17 Thread Thomas Abraham
Instead of aborting the probe in case a slot initialization fails, allow initialization of as many slots as possible. If there are atleast one instance of slot that is successfully initialized, allow the driver probe to succeed. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- drivers/mm

[PATCH v6 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-09-17 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham Acked-by: Will Ne

[PATCH v6 5/9] mmc: dw_mmc: add quirk to indicate missing write protect line

2012-09-17 Thread Thomas Abraham
If the write protect pad of the controller is not connected to the write protect pin of the slot, the driver should be notified of this condition so that incorrect check for write protection by reading the WRTORT register can avoided. The get_ro platform callback can be used for in such cases, but

[PATCH v6 6/9] mmc: dw_mmc: add device tree support

2012-09-17 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 79 drivers/mmc/host/dw_mmc-pltfm.c|9 ++ drivers/mmc/host/dw_mmc.c | 130 ++

[PATCH v6 7/9] mmc: dw_mmc: prepare functions in dw_mmc-pltfm for reuse

2012-09-17 Thread Thomas Abraham
Platform implementations of dw-mshc controller may choose to exterd the features of the standard dw-mshc controller such as adding additional clocking options or modifying the bus interface. Support for such implementation specific extensions can be incorporated into dw_mmc-pltfm, but including mul

[PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks

2012-09-17 Thread Thomas Abraham
The core dw-mshc controller driver can let platform specific implementations of the dw-mshc controller to control the hardware as required by such implementations. This is acheived by invoking implementation specific (optional) callbacks. Define the list of callbacks supported the add invocation po

[PATCH v6 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-17 Thread Thomas Abraham
From: Thomas Abraham Samsung Exynos SoC's extend the dw-mshc controller for additional clock and bus control. Add support for these extensions and include provide device tree based discovery suppory as well. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- .../devicetree/bindings/mmc/e

[GIT PULL] Samsung fixes-3 for v3.6

2012-09-17 Thread Kukjin Kim
Hi Arnd and Olof, Here is second Samsung fixes for v3.6. This includes using spin_lock_irqsave in clk_set_parent() to avoid spinlock recursion and fixing wrong definitions. If any problems, please kindly let me know. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Dev

Re: [GIT PULL] Samsung fixes-3 for v3.6

2012-09-17 Thread Olof Johansson
Hi, On Mon, Sep 17, 2012 at 3:56 PM, Kukjin Kim wrote: > Hi Arnd and Olof, > > Here is second Samsung fixes for v3.6. > > This includes using spin_lock_irqsave in clk_set_parent() to avoid spinlock > recursion and fixing wrong definitions. > > If any problems, please kindly let me know. > > Than

RE: [GIT PULL] Samsung fixes-3 for v3.6

2012-09-17 Thread Kukjin Kim
Olof Johansson wrote: > > Hi, > > > On Mon, Sep 17, 2012 at 3:56 PM, Kukjin Kim wrote: > > Hi Arnd and Olof, > > > > Here is second Samsung fixes for v3.6. > > > > This includes using spin_lock_irqsave in clk_set_parent() to avoid > spinlock > > recursion and fixing wrong definitions. > > > > I

Re: [GIT PULL] Samsung fixes-3 for v3.6

2012-09-17 Thread Olof Johansson
Hi, On Mon, Sep 17, 2012 at 4:05 PM, Kukjin Kim wrote: > Well...I don't think so, others also should be fixed before v3.6 because as > you can see, it can occur unexpected behavior and must be wrong. But last > one is small thing... "ARM: EXYNOS: fixed SYSMMU setup definition to mate parameter

RE: [GIT PULL] Samsung fixes-3 for v3.6

2012-09-17 Thread Kukjin Kim
Olof Johansson wrote: > > Hi, > > On Mon, Sep 17, 2012 at 4:05 PM, Kukjin Kim wrote: > > > Well...I don't think so, others also should be fixed before v3.6 because > as > > you can see, it can occur unexpected behavior and must be wrong. But > last > > one is small thing... > > "ARM: EXYNOS: f

Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support

2012-09-17 Thread Thomas Abraham
On 23 August 2012 22:40, Thomas Abraham wrote: > Add device tree based discovery support for Samsung's sdhci controller > > Cc: Ben Dooks > Cc: Kukjin Kim > Cc: Chris Ball > Signed-off-by: Thomas Abraham > --- > Changes since v4: > Adapted to new mmc core card detection bindings as specfied in

Re: [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-17 Thread Thomas Abraham
On 17 September 2012 23:46, Thomas Abraham wrote: > This series add device tree support for Synopsis Designware IP - Mobile > Storage > Host Controller (MSHC). I had addressed all comments for the v5 version of > this > patch series and had reposted only those patches that were modified. The >

Re: [PATCH 0/2] DMA: PL330: Clock and runtime cleanup

2012-09-17 Thread Vinod Koul
On Fri, 2012-09-07 at 12:14 +0530, Inderpal Singh wrote: > The controller clock is being managed at AMBA bus level probe/remove and > pm_runtime/suspend functions. The existing driver does the clock > enable/disable > again in the same code paths, which unneccessarily increments the usage count >

Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support

2012-09-17 Thread Chris Ball
Hi, On Mon, Sep 17 2012, Thomas Abraham wrote: > On 23 August 2012 22:40, Thomas Abraham wrote: >> Add device tree based discovery support for Samsung's sdhci controller >> >> Cc: Ben Dooks >> Cc: Kukjin Kim >> Cc: Chris Ball >> Signed-off-by: Thomas Abraham >> --- >> Changes since v4: >> Ada

Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support

2012-09-17 Thread Thomas Abraham
On 18 September 2012 09:20, Chris Ball wrote: > Hi, > > On Mon, Sep 17 2012, Thomas Abraham wrote: >> On 23 August 2012 22:40, Thomas Abraham wrote: >>> Add device tree based discovery support for Samsung's sdhci controller >>> >>> Cc: Ben Dooks >>> Cc: Kukjin Kim >>> Cc: Chris Ball >>> Signed

Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support

2012-09-17 Thread Jaehoon Chung
On 09/18/2012 12:50 PM, Chris Ball wrote: > Hi, > > On Mon, Sep 17 2012, Thomas Abraham wrote: >> On 23 August 2012 22:40, Thomas Abraham wrote: >>> Add device tree based discovery support for Samsung's sdhci controller >>> >>> Cc: Ben Dooks >>> Cc: Kukjin Kim >>> Cc: Chris Ball >>> Signed-off

Re: [PATCH 1/2] ARM: Exynos4: Put PCM, Slimbus, Spdif clocks to off state

2012-09-17 Thread Thomas Abraham
On 6 September 2012 19:46, Chander Kashyap wrote: > The clocks for PCM, Slimbus, Spdif added to off list in order > to turn them off at boot time. > > Signed-off-by: Chander Kashyap > --- > arch/arm/mach-exynos/clock-exynos4.c | 19 +++ > 1 file changed, 19 insertions(+) > > di

Re: [PATCH 2/2] ARM: SAMSUNG: Add check for NULL in clock interface

2012-09-17 Thread Thomas Abraham
On 6 September 2012 19:55, Chander Kashyap wrote: > The clock instance parameter in Samsung clock interface is not being checked > for NULL pointers. Add checks for NULL pointers. > > Signed-off-by: Chander Kashyap > --- > arch/arm/plat-samsung/clock.c |8 > 1 file changed, 4 insert

Re: [PATCH] ARM: dts: use uart2 for console on smdkv310 and smdk5250

2012-09-17 Thread Thomas Abraham
On 17 September 2012 17:16, Kukjin Kim wrote: > > Cc: Thomas Abraham > Signed-off-by: Kukjin Kim > --- > arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/