Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Inderpal Singh
On 25 September 2012 18:47, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function.

Re: [PATCH v4] ARM: EXYNOS: Add MFC device tree support

2012-09-26 Thread Tomasz Figa
Hi Arun, A little nitpick inline. On Saturday 22 of September 2012 23:37:17 Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen Krishna Chatradhi

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-26 Thread Praveen Paneri
Hi, On Tue, Sep 25, 2012 at 6:47 PM, ABRAHAM, KISHON VIJAY kis...@ti.com wrote: Hi, On Tue, Sep 25, 2012 at 5:48 PM, Rob Herring robherri...@gmail.com wrote: On 09/25/2012 06:23 AM, Praveen Paneri wrote: Hi Rob, On Mon, Sep 24, 2012 at 6:34 PM, Rob Herring robherri...@gmail.com wrote: On

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-26 Thread Praveen Paneri
On Tue, Sep 25, 2012 at 4:59 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 09/24/2012 11:38 AM, Praveen Paneri wrote: Hi Kishon, Felipe, Any further comments on these patches? Can they be merged now? One nitpick inline. Marc Thanks, Praveen On Mon, Sep 17, 2012 at 6:24 PM,

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: How about conditionally DMA_TERMINATE_ALL and free resources like below ? @@ -3017,9 +3017,11 @@ static int __devexit pl330_remove(struct amba_device *adev) /* Remove the channel */

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Inderpal Singh
On 26 September 2012 15:02, Jassi Brar jassisinghb...@gmail.com wrote: On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: How about conditionally DMA_TERMINATE_ALL and free resources like below ? @@ -3017,9 +3017,11 @@ static int __devexit pl330_remove(struct

RE: [PATCH v4] ARM: EXYNOS: Add MFC device tree support

2012-09-26 Thread Arun Kumar K
Hi Kukjin, As suggested by you, the function exynos_fdt_find_mfc_mem() can be moved to plat-samsung. I feel plat-samsung/s5p-dev-mfc.c would be a good place. Hope it is ok? Also I will wrap it with #ifdef CONFIG_OF for non-dt mode. I will post the updated patch with the suggested changes.

Re: [PATCH v4] ARM: EXYNOS: Add MFC device tree support

2012-09-26 Thread Arun Kumar K
Hi Tomasz, Maybe the base address and size could be merged into one property with two values, as it is done with the reg property? What do you think? + codec@1100 { + samsung,mfc-r = 0x4300; + samsung,mfc-r-size = 8388608; + samsung,mfc-l =

RE: [GIT PULL 4/4] Samsung DT for v3.7

2012-09-26 Thread Kukjin Kim
Kukjin Kim wrote: On 09/21/12 15:26, Kukjin Kim wrote: Hi Arnd, Olof This is for updating Samsung DT for v3.7. But now this makes many conflicts with pinctrl dt because of moving file so I'm sorting them out to avoid useless conflicts. I'll re-send this soon again. This is jut

[PATCH 1/2] ARM: SAMSUNG: Insert bitmap_gpio_int member in samsung_gpio_chip

2012-09-26 Thread Eunki Kim
When a device uses GPIO interrupt, its driver assumes that GPIO should be INPUT mode. However, GPIO of SAMSUNG SoC is sepated to INPUT mode and INTERRUPT mode. They are set by 0x0 and 0xF in GPIO control register. If the register is set to INPUT mode, the interrupt never occur. Therefore, it's

[PATCH 2/2] gpio: samsung: Fix input mode setting function for GPIO int

2012-09-26 Thread Eunki Kim
This patch makes GPIO pin to INTERRUPT mode or INPUT mode according to bitmap_gpio_int. When the related bit of bitmap_gpio_int is set, it makes GPIO pin to INTERRUPT mode instrad of INPUT mode in the samsung_gpiolib_4bit_input function. Signed-off-by: Eunki Kim eunki_...@samsung.com Cc: Kukjin

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Inderpal Singh
On 26 September 2012 22:19, Jassi Brar jassisinghb...@gmail.com wrote: On Wed, Sep 26, 2012 at 4:25 PM, Inderpal Singh inderpal.si...@linaro.org wrote: On 26 September 2012 15:02, Jassi Brar jassisinghb...@gmail.com wrote: On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh

Re: [PATCH 1/2] ARM: SAMSUNG: Insert bitmap_gpio_int member in samsung_gpio_chip

2012-09-26 Thread Joonyoung Shim
On 09/27/2012 12:55 PM, Eunki Kim wrote: When a device uses GPIO interrupt, its driver assumes that GPIO should be INPUT mode. However, GPIO of SAMSUNG SoC is sepated to INPUT mode and INTERRUPT mode. They are set by 0x0 and 0xF in GPIO control register. If the register is set to INPUT mode, the

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Inderpal Singh
On 27 September 2012 10:35, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Sep 27, 2012 at 9:43 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Don't you think free_chan_resource should be done __only if__ alloc_chan_resource was successful ? No, I don't think so. Thanks. Thanks

RE: [PATCH 1/2] ARM: SAMSUNG: Insert bitmap_gpio_int member in samsung_gpio_chip

2012-09-26 Thread Eunki Kim
-Original Message- From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] Sent: Thursday, September 27, 2012 1:50 PM To: Eunki Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; grant.lik...@secretlab.ca; linus.wall...@linaro.org; kgene@samsung.com