Re: [PATCH 2/2] ARM: S3C64XX: Statically define parent clock of the "camera" clock

2012-11-08 Thread Andrey Gusakov
Hi. I think .reg_src can be removed? This clock have only one source. On Thu, Nov 8, 2012 at 2:00 AM, Sylwester Nawrocki wrote: > The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null > clock source mux control register as it can have only one parent > clock. In such cases there i

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread Amit Kachhap
On 9 November 2012 09:21, Zhang Rui wrote: > On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: >> On 8 November 2012 11:31, Zhang Rui wrote: >> > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: >> >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL >> >>

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-11-08 Thread Jassi Brar
On 30 October 2012 14:51, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday 29 October 2012 22:45:48 Jassi Brar wrote: >> On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > * Add device tree (DT) property ("pl330,dma-memcpy") for DMA_MEMCPY >> > capability and inste

RE: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread R, Durgadoss
Hi Amit/Rui, > -Original Message- > From: Zhang, Rui > Sent: Friday, November 09, 2012 9:21 AM > To: Amit Kachhap > Cc: linux...@lists.linux-foundation.org; linux-samsung- > s...@vger.kernel.org; linux-ker...@vger.kernel.org; R, Durgadoss; > l...@kernel.org; linux-a...@vger.kernel.org; jon

RE: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread R, Durgadoss
Hi Rui/Amit, Sorry for the late response.. > -Original Message- > From: Amit Kachhap [mailto:amit.kach...@linaro.org] > Sent: Thursday, November 08, 2012 11:56 AM > To: Zhang, Rui > Cc: linux...@lists.linux-foundation.org; linux-samsung- > s...@vger.kernel.org; linux-ker...@vger.kernel.or

[PATCH 4/4] thermal: exynos: Use the new thermal trend type for quick cooling action.

2012-11-08 Thread Amit Daniel Kachhap
This patch uses the quick thermal cooling trend type macros. This is needed as exynos5 and other thermal sensors now supports only interrupt method for thresold temperature check. Signed-off-by: Amit Daniel Kachhap Signed-off-by: Amit Daniel Kachhap --- drivers/thermal/exynos_thermal.c |6 +

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread Zhang Rui
On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: > On 8 November 2012 11:31, Zhang Rui wrote: > > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: > >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL > >> and THERMAL_TREND_DROP_FULL. This thermal trend c

Re: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12

2012-11-08 Thread Linus Walleij
On Wed, Nov 7, 2012 at 5:41 AM, Kukjin Kim wrote: > A commit 1b6056d6 ("pinctrl: samsung: Include bank-specific eint offset in > bank struct") which is in your pinctrl tree (samsung branch) changed > macro(EXYNOS_PIN_BANK_EINTG) to add offset. Eventually, this series(due to > 3rd patch, pinctrl:

[PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ - if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin -

[PATCH] ARM: dma: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ - if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin -

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-08 Thread Andrey Gusakov
Hi. On Thu, Nov 8, 2012 at 1:57 AM, Sylwester Nawrocki wrote: > On 11/06/2012 10:34 PM, Andrey Gusakov wrote: >> >> Hi. >> >>> Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? >> >> Work! >> I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h >> It use significantly

Re: [PATCH v4 1/5] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-11-08 Thread Felipe Balbi
On Tue, Nov 06, 2012 at 08:24:55PM +0530, Vivek Gautam wrote: > Updating the names of usb-phy types to more generic names: > USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update its > dependencies. > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam Kukjin, I need your ack on

[PATCH v2] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-08 Thread Tomasz Figa
This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Confirmed with schematics of and tested on Origen board. Signed-off-by: Tomasz Figa --- arch/arm/mach-exynos/mach-origen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-exynos/m

Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC

2012-11-08 Thread Bartlomiej Zolnierkiewicz
On Thursday 08 November 2012 05:49:47 Kukjin Kim wrote: > Bartlomiej Zolnierkiewicz wrote: > > > > > Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address > > > can fix the problem you commented on EXYNOS4210 Rev0 without others?... > > > > The problem is affecting only EXYNOS4210

[PATCH 1/1] ARM: S3C24XX: Fix potential NULL pointer dereference error

2012-11-08 Thread Sachin Kamat
chan->end is tested for being NULL. However in the event that it is NULL, the subsequent assignment statement would lead to NULL pointer dereference. Thus dereferencing it only when it is not NULL. Signed-off-by: Sachin Kamat --- Based on Kukjin Kim's for-next branch. Compile tested. --- arch/ar

[PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-08 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 14 +++ arch/arm/boot/dts/exynos5250.dtsi |6 + arch/arm/

[PATCH v2] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller

2012-11-08 Thread Vivek Gautam
Changes from v1: - Changed the device node name from 'dwc3' to 'usb@1200'. - Added the documentation for device tree bindings for dwc3 controller. Based on changes for USB 2.0: 'https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/022046.html' Tested with required driver DT p

[PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver

2012-11-08 Thread Vivek Gautam
Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 15 +++ arch/arm/boot/dts/exynos5250.dtsi |6 ++ arch/arm/mach-exynos/

[PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-08 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 25 arch/arm/boot/dts/exynos5250-smdk5250.dts |4 ++

Re: [PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver

2012-11-08 Thread Vivek Gautam
Hi all, On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote: > Adding OHCI device tree node for Exynos5250 along with > the device base address. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-usb.txt | 15 +++ > arch/arm/

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-08 Thread Vivek Gautam
Hi all, On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-usb.txt | 25 > +++