RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Hi Doug, On Thursday, November 29, 2012, Doug Anderson wrote: > Seungwon, > > Thanks for the review. See below for comments. If you'd like me to > respin then please let me know. Otherwise I look forward to your ack. > > On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > > Yes. pin of w

[PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-28 Thread Naveen Krishna Chatradhi
From: Simon Glass The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus. We use it to arbitrate an i2c port between the AP and the EC. Signed-off-by: Simon Glass Cc: Grant Grundler Signed-off-by: Naveen Krishna Chatradhi --

[PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use

2012-11-28 Thread Naveen Krishna Chatradhi
From: Simon Glass There is a rather odd feature of the exynos i2c controller that if it is left enabled, it can lock itself up with the clk line held low. This makes the bus unusable. Unfortunately, the s3c24xx_i2c_set_master() function does not notice this, and reports a timeout. From then on t

[PATCH 0/2] i2c-s3c2410: Implementation bus arbitration support

2012-11-28 Thread Naveen Krishna Chatradhi
This patchset adds support for i2c bus arbitration between AP(exynos), device(EC) in i2c-s3c2410 driver. Simon Glass (2): i2c-s3c2410: Leave the bus disabled unless it is in use i2c-s3c2410: Add bus arbitration implementation .../devicetree/bindings/i2c/samsung-i2c.txt| 46 + d

Re: [PATCH V4 1/2] ASoC: Samsung: Get I2S src_clk from clock alias id.

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 04:17:48PM +0530, Padmavathi Venna wrote: > As the I2S src clks are registered with clkdev using generic > connection id, driver can get the clk name using generic id. > So the variable representing the array of rclk src clks is > deleted. Applied, thanks. signature.asc D

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Doug Anderson
Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to your ack. On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > Yes. pin of write protection is common property. > This change is good. I have some sugges

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-28 Thread Olof Johansson
On Wed, Nov 28, 2012 at 8:16 AM, Doug Anderson wrote: > Olof / Kukjin, > > On Tue, Nov 27, 2012 at 10:05 PM, Olof Johansson wrote: >> On Wed, Nov 28, 2012 at 02:23:09PM +0900, Kukjin Kim wrote: >>> Olof Johansson wrote: >>> > >>> > On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim wrote: >>> > > On 11

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-28 Thread Doug Anderson
Olof / Kukjin, On Tue, Nov 27, 2012 at 10:05 PM, Olof Johansson wrote: > On Wed, Nov 28, 2012 at 02:23:09PM +0900, Kukjin Kim wrote: >> Olof Johansson wrote: >> > >> > On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim wrote: >> > > On 11/28/12 07:11, Olof Johansson wrote: >> > >> >> > >> On Tue, Nov 2

Re: [PATCH v4 0/5] ARM: EXYNOS: Add secure firmware support

2012-11-28 Thread Tomasz Figa
Hi, On Saturday 24 of November 2012 11:21:03 Kukjin Kim wrote: > Tomasz Figa wrote: > > Some Exynos-based boards are running with secure firmware running in > > TrustZone secure world, which changes the way some things have to be > > initialized. > > > > This series adds support for specifying fi

Re: [RFC 1/2] ARM: S3C24XX: add devicetree support for interrupts

2012-11-28 Thread Thomas Abraham
Hi Heiko, On 27 November 2012 21:54, Heiko Stübner wrote: [...] > > > Because of the mails from yesterday I took another look at my code, after > letting it sit for the previous days and I found more optimization > possiblities. > > It should be possible to trim the irqtypes down to level,edge

[PATCH 3/3] ARM: EXYNOS: Add g2d clock support for EXYNOS5

2012-11-28 Thread Ajay Kumar
Add g2d clock instance for EXYNOS5 g2d controller. Signed-off-by: Ajay Kumar --- arch/arm/mach-exynos/clock-exynos5.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c index 5c63bc7..f16b027 10

[PATCH 2/3] ARM: EXYNOS: Add AUXDATA for G2D controller

2012-11-28 Thread Ajay Kumar
Use AUXDATA to set the device names for G2D controller instance discovered from device tree. Signed-off-by: Ajay Kumar --- arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exyn

[PATCH 1/3] ARM: dts: Add device tree node for G2D controller on Exynos5

2012-11-28 Thread Ajay Kumar
Signed-off-by: Ajay Kumar --- arch/arm/boot/dts/exynos5250.dtsi |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 581e57a..6d50c15 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm

Re: [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-28 Thread Tomasz Figa
Hi Praveen, On Friday 23 of November 2012 09:54:51 Praveen Paneri wrote: > We will anyway remove the platform data part soon. If you say I can > resend it again. I think that the requirement for platform data on DT-enabled systems should be removed before this series get merged, because there ar

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-28 Thread Tomasz Figa
Hi Praveen, On Friday 23 of November 2012 09:56:37 Praveen Paneri wrote: > >> +static void samsung_usbphy_enable(struct samsung_usbphy *sphy) > >> +{ > >> + void __iomem *regs = sphy->regs; > >> + u32 phypwr; > >> + u32 phyclk; > >> + u32 rstcon; > >> + > >> + /* set clock freq

[PATCH V4 0/2] Add DT support for i2s

2012-11-28 Thread Padmavathi Venna
V4 patches are based on Mark Brown's for-next branch of "git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git" Changes since V3: - Added syntex of gpio specifier as suggested by Mark Brown in DT document file - Added the requirement for having I2S alias ids

[PATCH V4 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-11-28 Thread Padmavathi Venna
Add support for device based discovery. Signed-off-by: Padmavathi Venna --- .../devicetree/bindings/sound/samsung-i2s.txt | 78 +++ sound/soc/samsung/dma.c|1 + sound/soc/samsung/dma.h|1 + sound/soc/samsung/i2s.c

[PATCH V4 1/2] ASoC: Samsung: Get I2S src_clk from clock alias id.

2012-11-28 Thread Padmavathi Venna
As the I2S src clks are registered with clkdev using generic connection id, driver can get the clk name using generic id. So the variable representing the array of rclk src clks is deleted. Signed-off-by: Padmavathi Venna --- include/linux/platform_data/asoc-s3c.h |6 -- sound/soc/samsun

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Yes. pin of write protection is common property. This change is good. I have some suggestion below. Could you check it? On Friday, November 23, 2012, Doug Anderson wrote: > The exynos code claimed wp-gpio with devm_gpio_request() but never did > anything with it. That meant that anyone using a wr

Re: [GIT PULL] ASoC: Samsung: Updates for v3.8

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 11:21:31AM +0530, Padma Venkat wrote: > On Wed, Nov 28, 2012 at 10:55 AM, Sangbeom Kim wrote: > >> > The requirement for an alias is also very odd, where does that come from? > >> I don't know that Which one is odd. Please let me know. > > Having them at all is odd - it'