Re: [PATCH v2 1/3] ARM: dts: exynos5: Set up power domain for MFC,G-scaler,MAU and ISP

2012-12-26 Thread Prasanna Kumar
Hi all, Any comments on this patch ? Thanks, Prasanna On Thu, Dec 20, 2012 at 5:56 PM, Prasanna Kumar wrote: > This patch adds device tree nodes for MFC,G-scaler,MAU and ISP power domains > of exynos5.It binds these power-domain nodes to repsective device tree nodes. > > Signed-off-by: Prasanna

Re: [PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines

2012-12-26 Thread Inderpal Singh
On 27 December 2012 09:39, Inderpal Singh wrote: > i2c->gpios[] is being used to free_gpios but it's not getting initialized. > > Signed-off-by: Inderpal Singh > --- > drivers/i2c/busses/i2c-s3c2410.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c

Re: [PATCH 2/2] i2c: s3c2410: free gpios in suspend function

2012-12-26 Thread Inderpal Singh
On 27 December 2012 09:39, Inderpal Singh wrote: > While resuming the gpios are being requested again, hence we need > to free the gpios before going to suspend otherwise it gives > "gpio request failed" errors while resuming. > > Signed-off-by: Inderpal Singh > --- > drivers/i2c/busses/i2c-s3c2

[PATCH 2/2] i2c: s3c2410: free gpios in suspend function

2012-12-26 Thread Inderpal Singh
While resuming the gpios are being requested again, hence we need to free the gpios before going to suspend otherwise it gives "gpio request failed" errors while resuming. Signed-off-by: Inderpal Singh --- drivers/i2c/busses/i2c-s3c2410.c |1 + 1 file changed, 1 insertion(+) diff --git a/dr

[PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines

2012-12-26 Thread Inderpal Singh
i2c->gpios[] is being used to free_gpios but it's not getting initialized. Signed-off-by: Inderpal Singh --- drivers/i2c/busses/i2c-s3c2410.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index a290d08..f1d1f1e 100644

[PATCH] ARM: EXYNOS4: Add support for rtc wakeup

2012-12-26 Thread Inderpal Singh
Set the gic arch extension callback to support rtc wakeup. Signed-off-by: Inderpal Singh --- arch/arm/mach-exynos/common.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index 578a610..bf2ee1d 100644 --- a/arch/arm/mach-exyn

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Russell King - ARM Linux
On Wed, Dec 26, 2012 at 05:58:32PM +0530, Vivek Gautam wrote: > + if (!ret) > + sphy->phyctrl_pmureg = ioremap(reg[0], reg[1]); > + > + of_node_put(usbphy_pmu); > + > + if (IS_ERR_OR_NULL(sphy->phyctrl_pmureg)) { No. Learn what the error return values are from functions.

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Sylwester Nawrocki
Hi, On 12/26/2012 02:56 PM, Vivek Gautam wrote: On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- Hope these changes align with what architectura

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-26 Thread Sylwester Nawrocki
On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug Anderson Well, I have another idea. Yes, I know, specific chip name should be used. But you know the specific chip name in compatible can cause another confusion on other SoC w

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Sylwester Nawrocki
On 12/26/2012 01:28 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 31 drivers/usb/phy/samsung-usbphy.c

[PATCH] cpufreq: exynos: Add the missing cpufreq_cpu_put function

2012-12-26 Thread Amit Daniel Kachhap
This patch adds the missing cpufreq_cpu_put function needed for returning the cpufreq policy instance. Signed-off-by: Amit Daniel Kachhap --- drivers/cpufreq/exynos-cpufreq.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufr

Re: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

2012-12-26 Thread Sergei Shtylyov
Hello. On 12/26/2012 09:42 PM, Dongjin Kim wrote: > This patch support to get interrupt resource from device tree as well as > platform device if ehci node is defined in device tree and it's irq is > described. > Signed-off-by: Dongjin Kim > --- > drivers/usb/host/ehci-s5p.c |8 +++- >

[PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

2012-12-26 Thread Dongjin Kim
This patch support to get interrupt resource from device tree as well as platform device if ehci node is defined in device tree and it's irq is described. Signed-off-by: Dongjin Kim --- drivers/usb/host/ehci-s5p.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH 1/2] ARM: dts: Add EHCI device tree node for Exynos4

2012-12-26 Thread Dongjin Kim
This patch adds EHCI device node on device tree for Exynos4 and defines its default platform data, s5p_usb_phy_init and s5p_usb_phy_exit, so that those function can be called from the driver. Signed-off-by: Dongjin Kim --- arch/arm/boot/dts/exynos4.dtsi |7 +++ arch/arm/mach-exyn

[PATCH 0/2] EXYNOS4: Add device tree support for USB/EHCI

2012-12-26 Thread Dongjin Kim
This patch set adds device tree upport for USB/EHCI device. Dongjin Kim (2): ARM: dts: Add EHCI device tree node for Exynos4 USB: ehci-s5p: Add to get interrupt from DT arch/arm/boot/dts/exynos4.dtsi |7 +++ arch/arm/mach-exynos/mach-exynos4-dt.c |9 + drivers/usb

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Hi Sylwester, On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam wrote: > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam > --- Hope these changes align with what architectural changes you had suggested

[PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 31 drivers/usb/phy/samsung-usbphy.c | 145 +--- 2 files c

[PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Changes form v3: - Removing the hostphy_en_mas since this gets used in forthcoming patches only when host phy support is added. - Resolving few nits: - using 'const' specifier for driver data structures. - using ARRAY_SIZE() instead of giving magic number for of_prope

Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Hi Doug, On Fri, Dec 21, 2012 at 10:35 PM, Doug Anderson wrote: > Vivek, > > Nothing really serious below and things look good to me, but figured > I'd put a few nits in (sorry!). > > > On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam > wrote: >> diff --git a/Documentation/devicetree/bindings/us

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-26 Thread Padma Venkat
Hi, On Mon, Dec 24, 2012 at 9:33 AM, Padma Venkat wrote: > Hi, > > On Sat, Dec 22, 2012 at 12:32 AM, Kukjin Kim wrote: >> Padma Venkat wrote: >>> >>> Hi, >>> >>> On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown >>> wrote: >>> > On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: >>> >> On

Re: [PATCH v4 3/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-12-26 Thread Arnd Bergmann
On Wednesday 26 December 2012, Barry Song wrote: > > / { > > /* ... */ > > > > firmware@0203F000 { > > compatible = "samsung,secure-firmware"; > > reg = <0x0203F000 0x1000>; > > }; > > > > /* .

Re: [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware

2012-12-26 Thread Barry Song
2012/11/12, Tomasz Figa : > Hi Russel, > > On Monday 12 of November 2012 09:51:14 Russell King - ARM Linux wrote: >> > + >> > +static int exynos_cpu_boot(int cpu) >> > +{ >> > + exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0); >> > + return 0; >> > +} >> >> Same for this (though, what _exactly_ is 'cpu',

Re: [PATCH v4 3/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-12-26 Thread Barry Song
2012/11/22, Tomasz Figa : > Some Exynos-based boards contain secure firmware and must use firmware > operations to set up some hardware. > > This patch adds firmware operations for Exynos secure firmware and a way > for board code and device tree to specify that they must be used. > > Example of us

Re: [PATCH v4 1/5] ARM: Add interface for registering and calling firmware-specific operations

2012-12-26 Thread Barry Song
2012/11/22, Tomasz Figa : > Some boards are running with secure firmware running in TrustZone secure > world, which changes the way some things have to be initialized. > > This patch adds an interface for platforms to specify available firmware > operations and call them. > > A wrapper macro, call_