Re: [PATCH] gpio: samsung: add GPIO interrupt registration for exynos5

2013-01-17 Thread Linus Walleij
On Fri, Dec 14, 2012 at 11:44 AM, Joonyoung Shim wrote: > This adds GPIO interrupt registration and modification needs to register > GPIO interrupt rightly for exynos5 SoCs. EXYNOS5_GPYx gpios shouldn't be > counted to GPIO interrupt group register number because they doesn't > support GPIO inter

Re: [PATCH] gpio: samsung: fix pinctrl condition for exynos and exynos5440

2013-01-17 Thread Linus Walleij
On Thu, Dec 27, 2012 at 7:11 PM, Kukjin Kim wrote: > Since EXYNOS5440 can select PINCTRL_EXYNOS5440 without PINCTRL_SAMSUNG, > it should be fixed. In detail, PINCTRL_SAMSUNG is a kind of frame work > for supporting pinctrl on most Samsung SoCs including S3C, S5P as well > except EXYNOS5440 so PIN

Re: [PATCH] gpio: samsung: silent build warning for EXYNOS5 SoCs

2013-01-17 Thread Linus Walleij
On Thu, Dec 27, 2012 at 7:12 PM, Kukjin Kim wrote: > This patch fixes following warning: > > drivers/gpio/gpio-samsung.c:450:32: warning: 'exynos_gpio_cfg' defined but > not used [-Wunused-variable] > drivers/gpio/gpio-samsung.c:2450:33: warning: 'exynos5_gpios_1' defined but > not used [-Wunus

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Linus Walleij
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > From: Thomas Abraham > > Fix the incorrect compatible property value of pin-controller module > EXYNOS5440 SoC. > (...) > > pinctrl { > - compatible = "samsung,pinctrl-exynos5440"; > + compatible = "samsung,e

Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Tomasz Figa
Hi Sachin, On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: > Added vmmc regulator node in exynos4412-origen.dts file. > > Signed-off-by: Sachin Kamat > --- > arch/arm/boot/dts/exynos4412-origen.dts |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git

Re: [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen

2013-01-17 Thread Tomasz Figa
Hi Sachin, On Thursday 17 of January 2013 11:18:13 Sachin Kamat wrote: > Added sdhci node for exynos4412-origen. > > Signed-off-by: Sachin Kamat > --- > arch/arm/boot/dts/exynos4412-origen.dts |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dt

Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Sachin Kamat
Hi Tomasz On 17 January 2013 14:56, Tomasz Figa wrote: > Hi Sachin, > > On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: >> Added vmmc regulator node in exynos4412-origen.dts file. >> >> Signed-off-by: Sachin Kamat >> --- > > > Reviewed-by: Tomasz Figa > Thank you for reviewing the

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Tomasz Figa
Hi Olof, On Saturday 05 of January 2013 14:57:54 Olof Johansson wrote: > On Wed, Jan 2, 2013 at 4:20 PM, Kukjin Kim wrote: > > Fix the incorrect compatible property value of pinctrl for EXYNOS4 > > SoCs. > Ah, this answers my question from the previous patch. So, why do 5450 > as a separate patc

Re: [PATCH 01/26] gpio: samsung: remove inclusion

2013-01-17 Thread Linus Walleij
On Thu, Jan 10, 2013 at 7:41 PM, Kukjin Kim wrote: > BTW, do you have any comments on following patches? > > [PATCH] gpio: samsung: silent build warning for EXYNOS5 > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14443.html Merged to fixes. > [PATCH] gpio: samsung: fix pinctr

Re: [PATCH] gpio: samsung: skip gpio lib registration for EXYNOS5440

2013-01-17 Thread Linus Walleij
On Thu, Dec 20, 2012 at 8:08 PM, Kukjin Kim wrote: > Since exynos5440 can support pinctrl so skip the legacy > gpiolib registration. If not, happens following. > > WARNING: at drivers/gpio/gpio-samsung.c:3102 samsung_gpiolib_init+0x68/0x8c() > Unknown SoC in gpio-samsung, no GPIOs added > > Acked

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Tomasz Figa
Hi Kukjin, On Wednesday 02 of January 2013 16:20:23 Kukjin Kim wrote: > Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. > > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: Grant Likely > Signed-off-by: Kukjin Kim > Cc: devicetree-disc...@lists.ozlabs.org > --- > .../dev

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Linus Walleij
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. > > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: Grant Likely > Signed-off-by: Kukjin Kim > Cc: devicetree-disc...@lists.ozlabs.org Acked-by: Linus Walleij Thanks! L

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Stephen Warren
On 01/17/2013 01:34 AM, Linus Walleij wrote: > On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > >> From: Thomas Abraham >> >> Fix the incorrect compatible property value of pin-controller module >> EXYNOS5440 SoC. >> > (...) >> >> pinctrl { >> - compatible = "samsung,pin

Re: [PATCH v5 06/14] ARM: EXYNOS: add System MMU definition to DT

2013-01-17 Thread Will Deacon
Hi Hiroshi, On Wed, Jan 16, 2013 at 04:43:21PM +, Hiroshi Doyu wrote: > Will Deacon wrote @ Wed, 16 Jan 2013 12:51:14 +0100: > > Given that this information is not discoverable, it needs to be encoded > > in the device tree, but where? I can see two approaches: > > > > 1. For each IOMMU no

Re: [PATCH V2 0/3] thermal: Add support for interrupt based notification to thermal layer

2013-01-17 Thread amit daniel kachhap
Hi Rui, Any update? Please merge these patch series as they have many critical fixes. Thanks, Amit Daniel On Sun, Jan 6, 2013 at 3:57 PM, amit daniel kachhap wrote: > Hi Rui, > > Any comment on these patches? These are based on new quick cooling > macros introduced. > Also my linaro ID is not

[PATCH] cpufreq: exynos: fix uninitialized warning in exynos-cpufreq.c

2013-01-17 Thread Kukjin Kim
From: Jonghwan Choi Fix "warning: 'ret' may be used uninitialized in this function" Signed-off-by: Jonghwan Choi Cc: Rafael J. Wysocki Signed-off-by: Kukjin Kim --- drivers/cpufreq/exynos-cpufreq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/exynos-

[PATCH] cpufreq: exynos: fix hang in pm handler due to frequency mismatch

2013-01-17 Thread Kukjin Kim
From: Jonghwan Choi When pm handler set freq & voltage, frequency mismatch occurred. Because freqs.new isn't set in pm handler. Reported-by: Abhilash Kesavan Signed-off-by: Jonghwan Choi Cc: Rafael J. Wysocki Signed-off-by: Kukjin Kim --- drivers/cpufreq/exynos-cpufreq.c |8 +--- 1

RE: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi Sachin, > > On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: > > Added vmmc regulator node in exynos4412-origen.dts file. > > > > Signed-off-by: Sachin Kamat > > --- > > arch/arm/boot/dts/exynos4412-origen.dts |9 + > > 1 files changed, 9 inserti

RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue

2013-01-17 Thread Kukjin Kim
Chen Gang wrote: > Firstly, thanks for your posting. But there are some comments. For subject: Please see the git log before your commit, it should be helpful to you. In this case, 'ARM: S5PV210: ...' is used. > > if not define CONFIG_CPU_S5PV210 > > it will define NULL in common.h for:

[GIT PULL] Samsung cleanup-header for v3.9

2013-01-17 Thread Kukjin Kim
Hi, Arnd, Olof Here is cleanup headers for Samsung stuff. AS I commented, this makes local so that they could be removed. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git next/cleanup-header If any problems, please kindly let me know. Thanks - Kukjin T

RE: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam > Reviewed-by: Sylwester Nawrocki > Reviewed-by: Doug Anderson This looks good to me, Acked-by: Kukjin Kim Vivek, could yo

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Rob Herring
On 01/17/2013 02:34 AM, Linus Walleij wrote: > On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > >> From: Thomas Abraham >> >> Fix the incorrect compatible property value of pin-controller module >> EXYNOS5440 SoC. >> > (...) >> >> pinctrl { >> - compatible = "samsung,pin

RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue

2013-01-17 Thread Kukjin Kim
Chen,Gang( ??) wrote: > > > > For subject: > > Please see the git log before your commit, it should be helpful to you. > > In this case, 'ARM: S5PV210: ...' is used. > > thank you, I should notice it next time. > an incorrect subject is not easy to get maintainer's notice > maybe it is

RE: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Kukjin Kim
Rob Herring wrote: [...] > > As long as we're consistently inconsistent... What about 4210 and 4x12? > Hopefully, the reason was to avoid breaking them. > > This creates horrible incompatibilities between dts and kernel versions > by changing both. Any prior kernel will not work with this dts o

RE: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

2013-01-17 Thread Kukjin Kim
Daniel Lezcano wrote: > > On 01/10/2013 11:33 PM, amit daniel kachhap wrote: > > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano > wrote: > >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote: > >>> Hi Daniel, > >> > >> Hi Amit Daniel, > >> > >>> This hotplug noifiers looks fine. I suppose it sh

RE: [PATCH] arm: mach-s3c24xx/common.c: fix uninitialized variable warning

2013-01-17 Thread Kukjin Kim
Cong Ding wrote: > > the use of variable tmp is uninitialized, so we fix it. > > Signed-off-by: Cong Ding > --- > arch/arm/mach-s3c24xx/common.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach- > s3c24xx/common.c > inde

RE: [PATCH] cpufreq: exynos: Get booting freq value in exynos_cpufreq_init

2013-01-17 Thread Kukjin Kim
Jonghwan Choi wrote: > > Boot_freq is for saving booting freq. But exynos_cpufreq_cpu_init > is called in hotplug. If boot_freq is existed in exynos_cpufreq_cpu_init, > boot_freq could be changed. > > Signed-off-by: Jonghwan Choi > --- > drivers/cpufreq/exynos-cpufreq.c |4 ++-- > 1 files c

RE: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies

2013-01-17 Thread Kukjin Kim
amit kachhap wrote: > > On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh > wrote: > > Add freq_attr attribute to show list of available frequencies. > > > > Signed-off-by: Donggeun Kim > > Signed-off-by: MyungJoo Ham > > Signed-off-by: KyungMin Park > > Signed-off-by: Inderpal Singh > > --- > >

Re: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue

2013-01-17 Thread Chen Gang
On 01/18/2013 11:33 AM, Kukjin Kim wrote: > Chen,Gang( ??) wrote: >> thank you, I should notice it next time. >> an incorrect subject is not easy to get maintainer's notice >> maybe it is the reason why you can not reply in time, since you can not >> notice it. >> >> :-) >> > Just I wa

Re: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Vivek Gautam
HI Kukjin, On Fri, Jan 18, 2013 at 6:46 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam >> Reviewed-by: Sylwester Nawrocki >> Reviewed-by: Doug A