Re: [PATCH] gpio: samsung: fix pinctrl condition for exynos and exynos5440

2013-01-17 Thread Linus Walleij
On Thu, Dec 27, 2012 at 7:11 PM, Kukjin Kim kgene@samsung.com wrote: Since EXYNOS5440 can select PINCTRL_EXYNOS5440 without PINCTRL_SAMSUNG, it should be fixed. In detail, PINCTRL_SAMSUNG is a kind of frame work for supporting pinctrl on most Samsung SoCs including S3C, S5P as well except

Re: [PATCH] gpio: samsung: silent build warning for EXYNOS5 SoCs

2013-01-17 Thread Linus Walleij
On Thu, Dec 27, 2012 at 7:12 PM, Kukjin Kim kgene@samsung.com wrote: This patch fixes following warning: drivers/gpio/gpio-samsung.c:450:32: warning: 'exynos_gpio_cfg' defined but not used [-Wunused-variable] drivers/gpio/gpio-samsung.c:2450:33: warning: 'exynos5_gpios_1' defined but

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Linus Walleij
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Fix the incorrect compatible property value of pin-controller module EXYNOS5440 SoC. (...) pinctrl { - compatible = samsung,pinctrl-exynos5440; +

Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Tomasz Figa
Hi Sachin, On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: Added vmmc regulator node in exynos4412-origen.dts file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4412-origen.dts |9 + 1 files changed, 9 insertions(+), 0

Re: [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen

2013-01-17 Thread Tomasz Figa
Hi Sachin, On Thursday 17 of January 2013 11:18:13 Sachin Kamat wrote: Added sdhci node for exynos4412-origen. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4412-origen.dts |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Sachin Kamat
Hi Tomasz On 17 January 2013 14:56, Tomasz Figa t.f...@samsung.com wrote: Hi Sachin, On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: Added vmmc regulator node in exynos4412-origen.dts file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Reviewed-by: Tomasz Figa

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Tomasz Figa
Hi Olof, On Saturday 05 of January 2013 14:57:54 Olof Johansson wrote: On Wed, Jan 2, 2013 at 4:20 PM, Kukjin Kim kgene@samsung.com wrote: Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. Ah, this answers my question from the previous patch. So, why do 5450 as

Re: [PATCH 01/26] gpio: samsung: remove inclusion mach/regs-clock.h

2013-01-17 Thread Linus Walleij
On Thu, Jan 10, 2013 at 7:41 PM, Kukjin Kim kgene@samsung.com wrote: BTW, do you have any comments on following patches? [PATCH] gpio: samsung: silent build warning for EXYNOS5 http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14443.html Merged to fixes. [PATCH] gpio:

Re: [PATCH] gpio: samsung: skip gpio lib registration for EXYNOS5440

2013-01-17 Thread Linus Walleij
On Thu, Dec 20, 2012 at 8:08 PM, Kukjin Kim kgene@samsung.com wrote: Since exynos5440 can support pinctrl so skip the legacy gpiolib registration. If not, happens following. WARNING: at drivers/gpio/gpio-samsung.c:3102 samsung_gpiolib_init+0x68/0x8c() Unknown SoC in gpio-samsung, no

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Tomasz Figa
Hi Kukjin, On Wednesday 02 of January 2013 16:20:23 Kukjin Kim wrote: Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. Cc: Thomas Abraham thomas...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by:

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Linus Walleij
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim kgene@samsung.com wrote: Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. Cc: Thomas Abraham thomas...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by:

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Stephen Warren
On 01/17/2013 01:34 AM, Linus Walleij wrote: On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Fix the incorrect compatible property value of pin-controller module EXYNOS5440 SoC. (...) pinctrl { -

Re: [PATCH v5 06/14] ARM: EXYNOS: add System MMU definition to DT

2013-01-17 Thread Will Deacon
Hi Hiroshi, On Wed, Jan 16, 2013 at 04:43:21PM +, Hiroshi Doyu wrote: Will Deacon will.dea...@arm.com wrote @ Wed, 16 Jan 2013 12:51:14 +0100: Given that this information is not discoverable, it needs to be encoded in the device tree, but where? I can see two approaches: 1. For

Re: [PATCH V2 0/3] thermal: Add support for interrupt based notification to thermal layer

2013-01-17 Thread amit daniel kachhap
Hi Rui, Any update? Please merge these patch series as they have many critical fixes. Thanks, Amit Daniel On Sun, Jan 6, 2013 at 3:57 PM, amit daniel kachhap amit.dan...@samsung.com wrote: Hi Rui, Any comment on these patches? These are based on new quick cooling macros introduced. Also

[PATCH] cpufreq: exynos: fix uninitialized warning in exynos-cpufreq.c

2013-01-17 Thread Kukjin Kim
From: Jonghwan Choi jhbird.c...@samsung.com Fix warning: 'ret' may be used uninitialized in this function Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/cpufreq/exynos-cpufreq.c |

[PATCH] cpufreq: exynos: fix hang in pm handler due to frequency mismatch

2013-01-17 Thread Kukjin Kim
From: Jonghwan Choi jhbird.c...@samsung.com When pm handler set freq voltage, frequency mismatch occurred. Because freqs.new isn't set in pm handler. Reported-by: Abhilash Kesavan a.kesa...@samsung.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Cc: Rafael J. Wysocki

RE: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts

2013-01-17 Thread Kukjin Kim
Tomasz Figa wrote: Hi Sachin, On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: Added vmmc regulator node in exynos4412-origen.dts file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4412-origen.dts |9 + 1 files changed, 9

RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue

2013-01-17 Thread Kukjin Kim
Chen Gang wrote: Firstly, thanks for your posting. But there are some comments. For subject: Please see the git log before your commit, it should be helpful to you. In this case, 'ARM: S5PV210: ...' is used. if not define CONFIG_CPU_S5PV210 it will define NULL in common.h for:

RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue

2013-01-17 Thread Kukjin Kim
Chen,Gang( ??) wrote: For subject: Please see the git log before your commit, it should be helpful to you. In this case, 'ARM: S5PV210: ...' is used. thank you, I should notice it next time. an incorrect subject is not easy to get maintainer's notice maybe it is the reason

RE: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Kukjin Kim
Rob Herring wrote: [...] As long as we're consistently inconsistent... What about 4210 and 4x12? Hopefully, the reason was to avoid breaking them. This creates horrible incompatibilities between dts and kernel versions by changing both. Any prior kernel will not work with this dts or

RE: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

2013-01-17 Thread Kukjin Kim
Daniel Lezcano wrote: On 01/10/2013 11:33 PM, amit daniel kachhap wrote: On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano daniel.lezc...@free.fr wrote: On 01/10/2013 09:07 PM, amit daniel kachhap wrote: Hi Daniel, Hi Amit Daniel, This hotplug noifiers looks fine. I suppose it

RE: [PATCH] arm: mach-s3c24xx/common.c: fix uninitialized variable warning

2013-01-17 Thread Kukjin Kim
Cong Ding wrote: the use of variable tmp is uninitialized, so we fix it. Signed-off-by: Cong Ding ding...@gmail.com --- arch/arm/mach-s3c24xx/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-

RE: [PATCH] cpufreq: exynos: Get booting freq value in exynos_cpufreq_init

2013-01-17 Thread Kukjin Kim
Jonghwan Choi wrote: Boot_freq is for saving booting freq. But exynos_cpufreq_cpu_init is called in hotplug. If boot_freq is existed in exynos_cpufreq_cpu_init, boot_freq could be changed. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- drivers/cpufreq/exynos-cpufreq.c |4

RE: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies

2013-01-17 Thread Kukjin Kim
amit kachhap wrote: On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Add freq_attr attribute to show list of available frequencies. Signed-off-by: Donggeun Kim dg77@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by:

Re: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue

2013-01-17 Thread Chen Gang
On 01/18/2013 11:33 AM, Kukjin Kim wrote: Chen,Gang( ??) wrote: thank you, I should notice it next time. an incorrect subject is not easy to get maintainer's notice maybe it is the reason why you can not reply in time, since you can not notice it. :-) Just I was busy ;-)

Re: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Vivek Gautam
HI Kukjin, On Fri, Jan 18, 2013 at 6:46 AM, Kukjin Kim kgene@samsung.com wrote: Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Sylwester