Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. I will address all you comments for this patch in the next version. Thanks, Shaik Ameer Basha On Mon, Mar 11, 2013 at 3:58 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds support for media device for EXY

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
On Mon, Mar 11, 2013 at 2:27 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -47,6 +47,8 @@ >> i2c6 =&i2c_6; >> i2c7 =&i2c_7; >>

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:24 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds necessary source definations needed for mipi-csis >> driver and adds devicetree node for exynos5250. >> >> Signed-off-by: Shaik Ameer Basha >> --- >>

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: > > Please don't leave the change log empty. I'll apply this patch. > I'm just wondering, if there aren't any further changes needed > to make the driver really working on e

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

2013-03-10 Thread Kukjin Kim
Sachin Kamat wrote: > > Hi Kukjin, > > Can you please look into this series as it is pending since quite some time. > Applied, I have another opinion about the compatible string though... I think, it can be sorted out next time :-) Thanks. - Kukjin > On 18 February 2013 10:32, Sachin Kamat

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-10 Thread Shaik Ameer Basha
Hi Sylweter, On Mon, Mar 11, 2013 at 2:09 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds the following functionalities to existing driver >> >> 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. >> This patch adds the

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:06 AM, Sylwester Nawrocki wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> This patch adds the Exynos5 soc compatibility to the fimc-lite driver. >> It also adds a version checking to deal with the changes between >> different fimc-lite hardw

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-10 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. Actually I know this is the important patch in this series and I wanted us to have enough time to discuss on this patch. That's why I posted this patch series in hurry. I will remove this patch from the exynos5-mdev series and will send this as a separate patc

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Viresh, On Sat, Mar 9, 2013 at 4:17 PM, Viresh Kumar wrote: > On 7 March 2013 12:13, Amit Daniel Kachhap wrote: >> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c >> b/drivers/cpufreq/exynos5440-cpufreq.c >> +struct exynos_dvfs_data { >> + void __iomem *base; >> + struct resour

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Russell, On Thu, Mar 7, 2013 at 9:07 PM, Russell King - ARM Linux wrote: > On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: >> On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: >> > + dvfs_info->cpu_clk = devm_clk_get(dvfs_info->dev, "armclk"); >> > + if (IS_ERR_OR_NULL

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Sylwester, Thanks for the review. Will update with your suggestion in the next version, Thanks, Amit D On Thu, Mar 7, 2013 at 8:58 PM, Sylwester Nawrocki wrote: > On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: >> +/* Register definations */ > > s/definations/definitions ok > >> +#define

RE: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-03-10 Thread Kukjin Kim
amit daniel kachhap wrote: > > The V2 of this patch is posted with comments suggested by Anil and > some missing LDO's. > OK, I see. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info

RE: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-03-10 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi, > > I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. > > Support for it in pinctrl-samsung driver has been already merged, but I > don't see any pinctrl nodes in exynos5250.dtsi. > > This is important because the legacy gpio-samsung support is go

RE: [PATCH] ARM: S3C64XX: Slow down mic detection rate for wm5102

2013-03-10 Thread Kukjin Kim
Mark Brown wrote: > > On Fri, Feb 22, 2013 at 12:02:44PM +, Charles Keepax wrote: > > > switch: arizona: Support microphone detection rate configuration > > commit 2e033db5ddf299de2ae568919d78b0258a5a6423 > > The commit ID is correct there, the commit log is (as you'd expect) > extcon: > >

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. * MIPI-CSIS Support interconnection(subdev interface) between devices * FIMC-LITE

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch modifies the current fimc_pipeline to exynos_pipeline, I think we could leave it as fimc_pipeline, exynos_pipeline seems too generic to me. which can be used across multiple media device drivers. Signed-off-by: Shaik Ameer Basha ---

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -47,6 +47,8 @@ i2c6 =&i2c_6; i2c7 =&i2c_7; i2c8 =&i2c_8; + csis0 =&csis_0; + csis1 =&csis

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer Basha --- arch/arm/boot/dts/exynos5250.dtsi | 18 ++ arch/arm/mach-exynos/clock

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make the driver really working on exynos5250 ? Signed-off-by: Shaik Ameer Basha --- drivers/media/platform/s5p-fim

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the following functionalities to existing driver 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. This patch adds the functionality of using shadow registers by checking the current FIMC-LITE hardware versi

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between different fimc-lite hardware versions. Is there really anything different between the Exynos4 and Exynos5 FIMC

Re: [RFC 00/12] Adding media device driver for Exynos imaging subsystem

2013-03-10 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: The following patchset features: 1] Creating a common pipeline framework which can be used by all Exynos series SoCs for developing media device drivers. 2] Modified the existing fimc-mdevice for exynos4 to use the common pipeline framework. 3] Ad