Re: [PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock

2013-04-29 Thread Rahul Sharma
On Mon, Apr 29, 2013 at 11:07 PM, Sylwester Nawrocki wrote: > Hi, > > On 04/29/2013 07:04 PM, Sean Paul wrote: >> On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma >> wrote: >>> Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly >>> accessed among hdmi and hdmiphy driver. Duri

Re: [PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock

2013-04-29 Thread Sylwester Nawrocki
Hi, On 04/29/2013 07:04 PM, Sean Paul wrote: > On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma > wrote: >> Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly >> accessed among hdmi and hdmiphy driver. During power cycle, each of these >> driver decrements the ref-count and e

Re: [PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock

2013-04-29 Thread Sean Paul
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma wrote: > Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly > accessed among hdmi and hdmiphy driver. During power cycle, each of these > driver decrements the ref-count and ensures that last user disables the > clock. Setting pa

Re: [PATCH v2] clk: exynos4: Add clock entries for TMU

2013-04-29 Thread Mike Turquette
Quoting Sachin Kamat (2013-04-21 20:55:46) > Added clock entries for thermal management unit (TMU) for > Exynos4 SoCs. > > Signed-off-by: Sachin Kamat > Cc: Thomas Abraham > Cc: Mike Turquette This has my Ack if you plan to take it through the Samsung tree. If you want it to go through the clk

Re: [PATCH 2/4] drm/exynos: hdmi: register hdmiphy driver from common drm hdmi

2013-04-29 Thread Sean Paul
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma wrote: > hdmiphy hardware block is a physically separate device. Hdmiphy driver > is glued inside hdmi driver and acessed through hdmi callbacks. With > increasing diversities in the hdmiphy mapping and configurations, hdmi > driver is expanding with

Re: [PATCH 1/4] drm/exynos: hdmi: move hdmi subsystem registration to drm common hdmi

2013-04-29 Thread Sean Paul
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma wrote: > Exynos hdmi sub-system consists of mixer, hdmi ip, hdmi-phy and hdmi-ddc > components. Currently, drivers for these components are getting registered > in exynos_drm_drv.c, which is meant for registration of drm sub-drivers. > > In this patch

Re: [PATCH v4] drm/exynos: hdmi: use drm_display_mode to check the supported modes

2013-04-29 Thread Sean Paul
On Mon, Apr 29, 2013 at 7:14 AM, Rahul Sharma wrote: > Exynos hdmi driver is using drm_display_mode for setting timing values > for a supported resolution. Conversion to fb_videomode and then comparing > with the mixer/hdmi/phy limits is not required. Instead, drm_display_mode > fields cane be dir

Re: [RFC v2 6/6] media: exynos5-is: Adding media device driver for exynos5

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > Signed-off-by: Shaik Ameer Basha > --- > .../devicetree/bindings/media/exynos

Re: [RFC v2 5/6] media: s5p-csis: Adding Exynos5250 compatibility

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. > This patch enables all those MIPI interrupts and adds the Exynos5 > compatible string. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/exynos4-is/mipi-csis.

Re: [RFC v2 3/6] media: fimc-lite: Adding support for Exynos5

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. > This patch adds the functionality of using shadow registers by > checking the driver data. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/exynos4-is/fi

[PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock

2013-04-29 Thread Rahul Sharma
Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly accessed among hdmi and hdmiphy driver. During power cycle, each of these driver decrements the ref-count and ensures that last user disables the clock. Setting parrent device to none ensure that both the drivers gets access t

[PATCH 3/4] drm/exynos: hdmi: move hdmiphy callbacks to hdmiphy driver

2013-04-29 Thread Rahul Sharma
Hdmiphy callbacks are tighly coupled with hdmi IP callbacks inside the hdmi driver. With increase in the support of different versions of hdmiphys, hdmi ip driver expanding with lots of phy related information. Above movement ensures that phy related code is present and maintained within the hdmiph

[PATCH 2/4] drm/exynos: hdmi: register hdmiphy driver from common drm hdmi

2013-04-29 Thread Rahul Sharma
hdmiphy hardware block is a physically separate device. Hdmiphy driver is glued inside hdmi driver and acessed through hdmi callbacks. With increasing diversities in the hdmiphy mapping and configurations, hdmi driver is expanding with un-related changes. This patch registers hdmiphy as a independ

[PATCH 1/4] drm/exynos: hdmi: move hdmi subsystem registration to drm common hdmi

2013-04-29 Thread Rahul Sharma
Exynos hdmi sub-system consists of mixer, hdmi ip, hdmi-phy and hdmi-ddc components. Currently, drivers for these components are getting registered in exynos_drm_drv.c, which is meant for registration of drm sub-drivers. In this patch, registration of drm hdmi sub-driver and device, drivers for hd

[PATCH 0/4] drm/exynos: hdmi: move hdmiphy related code to hdmiphy driver

2013-04-29 Thread Rahul Sharma
Right now hdmiphy operations and configs are kept inside hdmi driver. hdmiphy related code is tightly coupled with hdmi ip driver. Physicaly they are different devices and should be instantiated independently. In terms of versions/mapping/configurations Hdmi and hdmiphy are independent of each oth

Re: [RFC v2 2/6] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > This patch adds, > 1] Exynos5 soc compatibility to the fimc-lite driver > 2] Multiple dma output buffer support as from Exynos5 onwards, >fimc-lite h/w ip supports multiple dma buffers. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/me

Re: [PATCH] ARM: EXYNOS5: Fix kernel dump in AFTR idle mode

2013-04-29 Thread Chander Kashyap
On 29 April 2013 17:01, Inderpal Singh wrote: > > The kernel crashes while resuming from AFTR idle mode. It happens > because L2 cache was not going into retention state. > > This patch configures the USE_RETENTION bit of ARM_L2_OPTION register > so that it does not depend on MANUAL_L2RSTDISABLE_C

[PATCH] ARM: EXYNOS5: Fix kernel dump in AFTR idle mode

2013-04-29 Thread Inderpal Singh
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state. This patch configures the USE_RETENTION bit of ARM_L2_OPTION register so that it does not depend on MANUAL_L2RSTDISABLE_CONTROL of ARM_COMMON_OPTION register for L2RSTDISABLE sign

Re: [RFC v2 1/6] media: exynos4-is: modify existing mdev to use common pipeline

2013-04-29 Thread Sylwester Nawrocki
Hi Shaik, Thanks for the updated patch series. On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > Current fimc_pipeline is tightly coupled with exynos4-is media > device driver. And this will not allow to use the same pipeline > across different exynos series media device drivers. > > This patch

Re: [PATCH v4] drm/exynos: hdmi: use drm_display_mode to check the supported modes

2013-04-29 Thread 김승우
Hello Rahul, I looks good to me. On 2013년 04월 29일 20:14, Rahul Sharma wrote: > Exynos hdmi driver is using drm_display_mode for setting timing values > for a supported resolution. Conversion to fb_videomode and then comparing > with the mixer/hdmi/phy limits is not required. Instead, drm_display_

[PATCH v4] drm/exynos: hdmi: use drm_display_mode to check the supported modes

2013-04-29 Thread Rahul Sharma
Exynos hdmi driver is using drm_display_mode for setting timing values for a supported resolution. Conversion to fb_videomode and then comparing with the mixer/hdmi/phy limits is not required. Instead, drm_display_mode fields cane be directly compared. v4: 1) Removed __func__ from DRM_DEBUG_KMS.

Re: [PATCH v2] clk: exynos4: Add clock entries for TMU

2013-04-29 Thread Sachin Kamat
On 22 April 2013 09:25, Sachin Kamat wrote: > Added clock entries for thermal management unit (TMU) for > Exynos4 SoCs. > > Signed-off-by: Sachin Kamat > Cc: Thomas Abraham > Cc: Mike Turquette > --- > Should be applied on top of the below patches: > https://patchwork.kernel.org/patch/2448711/

Re: [PATCH 1/5] clk: exynos4: Add additional G2D clocks

2013-04-29 Thread Sachin Kamat
On 18 April 2013 22:29, Mike Turquette wrote: > Quoting Sachin Kamat (2013-04-18 04:15:15) >> Add G2D clocks for Exynos4x12 SoC and sclk_fimg2d required by G2D >> IP. >> >> Signed-off-by: Sachin Kamat >> Cc: Thomas Abraham >> Cc: Mike Turquette > > Acked-by: Mike Turquette Ping Kukjin. -- W

Re: [PATCH 1/3] clk: exynos4: Staticize local symbols

2013-04-29 Thread Sachin Kamat
Ping Kukjin. Can you please add this series to your tree? On 16 April 2013 15:35, Sachin Kamat wrote: > These symbols are used only in this file and hence should be > static. > > Signed-off-by: Sachin Kamat > --- > drivers/clk/samsung/clk-exynos4.c | 26 ++ > 1 file ch

[PATCH v3] drm/exynos: hdmi: use drm_display_mode to check the supported modes

2013-04-29 Thread Rahul Sharma
Exynos hdmi driver is using drm_display_mode for setting timing values for a supported resolution. Conversion to fb_videomode and then comparing with the mixer/hdmi/phy limits is not required. Instead, drm_display_mode fields cane be directly compared. v3: 1) Replaced check_timing callbacks with c