Re: [PATCH v5 7/7] clk: samsung: Add EPLL and VPLL freq table for exynos5250 SoC

2013-06-18 Thread Vikas Sajjan
Hi Andrew, On 18 June 2013 01:38, Andrew Bresticker wrote: >> +static __initdata struct samsung_pll_rate_table epll_24mhz_tbl[] = { >> + /* sorted in descending order */ >> + /* PLL_36XX_RATE(rate, m, p, s, k) */ >> + PLL_36XX_RATE(19200, 48, 3, 1, 0), >> + PLL_36XX_RA

Re: [PATCH v3 07/10] ARM: dts: Add initial device tree support for Exynos5420

2013-06-18 Thread Tomasz Figa
On Tuesday 18 of June 2013 09:51:14 Chander Kashyap wrote: > On 17 June 2013 17:14, Tomasz Figa wrote: > > -- > > Tomasz Figa > > Linux Kernel Developer > > Samsung R&D Institute Poland > > Samsung Electronics > > > > On Monday 17 of June 2013 16:30:32 Chander Kashyap wrote: > >> Add initial devi

Re: [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs

2013-06-18 Thread amit daniel kachhap
Hi Eduardo, On Tue, Jun 18, 2013 at 5:04 AM, Eduardo Valentin wrote: > Arnd, > > On 17-06-2013 15:59, Arnd Bergmann wrote: >> On Monday 17 June 2013, Tomasz Figa wrote: >>> diff --git a/drivers/thermal/exynos_thermal.c >>> b/drivers/thermal/exynos_thermal.c >>> index 788b1dd..4cbe3ee 100644 >>>

RE: [PATCH v2 30/38] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Exynos4212 and Exynos4412 SoCs differ only in number of ARM cores and > there is no need to have separate Kconfig options for them, since they > use the same code. > > This patch removes CONFIG_SOC_EXYNOS4412, leaving CONFIG_SOC_EXYNOS4212 > as the one supporting both SoCs

RE: [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to > check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. > > Cc: linux...@vger.kernel.org > Cc: Viresh Kumar > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > drivers/cpufreq

RE: [PATCH v2 32/38] [media] exynos4-is: Remove check for SOC_EXYNOS4412

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to > check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. > > Cc: linux-me...@vger.kernel.org > Cc: Mauro Carvalho Chehab > Cc: Sylwester Nawrocki > Signed-off-by: Tomasz Figa > Signed-off-by: K

RE: [PATCH v2 33/38] thermal: exynos: Remove check for SOC_EXYNOS4412

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to > check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. > > Cc: linux...@vger.kernel.org > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > -

Re: [PATCH v2 30/38] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412

2013-06-18 Thread Tomasz Figa
Hi Kukjin, On Tuesday 18 of June 2013 18:17:14 Kukjin Kim wrote: > Tomasz Figa wrote: > > Exynos4212 and Exynos4412 SoCs differ only in number of ARM cores and > > there is no need to have separate Kconfig options for them, since they > > use the same code. > > > > This patch removes CONFIG_SOC_E

RE: [PATCH v2 36/38] ARM: EXYNOS: Use exynos_init_io() as map_io callback

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Since there is no board specific mapping needed on Exynos, > exynos_init_io() can be simplified and used as map_io callback for both > Exynos4 and Exynos5. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > arch/arm/mach

Re: exynos-drm-next todo work.

2013-06-18 Thread Rahul Sharma
Hi Mr. Dae, Related to HDMI sound support in Alsa, I have posted a working RFC "exynos-hdmi to CDF complaint display driver". It registers a separate sound card by registering hdmi audio codec dai and cpu-dai, as you mentioned. But there is a problem with this approach that I2S being the single cp

Re: [PATCH v2 36/38] ARM: EXYNOS: Use exynos_init_io() as map_io callback

2013-06-18 Thread Tomasz Figa
On Tuesday 18 of June 2013 18:36:16 Kukjin Kim wrote: > Tomasz Figa wrote: > > Since there is no board specific mapping needed on Exynos, > > exynos_init_io() can be simplified and used as map_io callback for both > > Exynos4 and Exynos5. > > > > Signed-off-by: Arnd Bergmann > > Signed-off-by: To

Re: [PATCH v4 00/10] ARM: Exynos: Add Exynos5420 SoC support

2013-06-18 Thread Tomasz Figa
Hi Chander, On Tuesday 18 of June 2013 11:59:12 Chander Kashyap wrote: > Exynos5420 is new SoC in Samsung's Exynos5 SoC series. This series adds > initial support for this SoC. > > Changes since v3: > 1. Updated the max cpu clock frequency in dt node. > 2. Sorted DT nodes alphabetically as sugges

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-18 Thread Rahul Sharma
Thanks all, On Fri, Jun 14, 2013 at 11:39 AM, 김승우 wrote: > Hello Kishon, > > On 2013년 06월 13일 21:54, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 13 June 2013 04:51 PM, Inki Dae wrote: >>> >>> -Original Message- From: Sylwester Nawrocki [mailto:s.nawro...@samsung.com]

Re: [PATCH v4 00/10] ARM: Exynos: Add Exynos5420 SoC support

2013-06-18 Thread Chander Kashyap
On 18 June 2013 15:19, Tomasz Figa wrote: > Hi Chander, > > On Tuesday 18 of June 2013 11:59:12 Chander Kashyap wrote: >> Exynos5420 is new SoC in Samsung's Exynos5 SoC series. This series adds >> initial support for this SoC. >> >> Changes since v3: >> 1. Updated the max cpu clock frequency in dt

Re: [PATCH v4 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined

2013-06-18 Thread Chander Kashyap
On 18 June 2013 12:20, Girish KS wrote: > On Tue, Jun 18, 2013 at 11:59 AM, Chander Kashyap > wrote: >> All Exynos4/5 SoCs share a common driver data in the samsung serial >> driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS >> instead of SOC specific definition. >> >> Signed-o

RE: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi All, > > As I promised, I am doing some spring (or rather summer) cleaning > of Exynos- and Samsung- related code. > > This first part consists mostly of removing dead code remaining after > removal of ATAGS support for Exynos, but several patches cleans up > other thin

RE: [PATCH v4 00/10] ARM: Exynos: Add Exynos5420 SoC support

2013-06-18 Thread Kukjin Kim
Chander Kashyap wrote: > > Exynos5420 is new SoC in Samsung's Exynos5 SoC series. This series adds > initial support for this SoC. > > Changes since v3: > 1. Updated the max cpu clock frequency in dt node. > 2. Sorted DT nodes alphabetically as suggested by Kukjin. > 3. Removed the duplicate comm

RE: [PATCH v4 06/10] clk: exynos5420: register clocks using common clock framework

2013-06-18 Thread Kukjin Kim
Chander Kashyap wrote: > > The Exynos5420 clocks are statically listed and registered using the > Samsung specific common clock helper functions. > > Signed-off-by: Chander Kashyap > Signed-off-by: Thomas Abraham > Reviewed-by: Tomasz Figa (+ Mike) Mike, I'm going to apply this v4 change wit

RE: [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined

2013-06-18 Thread Kukjin Kim
Kukjin Kim wrote: > > Chander Kashyap wrote: > > > > All Exynos4/5 SoCs share a common driver data in the samsung serial > > driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS > > instead of SOC specific definition. > > > > Signed-off-by: Chander Kashyap > > (+ Greg, Jiri) > >

Re: [PATCH v4 00/10] ARM: Exynos: Add Exynos5420 SoC support

2013-06-18 Thread Chander Kashyap
On 18 June 2013 15:56, Kukjin Kim wrote: > Chander Kashyap wrote: >> >> Exynos5420 is new SoC in Samsung's Exynos5 SoC series. This series adds >> initial support for this SoC. >> >> Changes since v3: >> 1. Updated the max cpu clock frequency in dt node. >> 2. Sorted DT nodes alphabetically as sug

RE: [PATCH 0/2] Enable config options to enable S2R wakeup

2013-06-18 Thread Kukjin Kim
Olof Johansson wrote: > > On Mon, Jun 17, 2013 at 09:48:04AM +0530, Tushar Behera wrote: > > RTC source is very useful in testing S2R wakeup. Also enable > > gpio-keys driver in case someone wants wakeup the board using > > the buttons. > > > > S2R wakeup feature on Arndale depends on following tw

Re: [PATCH v2 0/4] ARM: dts: Add LCD and PWM support for exynos4210-origen

2013-06-18 Thread Sachin Kamat
Ping Kukjin. On 11 June 2013 11:59, Sachin Kamat wrote: > This series is based on for-next branch of Kukjin's tree. > Tested on Origen board. > > Changes since v1: > * Split LCD patch into LCD and PWM as suggested by Tomasz Figa. > * Added all PWM output nodes to pinctrl dtsi file. > > Sachin Kam

Re: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Tomasz Figa
On Tuesday 18 of June 2013 19:23:29 Kukjin Kim wrote: > Tomasz Figa wrote: > > Hi All, > > > > As I promised, I am doing some spring (or rather summer) cleaning > > of Exynos- and Samsung- related code. > > > > This first part consists mostly of removing dead code remaining after > > removal of A

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:33 PM, Rahul Sharma wrote: > Thanks all, > > On Fri, Jun 14, 2013 at 11:39 AM, 김승우 wrote: >> Hello Kishon, >> >> On 2013년 06월 13일 21:54, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Thursday 13 June 2013 04:51 PM, Inki Dae wrote: > -Original M

Re: [PATCH 7/9] drm/exynos: use of_get_named_gpio to get hdmi hpd gpio

2013-06-18 Thread Rahul Sharma
Thanks Mr. Dae, Please discard the REST of the patches in this series. I am posting a another patch-set which has all the patches independent of hdmiphy related changes. regards, Rahul Sharma. On Mon, Jun 17, 2013 at 8:22 AM, Inki Dae wrote: > Applied. > > Thanks, > Inki Dae > > > 2013/6/14 김승우

[PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-18 Thread Rahul Sharma
This patch renames the combatible strings for hdmi, mixer, ddc and hdmiphy. It follows the convention of using compatible string which represent the SoC in which the IP was added for the first time. Signed-off-by: Rahul Sharma --- Documentation/devicetree/bindings/video/exynos_hdmi.txt|6

[PATCH 0/4] exynos5420/hdmi: add support for hdmi subsystem

2013-06-18 Thread Rahul Sharma
Add support for exynos5420 hdmi subsystem. It adds compatible strings for exynos5420 mixer and Changes the drivers as per IP modifications. This set doesn't have changes for hdmiphy, which will posted independently. This set is based on drm-next branch of Inki Dae's tree at http://git.kernel.org/

[PATCH 2/4] drm/exynos: add support for exynos5420 mixer

2013-06-18 Thread Rahul Sharma
Add support for exynos5420 mixer IP in the drm mixer driver. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 49 + drivers/gpu/drm/exynos/regs-mixer.h |7 + 2 files changed, 44 insertions(+), 12 deletions(-) diff --git a/driver

[PATCH 3/4] drm/exynos: fix interlace resolutions for exynos5420

2013-06-18 Thread Rahul Sharma
Modified code for calculating hdmi IP register values from drm timing values. The modification is based on the inputs from hw team and specifically proposed for 1440x576i and 1440x480i. But same changes holds good for other interlaced resolutions also. Signed-off-by: Rahul Sharma --- drivers/gpu

[PATCH 4/4] ARM/dts: change compatible strings for hdmi subsystem

2013-06-18 Thread Rahul Sharma
This patch renames the combatible strings for hdmi, mixer, ddc and hdmiphy. It follows the convention of using compatible string which represent the SoC in which the IP was added for the first time. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/cros5250-common.dtsi|4 ++-- arch/arm/b

Re: [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Eduardo Valentin wrote: > The driver will work on supported exynos variants. Those that have the > need for thermal sensing. And each of them have specific thermal needs > (trigger points, thresholds, etc). That is what this file tries to > isolate. And there is specific da

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Jingoo Han wrote: > On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > > > > > Please look up the documentation about inbound viewport and describe

Re: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Chander Kashyap wrote: > >> + [Core Clocks] > >> + > >> + Clock ID > >> + > >> + > >> + fin_pll1 > >> + > >> + [Clock Gate for Special Clocks] > >> + > >> + Clock ID > >> + --

[PATCH 4/5] clk/exynos5420: add hdmi mux to change parents in hdmi driver

2013-06-18 Thread Rahul Sharma
hdmi driver needs to change the parent of hdmi clock to pixel clock or hdmiphy clock, based on the stability of hdmiphy. This patch is exposing the mux for changing the parent. Signed-off-by: Rahul Sharma --- Documentation/devicetree/bindings/clock/exynos5420-clock.txt |5 + drivers/clk/

[PATCH 3/5] clk/exynos5420: fix the order of parents of hdmi mux

2013-06-18 Thread Rahul Sharma
Listing sclk_hdmiphy at 0th position in the list of parents is causing wrong configuration in reg SRC_DISP10. Signed-off-by: Rahul Sharma --- drivers/clk/samsung/clk-exynos5420.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos5420.c b/driver

[PATCH 5/5] clk/exynos5420: assign sclk_pixel id to pixel clock divider

2013-06-18 Thread Rahul Sharma
sclk_pixel is used to represent pixel clock divider on all exynos SoCs not as a gate clock. It is queried in driver to pass as the parent to hdmi clock while switching between parents. A new ID can be asssigned Pixel gate clock which is currently not in use. Pixel clock gate is default 'on'. Signe

[PATCH 2/5] clk/exynos5420: add gate clock for tv sysmmu

2013-06-18 Thread Rahul Sharma
Adding sysmmu clock for tv for exynos5420. Signed-off-by: Rahul Sharma --- Documentation/devicetree/bindings/clock/exynos5420-clock.txt |1 + drivers/clk/samsung/clk-exynos5420.c |3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/d

[PATCH 1/5] clk/exynos5420: add sclk_hdmiphy to the list of special clocks

2013-06-18 Thread Rahul Sharma
Add sclk_hdmiphy to the list of exposed clocks. This is required by hdmi driver to change the parent of hdmi clock. Signed-off-by: Rahul Sharma --- Documentation/devicetree/bindings/clock/exynos5420-clock.txt |1 + drivers/clk/samsung/clk-exynos5420.c |4 ++-- 2 f

[PATCH 0/5] clk/exynos5420: add clocks for hdmi subsystem

2013-06-18 Thread Rahul Sharma
Add clock changes for hdmi subsystem for exynos5250 SoC. These include addition of new clocks like mout_hdmi and smmu_tv, associating ID to clk_hdmiphy and some essential corrections. This set is based on kukjin's for-next branch at http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.g

Re: [PATCH 5/5] clk/exynos5420: assign sclk_pixel id to pixel clock divider

2013-06-18 Thread Rahul Sharma
With this patch, it is at par with Exynos5250 and Exynos4 clocks where sclk_pixel ID is assigned to a divider clock but in real, sclk_pixel is listed under gate clocks (enum value). Alternate to this, I can allocate a new ID, div_pixel, listed under new category of Divider Clocks for Exyno4, 5250

Re: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework

2013-06-18 Thread Tomasz Figa
Hi Arnd, On Tuesday 18 of June 2013 16:01:16 Arnd Bergmann wrote: > On Tuesday 18 June 2013, Chander Kashyap wrote: > > >> + [Core Clocks] > > >> + > > >> + Clock ID > > >> + > > >> + > > >> + fin_pll1 > > >> + > > >> + [Clock

[PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
S5P_ARM_CORE1_* registers affect only core 1. To control further cores properly another registers must be used. This patch replaces S5P_ARM_CORE1_* register definitions with S5P_ARM_CORE_*(x) macro which return addresses of registers for specified core. This fixes CPU hotplug on quad core Exynos

Re: [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined

2013-06-18 Thread 'Greg Kroah-Hartman'
On Tue, Jun 18, 2013 at 07:31:06PM +0900, Kukjin Kim wrote: > Kukjin Kim wrote: > > > > Chander Kashyap wrote: > > > > > > All Exynos4/5 SoCs share a common driver data in the samsung serial > > > driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS > > > instead of SOC specific de

linux-next: origen build failed at drivers/pinctrl/pinctrl-exynos.c

2013-06-18 Thread Naresh Kamboju
Hi, linux-next branch failed to build origen build defconfig: exynos_defconfig full build log: https://ci.linaro.org/jenkins/job/linux-next/hwpack=origen,label=kernel_cloud/72/console build error log: 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/orig

Re: linux-next: origen build failed at drivers/pinctrl/pinctrl-exynos.c

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Naresh Kamboju wrote: > Hi, > > linux-next branch failed to build origen build > > defconfig: exynos_defconfig > > full build log: > > https://ci.linaro.org/jenkins/job/linux-next/hwpack=origen,label=kernel_cloud/72/console > > build error log: > --

Re: linux-next: origen build failed at drivers/pinctrl/pinctrl-exynos.c

2013-06-18 Thread Olof Johansson
Hi, On Tue, Jun 18, 2013 at 9:19 AM, Naresh Kamboju wrote: > Hi, > > linux-next branch failed to build origen build > > defconfig: exynos_defconfig This was broken yesterday and fixed today. Getting linux-next build error reports that are 24+ hours old isn't very useful, unfortunately. It'd al

Re: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Tomasz Figa wrote: > This is a binding that has been defined for Samsung Common Clock Framework > drivers. Exynos4 and Exynos5250 use the same convention. The numbers are > defined in a way that should allow adding further clocks of particular types > in > future as nee

Re: [PATCH 0/5] clk/exynos5250: add clocks for hdmi subsystem

2013-06-18 Thread Kukjin Kim
On 06/18/13 14:09, Rahul Sharma wrote: Hi Mr. Kukjin, Kindly consider the following patches for review and integration. (+ Mike) Rahul, basically, looks good to me but I'm waiting for Mike's ack on this series... regards, Rahul Sharma. On Fri, Jun 14, 2013 at 3:39 PM, Arun Kumar K wrote

Re: [PATCH v2 0/4] ARM: dts: Add LCD and PWM support for exynos4210-origen

2013-06-18 Thread Kukjin Kim
On 06/11/13 15:29, Sachin Kamat wrote: This series is based on for-next branch of Kukjin's tree. Tested on Origen board. Changes since v1: * Split LCD patch into LCD and PWM as suggested by Tomasz Figa. * Added all PWM output nodes to pinctrl dtsi file. Sachin Kamat (3): ARM: dts: exynos4210

Re: [PATCH 3/3] ARM: S3C24XX: update uart addresses in s3c2416-dt auxdata

2013-06-18 Thread Kukjin Kim
On 06/14/13 07:46, Heiko Stübner wrote: Commit 9ee51f01eee8 (tty: serial/samsung: make register definitions global) removed the S3C2410_PA_UARTX defines that the newly merged s3c2416 dt support still expected. So update mach-s3c2416-dt.c to use the S3C24XX_PA_UART constant until we have support

[PATCH] clocksource: samsung_pwm: Correct definition of AUTORELOAD bit

2013-06-18 Thread Tomasz Figa
PWM channel 4 (logically channel 5 in TCON register) has its autoreload bit located at different position. This patch fixes the driver to account for this. This fixes a problem with clocksource hanging after it overflows because it is not reloaded any more. Signed-off-by: Tomasz Figa --- driver

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
Ccing Arnd and Olof, because I forgot to add them to git send-email... Sorry for the noise. On Tuesday 18 of June 2013 17:26:31 Tomasz Figa wrote: > S5P_ARM_CORE1_* registers affect only core 1. To control further cores > properly another registers must be used. > > This patch replaces S5P_ARM_C

Re: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Kukjin Kim
On 06/18/13 20:11, Tomasz Figa wrote: On Tuesday 18 of June 2013 19:23:29 Kukjin Kim wrote: Tomasz Figa wrote: Hi All, As I promised, I am doing some spring (or rather summer) cleaning of Exynos- and Samsung- related code. This first part consists mostly of removing dead code remaining after

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
Hi Thierry, On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: > > This patch introduces new Samsung PWM driver, which uses Samsung > > PWM/timer master driver to control shared parts of the hardware. > > > > Signed-off-by: Toma

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Kukjin Kim
On 06/19/13 02:45, Tomasz Figa wrote: Ccing Arnd and Olof, because I forgot to add them to git send-email... Sorry for the noise. On Tuesday 18 of June 2013 17:26:31 Tomasz Figa wrote: S5P_ARM_CORE1_* registers affect only core 1. To control further cores properly another registers must be use

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Kukjin Kim
On 06/19/13 02:59, Tomasz Figa wrote: Hi Thierry, [...] +static void pwm_samsung_set_divisor(struct samsung_pwm_chip *pwm, + unsigned int channel, u8 divisor) Nit: please align arguments on subsequent lines with the first argument of the first line. Th

Re: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Tomasz Figa
On Wednesday 19 of June 2013 02:51:56 Kukjin Kim wrote: > On 06/18/13 20:11, Tomasz Figa wrote: > > On Tuesday 18 of June 2013 19:23:29 Kukjin Kim wrote: > >> Tomasz Figa wrote: > >>> Hi All, > >>> > >>> As I promised, I am doing some spring (or rather summer) cleaning > >>> of Exynos- and Samsung

Re: [PATCH V2 2/3] pinctrl: exynos: add exynos5420 SoC specific data

2013-06-18 Thread Doug Anderson
Leela, On Fri, Jun 14, 2013 at 6:02 AM, Leela Krishna Amudala wrote: > + EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpz", 0x00), Andrew realized that gpz only has 7 pins, not 8. Can you fix in your next spin? It looks like Tomasz has requested a spin anyway. -Doug -- To unsubscribe from this list

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
On Wednesday 19 of June 2013 03:06:31 Kukjin Kim wrote: > On 06/19/13 02:59, Tomasz Figa wrote: > > Hi Thierry, > > [...] > > >>> +static void pwm_samsung_set_divisor(struct samsung_pwm_chip *pwm, > >>> + unsigned int channel, u8 divisor) > >> > >> Nit: please ali

Re: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Tomasz Figa wrote: > OK. Looking forward to it. > > Btw. This leaves us with two things broken: > - sdhci-s3c checks for defined(CONFIG_SOC_EXYNOS4212), but does not check > for defined(CONFIG_SOC_EXYNOS4412), > - exynos-thermal checks for defined(CONFIG_SOC_EXYNOS4412)

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: > > This patch introduces new Samsung PWM driver, which uses Samsung > > PWM/timer master driver to control shared parts of the hardware. > > > > Signed-off-by: Tomasz Figa > >

[GIT PULL 03/10] Samsung EXYNOS DT-2 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit a38089057fa450944f2e2d07885d76fd727c8d16: ARM: dts: add ohci and ehci controller nodes for EXYNOS5440 (2013-06-12 04:58:34 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/exynos-d

[GIT PULL 00/10] Samsung 2nd pull-request for v3.11

2013-06-18 Thread Kukjin Kim
Hi Arnd, Olof This is 2nd pull-request for Samsung stuff for v3.11. This is including following branches. v3.11-next/cleanup-samsung v3.11-next/exynos-arch-2 v3.11-next/exynos-dt-2 v3.11-next/s3c24xx-dt-2 v3.11-next/dt-n-clk-audio v3.11-next/remove-nondt-exynos-3 v3.11-next/s3c24xx-pinctrl-2 v3.

[GIT PULL 02/10] Samsung EXYNOS arch for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/exynos-arch-2 for you to fetch changes up to b5f3c75a

[GIT PULL 01/10] Samsung cleanup-1 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-cleanup-1 for you to fetch changes up to db3

[GIT PULL 10/10] Samsung non-critical-fixes-1 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/non-critical-fixes-1 for you to fetch changes up to 3

[GIT PULL 09/10] Samsung exynos_defconfig for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-defconfig-1 for you to fetch changes up to 85

[GIT PULL 06/10] Samsung non-DT EXYNOS for v3.11

2013-06-18 Thread Kukjin Kim
Hi Arnd, Olof, Probably happens merge conflicts :( Note, following is my resolution for it. If any problems, please kindly let me know. Thanks, - Kukjin Conflicts: arch/arm/Kconfig arch/arm/mach-exynos/Kconfig diff --cc arch/arm/Kconfig index 7f6dff7,14f6e11..ddf2667 --- a/arc

[GIT PULL 08/10] Samsung SoC EXYNOS5420 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 79d743c177f99d6854e152d9e7fac5bbbeb7c25e: clk: exynos5250: Add enum entries for divider clock of i2s1 and i2s2 (2013-06-19 03:28:43 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags

[GIT PULL 07/10] Samsung S3C24XX PINCTRL-2 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit af99a7507469d4fa6dd4d8d633e093b1ff7aff6e: pinctrl: Add pinctrl-s3c24xx driver (2013-05-21 00:56:13 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/s3c24xx-pinctrl-2 for you to fet

[GIT PULL 04/10] Samsung S3C24XX DT-2 for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 35aca36450e6c3fb3b3fe9ea60a7c4689a219a87: ARM: dts: add devicetree support for s3c2416-smdk2416 (2013-05-21 01:06:12 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/s3c24xx-dt-2

[GIT PULL 05/10] Samsung common clk audio for v3.11

2013-06-18 Thread Kukjin Kim
The following changes since commit 166bc934f54cef4588fc141e709e376244e70106: Merge branch 'v3.11-next/s3c24xx-dt-2' into v3.11-next/dt-n-clk-audio (2013-06-19 03:27:44 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git ta

Re: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup

2013-06-18 Thread Olof Johansson
On Tue, Jun 18, 2013 at 11:29 AM, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Tomasz Figa wrote: >> OK. Looking forward to it. >> >> Btw. This leaves us with two things broken: >> - sdhci-s3c checks for defined(CONFIG_SOC_EXYNOS4212), but does not check >> for defined(CONFIG_SOC_EXYNOS4412),

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Thierry Reding
On Tue, Jun 18, 2013 at 08:13:51PM +0200, Tomasz Figa wrote: > On Wednesday 19 of June 2013 03:06:31 Kukjin Kim wrote: > > On 06/19/13 02:59, Tomasz Figa wrote: > > > Hi Thierry, > > > > [...] > > > > >>> +static void pwm_samsung_set_divisor(struct samsung_pwm_chip *pwm, > > >>> +

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
On Tuesday 18 of June 2013 23:33:45 Thierry Reding wrote: > On Tue, Jun 18, 2013 at 08:13:51PM +0200, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 03:06:31 Kukjin Kim wrote: > > > On 06/19/13 02:59, Tomasz Figa wrote: > > > > Hi Thierry, > > > > > > [...] > > > > > > >>> +static void pwm_s

Re: [PATCH] MAINTAINERS: Update S5P/Exynos FIMC driver entry

2013-06-18 Thread Sylwester Nawrocki
Hi Sachin, Thanks for your review. On 06/18/2013 05:39 AM, Sachin Kamat wrote: Hi Sylwester, Just a couple of nits inline. On 17 June 2013 22:12, Sylwester Nawrocki wrote: This change is mainly to update the driver's path changed from drivers/media/platform/s5p-fimc to drivers/media/platfor

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Thierry Reding
On Tue, Jun 18, 2013 at 09:41:09PM +0200, Tomasz Figa wrote: > On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: [...] > > > +struct samsung_pwm_channel { > > > + unsigned long period_ns; > > > + unsigned long duty_ns; > > > +

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
On Tuesday 18 of June 2013 23:40:23 Thierry Reding wrote: > On Tue, Jun 18, 2013 at 09:41:09PM +0200, Tomasz Figa wrote: > > On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > > > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: > [...] > > > > > +struct samsung_pwm_channel { >

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Thierry Reding
On Mon, Jun 17, 2013 at 10:50:40PM +0200, Tomasz Figa wrote: > On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: [...] > > > +#ifndef CONFIG_CLKSRC_SAMSUNG_PWM > > > +static DEFINE_SPINLOCK(samsung_pwm_lock); > > > +#endif > >

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Thierry Reding
On Tue, Jun 18, 2013 at 11:42:37PM +0200, Tomasz Figa wrote: > On Tuesday 18 of June 2013 23:40:23 Thierry Reding wrote: > > On Tue, Jun 18, 2013 at 09:41:09PM +0200, Tomasz Figa wrote: > > > On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > > > > On Wed, Jun 05, 2013 at 11:18:13PM +0200,

Re: [PATCH 08/15] pwm: Add new pwm-samsung driver

2013-06-18 Thread Tomasz Figa
On Wednesday 19 of June 2013 00:17:06 Thierry Reding wrote: > On Mon, Jun 17, 2013 at 10:50:40PM +0200, Tomasz Figa wrote: > > On Monday 17 of June 2013 22:29:11 Thierry Reding wrote: > > > On Wed, Jun 05, 2013 at 11:18:13PM +0200, Tomasz Figa wrote: > [...] > > > > > +#ifndef CONFIG_CLKSRC_SAMSUN

Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

2013-06-18 Thread Jingoo Han
On Tuesday, June 18, 2013 10:57 PM, Arnd Bergmann wrote: > On Tuesday 18 June 2013, Jingoo Han wrote: > > On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote: > > > On Monday 17 June 2013 18:45:52 Jingoo Han wrote: > > > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote: > > > > > [.]

Re: [GIT PULL 00/10] Samsung 2nd pull-request for v3.11

2013-06-18 Thread Sachin Kamat
Hi Kukjin, On 19 June 2013 01:29, Kukjin Kim wrote: > Hi Arnd, Olof > > This is 2nd pull-request for Samsung stuff for v3.11. > > This is including following branches. > v3.11-next/cleanup-samsung > v3.11-next/exynos-arch-2 > v3.11-next/exynos-dt-2 > v3.11-next/s3c24xx-dt-2 > v3.11-next/dt-n-clk-

Re: [PATCH 0/5] clk/exynos5420: add clocks for hdmi subsystem

2013-06-18 Thread Rahul Sharma
+ mike On Tue, Jun 18, 2013 at 8:03 PM, Rahul Sharma wrote: > Add clock changes for hdmi subsystem for exynos5250 SoC. These > include addition of new clocks like mout_hdmi and smmu_tv, associating > ID to clk_hdmiphy and some essential corrections. > > This set is based on kukjin's for-next bran

RE: exynos-drm-next todo work.

2013-06-18 Thread Inki Dae
> -Original Message- > From: Rahul Sharma [mailto:r.sh.o...@gmail.com] > Sent: Tuesday, June 18, 2013 6:46 PM > To: Inki Dae > Cc: linux-samsung-soc@vger.kernel.org; DRI mailing list > Subject: Re: exynos-drm-next todo work. > > Hi Mr. Dae, > > Related to HDMI sound support in Alsa, I h

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-18 Thread Tushar Behera
On 06/17/2013 10:20 AM, Tushar Behera wrote: > On 06/11/2013 12:23 AM, Tomasz Figa wrote: >> On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: >>> On 06/08/2013 05:20 PM, Tomasz Figa wrote: On Thursday 06 of June 2013 16:52:28 Tushar Behera wrote: > > [ ... ] > > MUX_A(mout_core,

Re: [PATCH 2/4] drm/exynos: add support for exynos5420 mixer

2013-06-18 Thread 김승우
Hi Rahul, Code part looks good to me but IMHO, binding document for exynos_mixer is also fixed like following because compitable string samsung,exynos5420-mixer is added with this patch. Required properties: - compatible: value should be: 1) "samsung,exynos4210-mixer" 2) "samsun

Re: [PATCH 2/4] drm/exynos: add support for exynos5420 mixer

2013-06-18 Thread Rahul Sharma
Sure Seung-Woo, I will update binding document along with this patch. regards, Rahul Sharma. On Wed, Jun 19, 2013 at 10:54 AM, 김승우 wrote: > Hi Rahul, > > Code part looks good to me but IMHO, binding document for exynos_mixer > is also fixed like following because compitable string > samsung,exy

Re: [PATCH 3/4] drm/exynos: fix interlace resolutions for exynos5420

2013-06-18 Thread 김승우
Hi Rahul, This patch looks good to me. On 2013년 06월 18일 21:49, Rahul Sharma wrote: > Modified code for calculating hdmi IP register values from drm timing > values. The modification is based on the inputs from hw team and specifically > proposed for 1440x576i and 1440x480i. But same changes holds

Re: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-18 Thread 김승우
Hi Rahul, It looks good, at least, to me. Best Regards, - Seung-Woo Kim On 2013년 06월 18일 21:49, Rahul Sharma wrote: > This patch renames the combatible strings for hdmi, mixer, ddc > and hdmiphy. It follows the convention of using compatible string > which represent the SoC in which the IP was a

RE: [PATCH 3/4] drm/exynos: fix interlace resolutions for exynos5420

2013-06-18 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: 김승우 [mailto:sw0312@samsung.com] > Sent: Wednesday, June 19, 2013 2:34 PM > To: Rahul Sharma > Cc: linux-samsung-soc@vger.kernel.org; devicetree- disc...@lists.ozlabs.org; > dri-de...@lists.freedesktop.org; kgene@samsung.com; >

Re: linux-next: origen build failed at drivers/pinctrl/pinctrl-exynos.c

2013-06-18 Thread Naresh Kamboju
Hi Olof, I will give you Kernel head commit ID of linux-next. Thanks for the feedback. Best regards Naresh Kamboju On 18 June 2013 22:33, Olof Johansson wrote: > Hi, > > > On Tue, Jun 18, 2013 at 9:19 AM, Naresh Kamboju > wrote: >> Hi, >> >> linux-next branch failed to build origen build >> >>

[PATCH v2 2/4] drm/exynos: add support for exynos5420 mixer

2013-06-18 Thread Rahul Sharma
Add support for exynos5420 mixer IP in the drm mixer driver. Signed-off-by: Rahul Sharma --- .../devicetree/bindings/video/exynos_mixer.txt |1 + drivers/gpu/drm/exynos/exynos_mixer.c | 49 +++- drivers/gpu/drm/exynos/regs-mixer.h|7 +++

Re: [PATCH v2 2/4] drm/exynos: add support for exynos5420 mixer

2013-06-18 Thread 김승우
On 2013년 06월 19일 15:50, Rahul Sharma wrote: > Add support for exynos5420 mixer IP in the drm mixer driver. > > Signed-off-by: Rahul Sharma Acked-by: Seung-Woo Kim This patch can be merged after merging "[PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem". Best Regards, - Seu

[PATCH V3 0/2] Add pinctrl support to Exynos5420

2013-06-18 Thread Leela Krishna Amudala
This patchset adds the pinctrl support to Exynos5420. This series is rebased and tested on for-next branch of kgene tree. Changes since V2: - As Tomasz figa suggested, changed the sd0_bus4, sd1_bus4 and sd2_bus4 nodes in pinctrl file so that gpio pins don't overlap between group

[PATCH V3 2/2] pinctrl: exynos: add exynos5420 SoC specific data

2013-06-18 Thread Leela Krishna Amudala
Add Samsung Exynos5420 SoC specific data to enable pinctrl support for all platforms based on Exynos5420. Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Reviewed-by: Tomasz Figa Acked-by: Linus Walleij --- .../bindings/pinctrl/samsung-pinctrl.txt |1 + drivers/p

[PATCH V3 1/2] ARM: dts: add pinctrl support to Exynos5420

2013-06-18 Thread Leela Krishna Amudala
Add the required pin configuration support to Exynos5420 using pinctrl interface. Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 680 + arch/arm/boot/dts/exynos5420.dtsi