Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Tomasz Figa
On Saturday 29 of June 2013 00:27:04 Daniel Lezcano wrote: > On 06/28/2013 07:31 PM, Tomasz Figa wrote: > > On Friday 28 of June 2013 13:20:09 Daniel Lezcano wrote: > [ ... ] > > >> The kernel is not a playground where you can upstream code and then > >> remove it because a feature seems broken an

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Tomasz Figa
On Friday 28 of June 2013 23:47:49 Daniel Lezcano wrote: > On 06/28/2013 06:27 PM, Bartlomiej Zolnierkiewicz wrote: > > On Friday, June 28, 2013 01:20:09 PM Daniel Lezcano wrote: > >> On 06/28/2013 12:11 PM, Tomasz Figa wrote: > >>> Hi Daniel, > >>> > >>> I've been fighting with this whole AFTR st

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Daniel Lezcano
On 06/28/2013 07:31 PM, Tomasz Figa wrote: > On Friday 28 of June 2013 13:20:09 Daniel Lezcano wrote: [ ... ] >> The kernel is not a playground where you can upstream code and then >> remove it because a feature seems broken and you don't have an idea of >> why. > > Well, first of all, it has no

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Daniel Lezcano
On 06/28/2013 06:27 PM, Bartlomiej Zolnierkiewicz wrote: > On Friday, June 28, 2013 01:20:09 PM Daniel Lezcano wrote: >> On 06/28/2013 12:11 PM, Tomasz Figa wrote: >>> Hi Daniel, >>> >>> I've been fighting with this whole AFTR state as well, before Bartlomiej. >>> Let me share my thoughts on this.

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Tomasz Figa
On Friday 28 of June 2013 13:20:09 Daniel Lezcano wrote: > On 06/28/2013 12:11 PM, Tomasz Figa wrote: > > Hi Daniel, > > > > I've been fighting with this whole AFTR state as well, before > > Bartlomiej. Let me share my thoughts on this. > > > > On Friday 28 of June 2013 11:57:25 Daniel Lezcano wr

[PATCH v2] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Bartlomiej Zolnierkiewicz
After conversion to using device tree only (no board files) on mach-exynos using exynos4_defconfig results in unbootable kernel (I used next-20130626): --- Uncompressing Linux... done, booting the kernel. Booting Linux on physical CPU 0x900 Linux version 3.10.0-rc7-next-20130626-dirty (bzolnier@am

Re: Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Bartlomiej Zolnierkiewicz
On Friday, June 28, 2013 01:20:09 PM Daniel Lezcano wrote: > On 06/28/2013 12:11 PM, Tomasz Figa wrote: > > Hi Daniel, > > > > I've been fighting with this whole AFTR state as well, before Bartlomiej. > > Let me share my thoughts on this. > > > > On Friday 28 of June 2013 11:57:25 Daniel Lezcano

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Tomasz Figa
Hi Lorenzo, On Friday 28 of June 2013 12:13:33 Lorenzo Pieralisi wrote: > On Fri, Jun 28, 2013 at 11:11:24AM +0100, Tomasz Figa wrote: > > Hi Daniel, > > > > I've been fighting with this whole AFTR state as well, before > > Bartlomiej. Let me share my thoughts on this. > > > > On Friday 28 of Ju

Re: [PATCH] mfd: sec: Remove fields not used since regmap conversion

2013-06-28 Thread Samuel Ortiz
Hi Mark, On Fri, Jun 28, 2013 at 03:12:23PM +0100, Mark Brown wrote: > From: Mark Brown > > These were all used by the open coded I/O and IRQ implementations and are > no longer referenced now that the regmap core variants are used instead. > > Signed-off-by: Mark Brown > --- > include/linux/

Re: [PATCH] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Daniel Lezcano
On 06/28/2013 02:45 PM, Bartlomiej Zolnierkiewicz wrote: > On Friday, June 28, 2013 11:51:23 AM Daniel Lezcano wrote: >> On 06/28/2013 11:48 AM, Bartlomiej Zolnierkiewicz wrote: >>> It hasn't been updated since Novemeber 2011 and exynos_defconfig >>> should be used instead. >> >> Why ? > > After c

[PATCH] mfd: sec: Remove fields not used since regmap conversion

2013-06-28 Thread Mark Brown
From: Mark Brown These were all used by the open coded I/O and IRQ implementations and are no longer referenced now that the regmap core variants are used instead. Signed-off-by: Mark Brown --- include/linux/mfd/samsung/core.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/li

[PATCH v4 5/5] ARM: Samsung: Remove the MIPI PHY setup code

2013-06-28 Thread Sylwester Nawrocki
Generic PHY drivers are used to handle the MIPI CSIS and MIPI DSIM DPHYs so we can remove now unused code at arch/arm/plat-samsung. In case there is any board file for S5PV210 platforms using MIPI CSIS/DSIM (not any upstream currently) it should use the generic PHY API to bind the PHYs to respectiv

[PATCH v4 4/5] [media] exynos4-is: Use the generic MIPI CSIS PHY driver

2013-06-28 Thread Sylwester Nawrocki
Use the generic PHY API instead of the platform callback to control the MIPI CSIS DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-by: Mauro Car

[PATCH v4 2/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-28 Thread Sylwester Nawrocki
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi --- Changes since v3: - replaced spin_(un)lock_irq_{save,restore} with spin_{lock,unlock}. - DT bi

[PATCH v4 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-06-28 Thread Sylwester Nawrocki
Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi --- arch/arm/boot/dts/exynos4.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/

[PATCH v4 3/5] video: exynos_mipi_dsim: Use the generic PHY driver

2013-06-28 Thread Sylwester Nawrocki
Use the generic PHY API instead of the platform callback to control the MIPI DSIM DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-by: Donghwa

[PATCH v4 0/5] Generic PHY driver for the Exynos SoC MIPI CSI-2/DSI DPHYs

2013-06-28 Thread Sylwester Nawrocki
This patch series adds a simple driver for the Samsung S5P/Exynos SoC series MIPI CSI-2 receiver (MIPI CSIS) and MIPI DSI transmitter (MIPI DSIM) DPHYs, using the generic PHY framework [1]. Previously the MIPI CSIS and MIPI DSIM used a platform callback to control the PHY power enable and reset bit

Re: [PATCH] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Sylwester Nawrocki
On 06/28/2013 11:48 AM, Bartlomiej Zolnierkiewicz wrote: > It hasn't been updated since Novemeber 2011 and exynos_defconfig > should be used instead. > > Cc: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz Since it has been already discus

Re: Re: [PATCH] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Bartlomiej Zolnierkiewicz
On Friday, June 28, 2013 11:51:23 AM Daniel Lezcano wrote: > On 06/28/2013 11:48 AM, Bartlomiej Zolnierkiewicz wrote: > > It hasn't been updated since Novemeber 2011 and exynos_defconfig > > should be used instead. > > Why ? After conversion to using device tree only (no board files) on mach-exyn

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Sylwester Nawrocki
Hi, On 06/28/2013 12:27 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:35 Fri 28 Jun , Felipe Balbi wrote: >> > On Fri, Jun 28, 2013 at 04:18:23PM +0900, Jingoo Han wrote: >>> > > Use the generic PHY API instead of the platform callback to control >>> > > the DP PHY. The 'phy_label' field

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Daniel Lezcano
On 06/28/2013 12:11 PM, Tomasz Figa wrote: > Hi Daniel, > > I've been fighting with this whole AFTR state as well, before Bartlomiej. > Let me share my thoughts on this. > > On Friday 28 of June 2013 11:57:25 Daniel Lezcano wrote: >> On 06/27/2013 08:10 PM, Bartlomiej Zolnierkiewicz wrote: >>> O

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Lorenzo Pieralisi
On Fri, Jun 28, 2013 at 11:11:24AM +0100, Tomasz Figa wrote: > Hi Daniel, > > I've been fighting with this whole AFTR state as well, before Bartlomiej. > Let me share my thoughts on this. > > On Friday 28 of June 2013 11:57:25 Daniel Lezcano wrote: > > On 06/27/2013 08:10 PM, Bartlomiej Zolnierki

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Jean-Christophe PLAGNIOL-VILLARD
On 12:35 Fri 28 Jun , Felipe Balbi wrote: > On Fri, Jun 28, 2013 at 04:18:23PM +0900, Jingoo Han wrote: > > Use the generic PHY API instead of the platform callback to control > > the DP PHY. The 'phy_label' field is added to the platform data > > structure to allow PHY lookup on non-dt platfor

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-28 Thread Sylwester Nawrocki
On 06/28/2013 10:17 AM, Hui Wang wrote: > On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote: >> Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 >> receiver and MIPI DSI transmitter DPHYs. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> --- >> Changes

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Tomasz Figa
Hi Daniel, I've been fighting with this whole AFTR state as well, before Bartlomiej. Let me share my thoughts on this. On Friday 28 of June 2013 11:57:25 Daniel Lezcano wrote: > On 06/27/2013 08:10 PM, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday, June 26, 2013 12:36:12 PM Daniel Lezcano wr

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Sylwester Nawrocki
Hi, On 06/28/2013 11:31 AM, Kishon Vijay Abraham I wrote: >> diff --git >> a/Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt >> new file mode 100644 >> index 000..8b6fa79 >> --- /dev/null

Re: [PATCH 1/3] ARM: EXYNOS: remove non-working AFTR mode support

2013-06-28 Thread Daniel Lezcano
On 06/27/2013 08:10 PM, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, June 26, 2013 12:36:12 PM Daniel Lezcano wrote: >> On 06/26/2013 12:13 PM, Bartlomiej Zolnierkiewicz wrote: >>> AFTR mode support was introduced by commit 67173ca ("ARM: EXYNOS: Add >>> support AFTR mode on EXYNOS4210") in v3.

Re: [PATCH] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Daniel Lezcano
On 06/28/2013 11:48 AM, Bartlomiej Zolnierkiewicz wrote: > It hasn't been updated since Novemeber 2011 and exynos_defconfig > should be used instead. Why ? > Cc: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/configs/ex

[PATCH] ARM: EXYNOS: remove obsolete exynos4_defconfig

2013-06-28 Thread Bartlomiej Zolnierkiewicz
It hasn't been updated since Novemeber 2011 and exynos_defconfig should be used instead. Cc: Tomasz Figa Cc: Kukjin Kim Signed-off-by: Kyungmin Park Signed-off-by: Bartlomiej Zolnierkiewicz --- arch/arm/configs/exynos4_defconfig | 68 -- 1 file changed, 68

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 04:18:23PM +0900, Jingoo Han wrote: > Use the generic PHY API instead of the platform callback to control > the DP PHY. The 'phy_label' field is added to the platform data > structure to allow PHY lookup on non-dt platforms. > > Signed-off-by: Jingoo Han > --- > .../devic

Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote: > Add PHY provider node for the DP PHY. > > Signed-off-by: Jingoo Han > --- > arch/arm/boot/dts/exynos5250.dtsi | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi

Re: [PATCH V2 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 04:15:32PM +0900, Jingoo Han wrote: > Add a PHY provider driver for the Samsung Exynos SoC DP PHY. > > Signed-off-by: Jingoo Han Now that you fixed Kishon's concerns, this looks pretty good: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signatur

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Kishon Vijay Abraham I
Hi, On Friday 28 June 2013 10:52 AM, Jingoo Han wrote: Add a PHY provider driver for the Samsung Exynos SoC DP PHY. Signed-off-by: Jingoo Han --- .../phy/samsung,exynos5250-dp-video-phy.txt|7 ++ drivers/phy/Kconfig|8 ++ drivers/phy/Makefile

Re: [PATCH 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Kishon Vijay Abraham I
Hi, On Friday 28 June 2013 11:34 AM, Jingoo Han wrote: On Friday, June 28, 2013 2:58 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 28 June 2013 10:54 AM, Jingoo Han wrote: Use the generic PHY API instead of the platform callback to control the DP PHY. The 'phy_label' field is added to the

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-28 Thread Hui Wang
On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote: Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v2: - adapted to the generic PHY API v9: use phy_set

[PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Jingoo Han
Use the generic PHY API instead of the platform callback to control the DP PHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms. Signed-off-by: Jingoo Han --- .../devicetree/bindings/video/exynos_dp.txt| 17 --- drivers/video/exynos

[PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

2013-06-28 Thread Jingoo Han
Add PHY provider node for the DP PHY. Signed-off-by: Jingoo Han --- arch/arm/boot/dts/exynos5250.dtsi | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 41cd625..f7bac75 100644 --- a/arc

[PATCH V2 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC DP PHY. Signed-off-by: Jingoo Han --- .../phy/samsung,exynos5250-dp-video-phy.txt|7 ++ drivers/phy/Kconfig|8 ++ drivers/phy/Makefile |3 +- drivers/phy/phy-exy

[PATCH V2 0/3] Generic PHY driver for the Exynos SoC DP PHY

2013-06-28 Thread Jingoo Han
This patch series adds a simple driver for the Samsung Exynos SoC series DP transmitter PHY, using the generic PHY framework [1]. Previously the DP PHY used a platform callback or internal DT node to control the PHY power enable bit. The platform callback and internal DT node can be dropped and thi