Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sascha Hauer
On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Kishon Vijay Abraham I
Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Rob Herring
On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: So I called of_platform_populate() on a device to get each child device probed and on rmmod and I need to reverse its doing. After a quick grep I did what others did as well and rmmod ended in: | Unable to handle kernel NULL pointer

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Alan Stern
On Sun, 21 Jul 2013, Sylwester Nawrocki wrote: What's wrong with the platform_data structure, why can't that be used for this? At the point the platform data of some driver is initialized, e.g. in board setup code the PHY pointer is not known, since the PHY supplier driver has not

[PATCH] ARM: S3C24XX: Add missing clkdev entries for s3c2440 UART

2013-07-21 Thread Sylwester Nawrocki
This patch restores serial port operation which has been broken since commit 60e93575476f90a72146b51283f514da655410a7 serial: samsung: enable clock before clearing pending interrupts during init That commit only uncovered the real issue which was missing clkdev entries for the uart clocks on

Re: [PATCH v4 07/20] ARM: SAMSUNG: Add new PWM platform device

2013-07-21 Thread Sylwester Nawrocki
Hi Tomasz, On 07/20/2013 02:04 AM, Tomasz Figa wrote: This patch adds new samsung_device_pwm platform device that represents the whole PWM/timer block and includes memory and IRQ resources. Signed-off-by: Tomasz Figatomasz.f...@gmail.com --- arch/arm/plat-samsung/devs.c | 17

Re: [PATCH v4 13/20] pwm: Add new pwm-samsung driver

2013-07-21 Thread Sylwester Nawrocki
On 07/20/2013 02:04 AM, Tomasz Figa wrote: This patch introduces new Samsung PWM driver, which uses Samsung PWM/timer master driver to control shared parts of the hardware. Signed-off-by: Tomasz Figatomasz.f...@gmail.com --- drivers/pwm/Makefile | 1 + drivers/pwm/pwm-samsung.c | 606

Re: [PATCH v4 13/20] pwm: Add new pwm-samsung driver

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 21:50:47 Sylwester Nawrocki wrote: On 07/20/2013 02:04 AM, Tomasz Figa wrote: This patch introduces new Samsung PWM driver, which uses Samsung PWM/timer master driver to control shared parts of the hardware. Signed-off-by: Tomasz Figatomasz.f...@gmail.com ---

Re: [PATCH v4 00/20] Samsung PWM support cleanup

2013-07-21 Thread Sylwester Nawrocki
On 07/20/2013 02:04 AM, Tomasz Figa wrote: Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung SoCs. This series attempts to achieve this goal by: 1) fixing up few things in samsung_pwm_timer clocksource

Re: [PATCH v4 00/20] Samsung PWM support cleanup

2013-07-21 Thread Tomasz Figa
On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote: On 07/20/2013 02:04 AM, Tomasz Figa wrote: Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung SoCs. This series attempts to achieve this goal

Re: [PATCH v4 07/20] ARM: SAMSUNG: Add new PWM platform device

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 23:51:24 Tomasz Figa wrote: Hi Sylwester, On Sunday 21 of July 2013 21:46:09 Sylwester Nawrocki wrote: Hi Tomasz, On 07/20/2013 02:04 AM, Tomasz Figa wrote: This patch adds new samsung_device_pwm platform device that represents the whole PWM/timer

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Grant Likely
On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring robherri...@gmail.com wrote: On 07/21/2013 09:42 AM, Rob Herring wrote: On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: So I called of_platform_populate() on a device to get each child device probed and on rmmod and I need to reverse its

Re: [PATCH] watchdog: s3c2410_wdt: code clean up

2013-07-21 Thread Jingoo Han
On Friday, July 19, 2013 5:58 PM, Leela Krishna Amudala wrote: This patch removes the global variables in the driver file and group them into a structure. How about changing the subject as below? [PATCH] watchdog: s3c2410_wdt: remove the global variables [.] -static struct device

RE: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-21 Thread Kukjin Kim
Sachin Kamat wrote: With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols any more) and b910 (ARM: EXYNOS: Remove mach/gpio.h), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like

RE: [PATCH 1/1] of/documentation: Fix a typo in exynos5250-clock.txt

2013-07-21 Thread Kukjin Kim
Sachin Kamat wrote: The clocks should be numbered sequentially as they are represented as enum values in the clock driver. Typo introduced by commit 17d4caccef (clk: exynos5250: register display block gate clocks to common clock framework) Signed-off-by: Sachin Kamat

RE: [PATCH v4 00/20] Samsung PWM support cleanup

2013-07-21 Thread Kukjin Kim
Tomasz Figa wrote: On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote: On 07/20/2013 02:04 AM, Tomasz Figa wrote: Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung SoCs. This series

RE: [PATCH v4 00/20] Samsung PWM support cleanup

2013-07-21 Thread Kukjin Kim
Kukjin Kim wrote: Tomasz Figa wrote: On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote: On 07/20/2013 02:04 AM, Tomasz Figa wrote: Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung

Re: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-21 Thread Sachin Kamat
On 22 July 2013 07:18, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols any more) and b910 (ARM: EXYNOS: Remove mach/gpio.h), the definition of

RE: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-21 Thread Kukjin Kim
Sachin Kamat wrote: On 22 July 2013 07:18, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols any more) and b910 (ARM: EXYNOS: Remove mach/gpio.h),

Re: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-21 Thread Sachin Kamat
On 22 July 2013 09:07, Kukjin Kim kg...@kernel.org wrote: Sachin Kamat wrote: On 22 July 2013 07:18, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols

Re: [PATCH v4 02/20] clocksource: samsung_pwm_timer: Correct definition of AUTORELOAD bit

2013-07-21 Thread Daniel Lezcano
On 07/20/2013 02:04 AM, Tomasz Figa wrote: PWM channel 4 has its autoreload bit located at different position. This patch fixes the driver to account for that. This fixes a problem with the clocksource hanging after it overflows because it is not reloaded any more. Signed-off-by: Tomasz

Re: [PATCH v4 04/20] clocksource: samsung_pwm_timer: Do not use clocksource_mmio

2013-07-21 Thread Daniel Lezcano
On 07/20/2013 02:04 AM, Tomasz Figa wrote: In case of Samsung PWM timer, clocksource MMIO can not be used, because custom suspend/resume callbacks are required. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org Please in the future

Re: [PATCH v4 05/20] clocksource: samsung_pwm_timer: Handle suspend/resume correctly

2013-07-21 Thread Daniel Lezcano
On 07/20/2013 02:04 AM, Tomasz Figa wrote: Current suspend/resume handling of the driver was broken, because: - periodic timer was being enabled in CLOCK_EVT_MODE_RESUME mode, which does not seem to be correct behavior looking at other platforms, - PWM divisors need to be restored, but

Re: [PATCH v4 09/20] ARM: SAMSUNG: Move all platforms to new clocksource driver

2013-07-21 Thread Daniel Lezcano
On 07/20/2013 02:04 AM, Tomasz Figa wrote: This patch moves all Samsung platforms using PWM clocksource from legacy samsung-time to new samsung-pwm-timer driver. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org arch/arm/Kconfig

RE: [PATCH] ARM: S3C24XX: Add missing clkdev entries for s3c2440 UART

2013-07-21 Thread Kukjin Kim
Sylwester Nawrocki wrote: This patch restores serial port operation which has been broken since commit 60e93575476f90a72146b51283f514da655410a7 serial: samsung: enable clock before clearing pending interrupts during init That commit only uncovered the real issue which was missing clkdev

Re: RE: [PATCH 1/1] of/documentation: Fix a typo in exynos5250-clock.txt

2013-07-21 Thread Mike Turquette
Quoting Kukjin Kim (2013-07-21 18:51:54) Sachin Kamat wrote: The clocks should be numbered sequentially as they are represented as enum values in the clock driver. Typo introduced by commit 17d4caccef (clk: exynos5250: register display block gate clocks to common clock framework)

[PATCH v2 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-21 Thread Sachin Kamat
With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols any more) and b910 (ARM: EXYNOS: Remove mach/gpio.h), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like Exynos4412 which have more

Re: RE: [PATCH 1/1] of/documentation: Fix a typo in exynos5250-clock.txt

2013-07-21 Thread Sachin Kamat
On 22 July 2013 10:12, Mike Turquette mturque...@linaro.org wrote: Quoting Kukjin Kim (2013-07-21 18:51:54) Sachin Kamat wrote: The clocks should be numbered sequentially as they are represented as enum values in the clock driver. Typo introduced by commit 17d4caccef (clk: exynos5250:

Re: [PATCH] watchdog: s3c2410_wdt: code clean up

2013-07-21 Thread Leela Krishna Amudala
Hi Jingoo Han, Thanks for reviewing the patch. On Mon, Jul 22, 2013 at 5:44 AM, Jingoo Han jg1@samsung.com wrote: On Friday, July 19, 2013 5:58 PM, Leela Krishna Amudala wrote: This patch removes the global variables in the driver file and group them into a structure. How about

[PATCH] dts: arm: add arm-pmu node for exynos4412

2013-07-21 Thread Chanho Park
The Exynos4412 has 4 cpus and each has a performance counter. Thus, we should define 4 interrupts which are combined by irq-combiner for arm pmu. Signed-off-by: Chanho Park chanho61.p...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4412.dtsi |

[PATCH V2] watchdog: s3c2410_wdt: remove the global variables

2013-07-21 Thread Leela Krishna Amudala
This patch removes the global variables in the driver file and group them into a structure. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- Note: This patch is rebased on kgene's for-next branch and tested on SMDK5420. Changes since V1: - changed the patch subject.