Re: [PATCH 1/2] ARM: dts: exynos4210-origen: Add fixed voltage regulator to simple bus

2013-09-26 Thread Sachin Kamat
Hi Tomasz, On 26 September 2013 13:50, Tomasz Figa wrote: > Hi Sachin, > > I must have missed this patch so better later than never ;). Since you are quite prompt at reviewing I thought you did not have any comments :) > Please see my comments inline. > > On Thursday 26 of September 2013 10:32:

Re: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-09-26 Thread Kishon Vijay Abraham I
Hi Greg, On Friday 27 September 2013 12:21 AM, Greg KH wrote: > On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> T

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-26 Thread Rahul Sharma
On 16 September 2013 18:10, Inki Dae wrote: > CCing devicetree, > >> -Original Message- >> From: Rahul Sharma [mailto:r.sh.o...@gmail.com] >> Sent: Tuesday, September 10, 2013 5:28 PM >> To: Sean Paul >> Cc: Inki Dae; Rahul Sharma; linux-samsung-soc; dri-devel; kgene.kim; >> sw0312.kim; Lu

Re: [PATCH 31/51] DMA-API: media: omap3isp: use dma_coerce_mask_and_coherent()

2013-09-26 Thread Laurent Pinchart
Hi Russell, Thank you for the patch. On Thursday 19 September 2013 22:56:02 Russell King wrote: > The code sequence: > isp->raw_dmamask = DMA_BIT_MASK(32); > isp->dev->dma_mask = &isp->raw_dmamask; > isp->dev->coherent_dma_mask = DMA_BIT_MASK(32); > bypasses the architectures ch

Re: [PATCH 00/51] DMA mask changes

2013-09-26 Thread Rafał Miłecki
2013/9/19 Russell King - ARM Linux : > This email is only being sent to the mailing lists in question, not to > anyone personally. The list of individuals is far to great to do that. > I'm hoping no mailing lists reject the patches based on the number of > recipients. Huh, I think it was enough t

Re: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-09-26 Thread Greg KH
On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote: > Used the generic PHY framework API to create the PHY. Now the power off and > power on are done in omap_usb_power_off and omap_usb_power_on respectively. > The omap-usb2 driver is also moved to driver/phy. > > However using

Re: [RFC 3/3] Samsung: DT: Add Device tree for S5PC110/S5PV210 Boards

2013-09-26 Thread Bartlomiej Zolnierkiewicz
Hi Mateusz, On Thursday, September 26, 2013 06:59:29 PM Mateusz Krawczuk wrote: > Add DTS for s5pc110 boards: goni, aquila, smdkc110 > s5pv210: smdkv210, tiny210 > Torbreck is replaced by FriendlyARM Tiny210 board. Could you please explain what do you mean by "replaced" here? Looking at the cur

[RFC 1/3] ARM: s5pv210: Add board file for boot using Device Tree

2013-09-26 Thread Mateusz Krawczuk
This patch adds board file that will be used to boot S5PV210/S5PC110-based boards using Device Tree. Signed-off-by: Mateusz Krawczuk Signed-off-by: Kyungmin Park --- arch/arm/mach-s5pv210/Kconfig | 14 + arch/arm/mach-s5pv210/Makefile | 2 +- arch/arm/mach-s5pv210/mach-s

[RFC 3/3] Samsung: DT: Add Device tree for S5PC110/S5PV210 Boards

2013-09-26 Thread Mateusz Krawczuk
Add DTS for s5pc110 boards: goni, aquila, smdkc110 s5pv210: smdkv210, tiny210 Torbreck is replaced by FriendlyARM Tiny210 board. Signed-off-by: Mateusz Krawczuk Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/Makefile | 6 + arch/arm/boot/dts/s5pv210-aquila.dts | 407

[RFC 2/3] Samsung: DT: Add Device tree for s5pv210

2013-09-26 Thread Mateusz Krawczuk
Add generic device tree for s5pv210 and s5pv210-pinctrl Signed-off-by: Mateusz Krawczuk Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 820 + arch/arm/boot/dts/s5pv210.dtsi | 498 2 files changed, 1318 inser

[RFC 0/3]ARM: SAMSUNG: MACH S5PV210: Add support for Devicetree

2013-09-26 Thread Mateusz Krawczuk
This patch series add initial device tree support for mach s5pv210. It was tested on goni, aquila and tiny210. Mateusz Krawczuk (3): ARM: s5pv210: Add board file for boot using Device Tree Samsung: DT: Add Device tree for s5pv210 Samsung: DT: Add Device tree for S5PC110/S5PV210 Boards arch

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-26 Thread Tomasz Figa
Hi Yadwinder, I haven't reviewed this series yet, but let me clarify some things from your comments. On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: > > + > > +/* Helper macros to define clock arrays. */ > > +#define FIXED_RATE_CLOCKS(name)\ > > + stati

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-26 Thread Andrzej Hajda
Hi Mark, Thanks for the review, sorry for late response. On 09/20/2013 07:06 PM, Mark Rutland wrote: > On Fri, Sep 06, 2013 at 11:31:06AM +0100, Andrzej Hajda wrote: >> Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor >> with embedded SoC ISP. >> The driver exposes the sensor as two V4L2

Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros

2013-09-26 Thread Andrzej Hajda
On 09/16/2013 09:37 PM, Mike Turquette wrote: > Quoting Sylwester Nawrocki (2013-09-16 07:33:45) >> On 09/12/2013 12:50 PM, Kukjin Kim wrote: >>> Well...I'm not sure changing to use macro is better or not at this moment... >> I think it is. ;) It's really less error prone to have symbolic names ins

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-26 Thread Yadwinder Singh Brar
Hi Mateusz, After a quick view, just few things regarding coding styles. [...] > +#defineGENERAL_STATUS 0x0104 > +#defineCAM_MUX_SEL 0x0300 > +#defineMIXER_OUT_SEL 0x0304 > +#defineLPMP3_MODE_SEL 0x0308 > +#define MIPI_PHY_C

Re: [PATCH v2] MTD: Onenand: Add device tree support for samsung onenand

2013-09-26 Thread Mark Rutland
On Tue, Sep 24, 2013 at 02:00:01PM +0100, Tomasz Figa wrote: > Hi Mateusz, Mark, Hi, > > On Monday 23 of September 2013 15:08:23 Mark Rutland wrote: > > On Mon, Sep 23, 2013 at 02:06:48PM +0100, Mateusz Krawczuk wrote: > > > + > > > +Required properties: > > > + - compatible: value should be ei

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-26 Thread Archit Taneja
Hi, On Friday 20 September 2013 04:41 AM, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and bus code should access this member directly. Convert all direc

Re: [PATCH] clockevent: exynos_mct: fix lockdep warning

2013-09-26 Thread Daniel Lezcano
On 09/26/2013 12:32 PM, Tomasz Figa wrote: Hi Daniel, On Thursday 26 of September 2013 02:39:25 Daniel Lezcano wrote: On 09/25/2013 04:49 PM, Ming Lei wrote: This patch moves request_irq() out of cpu notifier callback to fix below lockdep warning: [0.249513] [ cut here ]--

Re: [PATCH] clockevent: exynos_mct: fix lockdep warning

2013-09-26 Thread Tomasz Figa
Hi Daniel, On Thursday 26 of September 2013 02:39:25 Daniel Lezcano wrote: > On 09/25/2013 04:49 PM, Ming Lei wrote: > > This patch moves request_irq() out of cpu notifier callback > > to fix below lockdep warning: > > > > [0.249513] [ cut here ] > > [0.249525] WAR

Re: [PATCH V3] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-09-26 Thread Kishon Vijay Abraham I
Hi Arnd, On Thursday 26 September 2013 03:21 PM, Arnd Bergmann wrote: > On Thursday 26 September 2013, Kishon Vijay Abraham I wrote: >> On Wednesday 25 September 2013 02:53 AM, Arnd Bergmann wrote: >>> On Monday 23 September 2013, Kishon Vijay Abraham I wrote: Btw if we hadn't programmed inbo

Re: [PATCH V3] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-09-26 Thread Arnd Bergmann
On Thursday 26 September 2013, Kishon Vijay Abraham I wrote: > On Wednesday 25 September 2013 02:53 AM, Arnd Bergmann wrote: > > On Monday 23 September 2013, Kishon Vijay Abraham I wrote: > >> Btw if we hadn't programmed inbound translation table, the address will go > >> untranslated (according to

Re: [PATCH 1/2] cpufreq: exynos4x12: Use the common clock framework to set APLL clock rate

2013-09-26 Thread Lukasz Majewski
Hi Yadwinder, > Hi Tomasz, > > >> On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski > >> wrote: > >> > In the exynos4x12_set_apll() function, the APLL frequency is set > >> > with direct register manipulation. > >> > > >> > Such approach is not allowed in the common clock framework. The > >> > fr

[PATCH v2] clk: exynos5420: fix cpll clock register offsets

2013-09-26 Thread Chander Kashyap
Fixes cpll control and lock register offset values for Exynos5420 SoC. Signed-off-by: Chander Kashyap Acked-by: Kukjin Kim --- Changes Since v1: - Fixed patch subject as per Kukgin suggestion. drivers/clk/samsung/clk-exynos5420.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH] clk: samsung: fix cpll clock register offsets for exynos5420 SoC

2013-09-26 Thread Chander Kashyap
On 26 September 2013 10:29, Kukjin Kim wrote: > Chander Kashyap wrote: >> >> Fixes cpll control and lock register offset values for Exynos5420 SoC. >> >> Signed-off-by: Chander Kashyap > > Just nit in the subject, > 'clk: exynos5420: ...' or 'clk/exynos5420: ...' would be nice... > Thanks for re

Re: [PATCH 1/2] ARM: dts: exynos4210-origen: Add fixed voltage regulator to simple bus

2013-09-26 Thread Tomasz Figa
Hi Sachin, I must have missed this patch so better later than never ;). Please see my comments inline. On Thursday 26 of September 2013 10:32:01 Sachin Kamat wrote: > > + regulators { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > +

Re: [PATCH 12/26] ARM: exynos: remove custom .init_time hook

2013-09-26 Thread Tomasz Figa
Hi Sebastian, On Thursday 26 of September 2013 08:21:27 Sebastian Hesselbarth wrote: > On 09/18/2013 07:53 PM, Sebastian Hesselbarth wrote: > > With arch/arm calling of_clk_init(NULL) from time_init(), we can now > > remove custom .init_time hooks. While at it, also remove some now > > redundant i