Re: [PATCH 3/4] mfd: sec-core: Add cells for S5M8767-clocks

2013-11-04 Thread Kyungmin Park
On Tue, Nov 5, 2013 at 3:29 PM, Tushar Behera wrote: > On 31 October 2013 21:46, Lee Jones wrote: >> On Thu, 31 Oct 2013, Tushar Behera wrote: >> >>> S5M8767 chip has 3 crystal oscillators running at 32KHz. These are >>> supported by s2mps11-clk driver. >>> >>> Signed-off-by: Tushar Behera >>> C

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Vivek Gautam
Hi Kishon, On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I wrote: > Hi, > > > On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: >> >> Hi Kishon, >> >>> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] >>> Sent: Monday, November 04, 2013 7:55 AM >>> >>> Hi Vivek, >>> >>> On Thur

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Vivek Gautam
On Tue, Nov 5, 2013 at 11:06 AM, Vivek Gautam wrote: > Hi Tomasz, Sorry my mail client had some problem, so forwarding this again. > > On Nov 4, 2013 5:59 PM, "Tomasz Figa" wrote: >> >> Hi Kishon, >> >> On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: >> > Hi Vivek, >> > >>

Re: [PATCH 3/4] mfd: sec-core: Add cells for S5M8767-clocks

2013-11-04 Thread Tushar Behera
On 31 October 2013 21:46, Lee Jones wrote: > On Thu, 31 Oct 2013, Tushar Behera wrote: > >> S5M8767 chip has 3 crystal oscillators running at 32KHz. These are >> supported by s2mps11-clk driver. >> >> Signed-off-by: Tushar Behera >> CC: Lee Jones >> --- >> drivers/mfd/sec-core.c |4 +++- >>

[PATCH v3 2/2] ARM: dts: Update Samsung sysreg binding document

2013-11-04 Thread Sachin Kamat
Added a binding example for reference and updated the node name. While at it also removed the name description as it is not necessary. Signed-off-by: Sachin Kamat --- Changes since v2: * Removed node name description as suggested by Tomasz Figa. --- .../devicetree/bindings/arm/samsung/sysreg.txt

[PATCH v3 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

2013-11-04 Thread Sachin Kamat
Fix the name as per DT node naming convention. - rename the node to syscon which is a more generic name. - append the register value to the node name. Signed-off-by: Sachin Kamat Reviewed-by: Tomasz Figa --- Changes since v2: None. --- arch/arm/boot/dts/exynos4.dtsi |2 +- 1 file changed, 1

[PATCH v11 08/12] [media] exynos5-fimc-is: Add the hardware pipeline control

2013-11-04 Thread Arun Kumar K
This patch adds the crucial hardware pipeline control for the fimc-is driver. All the subdev nodes will call this pipeline interfaces to reach the hardware. Responsibilities of this module involves configuring and maintaining the hardware pipeline involving multiple sub-ips like ISP, DRC, Scalers,

[PATCH v11 09/12] [media] exynos5-fimc-is: Add the hardware interface module

2013-11-04 Thread Arun Kumar K
The hardware interface module finally sends the commands to the FIMC-IS firmware and runs the interrupt handler for getting the responses. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- .../media/platform/exynos5-is/fimc-is-interface.c | 810 +++

[PATCH v11 12/12] V4L: Add s5k4e5 sensor driver

2013-11-04 Thread Arun Kumar K
This patch adds subdev driver for Samsung S5K4E5 raw image sensor. Like s5k6a3, it is also another fimc-is firmware controlled sensor. This minimal sensor driver doesn't do any I2C communications as its done by ISP firmware. It can be updated if needed to a regular sensor driver by adding the I2C c

[PATCH v11 07/12] [media] exynos5-fimc-is: Add sensor interface

2013-11-04 Thread Arun Kumar K
Some sensors to be used with fimc-is are exclusively controlled by the fimc-is firmware. This minimal sensor driver provides the required info for the firmware to configure the sensors sitting on I2C bus. Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exy

[PATCH v11 05/12] [media] exynos5-fimc-is: Add isp subdev

2013-11-04 Thread Arun Kumar K
fimc-is driver takes video data input from the ISP video node which is added in this patch. This node accepts Bayer input buffers which is given from the IS sensors. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc

[PATCH v11 10/12] [media] exynos5-is: Add Kconfig and Makefile

2013-11-04 Thread Arun Kumar K
Adds Kconfig and Makefile for exynos5-is driver files. Signed-off-by: Shaik Ameer Basha Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile|1 + drivers/media/platform/exynos5-is/Kc

[PATCH v11 11/12] V4L: Add DT binding doc for s5k4e5 image sensor

2013-11-04 Thread Arun Kumar K
S5K4E5 is a Samsung raw image sensor controlled via I2C. This patch adds the DT binding documentation for the same. Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki Acked-by: Mark Rutland --- .../devicetree/bindings/media/samsung-s5k4e5.txt | 45 1 file chan

[PATCH v11 06/12] [media] exynos5-fimc-is: Add scaler subdev

2013-11-04 Thread Arun Kumar K
FIMC-IS has two hardware scalers named as scaler-codec and scaler-preview. This patch adds the common code handling the video nodes and subdevs of both the scalers. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-

[PATCH v11 04/12] [media] exynos5-fimc-is: Add register definition and context header

2013-11-04 Thread Arun Kumar K
This patch adds the register definition file for the fimc-is driver and also the header file containing the main context for the driver. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-is-regs.h | 105 +++

[PATCH v11 00/12] Exynos5 IS driver

2013-11-04 Thread Arun Kumar K
The patch series adds support for exynos5 fimc-is driver and a new sensor s5k4e5. The media driver part is omitted form this series as it is already applied. Changes from v10 --- - Addressed DT binding review comments from Mark Rutland https://www.mail-archive.com/linux-media@vger.kern

[PATCH v11 01/12] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-04 Thread Arun Kumar K
The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki Acked-by: Mark Rutland --- .../devicetree/bindings/media/exynos5-fimc-is.txt | 113 1 file changed, 113 ins

[PATCH v11 02/12] [media] exynos5-fimc-is: Add driver core files

2013-11-04 Thread Arun Kumar K
This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-is-core.c | 410 +

Re: [PATCH v10 01/12] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-04 Thread Arun Kumar K
Hi Mark, Thank you for the review. Will address your comments. Regards Arun On Tue, Oct 29, 2013 at 5:02 AM, Mark Rutland wrote: > Hi, > > Apologies for the late reply. I have a few comments, but nothing major. > > On Fri, Oct 18, 2013 at 06:37:28AM +0100, Arun Kumar K wrote: >> The patch adds

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/04/2013 03:24 PM, Sylwester Nawrocki wrote: > On 04/11/13 15:12, Hans Verkuil wrote: >> On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: Hello Hans Thanks for your comments. Please take a look to v4 of this patch https://patchwork.linuxtv.org/patch/20529/ >

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Sylwester Nawrocki
On 04/11/13 15:12, Hans Verkuil wrote: > On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: >> > Hello Hans >> > >> > Thanks for your comments. >> > >> > Please take a look to v4 of this patch >> > https://patchwork.linuxtv.org/patch/20529/ >> > >> > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verk

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > Thanks for your comments. > > Please take a look to v4 of this patch > https://patchwork.linuxtv.org/patch/20529/ > > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: >> On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wr

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Sylwester Nawrocki
Hi, On 04/11/13 14:54, Ricardo Ribalda Delgado wrote: > Hello Hans > > Thanks for your comments. > > Please take a look to v4 of this patch > https://patchwork.linuxtv.org/patch/20529/ We're discussing v4 actually ;) > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: >> On 11/02/2013 10:53

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Ricardo Ribalda Delgado
Hello Hans Thanks for your comments. Please take a look to v4 of this patch https://patchwork.linuxtv.org/patch/20529/ On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: > On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote: >> From: Ricardo Ribalda >> >> vb2_fop_relase does not held the lo

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Kishon Vijay Abraham I
Hi, On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: Hi Kishon, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Monday, November 04, 2013 7:55 AM Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of S

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Kishon Vijay Abraham I
On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote: Hi Kishon, On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the g

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda > > vb2_fop_relase does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video d

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Tomasz Figa
Hi Kishon, On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: > > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > > The new driver uses the generic PHY framework and will interact > > wit

RE: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Kamil Debski
Hi Kishon, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, November 04, 2013 7:55 AM > > Hi Vivek, > > On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: > > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > > The new driver uses the generic PHY frame

Re: [PATCH] ARM: SAMSUNG: remove unused SAMSUNG_GPIOLIB_4BIT Kconfig parameter

2013-11-04 Thread Jingoo Han
On Monday, November 04, 2013 6:51 PM, Michael Opdenacker wrote: > > This removes the SAMSUNG_GPIOLIB_4BIT Kconfig parameter, > which was no longer used anywhere in the source code > and Makefiles. > > Signed-off-by: Michael Opdenacker It looks good. Reviewed-by: Jingoo Han Best regards, Jingo

[PATCH] ARM: SAMSUNG: remove unused SAMSUNG_GPIOLIB_4BIT Kconfig parameter

2013-11-04 Thread Michael Opdenacker
This removes the SAMSUNG_GPIOLIB_4BIT Kconfig parameter, which was no longer used anywhere in the source code and Makefiles. Signed-off-by: Michael Opdenacker --- arch/arm/Kconfig | 1 - arch/arm/plat-samsung/Kconfig | 8 2 files changed, 9 deletions(-) diff --git a/arch/a

Re: [PATCH] ARM: S3C24XX: remove unused Kconfig parameter

2013-11-04 Thread Michael Opdenacker
On 11/03/2013 08:25 AM, Michael Opdenacker wrote: > This removes the MACH_S3C2413 Kconfig parameter, > which was no longer used anywhere in the source code > and Makefiles. > > Signed-off-by: Michael Opdenacker > --- > arch/arm/mach-s3c24xx/Kconfig | 7 --- > 1 file changed, 7 deletions(-) >