Re: [PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Guenter Roeck
On 11/18/2013 09:26 PM, Leela Krishna Amudala wrote: Hi Guenter Roeck, On Tue, Nov 19, 2013 at 10:30 AM, Guenter Roeck wrote: On 11/18/2013 08:36 PM, Leela Krishna Amudala wrote: Hi Guenter Roeck, Thanks for reviewing the patch. On Mon, Nov 18, 2013 at 10:12 PM, Guenter Roeck wrote: On

[PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-11-18 Thread Naveen Krishna Chatradhi
For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based on a fixed 66 MHz peripheral clock, and therefore is completely independent of the cpu frequency. Thus, registering for a CPU freq notifier is very wasteful. This patch modifes the code such that, i2c bus registers to cpu_freq_transi

Re: [PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Leela Krishna Amudala
Hi Guenter Roeck, On Tue, Nov 19, 2013 at 10:30 AM, Guenter Roeck wrote: > On 11/18/2013 08:36 PM, Leela Krishna Amudala wrote: >> >> Hi Guenter Roeck, >> >> Thanks for reviewing the patch. >> >> >> On Mon, Nov 18, 2013 at 10:12 PM, Guenter Roeck >> wrote: >>> >>> On Mon, Nov 18, 2013 at 03:19:4

Re: [PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Guenter Roeck
On 11/18/2013 08:36 PM, Leela Krishna Amudala wrote: Hi Guenter Roeck, Thanks for reviewing the patch. On Mon, Nov 18, 2013 at 10:12 PM, Guenter Roeck wrote: On Mon, Nov 18, 2013 at 03:19:48PM +0530, Leela Krishna Amudala wrote: Add device tree support for exynos5250 and 5420 SoCs and use s

Re: [PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Leela Krishna Amudala
Hi Guenter Roeck, Thanks for reviewing the patch. On Mon, Nov 18, 2013 at 10:12 PM, Guenter Roeck wrote: > On Mon, Nov 18, 2013 at 03:19:48PM +0530, Leela Krishna Amudala wrote: >> Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap >> interface >> to configure AUTOMATIC

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Alex Courbot
On 11/18/2013 08:58 PM, Catalin Marinas wrote: On Mon, Nov 18, 2013 at 03:05:59AM +, Alex Courbot wrote: On 11/18/2013 12:59 AM, Catalin Marinas wrote: On 17 November 2013 08:49, Alexandre Courbot wrote: The ARM tree includes a firmware_ops interface that is designed to implement support

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Christopher Covington
Hi Catalin, On 11/18/2013 12:30 PM, Catalin Marinas wrote: [...] > You can't run legacy AArch32 code at EL3 and have lower levels in AArch64 > mode (architectural constraint). What prevents AArch32 code from running at EL3 and then requesting a reset to AArch64 by writing to the Reset Management

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 10:30 AM, Catalin Marinas wrote: > On Mon, Nov 18, 2013 at 05:03:37PM +, Stephen Warren wrote: >> On 11/18/2013 04:58 AM, Catalin Marinas wrote: >> ... >>> Of course, trusted foundations interface could be plugged into cpu_ops >>> on arm64 but I will NAK it on the grounds of not u

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Catalin Marinas
On Mon, Nov 18, 2013 at 05:00:32PM +, Stephen Warren wrote: > On 11/17/2013 08:59 AM, Catalin Marinas wrote: > > On 17 November 2013 08:49, Alexandre Courbot wrote: > >> The ARM tree includes a firmware_ops interface that is designed to > >> implement support for simple, TrustZone-based firmwa

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Catalin Marinas
On Mon, Nov 18, 2013 at 05:03:37PM +, Stephen Warren wrote: > On 11/18/2013 04:58 AM, Catalin Marinas wrote: > ... > > Of course, trusted foundations interface could be plugged into cpu_ops > > on arm64 but I will NAK it on the grounds of not using the PSCI API, nor > > the SMC calling conventi

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 10:10 AM, Russell King - ARM Linux wrote: > On Mon, Nov 18, 2013 at 10:03:37AM -0700, Stephen Warren wrote: >> On 11/18/2013 04:58 AM, Catalin Marinas wrote: >> ... >>> Of course, trusted foundations interface could be plugged into cpu_ops >>> on arm64 but I will NAK it on the grounds

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Russell King - ARM Linux
On Mon, Nov 18, 2013 at 10:03:37AM -0700, Stephen Warren wrote: > On 11/18/2013 04:58 AM, Catalin Marinas wrote: > ... > > Of course, trusted foundations interface could be plugged into cpu_ops > > on arm64 but I will NAK it on the grounds of not using the PSCI API, nor > > the SMC calling conventi

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Russell King - ARM Linux
On Sun, Nov 17, 2013 at 03:59:04PM +, Catalin Marinas wrote: > No L2x0 (L210, L220, PL310) cache on ARMv8. And here I strongly > recommend the hardware people to make proper external caches which can > be flushed by standard CPU instructions, not MMIO. Any such caches > must be enabled by firmw

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 04:58 AM, Catalin Marinas wrote: ... > Of course, trusted foundations interface could be plugged into cpu_ops > on arm64 but I will NAK it on the grounds of not using the PSCI API, nor > the SMC calling convention (and it's easy to fix when porting to ARMv8). > If a supported standard

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/17/2013 08:59 AM, Catalin Marinas wrote: > On 17 November 2013 08:49, Alexandre Courbot wrote: >> The ARM tree includes a firmware_ops interface that is designed to >> implement support for simple, TrustZone-based firmwares but could >> also cover other use-cases. It has been suggested that

Re: [PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Guenter Roeck
On Mon, Nov 18, 2013 at 03:19:48PM +0530, Leela Krishna Amudala wrote: > Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap > interface > to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers > of PMU > to mask/unmask enable/disable of watchdog in p

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Catalin Marinas
On Mon, Nov 18, 2013 at 03:05:59AM +, Alex Courbot wrote: > On 11/18/2013 12:59 AM, Catalin Marinas wrote: > > On 17 November 2013 08:49, Alexandre Courbot wrote: > >> The ARM tree includes a firmware_ops interface that is designed to > >> implement support for simple, TrustZone-based firmware

Re: [PATCH 3/4 v9] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-11-18 Thread Mark Rutland
On Mon, Nov 18, 2013 at 03:22:57AM +, Naveen Krishna Ch wrote: > Hello All, > > On 12 November 2013 12:07, Naveen Krishna Chatradhi > wrote: > > Exynos5420 has 5 TMU channels, the TRIMINFO register is > > misplaced for TMU channels 2, 3 and 4 > > TRIMINFO at 0x1006c000 contains data for TMU c

Re: [PATCH V9 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

2013-11-18 Thread Tomasz Figa
Hi Leela, On Monday 18 of November 2013 15:19:46 Leela Krishna Amudala wrote: > This patchset does the following things > - Adds pmusysreg device node to exynos5.dtsi file > - Adds watchdog DT nodes to Exynos5250 and 5420 > - Uses syscon regmap interface to configure pmu register

[PATCH V9 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register

2013-11-18 Thread Leela Krishna Amudala
Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap interface to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers of PMU to mask/unmask enable/disable of watchdog in probe and s2r scenarios. Signed-off-by: Leela Krishna Amudala --- .../devicetre

[PATCH V9 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers

2013-11-18 Thread Leela Krishna Amudala
This patchset does the following things - Adds pmusysreg device node to exynos5.dtsi file - Adds watchdog DT nodes to Exynos5250 and 5420 - Uses syscon regmap interface to configure pmu registers to mask/unmask enable/disable of watchdog. This patch set is

[PATCH V9 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

2013-11-18 Thread Leela Krishna Amudala
In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask watchdog timer which is not the case with s3c series SoCs so, there is a need to have different compatible names for watchdog to handle these pmu registers access. Hence this patch removes watchdog node from Exynos5.dtsi commo

[PATCH V9 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

2013-11-18 Thread Leela Krishna Amudala
This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to handle PMU register accesses in a centralized way using syscon driver Signed-off-by: Leela Krishna Amudala Reviewed-by: Tomasz Figa --- Documentation/devicetree/bindings/arm/samsung/pmu.txt | 16 arch/a

Re: [PATCH V8 2/3] watchdog: s3c2410_wdt: add device tree support and use syscon regmap interface to configure pmu register

2013-11-18 Thread Leela Krishna Amudala
Hi Tomasz On Sat, Nov 16, 2013 at 5:27 AM, Tomasz Figa wrote: > On Thursday 14 of November 2013 18:49:34 Guenter Roeck wrote: >> On 11/11/2013 10:34 PM, Leela Krishna Amudala wrote: >> > Add device tree support and use syscon regmap interface to configure >> > AUTOMATIC_WDT_RESET_DISABLE and MASK

Re: [PATCH V8 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

2013-11-18 Thread Leela Krishna Amudala
Hi Tomasz, On Sat, Nov 16, 2013 at 5:13 AM, Tomasz Figa wrote: > On Tuesday 12 of November 2013 12:04:46 Leela Krishna Amudala wrote: >> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to >> handle PMU register accesses in a centralized way using syscon driver >> >> Signed-