On 30 December 2013 03:47, Mike Turquette wrote:
> Quoting Tushar Behera (2013-12-26 02:18:58)
>> The clocks in S2MPS11 and S5M8767 are managed in the same way, baring
>> a difference in the register offset. It would be better to update
>> existing S2MPS11 driver to support the clocks in S5M8767,
(Trimmed down the CC list)
Hi Mateusz,
On 28 December 2013 22:39, Mateusz Krawczuk wrote:
> From: Mateusz Krawczuk
>
> Use common clock framework api to get clock.
The commit message looks a bit off. clk_get() is also a CCF API.
Hence it makes more sense to mention the reason for replacing clk
On Monday, December 30, 2013 7:48 AM, Julia Lawall wrote:
>
> From: Julia Lawall
>
> Set the return variable to an error code as done elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> (
> if
Quoting Tushar Behera (2013-12-26 02:18:58)
> The clocks in S2MPS11 and S5M8767 are managed in the same way, baring
> a difference in the register offset. It would be better to update
> existing S2MPS11 driver to support the clocks in S5M8767, rather than
> creating an almost duplicate driver altog
These patches fix cases where the return variable is not set to an error
code in an error case.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Julia Lawall
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret =
Quoting Mateusz Krawczuk (2013-12-28 09:09:14)
> From: Mateusz Krawczuk
>
> This patch adds new, Common Clock Framework-based clock driver for Samsung
> S5PV210 SoCs. The driver is just added, without enabling it yet.
>
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
Acked-by
