Re: [PATCH] ARM: dts: Add l2x0 device node for Exynos4-based boards

2014-01-23 Thread Tushar Behera
On 23 January 2014 23:45, Tomasz Figa wrote: > Hi, > > > On 07.01.2014 09:53, Tushar Behera wrote: >> >> For Exynos4 platform, L2 cache initialization is done only if >> a device node for l2x0 device exists. >> >> L2 cache initialization path is different when a board boots with >> secure firmware

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-23 Thread Tomasz Figa
On 23.01.2014 20:02, Heiko Stübner wrote: Am Donnerstag, 23. Januar 2014, 19:51:34 schrieb Tomasz Figa: On 23.01.2014 19:36, Heiko Stübner wrote: Am Donnerstag, 23. Januar 2014, 19:12:04 schrieb Tomasz Figa: Hi Heiko, On 06.01.2014 19:40, Heiko Stübner wrote: This converts all boards to us

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Alan Cox
On Thu, 23 Jan 2014 20:05:09 + Mark Brown wrote: > On Thu, Jan 23, 2014 at 07:51:44PM +, Alan Cox wrote: > > > That strikes me as rather more risky. We can propogate it through the > > drivers as we are sure it is safe to do so on that platform and encourage > > driver authors to migrate

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Mark Brown
On Thu, Jan 23, 2014 at 07:51:44PM +, Alan Cox wrote: > That strikes me as rather more risky. We can propogate it through the > drivers as we are sure it is safe to do so on that platform and encourage > driver authors to migrate. Better than a "big bang" and the inevitable > fallout. I don't

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Alan Cox
On Thu, 23 Jan 2014 19:36:33 + Mark Brown wrote: > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > > On 23.01.2014 19:40, Mark Brown wrote: > > > >We'd need to leave it user selectable rather than enabling it for ARM, > > >the whole reason this got noticed is that people are t

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Mark Brown
On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > On 23.01.2014 19:40, Mark Brown wrote: > >We'd need to leave it user selectable rather than enabling it for ARM, > >the whole reason this got noticed is that people are trying to build > >kernels that support a wider range of devices f

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-23 Thread Heiko Stübner
Am Donnerstag, 23. Januar 2014, 19:51:34 schrieb Tomasz Figa: > On 23.01.2014 19:36, Heiko Stübner wrote: > > Am Donnerstag, 23. Januar 2014, 19:12:04 schrieb Tomasz Figa: > >> Hi Heiko, > >> > >> On 06.01.2014 19:40, Heiko Stübner wrote: > >>> This converts all boards to use the new common restar

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-23 Thread Tomasz Figa
On 23.01.2014 19:36, Heiko Stübner wrote: Am Donnerstag, 23. Januar 2014, 19:12:04 schrieb Tomasz Figa: Hi Heiko, On 06.01.2014 19:40, Heiko Stübner wrote: This converts all boards to use the new common restart function instead of SoC specific ones. The mach-s3c2416-dt board now tries to setu

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Tomasz Figa
On 23.01.2014 19:40, Mark Brown wrote: On Thu, Jan 23, 2014 at 06:04:23PM +, Alan Cox wrote: We can then enable that config option for ARM (and in time for any other architecture that turns out to need/want it). Eventually it can go away (not that its exactly doing any harm if it doesnt).

Re: [PATCH V2 06/10] clk/samsung: add support for pll2650xx

2014-01-23 Thread Tomasz Figa
Hi Rahul, On 07.01.2014 13:59, Rahul Sharma wrote: Add support for pll2650xx in samsung pll file. This pll variant is close to pll36xx but uses CON2 registers instead of CON1. Aud_pll in Exynos5260 is pll2650xx and uses this code. Signed-off-by: Rahul Sharma --- drivers/clk/samsung/clk-pll.

Re: [PATCH V2 05/10] clk/samsung: add support for pll2550xx

2014-01-23 Thread Tomasz Figa
On 07.01.2014 13:59, Rahul Sharma wrote: From: Pankaj Dubey exynos5260 use pll2550xx and it has different bit fields for P,M,S values as compared to pll2550. Support for pll2550xx is added here. Signed-off-by: Pankaj Dubey Signed-off-by: Rahul Sharma Signed-off-by: Arun Kumar K --- driver

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Mark Brown
On Thu, Jan 23, 2014 at 06:04:23PM +, Alan Cox wrote: > We can then enable that config option for ARM (and in time for any other > architecture that turns out to need/want it). Eventually it can go away > (not that its exactly doing any harm if it doesnt). We'd need to leave it user selectabl

Re: [PATCH V2 03/10] pinctrl: exynos: add exynos5260 SoC specific data

2014-01-23 Thread Tomasz Figa
On 07.01.2014 14:31, Arnd Bergmann wrote: On Tuesday 07 January 2014 18:29:01 Rahul Sharma wrote: From: Young-Gun Jang Add Samsung Exynos5260 SoC specific data to enable pinctrl support for all platforms based on EXYNOS5260. Signed-off-by: Pankaj Dubey Signed-off-by: Young-Gun Jang Signed

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-23 Thread Heiko Stübner
Am Donnerstag, 23. Januar 2014, 19:12:04 schrieb Tomasz Figa: > Hi Heiko, > > On 06.01.2014 19:40, Heiko Stübner wrote: > > This converts all boards to use the new common restart function instead > > of SoC specific ones. > > > > The mach-s3c2416-dt board now tries to setup either a swrst- or wat

Re: [PATCH V2 04/10] clk/samsung: add support for multiple clock providers

2014-01-23 Thread Tomasz Figa
Hi Rahul, The patch looks mostly fine now, but I still have one inline comment. On 07.01.2014 13:59, Rahul Sharma wrote: Samsung CCF helper functions do not provide support to register multiple Clock Providers for a given SoC. Due to this limitation SoC platforms are not able to use these helpe

Re: [PATCH V2 01/10] clk/exynos5410: move suspend/resume handling to SoC driver

2014-01-23 Thread Tomasz Figa
On 07.01.2014 13:58, Rahul Sharma wrote: Suspend/resume handling is already moved for all other Exynos SoCs other than Exynos5420 which is addressed in this patch. Signed-off-by: Rahul Sharma --- drivers/clk/samsung/clk-exynos5410.c | 49 ++ 1 file changed,

Re: [PATCH] ARM: dts: Add l2x0 device node for Exynos4-based boards

2014-01-23 Thread Tomasz Figa
Hi, On 07.01.2014 09:53, Tushar Behera wrote: For Exynos4 platform, L2 cache initialization is done only if a device node for l2x0 device exists. L2 cache initialization path is different when a board boots with secure firmware. Since there are many Exynos4 based SoCs that boot in secure mode,

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-23 Thread Tomasz Figa
Hi Heiko, On 06.01.2014 19:40, Heiko Stübner wrote: This converts all boards to use the new common restart function instead of SoC specific ones. The mach-s3c2416-dt board now tries to setup either a swrst- or watchdog- reset so that it will be able to handle more s3c24xx-SoCs later on. [snip]

Re: [PATCH 1/5] dt-bindings: document the s3c24xx software-reset register

2014-01-23 Thread Tomasz Figa
Hi Heiko, On 06.01.2014 19:37, Heiko Stübner wrote: The S3C2412/S3C2413 as well as the S3C2443 and following contain a special register that restarts the system when written to. This adds a simple binding, so that it gets accessible on dt systems too. We distinguish between the two types (s3c24

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Alan Cox
> I had earlier submitted a patch [1] to remove the hard coded > major/minor number for Samsung UART driver, but that was rejected > because of userspace breakage. Without this patch, Samsung UART driver > can't bind to the hard-coded device node. Changing the default > major/minor will also not he

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Mark Rutland
On Thu, Jan 23, 2014 at 05:47:25PM +, Sylwester Nawrocki wrote: > On 23/01/14 18:41, Mark Rutland wrote: > >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > >>> > > index 93cddeb..2da5617 100644 > >>> > > --- a/drivers/crypto/s5p-sss.c > >>> > > +++ b/drivers/crypto/s5p-sss

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Sylwester Nawrocki
On 23/01/14 18:41, Mark Rutland wrote: >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >>> > > index 93cddeb..2da5617 100644 >>> > > --- a/drivers/crypto/s5p-sss.c >>> > > +++ b/drivers/crypto/s5p-sss.c >>> > > @@ -22,6 +22,7 @@ >>> > > #include >>> > > #include >>> > > #i

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Mark Rutland
On Thu, Jan 23, 2014 at 10:28:08AM +, Sylwester Nawrocki wrote: > Hi, > > (Adding missing devicetre ML list at CC.) > > On 15/01/14 10:14, Naveen Krishna Chatradhi wrote: > > This patch adds device tree support to the s5p-sss.c crypto driver. > > > > Also, Documentation under devicetree/bind

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Sylwester Nawrocki
Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: > Hello All, > > On 15 January 2014 14:47, Naveen Krishna Chatradhi > wrote: >> This patch set adds use of clk_prepare/clk_unprepare as >> required by generic clock framework. >> >> Signed-off-by: Naveen Krishna Chatradhi >> Reviewed-by: Tomasz Fi

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Sylwester Nawrocki
Hi, (Adding missing devicetre ML list at CC.) On 15/01/14 10:14, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S.

Re: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-23 Thread Sylwester Nawrocki
Hi, On 23/01/14 11:11, Kamil Debski wrote: >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > index 4ff3b6c..a02e7b8 100644 >> > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_e

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S. Miller > CC: Vladimir Zapolsk

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds gating clock for SSS(Security SubSystem) > module on Exynos5250/5420. > > Signed-off-by: Naveen Krishna Chatradhi > TO: > TO: Tomasz Figa > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1. Rebased on to

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch adds code to validate "iv" buffer before trying to > memcpy the contents > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > None > > drivers/crypto/s5p-sss.c |3 ++- > 1 file changed, 2 in

Re: [PATCH 1/8 v4] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > This patch uses the platform_get_irq() instead of the > platform_get_irq_byname(). Making feeder control interrupt > as resource "0" and hash interrupt as "1". > > reasons for this change. > 1. Can

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds the device tree node for SSS module > found on Exynos5420 and Exynos5250 > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > TO: > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1. M

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch set adds use of clk_prepare/clk_unprepare as > required by generic clock framework. > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > --- > Changes since v3: > None > > drivers/crypto/s5p-s

RE: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-23 Thread Kamil Debski
Hi Amit, > From: Amit Grover [mailto:amit.gro...@samsung.com] > Sent: Monday, December 30, 2013 11:43 AM > > This patch adds Controls to set Horizontal and Vertical search range > for Motion Estimation block for Samsung MFC video Encoders. > > Signed-off-by: Swami Nathan > Signed-off-by: Amit G