Re: [PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-14 Thread Grant Grundler
Please apply this. It's way overdue. It fixes customer kernel crashes we've seen in the field. I'd also advocate for seeing this be applied to stable kernels. thanks, grant On Thu, Mar 13, 2014 at 10:02 PM, Cho KyongHo wrote: > This commit adds cache flush for removed small and large page entr

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-14 Thread Kevin Hilman
Tomasz Figa writes: > This patch introduces generic code to perform power domain look-up using > device tree and automatically bind devices to their power domains. > Generic device tree binding is introduced to specify power domains of > devices in their device tree nodes. > > Backwards compatibi

Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patchset support devicetree and use common ppmu driver instead of individual code of exynos4_bus.c to remove duplicate code. Also this patchset get the resources for busfreq from dt data by using DT helper function. - PPMU register addres

Re: [PATCHv2 6/8] devfreq: exynos4: Fix power-leakage of clock on suspend state

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patch disable ppmu clocks before entering suspend state to remove power-leakage and enable ppmu clocks on resume function. I don't think there is any need for this, because all the clocks are stopped anyway in SLEEP mode. Best regard

Re: [PATCHv2 4/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe()

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patch fix bug about resource leak when happening probe fail and code clean to add debug message. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 32 ++-- 1 file changed, 26 insertion

Re: [PATCHv2 3/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: There are not the clock controller of ppmudmc0/1. This patch control the clock of ppmudmc0/1 which is used for monitoring memory bus utilization. Also, this patch code clean about regulator control and free resource when calling exit/remove f

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Tomasz Figa
Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 02:53 AM, Mark Rutland wrote: On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: T

Re: [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ

2014-03-14 Thread Tomasz Figa
Hi Robert, On 14.03.2014 11:13, Robert Baldyga wrote: This patch adds device tree node for IRQ used by max8997. Generally, this patch does not add just a node, but rather "IRQ line specification for the MAX8997 PMIC chip and necessary pinctrl group to configure pull-up and driver strength o

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa wrote: > Hi KyongHo, > > > On 14.03.2014 06:09, Cho KyongHo wrote: >> >> exynos-iommu driver must care about master H/W's gate clock as well as >> System MMU's gate clock. To enhance readability of the source code, >> macros to gate/ungate those cl

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices, the design of the link between System MMU and its master H/W is needed to be reconsidered. A link structur

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: This adds support for Suspend to RAM and Runtime Power Management. Since System MMU is located in the same local power domain of its master H/W, System MMU must be initialized before it is working if its power domain was ever turned off. TLB i

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo wrote: > This commit adds device tree support for System MMU. > > Signed-off-by: Cho KyongHo > --- > drivers/iommu/Kconfig|5 ++--- > drivers/iommu/exynos-iommu.c | 21 + > 2 files changed, 19 insertions(+), 7 del

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo wrote: > This patch uses managed device helper functions in the probe(). > > Signed-off-by: Cho KyongHo > --- [snip] > + data->clk = devm_clk_get(dev, "sysmmu"); > + if (IS_ERR(data->clk)) { > + dev_info(dev, "No gate clo

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care about master H/W's gate clock as well as System MMU's gate clock. To enhance readability of the source code, macros to gate/ungate those clocks are defined. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-i

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: This commit adds device tree support for System MMU. Signed-off-by: Cho KyongHo --- drivers/iommu/Kconfig|5 ++--- drivers/iommu/exynos-iommu.c | 21 + 2 files changed, 19 insertions(+), 7 deletions(-) d

Re: [PATCH 2/2] ARM: dts: imx: fix invalid #address-cells value

2014-03-14 Thread Shawn Guo
On Thu, Mar 13, 2014 at 10:40:05AM -0700, Tim Harvey wrote: > The invalid value of #address-cells in the imx6 pcie host controller node > causes of_irq_parse_raw() to incorrectly advance through an interrupt-map > table of more than one interrupt. > > This patch resolves this issue and allows prop

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 64 +- 1 file changed, 26 insertions(+), 38 deletions(-) diff --git a/

Re: [PATCH v11 08/27] iommu/exynos: always use a single clock descriptor

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: System MMU driver is changed to control only a single instance of System MMU at a time. Since a single instance of System MMU has only a single clock descriptor for its clock gating, there is no need to obtain two or more clock descriptors.

Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-14 Thread Grant Likely
On Thu, Mar 13, 2014 at 6:25 PM, Jason Gunthorpe wrote: > On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote: >> On 03/13/2014 11:40 AM, Tim Harvey wrote: >> > When using interrupt-maps, the size of a map entry is #address-cells + >> > #interrupt-cells for the parent interrupt control

[PATCH 1/1] clk: exynos5420: Register APLL rate table

2014-03-14 Thread Sachin Kamat
Register APLL rate table in Exynos5420 clock driver. Will be required for the CPUFreq driver. Signed-off-by: Sachin Kamat --- drivers/clk/samsung/clk-exynos5420.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/c

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: Runtime power management by exynos-iommu driver independently from master H/W's runtime pm is not useful for power saving since attaching master H/W in probing time turns on its local power endlessly. Thus this removes runtime pm API calls. Run

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-14 Thread Mark Brown
On Thu, Mar 13, 2014 at 10:33:29AM +, Mark Rutland wrote: > On Wed, Mar 12, 2014 at 04:31:56AM +, Kukjin Kim wrote: > > > > +/ { > > > > + model = "SAMSUNG SSDK-GH7 board based on GH7 SoC"; > > > Is the "based on GH7 SoC" part necessary? Does the "SSDK-GH7" not give > > > that away?

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This patch adds dts entries for the System MMU devices found on Exynos4 and Exynos5 SoC series and the System MMU binding documentation. CC: Rob Herring CC: Sylwester Nawrocki Signed-off-by: Cho KyongHo --- .../bindings/iommu/samsung,exyn

Re: [PATCH v11 11/27] clk: exynos: add gate clock descriptions of System MMU

2014-03-14 Thread Tomasz Figa
Hi KyongHo, On 14.03.2014 06:06, Cho KyongHo wrote: This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c and clk-exynos5420.c Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA to GATE for System MMU clocks in clk-exynos4.c Signed-off-by: Cho

Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-14 Thread Shawn Guo
On Thu, Mar 13, 2014 at 03:25:50PM -0700, Tim Harvey wrote: > On Thu, Mar 13, 2014 at 11:25 AM, Jason Gunthorpe > wrote: > > On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote: > >> On 03/13/2014 11:40 AM, Tim Harvey wrote: > >> > When using interrupt-maps, the size of a map entry is #

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 17:19, Cho KyongHo wrote: >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Friday, March 14, 2014 7:00 PM >> >> On 14 March 2014 10:31, Cho KyongHo wrote: >> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from >> > exynos tree) removed arch/arm/

RE: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Cho KyongHo
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Friday, March 14, 2014 7:00 PM > > On 14 March 2014 10:31, Cho KyongHo wrote: > > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from > > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without > > remo

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Chanwoo Choi
Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: > On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: >> Hi Mark, >> >> On 03/14/2014 02:53 AM, Mark Rutland wrote: >>> On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: This patch add busfreq driver for Exynos4210/Exy

Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-14 Thread Bartlomiej Zolnierkiewicz
On Friday, March 14, 2014 12:14:03 PM Chanwoo Choi wrote: > Hi, > > On 03/14/2014 01:43 AM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Thursday, March 13, 2014 05:17:21 PM Chanwoo Choi wrote: > >> This patchset support devicetree and use common ppmu driver instead of > >> individual

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Mark Rutland
On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: > Hi Mark, > > On 03/14/2014 02:53 AM, Mark Rutland wrote: > > On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: > >> This patch add busfreq driver for Exynos4210/Exynos4x12 memory interface > >> and bus to support DVFS(Dyna

[PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ

2014-03-14 Thread Robert Baldyga
This patch adds device tree node for IRQ used by max8997. Signed-off-by: Robert Baldyga --- arch/arm/boot/dts/exynos4210-trats.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 1d18428..

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 10:31, Cho KyongHo wrote: > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without > removing remaining use of it from exynos-iommu driver, thus causing a > compilation error. > > This patch fi

[PATCHv3 6/8] devfreq: exynos4: Fix power-leakage of clock on suspend state

2014-03-14 Thread Chanwoo Choi
This patch disable ppmu clocks before entering suspend state to remove power-leakage and enable ppmu clocks on resume function. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drive

[PATCHv3 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-14 Thread Chanwoo Choi
This patchset support devicetree and use common ppmu driver instead of individual code of exynos4_bus.c to remove duplicate code. Also this patchset get the resources for busfreq from dt data by using DT helper function. - PPMU register address - PPMU clock - Regulator for INT/MIF block This patch

[PATCHv3 5/8] devfreq: exynos4: Use SET_SYSTEM_SLEEP_PM_OPS macro

2014-03-14 Thread Chanwoo Choi
This patch use SET_SYSTEM_SLEEP_PM_OPS macro instead of legacy method. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/exynos/exynos4_bus.c b/drivers/devfreq/exynos/exynos4_bus.c index 60

[PATCHv3 1/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe()

2014-03-14 Thread Chanwoo Choi
This patch fix bug about resource leak when happening probe fail and code clean to add debug message. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/devfreq/exynos/ex

[PATCHv3 4/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control

2014-03-14 Thread Chanwoo Choi
There are not the clock controller of ppmudmc0/1. This patch control the clock of ppmudmc0/1 which is used for monitoring memory bus utilization. Also, this patch code clean about regulator control and free resource when calling exit/remove function. For example, busfreq@106A { compat

[PATCHv3 3/8] devfreq: exynos4: Use common ppmu driver and get ppmu address from dt data

2014-03-14 Thread Chanwoo Choi
This patch use common ppmu driver of exynos_ppmu.c driver instead of individual function related to PPC because PPMU is integrated module with both PPC and Bus event generator. When using PPMU to get bus performance read/write event, exynos4_bus.c don't need to consider memory type. And get ppmu a

[PATCHv3 7/8] devfreq: exynos4: Add CONFIG_PM_OPP dependency to fix probe fail

2014-03-14 Thread Chanwoo Choi
This patch add CONFIG_PM_OPP dependecy to exynos4_bus driver to fix probe fail as following log: [3.721389] exynos4-busfreq busfreq.3: Fail to add opp entries. [3.721697] exynos4-busfreq: probe of busfreq.3 failed with error -22 If CONFIG_PM_OPP is disabled, dev_pm_opp_find_freq_floor() i

[PATCHv3 8/8] Documentation: dt: devfreq: Add device tree binding of Exynos4 busfreq

2014-03-14 Thread Chanwoo Choi
This patch introduce device tree binding for the Exynos4's busfreq driver. The Exynos4's busfreq driver support DVFS(Dynamic Voltage Frequency Scaling) of Exynos4 memory bus to optimize power-consumption on runtime state. Exynos4's busfreq driver need the utilization of memory bus. So, busfreq driv

[PATCHv3 2/8] devfreq: exynos4: Support devicetree to get device id of Exynos4 SoC

2014-03-14 Thread Chanwoo Choi
This patch support DT(DeviceTree) method to probe exynos4_bus and get device id of each Exynos4 SoC by using dt helper function. Signed-off-by: Chanwoo Choi --- drivers/devfreq/exynos/exynos4_bus.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/dri

Enabling uart 3 in arndale

2014-03-14 Thread armdev
Hi, We are trying to enable the UART3 on COM18 pins of arndale board. The UART3 RXD and TXD are on pins 2 and 4 which as per the base board specification is connected as XuRXD3 : UART_3_RXD/GPA1[4] : 2 XuTXD3 : UART_3_TXD/GPA1[5] : 4 As per the public reference manual of exynos 5250, there is

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Chanwoo Choi
Hi Mark, On 03/14/2014 02:53 AM, Mark Rutland wrote: > On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: >> This patch add busfreq driver for Exynos4210/Exynos4x12 memory interface >> and bus to support DVFS(Dynamic Voltage Frequency Scaling) according to PPMU >> counters. PPMU (Perfor