Move the structure below the 'exynos4_enter_lowpower' function so no more
need of forward declaration.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 40 ++--
1 file changed, 18 insertions(+), 22 deletions(-)
The driver was initially written for exynos4 but the driver is used also for
exynos5.
Change the function prefix name exynos4 - exynos
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 20 ++--
1 file changed, 10 insertions(+), 10
This function should be called only when the powerdown sequence fails.
Even if the current code does not hurt, by moving this line, we have the same
code than the one in pm.c.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |5 ++---
1 file
Use the cpu_pm_enter/exit notifier to group some pm code inside the pm file.
The save and restore code is duplicated across pm.c and cpuidle.c. By using
the cpu_pm notifier, we can factor out the routine.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
arch/arm/mach-exynos/pm.c |3 +++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c
That makes the code cleaner and encapsulted. The function will be reused in the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c | 65 -
1 file changed, 41 insertions(+), 24 deletions(-)
diff --git
The scu_enable function is already a noop in the scu's header file is
CONFIG_SMP=n, so no need to use these macros in the code.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c |5 -
1 file changed, 5 deletions(-)
diff --git
Move the S5P_CHECK_AFTR definition to the header it belongs to.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |2 --
arch/arm/mach-exynos/regs-pmu.h |1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
Let's encapsulate more the PM code inside the PM file by moving the
'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm
notifier.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |7 ---
arch/arm/mach-exynos/pm.c |
Move the code around to differentiate different section of code and prepare it
to be factored out in the next patches.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git
This patchset relies on the cpm_pm notifier to initiate the powerdown sequence
operations from pm.c instead cpuidle.c. Thus the cpuidle driver is no longer
dependent from arch specific code as everything is called from the pm.c file.
The patchset applies on top of v3.14.
Tested on exynos4: 4210
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/Makefile |1 -
drivers/cpuidle/Kconfig.arm|7 +++
drivers/cpuidle/Makefile |1 +
.../cpuidle.c = drivers/cpuidle/cpuidle-exynos.c
The code to initiate and exit the powerdown sequence is the same in pm.c and
cpuidle.c.
Let's split the common part in the pm.c and reuse it from the cpu_pm notifier.
That is one more step forward to make the cpuidle driver arch indenpendant.
Signed-off-by: Daniel Lezcano
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/configs/exynos_defconfig |1 +
1 file changed, 1 insertion(+)
diff --git
One more step is moving the clock ratio setting at idle time in pm.c
The macro names have been changed to be consistent with the other macros
name in the file.
Note, the clock divider was working only when cpuidle was enabled because it
was in its init routine. With this change, the clock
No more dependency on the arch code. The platform_data field is used to set the
PM callback as the other cpuidle driver.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/common.c |5 +++--
arch/arm/mach-exynos/common.h |1 +
As usual, move the boot vector setting in the pm.c file and use the cpu_pm
notifier to set it up.
Remove the unused headers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 22 --
arch/arm/mach-exynos/pm.c | 15
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Move the structure below the 'exynos4_enter_lowpower' function so no more
need of forward declaration.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 40
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Use the cpuidle generic function 'cpuidle_register'. That saves us from some
extra lines of code and unneeded variables.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 18
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
That makes the code cleaner and encapsulted. The function will be reused in
the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c | 65
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Move the code around to differentiate different section of code and prepare it
to be factored out in the next patches.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 17
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
This function should be called only when the powerdown sequence fails.
Even if the current code does not hurt, by moving this line, we have the same
code than the one in pm.c.
Signed-off-by: Daniel Lezcano
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
arch/arm/mach-exynos/pm.c |3 +++
2 files changed, 3
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
The scu_enable function is already a noop in the scu's header file is
CONFIG_SMP=n, so no need to use these macros in the code.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c |5
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Let's encapsulate more the PM code inside the PM file by moving the
'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm
notifier.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
Hi Daniel,
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
This patchset relies on the cpm_pm notifier to initiate the powerdown sequence
operations from pm.c instead cpuidle.c. Thus the cpuidle driver is no longer
dependent from arch specific code as everything is
On 04/04/2014 10:57 AM, Viresh Kumar wrote:
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Move the S5P_CHECK_AFTR definition to the header it belongs to.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |2 --
arch/arm/mach-exynos/regs-pmu.h |1 +
2 files
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
One more step is moving the clock ratio setting at idle time in pm.c
The macro names have been changed to be consistent with the other macros
name in the file.
Note, the clock divider was working only when cpuidle was
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
As usual, move the boot vector setting in the pm.c file and use the cpu_pm
notifier to set it up.
Remove the unused headers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
Maybe a few lines here on why this is important..
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/Makefile |1 -
drivers/cpuidle/Kconfig.arm
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
No more dependency on the arch code. The platform_data field is used to set
the
PM callback as the other cpuidle driver.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/common.c |5
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
On 04/04/2014 11:10 AM, Viresh Kumar wrote:
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano
AFAICT, the fb_base of a drm_device's mode_config is never used. It isn't
accessed by core drm, it isn't used by fbmem, and it isn't exposed to user
space.
Furthermore, it is probably supposed to be a physical address, not the
dma address mapped to the display controller, so this is just wrong.
Kernel access to the eyxnos fbdev framebuffer is via its gem object's
kernel mapping (kvaddr, stored in info-screen_base).
User space access is provided by mmap(), read() and write() of /dev/fb/fb0.
These functions also only use screen_base/screen_size().
Therefore, it is not necessary to set
The following driver is for exynos4210. I did not yet finished the other
boards, so
I created a specific driver for 4210 which could be merged later.
The driver is based on Colin Cross's driver found at:
On 04/04/2014 11:00 AM, Sachin Kamat wrote:
Hi Daniel,
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
This patchset relies on the cpm_pm notifier to initiate the powerdown sequence
operations from pm.c instead cpuidle.c. Thus the cpuidle driver is no longer
dependent
Whatever happened with this btw? Also are you sure we don't need a
second check after line 457?
regards,
dan carpenter
On Tue, Aug 27, 2013 at 04:26:07PM +0200, Sylwester Nawrocki wrote:
On 08/27/2013 04:19 PM, Dan Carpenter wrote:
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki
1:GOOD NEWS,.....
..,1,...docx
Description: application/vnd.openxmlformats-officedocument.wordprocessingml.document
1:GOOD NEWS,.....
..,1,...docx
Description: application/vnd.openxmlformats-officedocument.wordprocessingml.document
Hi,
I tried to make the idle AFTR state working on arndale 5250 but that
leads to a kernel reboot and crash.
How to reproduce ?
echo 0 /sys/devices/system/cpu/cpu1/online
Reproductible on v3.14 and samsung/for-next
Any ideas ?
Thanks
-- Daniel
--
http://www.linaro.org/ Linaro.org │
Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
has already removed 'ohci_hcd' settings from exynos glue layer
as a part of streamlining the ohci controller's suspend.
So we don't need the locks for 'ohci_hcd' anymore.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc:
That makes the code cleaner and encapsulted. The function will be reused in the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/pm.c | 65 -
1 file
One more step is moving the clock ratio setting at idle time in pm.c
The macro names have been changed to be consistent with the other macros
name in the file.
Note, the clock divider was working only when cpuidle was enabled because it
was in its init routine. With this change, the clock
This function should be called only when the powerdown sequence fails.
Even if the current code does not hurt, by moving this line, we have the same
code than the one in pm.c.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
Let's encapsulate more the PM code inside the PM file by moving the
'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm
notifier.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |
The driver was initially written for exynos4 but the driver is used also for
exynos5.
Change the function prefix name exynos4 - exynos
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 20
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
arch/arm/mach-exynos/pm.c |4
2 files changed, 4 insertions(+), 6 deletions(-)
Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
has already removed 'ohci_hcd' settings from exynos glue layer
as a part of streamlining the ohci controller's suspend.
So we don't need the locks for 'ohci_hcd' anymore.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc:
On Fri, Apr 4, 2014 at 7:03 PM, Vivek Gautam gautamvivek1...@gmail.com wrote:
Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
has already removed 'ohci_hcd' settings from exynos glue layer
as a part of streamlining the ohci controller's suspend.
So we don't need the locks for
Hi Daniel,
On Fri, Apr 04, 2014 at 10:48:45AM +0100, Daniel Lezcano wrote:
The following driver is for exynos4210. I did not yet finished the other
boards, so
I created a specific driver for 4210 which could be merged later.
The driver is based on Colin Cross's driver found at:
This patchset adds some updates to clocks for Exynos4 platform and to the clock
core. The patches are rebased on linux/next.
An interesting part might be 'propagation of clk_set_parent()'. This feature
simplifies configuration of complex topologyof clocks by drivers. Such a
situation happens
Export sclk_hdmiphy clock to be usable from DT.
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
---
drivers/clk/samsung/clk-exynos4.c |2 +-
include/dt-bindings/clock/exynos4.h |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
This reverts commit 59956d35a8618235ea715280b49447bb36f2c975.
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
This patch adds support for propagation of setup of clock's parent one level
up.
This feature is helpful when a driver changes topology of its clocks using
clk_set_parent(). The problem occurs when on one platform/SoC driver's clock
is located at MUX output but on the other platform/SoC there is
On Friday, April 04, 2014 03:42:53 PM Daniel Lezcano wrote:
Move the structure below the 'exynos4_enter_lowpower' function so no more
need of forward declaration.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by:
On Friday, April 04, 2014 03:42:55 PM Daniel Lezcano wrote:
The driver was initially written for exynos4 but the driver is used also for
exynos5.
Change the function prefix name exynos4 - exynos
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar
On Friday, April 04, 2014 03:42:54 PM Daniel Lezcano wrote:
Use the cpuidle generic function 'cpuidle_register'. That saves us from some
extra lines of code and unneeded variables.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
On Friday, April 04, 2014 03:42:56 PM Daniel Lezcano wrote:
That makes the code cleaner and encapsulted. The function will be reused in
the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Bartlomiej
On Friday, April 04, 2014 03:42:58 PM Daniel Lezcano wrote:
This function should be called only when the powerdown sequence fails.
Even if the current code does not hurt, by moving this line, we have the same
code than the one in pm.c.
Signed-off-by: Daniel Lezcano
On Friday, April 04, 2014 03:42:59 PM Daniel Lezcano wrote:
Use the cpu_pm_enter/exit notifier to group some pm code inside the pm file.
The save and restore code is duplicated across pm.c and cpuidle.c. By using
the cpu_pm notifier, we can factor out the routine.
Signed-off-by: Daniel
On Friday, April 04, 2014 03:43:00 PM Daniel Lezcano wrote:
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Best regards,
On Friday, April 04, 2014 03:43:01 PM Daniel Lezcano wrote:
The scu_enable function is already a noop in the scu's header file is
CONFIG_SMP=n, so no need to use these macros in the code.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar
On Friday, April 04, 2014 03:43:02 PM Daniel Lezcano wrote:
Let's encapsulate more the PM code inside the PM file by moving the
'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm
notifier.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh
On Friday, April 04, 2014 03:43:03 PM Daniel Lezcano wrote:
The code to initiate and exit the powerdown sequence is the same in pm.c and
cpuidle.c.
Let's split the common part in the pm.c and reuse it from the cpu_pm notifier.
That is one more step forward to make the cpuidle driver arch
On Friday, April 04, 2014 03:43:04 PM Daniel Lezcano wrote:
Move the S5P_CHECK_AFTR definition to the header it belongs to.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Bartlomiej Zolnierkiewicz
On Friday, April 04, 2014 03:43:06 PM Daniel Lezcano wrote:
As usual, move the boot vector setting in the pm.c file and use the cpu_pm
notifier to set it up.
Remove the unused headers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar
On Friday, April 04, 2014 03:43:05 PM Daniel Lezcano wrote:
One more step is moving the clock ratio setting at idle time in pm.c
The macro names have been changed to be consistent with the other macros
name in the file.
Note, the clock divider was working only when cpuidle was enabled
On Friday, April 04, 2014 03:43:07 PM Daniel Lezcano wrote:
No more dependency on the arch code. The platform_data field is used to set
the
PM callback as the other cpuidle drivers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
On Friday, April 04, 2014 03:43:08 PM Daniel Lezcano wrote:
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung RD Institute
On Friday, April 04, 2014 03:43:09 PM Daniel Lezcano wrote:
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar
On 4/3/2014 4:32 AM, Lucas Stach wrote:
Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri:
Arnd,
Thanks for reviewing the RFC patch. Please see below my response.
On 3/25/2014 3:44 AM, Arnd Bergmann wrote:
On Monday 24 March 2014 20:35:26 Murali Karicheri wrote:
[...]
+
On Wed, Mar 05, 2014 at 02:25:47PM +0100, Lucas Stach wrote:
This is the recommended method of doing the IRQ
mapping. For old devicetrees we fall back to the
previous practice.
Signed-off-by: Lucas Stach l.st...@pengutronix.de
Acked-by: Arnd Bergmann a...@arndb.de
Applied with Stephen's
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote:
On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
- return pp-irq;
+ irq = of_irq_parse_and_map_pci(dev, slot, pin);
+ if (!irq)
+ irq = pp-irq;
In light of the two bugs that Tim found, it might
On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote:
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote:
On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
- return pp-irq;
+ irq = of_irq_parse_and_map_pci(dev, slot, pin);
+ if (!irq)
+ irq =
76 matches
Mail list logo
