Re: [PATCH 00/10] thermal: exynos: various cleanups

On 5/15/14, Zhang Rui wrote: > On 一, 2014-05-05 at 13:15 +0200, Bartlomiej Zolnierkiewicz wrote: >> Hi, >> >> This patch series contains various cleanups for EXYNOS thermal >> driver. Overall it decreases driver's LOC by 13%. It is based >> on next-20140428 kernel. It should not cause any funct

Re: [PATCH 10/10] thermal: exynos: remove identical values from exynos*_tmu_registers structures

On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There is no need for abstracting configuration for registers that > are identical on all SoC types. Changes look fine and also that shift and masks may not change in future socs also. Reviewed-by: Amit Daniel Kachhap > > There should be no functional c

Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > pdata->reference_voltage and pdata->gain are always defined > to non-zero values so remove the redundant checks from > exynos_tmu_control(). I prefer to have these checks for the same reason that new soc support should not add these same

Re: [PATCH 08/10] thermal: exynos: cache non_hw_trigger_levels in pdata

On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Cache number of non-hardware trigger levels in a new pdata field > (non_hw_trigger_levels) and convert code in exynos_tmu_initialize() > accordingly. Changes looks fine, Reviewed-by: Amit Daniel Kachhap > > There should be no functional changes caused

Re: [PATCH 07/10] thermal: exynos: simplify temp_to_code() and code_to_temp()

On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > * Remove dead temp check from temp_to_code() (this function users > in exynos_tmu_initialize() always pass correct temperatures and > exynos_tmu_set_emulation() returns early for EXYNOS4210 because > TMU_SUPPORT_EMULATION flag is not set on this

Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Remove runtime checks for negative return values of temp_to_code() > from exynos_tmu_initialize(). The current level temperature data > hardcoded in pdata will never cause a negative temp_to_code() > return values and for the new code potential mistak

Re: [PATCH 05/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_initialize()

On 5/15/14, Bartlomiej Zolnierkiewicz wrote: > On Thursday, May 15, 2014 10:47:40 AM Eduardo Valentin wrote: >> Hello Bartlomiej, > > Hi, > >> On Mon, May 05, 2014 at 01:15:34PM +0200, Bartlomiej Zolnierkiewicz >> wrote: >> > Remove runtime checks for pdata sanity from exynos_tmu_initialize(). >>

Re: [PATCH 04/10] thermal: exynos: remove dead code for TYPE_TWO_POINT_TRIMMING calibration

On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Only TYPE_ONE_POINT_TRIMMING calibration is used so remove > the dead code for TYPE_TWO_POINT_TRIMMING calibration. I prefer to retain this feature as it is provided by the TMU controller. This will avoid unnecessary churning of code when some new soc

Re: [PATCH v6 0/6] add cpuidle support for Exynos5420

Hi Daniel/Kgene, On 16 May 2014 13:33, Chander Kashyap wrote: > Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores. > > This patchset adds cpuidle support for Exynos5420 SoC based on > generic big.little cpuidle driver. > > Tested on SMDK5420. > > This patch set depends on:

Re: [PATCH] Fix for possible null pointer dereference in dma.c

Hi, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > sound/soc/samsung/dma.c | 10 ++ > 1 fil ändrad, 6 tillägg(

Re: [PATCH 03/10] thermal: exynos: remove dead code for HW_MODE calibration

Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu.c | 33 > +-- > drivers/thermal/samsung/exynos_tmu.h

Re: [PATCH 02/10] thermal: exynos: remove unused defines

Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu_data.h | 27 +-- > 1 file changed, 1 insertion(+), 26 deletion

[PATCH V2 2/2] ARM: dts: enable pwm backlight for snow

Add PWM backlight node for exynos5250 based snow board. Signed-off-by: Olof Johansson Signed-off-by: Ajay Kumar --- arch/arm/boot/dts/exynos5250-snow.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.

[PATCH V2 1/2] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5250

Adds the PWM nodes to 5250 pinctrl dtsi file. Signed-off-by: Ajay Kumar --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index 9

[PATCH V2 0/2] ARM: dts: snow: add backlight node

This series is based on Kukjin Kim's tree, for-next branch. This series adds: -- pinctrl definitions for pwmX_out on exynos5250 -- pwm-backlight DT node for exynos5250 based snow board Changes since V1: -- Added the branch name against which patches are created. --

Re: [PATCH 01/10] thermal: exynos: remove unused struct exynos_tmu_registers entries

Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu.h | 40 > --- > drivers/thermal/samsung/exynos_tmu_da

[PATCH v9 0/3] Exynos 5410 support

The series of patches represent support of Exynos 5410 SoC The Exynos 5410 is the first Samsung SoC based on big.LITTLE architecture Patches add new platform description, support of clock controller and device tree for Exynos 5410. Has been build on Samsung Linux Kernel (branch: for-next, comm

[PATCH v9 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC

EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. Add initial support for this SoC. Signed-off-by: Tarek Dakhran Signed-off-by: Vyacheslav Tyrtov Reviewed-by: Tomasz Figa --- arch/arm/mach-exynos/Kconfig |8 arch/arm/mach-exynos/exynos.c|1 + arch/arm/

[PATCH v9 2/3] clk: exynos5410: register clocks using common clock framework

The EXYNOS5410 clocks are statically listed and registered using the Samsung specific common clock helper functions. Signed-off-by: Tarek Dakhran Signed-off-by: Vyacheslav Tyrtov Acked-by: Tomasz Figa --- .../devicetree/bindings/clock/exynos5410-clock.txt | 51 + drivers/clk/samsung/Make

[PATCH v9 3/3] ARM: dts: Add initial device tree support for EXYNOS5410

Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board. Signed-off-by: Tarek Dakhran Signed-off-by: Vyacheslav Tyrtov Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/Makefile|1 + arch/arm/boot/dts/exynos5410-smdk5410.dts | 65 arch/arm/boot/dts/e

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

On 15 May 2014 19:37, Tomasz Figa wrote: > Hi Rahul, Tushar, > > On 15.05.2014 15:44, Rahul Sharma wrote: >> Hi Tushar, >> >> Basically you are adding a new clock-type for Clkout. IMO clkout >> is not a special hardware. Existing clock types can be reused to >> support clkout. I see 3 major proble

Re: [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs

Hi Tomasz, On Sat, May 17, 2014 at 6:02 AM, Tomasz Figa wrote: > > > On 16.05.2014 07:07, Abhilash Kesavan wrote: >> Hi Tomasz, >> >> On Fri, May 16, 2014 at 2:41 AM, Tomasz Figa wrote: >>> Hi Abhilash, >>> >>> On 13.05.2014 12:12, Abhilash Kesavan wrote: On Tue, May 13, 2014 at 7:54 AM, Ku

Re: [PATCH v4 4/4] clk: samsung: exynos5420: Setup clocks before system suspend

Hi Tomasz, On Fri, May 16, 2014 at 2:48 AM, Tomasz Figa wrote: > Hi Abhilash, > > On 13.05.2014 14:02, Abhilash Kesavan wrote: >> Prior to suspending the system, we need to ensure that certain >> clock source and gate registers are unmasked. >> >> Signed-off-by: Vikas Sajjan >> Signed-off-by: Ab

Re: [PATCH v6 0/5] MCPM backend for Exynos5420

Hi Nicolas, On Thu, May 15, 2014 at 10:22 PM, Nicolas Pitre wrote: > On Thu, 15 May 2014, Abhilash Kesavan wrote: > >> Hi Nicolas, >> >> On Wed, May 14, 2014 at 7:09 PM, Abhilash Kesavan >> wrote: >> > Hi Nicolas, >> > >> > On Wed, May 14, 2014 at 7:03 PM, Nicolas Pitre >> > wrote: >> >> On We

Re: [PATCH v6 0/5] MCPM backend for Exynos5420

Hi Kukjin, On Sat, May 17, 2014 at 5:25 AM, Kukjin Kim wrote: > On 05/16/14 01:52, Nicolas Pitre wrote: >> >> On Thu, 15 May 2014, Abhilash Kesavan wrote: >> >>> Hi Nicolas, > > > Hi all, > > >> [...] >> >> Good, that looks pretty good. >> > Thanks for you guys effort and time. > > Applied this w

RE: [PATCH v8 0/3] Exynos 5410 support

Kevin Hilman wrote: > > Tarek Dakhran writes: > > > The series of patches represent support of Exynos 5410 SoC > > > > The Exynos 5410 is the first Samsung SoC based on bigLITTLE architecture > > > > Patches add new platform description, support of clock controller and > device > > tree for Exyn

Re: exynos4412: porting hdmiddc and hdmiphy node entries

Hello, I made some progress with the HDMI output on the board. I updated to v4 of the exynos-simple-phy driver. @Rahul: You can add a tested-by from me, if you want. My dts now looks like this: https://github.com/tobiasjakobi/linux-odroid/blob/odroid-3.15.y/arch/arm/boot/dts/exynos4412-odroidx2.

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

On Sun, May 18, 2014 at 2:44 AM, Thierry Reding wrote: > On Thu, May 15, 2014 at 05:10:16PM +0530, Ajay kumar wrote: >> On Thu, May 15, 2014 at 1:43 PM, Thierry Reding >> wrote: > [...] >> > I still don't see how controlling the enable GPIO from the panel will be >> > in any way better, or diffe