Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support

2014-08-19 Thread Marek Szyprowski
Hello, On 2014-08-19 22:26, Olof Johansson wrote: On Tue, Aug 19, 2014 at 12:54 PM, Daniel Drake wrote: On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson wrote: ODROID-U3 has been broken in mainline for quite a while. Have patches been posted for this already? http://arm-soc.lixom.net/bootlog

Re: [PATCH] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-19 Thread amit daniel kachhap
On Wed, Aug 20, 2014 at 9:54 AM, Chanwoo Choi wrote: > This patch remove simply duplicate code when reading triminfo register of > Exynos5440. > > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Amit Daniel Kachhap Reviewed-by: Amit Daniel K

Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread Chanwoo Choi
Dear Amit, On 08/20/2014 01:51 PM, amit daniel kachhap wrote: > On Wed, Aug 20, 2014 at 5:22 AM, Chanwoo Choi wrote: >> This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of >> Exynos3250 has two TRIMINFO_CON register. >> >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Pa

Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread amit daniel kachhap
On Wed, Aug 20, 2014 at 5:22 AM, Chanwoo Choi wrote: > This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of > Exynos3250 has two TRIMINFO_CON register. > > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Amit Daniel Kachhap

[PATCH] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-19 Thread Chanwoo Choi
This patch remove simply duplicate code when reading triminfo register of Exynos5440. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Cc: Zhang Rui Cc: Eduardo Valentin Cc: Amit Daniel Kachhap --- drivers/thermal/samsung/exynos_tmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

Re: [PATCH V2 4/9] drm/exynos: add exynos_dp_panel driver registration to drm driver

2014-08-19 Thread Stéphane Marchesin
On Tue, Apr 22, 2014 at 8:26 AM, Thierry Reding wrote: > On Tue, Apr 22, 2014 at 08:33:23PM +0530, Ajay kumar wrote: >> Hi Thierry, >> >> On Tue, Apr 22, 2014 at 2:03 PM, Thierry Reding >> wrote: >> > On Tue, Apr 22, 2014 at 04:09:13AM +0530, Ajay Kumar wrote: >> >> Register exynos_dp_panel befor

[PATCH] videobuf2-core: make checking condition more strict

2014-08-19 Thread Zhaowei Yuan
It's also invalid that plane_no equals to vb->num_planes Signed-off-by: Zhaowei Yuan --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index c359

[PATCH v7 01/11] kernel: Add support for kernel restart handler call chain

2014-08-19 Thread Guenter Roeck
Various drivers implement architecture and/or device specific means to restart (reset) the system. Various mechanisms have been implemented to support those schemes. The best known mechanism is arm_pm_restart, which is a function pointer to be set either from platform specific code or from drivers.

[PATCH v7 03/11] arm64: Support restart through restart handler call chain

2014-08-19 Thread Guenter Roeck
The kernel core now supports a restart handler call chain to restart the system. Call it if arm_pm_restart is not set. Signed-off-by: Guenter Roeck Acked-by: Catalin Marinas Acked-by: Heiko Stuebner --- v7: No change. v6: No change. v5: Renamed restart function to do_kernel_restart v4: No chang

[PATCH v7 00/11] kernel: Add support for restart handler call chain

2014-08-19 Thread Guenter Roeck
Various drivers implement architecture and/or device specific means to restart (reset) the system. Various mechanisms have been implemented to support those schemes. The best known mechanism is arm_pm_restart, which is a function pointer to be set either from platform specific code or from drivers.

[PATCH v7 05/11] watchdog: moxart: Register restart handler with kernel restart handler

2014-08-19 Thread Guenter Roeck
The kernel now provides an API to trigger a system restart. Register with it instead of setting arm_pm_restart. Signed-off-by: Guenter Roeck Acked-by: Catalin Marinas Acked-by: Heiko Stuebner --- v7: No change. v6: No change. v5: Functions and variables renamed: *notifier -> *handler v4: Set no

[PATCH v7 02/11] power/restart: Call machine_restart instead of arm_pm_restart

2014-08-19 Thread Guenter Roeck
machine_restart is supported on non-ARM platforms, and and ultimately calls arm_pm_restart, so dont call arm_pm_restart directly but use the more generic function. Cc: Russell King Signed-off-by: Guenter Roeck Acked-by: Catalin Marinas Acked-by: Heiko Stuebner --- v7: No change. v6: No change.

[PATCH v7 04/11] arm: Support restart through restart handler call chain

2014-08-19 Thread Guenter Roeck
The kernel core now supports a restart handler call chain for system restart functions. With this change, the arm_pm_restart callback is now optional, so drop its initialization and check if it is set before calling it. Only call the kernel restart handler if arm_pm_restart is not set. Signed-off

[PATCH v7 06/11] watchdog: alim7101: Register restart handler with kernel restart handler

2014-08-19 Thread Guenter Roeck
The kernel core now provides an API to trigger a system restart. Register with it to restart the system instead of misusing the reboot notifier. Signed-off-by: Guenter Roeck Acked-by: Catalin Marinas Acked-by: Heiko Stuebner --- v7: No change. v6: No change. v5: Function and variable renames: *

[PATCH v7 07/11] watchdog: sunxi: Register restart handler with kernel restart handler

2014-08-19 Thread Guenter Roeck
The kernel core now provides an API to trigger a system restart. Register with it instead of setting arm_pm_restart. Signed-off-by: Guenter Roeck Acked-by: Heiko Stuebner --- v7: Added patch to series. Necessary since the restart handler in the driver is now available upstream. drivers/wat

[PATCH v7 08/11] arm/arm64: Unexport restart handlers

2014-08-19 Thread Guenter Roeck
Implementing a restart handler in a module don't make sense as there would be no guarantee that the module is loaded when a restart is needed. Unexport arm_pm_restart to ensure that no one gets the idea to do it anyway. Signed-off-by: Guenter Roeck Acked-by: Catalin Marinas Acked-by: Heiko Stueb

[PATCH v7 10/11] clk: samsung: register restart handlers for s3c2412 and s3c2443

2014-08-19 Thread Guenter Roeck
From: Heiko Stübner S3C2412, S3C2443 and their derivatives contain a special software-reset register in their system-controller. Therefore register a restart handler for those. Tested on a s3c2416-based board, s3c2412 compile-tested. Signed-off-by: Heiko Stuebner Signed-off-by: Guenter Roeck

[PATCH v7 09/11] watchdog: s3c2410: add restart handler

2014-08-19 Thread Guenter Roeck
From: Heiko Stübner On a lot of Samsung systems the watchdog is responsible for restarting the system and until now this code was contained in plat-samsung/watchdog-reset.c. With the introduction of the restart handlers, this code can now move into driver itself, removing the need for arch-speci

[PATCH v7 11/11] clk: rockchip: add restart handler

2014-08-19 Thread Guenter Roeck
From: Heiko Stübner Add infrastructure to write the correct value to the restart register and register the restart notifier for both rk3188 (including rk3066) and rk3288. Signed-off-by: Heiko Stuebner Signed-off-by: Guenter Roeck --- v7: Added patch to series. drivers/clk/rockchip/clk-rk3188

[PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread Chanwoo Choi
This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of Exynos3250 has two TRIMINFO_CON register. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Cc: Zhang Rui Cc: Eduardo Valentin Cc: Amit Daniel Kachhap --- Changes from v2: - Fix build break because of missing 'or' oper

Re: [PATCHv2] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread Chanwoo Choi
Dear Eduardo, I'm so sorry. This patch has build break as following: It is my mistake about missing 'or' operation when adding TMU_SUPPORT_TRIM_RELOAD. + .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD\ I'll send new patch to fix it right now. Best Regards, Chanwoo Choi On

Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support

2014-08-19 Thread Olof Johansson
On Tue, Aug 19, 2014 at 12:54 PM, Daniel Drake wrote: > On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson wrote: >> ODROID-U3 has been broken in mainline for quite a while. Have patches >> been posted for this already? >> >> http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_d

Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support

2014-08-19 Thread Daniel Drake
On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson wrote: > ODROID-U3 has been broken in mainline for quite a while. Have patches > been posted for this already? > > http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html > for one of the latest boots that failed. Ye

Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support

2014-08-19 Thread Olof Johansson
ODROID-U3 has been broken in mainline for quite a while. Have patches been posted for this already? http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html for one of the latest boots that failed. -Olof On Fri, Jul 18, 2014 at 8:40 AM, Przemyslaw Marczak wrote

Re: [PATCH 1/6] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC

2014-08-19 Thread Andreas Färber
Am 19.08.2014 17:08, schrieb Javier Martinez Canillas: > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts > b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 228a6b1..8619d58 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Andreas Färber
Hi Javier, Am 19.08.2014 17:08, schrieb Javier Martinez Canillas: > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts > b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8e50042..5b9dbb9 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-

[PATCH v10 11/19] irqchip: vic: Add support for FIQ management

2014-08-19 Thread Daniel Thompson
This patch introduces callbacks to route interrupts to or away from the FIQ signal. It also causes these callbacks to be registered with the FIQ infrastructure. This patch enable FIQ support for mach-versatile whilst mach-ep93xx, mach-netx, mach-s3c64xx and plat-samsung are unmodified (and can the

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Doug Anderson
Javier, On Tue, Aug 19, 2014 at 8:08 AM, Javier Martinez Canillas wrote: > The VCC/VDD and VCCQ/VDD_IO power supplies for the MMC are > provided by the tps65090 fet4 and max77802 ldo4 regulators > respectively. Add the phandle to the regulators tree nodes > for the the dw_mmc device device. > > T

[PATCH 6/6] ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor

2014-08-19 Thread Javier Martinez Canillas
The Exynos5420 based Peach Pit and the Exynos5800 based Peach Pi machines have an i2c ISL29018 light sensor. This patch adds the device nodes needed to support this device. These DTS snippets were taken from the downstream Chrome OS 3.8 kernel Device Tree for Peach Pit and Pi boards. Signed-off-b

[PATCH 4/6] ARM: dts: Add thermistor dts fragment used by exynos based Peach boards

2014-08-19 Thread Javier Martinez Canillas
From: Naveen Krishna Chatradhi This patch creates a thermistor fragment carrying the NTC Thermistor nodes as children of the IIO based ADC. This fragment is included in exynos5420-peach-pit.dts and exynos5800-peach-pi.dts. Signed-off-by: Naveen Krishna Chatradhi Signed-off-by: Javier Martinez

[PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Javier Martinez Canillas
The VCC/VDD and VCCQ/VDD_IO power supplies for the MMC are provided by the tps65090 fet4 and max77802 ldo4 regulators respectively. Add the phandle to the regulators tree nodes for the the dw_mmc device device. These DTS snippets were taken from the downstream ChromeOS 3.8 kernel Device Tree for P

[PATCH 3/6] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board

2014-08-19 Thread Javier Martinez Canillas
From: Rahul Sharma Adding regulators for hdmi for peach-pit board. Signed-off-by: Rahul Sharma Reviewed-by: Javier Martinez Canillas Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/d

[PATCH 2/6] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-08-19 Thread Javier Martinez Canillas
From: Rahul Sharma Adding regulators for HDMI for Peach-pi board. Signed-off-by: Rahul Sharma Reviewed-by: Javier Martinez Canillas Signed-off-by: Javier Martinez Canillas --- v2: 1) Add blank line before hdmi regulators. arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 + 1 file changed,

[PATCH 1/6] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC

2014-08-19 Thread Javier Martinez Canillas
Exynos5420 based Peach Pit and Exynos5800 based Peach Pi boards uses a Maxim 77802 power management IC to drive regulators and its Real Time Clock. This patch adds support for this chip. These are the device nodes and pinctrl configuration that are present on the Peach pit DeviceTree source file i

[PATCH 0/6] Add max77802 support for Peach boards

2014-08-19 Thread Javier Martinez Canillas
Hello Kukjin, Mark Brown has already queued for 3.18 the max77802 PMIC regulators driver so now we can add support for these in the Peach Pit and Pi DTS and also merge all the posted patches that depend on this. I've picked all the patches I found and rebased them to be sure that they apply cleanl

Re: [PATCH v7 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-08-19 Thread Tomasz Figa
Hi Bart, On 18.08.2014 19:42, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, July 28, 2014 08:40:52 AM Pankaj Dubey wrote: >> Hi Tomasz, >> >> On Friday, July 25, 2014 Tomasz Figa wrote: >> >>> To: Pankaj Dubey; 'Kukjin Kim'; linux-arm-ker...@lists.infradead.org; >> linux- >>> samsung-.

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Javier Martinez Canillas
On 08/19/2014 02:43 PM, Ulf Hansson wrote: > > Well, currently this seems like the best approach. If we end up having > some new regulator helper function, future wise, we can convert to > such later on. > Great, thanks a lot for your help! > Kind regards > Uffe > Best regards, Javier -- To un

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Ulf Hansson
On 14 August 2014 14:39, Javier Martinez Canillas wrote: > The operation conditions register (OCR) stores the voltage > profile of the card, however the list of possible voltages > is restricted by the voltage range supported by the supply > used as VCC/VDD. So in mmc_vddrange_to_ocrmask() a OCR m

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Ulf Hansson
On 19 August 2014 13:29, Javier Martinez Canillas wrote: > Hello Ulf, > > On 08/15/2014 04:51 PM, Ulf Hansson wrote: >> >> Just wanted to add some input regarding the errors in the mmc case. >> These are of high importance. In principle if you get, "Failed getting >> OCR mask: -22", likely you wil

Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2014-08-19 Thread Andreas Färber
Hi, Am 19.08.2014 14:01, schrieb Marek Szyprowski: > On 2014-08-19 13:39, Andreas Färber wrote: >> I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 >> got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my >> machine stops booting. So I'm wondering, is any of

Re: [PATCHv2] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread edubez...@gmail.com
Amit, On Tue, Aug 19, 2014 at 8:07 AM, Chanwoo Choi wrote: > This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of > Exynos3250 has two TRIMINFO_CON register. > > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park > Cc: Zhang Rui > Cc: Eduardo Valentin What do you think

[PATCHv2] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread Chanwoo Choi
This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of Exynos3250 has two TRIMINFO_CON register. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Cc: Zhang Rui Cc: Eduardo Valentin --- Changes from v1: - Add missing 'TMU_SUPPORT_TRIM_RELOAD' features drivers/thermal/sams

Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2014-08-19 Thread Marek Szyprowski
Hello, On 2014-08-19 13:39, Andreas Färber wrote: Hi Marek and Inki, Am 19.08.2014 08:07, schrieb Marek Szyprowski: On 2014-08-19 01:32, Joerg Roedel wrote: On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: [...] 33 files changed, 1016 insertions(+), 356 deletions(-) Thi

[PATCH] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread Chanwoo Choi
This patch add support for TRIM_RELOAD feature at Exynos3250. The TMU of Exynos3250 has two TRIMINFO_CON register. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Cc: Zhang Rui Cc: Eduardo Valentin --- drivers/thermal/samsung/exynos_tmu.c | 7 +-- drivers/thermal/samsung/exynos_t

Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2014-08-19 Thread Andreas Färber
Hi Marek and Inki, Am 19.08.2014 08:07, schrieb Marek Szyprowski: > On 2014-08-19 01:32, Joerg Roedel wrote: >> On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: [...] >>> 33 files changed, 1016 insertions(+), 356 deletions(-) >> This touches a lot of non-iommu stuff. What is you

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Javier Martinez Canillas
Hello Ulf, On 08/15/2014 04:51 PM, Ulf Hansson wrote: > > Just wanted to add some input regarding the errors in the mmc case. > These are of high importance. In principle if you get, "Failed getting > OCR mask: -22", likely you will be using a wrong OCR mask while > negotiating the voltage level

Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID

2014-08-19 Thread Javier Martinez Canillas
Hello, On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz wrote: > > IMHO they should go to upstream ASAP as they fix the boot for > ODROID boards and they cannot break anything as they are limited > to ODROID dts files. > Agreed, this is definitely -rc material IMHO. Best regards, Jav

Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID

2014-08-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote: > On 08/12/14 08:06, Tomeu Vizoso wrote: > > Tested on an Odroid-U2: > > > > Tested-by: Tomeu Vizoso > > > > Thanks, > > > > Tomeu > > > > > > On 16 July 2014 10:50, Daniel Drake wrote: > >> The ODROID kernel shows that the PMIC interr

Re: [PATCH] ARM: Exynos: remove arm diagnostic and power register save/restore code

2014-08-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, August 19, 2014 02:58:31 PM Chander Kashyap wrote: > On Mon, Aug 11, 2014 at 11:52 AM, Chander Kashyap > wrote: > > As save/restore of arm "diagnostic" and "power" registers is handled by > > generic code, so remove the same. > > > > Signed-off-by: Chander Kashyap > > --- > >

Re: [RESEND PATCH v4 2/2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, August 19, 2014 01:26:49 PM Vikas Sajjan wrote: > Hi Kukjin, > > On Tue, Aug 19, 2014 at 12:22 PM, Vikas Sajjan > wrote: > > Refactoring the pm.c to avoid using "soc_is_exynos" checks, > > instead use the DT based lookup. > > > > While at it, consolidate the common code across

Re: [PATCH] ARM: Exynos: remove arm diagnostic and power register save/restore code

2014-08-19 Thread Chander Kashyap
On Mon, Aug 11, 2014 at 11:52 AM, Chander Kashyap wrote: > As save/restore of arm "diagnostic" and "power" registers is handled by > generic code, so remove the same. > > Signed-off-by: Chander Kashyap > --- > arch/arm/mach-exynos/pm.c | 54 > ++--- > 1

Re: [RESEND PATCH v4 2/2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-19 Thread Vikas Sajjan
Hi Kukjin, On Tue, Aug 19, 2014 at 12:22 PM, Vikas Sajjan wrote: > Refactoring the pm.c to avoid using "soc_is_exynos" checks, > instead use the DT based lookup. > > While at it, consolidate the common code across SoCs > and create static helper functions. > > Signed-off-by: Vikas Sajjan > Revie