Re: [PATCH] ARM: dts: add board dts file for Exynos3250-based Monk board

2014-10-02 Thread Kyungmin Park
+ Adding ARM maintainers. I know it's too late. just to know we trying to push product board support at mainline. Thank you, Kyungmin Park On Thu, Oct 2, 2014 at 9:50 AM, YoungJun Cho yj44@samsung.com wrote: From: Youngjun Cho yj44@samsung.com This patch adds new board dts file to

Re: [PATCH 0/2] ARM: dts: Add new board dts file for Exynos3250-based Rinato board

2014-10-02 Thread Kyungmin Park
+ ARM maintainers. It's Gear 2 board support. Thank you, Kyungmin Park On Tue, Sep 30, 2014 at 8:07 PM, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset adds new board dts file for Samsung Rinato board (Gear 2) which is based on Exynos3250 SoC and adds sleep mode pin configuration

Re: [PATCH 0/5] pinctrl: samsung: Data structure clean-up

2014-10-02 Thread Linus Walleij
On Sat, Sep 27, 2014 at 2:50 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 25.09.2014 09:49, Tomasz Figa wrote: On 25.09.2014 09:47, Linus Walleij wrote: On Tue, Sep 23, 2014 at 9:05 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This series intends to clean up data structures used by

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Joonyoung Shim
Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being able to acquire vblank counter. This problem

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Ulf Hansson
On 1 October 2014 18:36, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 01/10/14 16:41, Ulf Hansson wrote: There are currently no users of this API, let's remove it. Hi Sylwester, Thanks for your reply! The sad fact is that removal of pm_genpd_dev_need_restore() calls from

RE: [GIT PULL 1/3] 3rd Round for Samsung-cleanup-2 for v3.18

2014-10-02 Thread Kukjin Kim
Arnd Bergmann wrote: On Thursday 25 September 2014, Kukjin Kim wrote: The following changes since commit f6361c6b3880063c2248d4e453331e3dc1efbf83: ARM: S3C24XX: remove separate restart code (2014-09-14 02:43:09 +0900) are available in the git repository at:

Re: [PATCH v2 2/4] ARM: exynos: Ensure PM domains are powered at initialization

2014-10-02 Thread Ulf Hansson
On 1 October 2014 21:50, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, October 01, 2014 06:18:58 PM Sylwester Nawrocki wrote: On 01/10/14 16:41, Ulf Hansson wrote: At -probe() it's common practice for drivers/subsystems to bring their devices to full power and without depending

Re: [PATCH v2 2/4] ARM: exynos: Ensure PM domains are powered at initialization

2014-10-02 Thread Ulf Hansson
On 2 October 2014 11:42, Ulf Hansson ulf.hans...@linaro.org wrote: On 1 October 2014 21:50, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, October 01, 2014 06:18:58 PM Sylwester Nawrocki wrote: On 01/10/14 16:41, Ulf Hansson wrote: At -probe() it's common practice for

Re: [PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-10-02 Thread Inki Dae
On 2014년 10월 01일 22:17, Tomasz Figa wrote: Hi Inki, On 17.09.2014 15:48, Inki Dae wrote: This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific to Exynos drm and instead uses drm generic mmap. It looks like libdrm_exynos is still using DRM_EXYNOS_GEM_MMAP, but this patch just

Re: [PATCH 1/2] drm/exynos: remove DRM_EXYNOS_GEM_MAP_OFFSET ioctl

2014-10-02 Thread Inki Dae
On 2014년 10월 02일 08:47, Joonyoung Shim wrote: Hi Tomasz, On 10/02/2014 12:13 AM, Tomasz Figa wrote: Hi Inki, On 17.09.2014 15:48, Inki Dae wrote: This interface and relevant codes aren't used anymore. Hmm, I might be missing something, but after removing this IOCTL, how do we obtain an

Re: [PATCH 1/2] drm/exynos: remove DRM_EXYNOS_GEM_MAP_OFFSET ioctl

2014-10-02 Thread Tomasz Figa
On 02.10.2014 12:25, Inki Dae wrote: On 2014년 10월 02일 08:47, Joonyoung Shim wrote: Hi Tomasz, On 10/02/2014 12:13 AM, Tomasz Figa wrote: Hi Inki, On 17.09.2014 15:48, Inki Dae wrote: This interface and relevant codes aren't used anymore. Hmm, I might be missing something, but after

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Inki Dae
On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being

Re: [PATCH] ARM: dts: add board dts file for Exynos3250-based Monk board

2014-10-02 Thread Mark Rutland
On Thu, Oct 02, 2014 at 01:50:25AM +0100, YoungJun Cho wrote: From: Youngjun Cho yj44@samsung.com This patch adds new board dts file to support Samsung Monk board which is based on Exynos3250 SoC and has different H/W configuration from Rinato. This patch is based on linux-samsung.git

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Andrzej Hajda
Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Sylwester Nawrocki
Hello Ulf, On 02/10/14 11:09, Ulf Hansson wrote: On 1 October 2014 18:36, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 01/10/14 16:41, Ulf Hansson wrote: There are currently no users of this API, let's remove it. Hi Sylwester, Thanks for your reply! The sad fact is that removal

re: [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver

2014-10-02 Thread Dan Carpenter
Hello Sylwester Nawrocki, The patch 34947b8aebe3: [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver from Dec 20, 2013, leads to the following static checker warning: drivers/media/platform/exynos4-is/fimc-isp-video.c:413 isp_video_try_fmt_mplane() error: NULL

[PATCH 4/7] Documentation: charger: max77693: Document exported sysfs entry

2014-10-02 Thread Krzysztof Kozlowski
Document the settings exported by max77693 charger driver through sysfs entries: - fast_charge_timer - top_off_threshold_current - top_off_timer Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/ABI/testing/sysfs-class-power | 42 + 1

[PATCH 3/7] devicetree: mfd: max77693: Document new bindings for charger

2014-10-02 Thread Krzysztof Kozlowski
Document new device tree bindings for for Maxim 77693 charger driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell

[PATCH 6/7] ARM: exynos_defconfig: Enable Maxim 77693 charger

2014-10-02 Thread Krzysztof Kozlowski
Enable the max77693 charger driver used on Trats2 board. This allows querying the charging status through power supply interface. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/7] mfd: max77693: Add defines for MAX77693 charger driver

2014-10-02 Thread Krzysztof Kozlowski
Prepare for adding support for Maxim 77693 charger by adding necessary new defines and structure for device tree parsed data. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- include/linux/mfd/max77693-private.h | 108 +++

[PATCH 7/7] ARM: multi_v7_defconfig: Enable Maxim 77693 charger

2014-10-02 Thread Krzysztof Kozlowski
Enable the max77693 charger driver used on Trats2 board. This allows querying the charging status through power supply interface. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/7] power: max77693: Add charger driver for Maxim 77693

2014-10-02 Thread Krzysztof Kozlowski
Add new driver for Maxim 77693 switch-mode charger (part of max77693 MFD driver) providing power supply class information to userspace. The charger has +20V tolerant input. Current input can be set from 0 to 2.58 A. The charger can deliver up to 2.1 A to the battery or 3.5 A to the system (when

[PATCH 0/7] power/mfd: Add max77693 charger driver

2014-10-02 Thread Krzysztof Kozlowski
Hi, The patchset adds max77693 charger driver present on Trats2 board (and Galaxy S III). The driver configures battery charger and exposes power supply interface. Driver is necessary to provide full charging stack on Trats2 device (extcon, charger-manager etc.). The first 2 patches depend on

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Ulf Hansson
On 2 October 2014 14:00, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hello Ulf, On 02/10/14 11:09, Ulf Hansson wrote: On 1 October 2014 18:36, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 01/10/14 16:41, Ulf Hansson wrote: There are currently no users of this API, let's remove

Re: [GIT PULL 3/3] 3rd Round of Exynos-PM-2 Updates for v3.18

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, October 01, 2014 08:31:47 PM Arnd Bergmann wrote: On Wednesday 01 October 2014 18:49:20 Bartlomiej Zolnierkiewicz wrote: On Wednesday, October 01, 2014 06:01:29 PM Arnd Bergmann wrote: On Thursday 25 September 2014, Kukjin Kim wrote: Exynos 2nd PM related updates for

Re: [PATCH v8 0/2] Adds PMU and S2R support for exynos5420

2014-10-02 Thread Vikas Sajjan
Hi Javier, On Wed, Oct 1, 2014 at 7:20 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Vikas, On Wed, Oct 1, 2014 at 12:23 PM, Vikas Sajjan vikas.saj...@samsung.com wrote: My git log looks like below on top of Kukjin's for-next branch, d861ddd clk: exynos: Add

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Sylwester Nawrocki
On 02/10/14 15:30, Ulf Hansson wrote: [...] Correct me if I am wrong, but I think in principle these exynos drivers don't use pm_runtime_set_active() during -probe() and are instead relying on CONFIG_PM_RUNTIME to be enabled. Yes, pm_runtime_set_active() is not used in probe(), I believe this

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, October 01, 2014 09:04:09 AM Doug Anderson wrote: Hi, On Wed, Oct 1, 2014 at 7:00 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Wednesday, October 01, 2014 12:47:52 AM YUVARAJ CD wrote: Since I am out of station, i dont have an access to

[PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is not specified. Fix it. Without this patch: - mmc: dw_mmc: use mmc_regulator_get_supply to

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
Bartiomiej, On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and

Re: [PATCH] ASoC: samsung: fix CDCLK handling

2014-10-02 Thread Sylwester Nawrocki
[dropping unrelated addresses from Cc] On 30/09/14 18:40, Daniel Drake wrote: ODROID is the only platform that uses CDCLK, and right now, CDCLK handling is buggy. If you start pulseaudio on ODROID, audio is broken until reboot (even after killing pulse). This happens because CDCLK gets

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: Bartiomiej, On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
Bartiomiej On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: Bartiomiej, On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Regulators for MMC2 (SD

Re: [PATCH v8 0/2] Adds PMU and S2R support for exynos5420

2014-10-02 Thread Javier Martinez Canillas
Hello Vikas, On Thu, Oct 2, 2014 at 4:24 PM, Vikas Sajjan vikas.saj...@samsung.com wrote: Hi Javier, On Wed, Oct 1, 2014 at 7:20 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Vikas, On Wed, Oct 1, 2014 at 12:23 PM, Vikas Sajjan vikas.saj...@samsung.com wrote: My git log

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: Bartiomiej On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: Bartiomiej, On Thu, Oct 2, 2014 at 9:10 AM,

Re: [PATCH] ASoC: samsung: fix CDCLK handling

2014-10-02 Thread Mark Brown
On Thu, Oct 02, 2014 at 06:16:43PM +0200, Sylwester Nawrocki wrote: [dropping unrelated addresses from Cc] You've dropped Liam who's the other ASoC maintainer. Sorry for getting back late to this. Indeed we have a mess here. I mostly tested interaction between two CPU DAIs - the main and the

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Ulf Hansson
On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is not

[PATCH v2 2/5] pinctrl: samsung: Drop unused label field in samsung_pin_ctrl struct

2014-10-02 Thread Tomasz Figa
There is no code using it and in fact there are pin controller variants that do not even have this field initialized in their init data. This patch removes it completely. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Tested-by: Marek Szyprowski m.szyprow...@samsung.com Tested by: Javier

[PATCH v2 0/5] pinctrl: samsung: Data structure clean-up

2014-10-02 Thread Tomasz Figa
This series intends to clean up data structures used by pinctrl-samsung driver. More specifically, it separates initial compile time constants from data used at runtime, allowing unused variant data to be dropped and selected structures constified to improve safety. As a side effect, size of

[PATCH v2 5/5] pinctrl: samsung: Separate per-bank init and runtime data

2014-10-02 Thread Tomasz Figa
Currently the driver mixes constant init data with runtime data, which is far from being elegant and can invite potential hard to track issues. This patch intends to solve this by introducing a new samsung_pin_bank_data structure to hold only constant data known at compile time, which can be

[PATCH v2 4/5] pinctrl: samsung: Constify samsung_pin_ctrl struct

2014-10-02 Thread Tomasz Figa
In order to separate initialization constants from runtime data, this patch modifies the driver to store only constant data in samsung_pin_ctrl struct and copy data required at runtime to samsung_pinctrl_drv_data struct. This makes it possible to mark all existing instances of samsung_pin_ctrl

[PATCH v2 1/5] pinctrl: samsung: Make samsung_pinctrl_get_soc_data use ERR_PTR()

2014-10-02 Thread Tomasz Figa
Currently the function returns a valid pointer on success and NULL on error, so exact error code is lost. This patch changes return convention of the function to use ERR_PTR() on error instead. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Tested-by: Marek Szyprowski m.szyprow...@samsung.com

[PATCH v2 3/5] pinctrl: samsung: Constify samsung_pin_bank_type struct

2014-10-02 Thread Tomasz Figa
This structure is not intended to be modified at runtime and functions as constant data shared between multiple pin banks. This patch makes all instances of it constant across the driver. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Tested-by: Marek Szyprowski m.szyprow...@samsung.com Tested

Re: pwm-samsung: incorrect register values for 100% duty cycle

2014-10-02 Thread Daniel Drake
Hi, Thanks for looking into this. On Wed, Oct 1, 2014 at 4:55 AM, Tomasz Figa tomasz.f...@gmail.com wrote: I think that comment is incorrect. If tcmp is written as -1UL then the LED totally turns off. And there is nothing in the Exynos4412 manual to suggest that -1UL should be set in the TCMP

Re: pwm-samsung: incorrect register values for 100% duty cycle

2014-10-02 Thread Tomasz Figa
On 02.10.2014 21:27, Daniel Drake wrote: Hi, Thanks for looking into this. On Wed, Oct 1, 2014 at 4:55 AM, Tomasz Figa tomasz.f...@gmail.com wrote: I think that comment is incorrect. If tcmp is written as -1UL then the LED totally turns off. And there is nothing in the Exynos4412 manual

Re: pwm-samsung: incorrect register values for 100% duty cycle

2014-10-02 Thread Daniel Drake
On Thu, Oct 2, 2014 at 1:49 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This is strange. I remember verifying various edge cases with a scope on an Exynos4210-based Origen board and I don't recall any issues. Unfortunately I don't have appropriate hardware to recheck this specific case

Re: [PATCH] ASoC: samsung: fix CDCLK handling

2014-10-02 Thread Sylwester Nawrocki
On 2014-10-02 19:54, Mark Brown wrote: On Thu, Oct 02, 2014 at 06:16:43PM +0200, Sylwester Nawrocki wrote: [dropping unrelated addresses from Cc] You've dropped Liam who's the other ASoC maintainer. Whoops, pardon me, somewhat I thought about Liam more as the regulator API author, rather

Re: [PATCH v2 0/4] PM / Domains: Fix race conditions during boot

2014-10-02 Thread Kevin Hilman
Ulf, Rafael, Ulf Hansson ulf.hans...@linaro.org writes: When there are more than one device in a PM domain these will obviously be probed at different times. Depending on timing and the implemented support for runtime PM in a driver/subsystem, genpd may be advised to power off a PM domain

Re: [PATCH 1/2] i2c: exynos: add support for HSI2C module on Exynos7

2014-10-02 Thread Wolfram Sang
On Tue, Sep 16, 2014 at 03:03:17PM +0530, Naveen Krishna Chatradhi wrote: The HSI2C module on Exynos7 differs in the transfer status bits. Transfer status bits were moved to INT_ENABLE and INT_STATUS registers This patch adds support for the HSI2C module on Exynos7. 1. Implementes a hw