On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski
wrote:
> On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote:
>> Hi, and thanks for bringing this issue to us!
>>
>> On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas
>> wrote:
>> > [adding Linus and Alexandre to the cc list]
>>
Hi Kukjin,
On Tue, Oct 28, 2014 at 5:56 PM, Abhilash Kesavan
wrote:
> Hi Kukjin
>
> On Tue, Oct 28, 2014 at 4:01 PM, Kukjin Kim wrote:
>> Abhilash Kesavan wrote:
>>>
>> Hi,
>>
>> Sorry for late response.
>>
>>> Remove symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS which
>>> select the n
On Thu, Oct 30, 2014 at 01:47:27PM -0700, Kevin Hilman wrote:
> Ulf Hansson writes:
>
> > To sucessfully probe some devices their corresponding PM domains may
> > need to be powered.
>
> Isn't that what pm_runtime_get*() is supposed to be doing? Why isn't
> that working?
Also, I do not underst
On Thu, Oct 30, 2014 at 01:46:43PM -0700, Kevin Hilman wrote:
> Mark Brown writes:
> > On Fri, Oct 24, 2014 at 09:12:39AM -0700, Kevin Hilman wrote:
> >> I'm confused. Why arent' pm_runtime_get*() and pm_runtime_put*() working?
> >> What's not explained here (or what I'm not understanding) is wh
Ulf Hansson writes:
> To sucessfully probe some devices their corresponding PM domains may
> need to be powered.
Isn't that what pm_runtime_get*() is supposed to be doing? Why isn't
that working?
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body
Mark Brown writes:
> On Fri, Oct 24, 2014 at 09:12:39AM -0700, Kevin Hilman wrote:
>> Ulf Hansson writes:
>
>> > There may be more than one device in a PM domain which then will be
>> > probed at different points in time.
>
>> > Depending on timing and runtime PM support, in for the device relat
"Rafael J. Wysocki" writes:
> On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote:
>> Convert the prototype to return and int. This is just an initial step,
>> needed to support error handling.
>>
>> Signed-off-by: Ulf Hansson
Acked-by: Kevin Hilman
>>
>> This patch is intended as f
On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote:
> Convert the prototype to return and int. This is just an initial step,
> needed to support error handling.
>
> Signed-off-by: Ulf Hansson
> ---
>
> This patch is intended as fix for 3.18 rc[n]. Why?
>
> There are other SOC specific
On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote:
> Hi, and thanks for bringing this issue to us!
>
> On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas
> wrote:
> > [adding Linus and Alexandre to the cc list]
> >
> > Hello Krzysztof,
> >
> > On 10/29/2014 11:42 AM, Krzysztof Koz
Hello Krzysztof,
On 10/30/2014 01:53 PM, Krzysztof Kozlowski wrote:
>
> To me a intuitive structure would be:
> MFD device
> |
> - clock device
> |
> - clock1
> - clock2
> - regulator device
> |
> - LDO1
> - LDO2
> etc.
>
> This also maps to structure in DTS.
Hi, and thanks for bringing this issue to us!
On Wed, Oct 29, 2014 at 7:49 PM, Javier Martinez Canillas
wrote:
> [adding Linus and Alexandre to the cc list]
>
> Hello Krzysztof,
>
> On 10/29/2014 11:42 AM, Krzysztof Kozlowski wrote:
>> On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote:
DP PHY now require pmu-system-controller to handle PMU register
to control PHY's power isolation. Adding the same to dp-phy
node.
Signed-off-by: Vivek Gautam
Cc: Jingoo Han
---
Changes from V1:
- none.
arch/arm/boot/dts/exynos5250.dtsi |2 +-
arch/arm/boot/dts/exynos5420.dtsi |4 ++--
Now that we have moved to generic phy based bindings,
we don't need to have any code related to older dptx-phy.
Nobody is using this dptx-phy anymore, so removing the
same.
Signed-off-by: Vivek Gautam
Cc: Inki Dae
Cc: Jingoo Han
---
Changes from V1:
- Reworked error handling in exynos_dp_dt_p
Hi Inki,
On Thu, Oct 30, 2014 at 5:50 PM, Inki Dae wrote:
>
> Sorry for late. I missed this patch a little bit for long time.
Thanks for reviewing.
>
>
> On 2014년 09월 15일 22:13, Vivek Gautam wrote:
>> Now that we have moved to generic phy based bindings,
>> we don't need to have any code relat
On 2014년 10월 30일 21:36, Andrzej Hajda wrote:
> On 09/10/2014 01:53 PM, Andrzej Hajda wrote:
>> The patch replaces separate calls to driver (de)registration by
>> loops over the array of drivers. As a result it significantly
>> decreases number of ifdefs. Additionally it moves device registration
>>
On 2014년 10월 30일 21:39, Andrzej Hajda wrote:
> On 10/07/2014 02:01 PM, Andrzej Hajda wrote:
>> Hi Inki,
>>
>> Many Exynos DRM drivers uses global variables to represent associated devices
>> in Exynos DRM internal framework. It is quite confusing, it adds data
>> duplication
>> and finally it does
On czw, 2014-10-30 at 13:42 +0100, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 10/30/2014 01:30 PM, Krzysztof Kozlowski wrote:
> tor_of_get_init_data() function?
> >> >
> >> > The regulator_of_get_init_data() searches from dev->of_node or its child
> >> > node.
> >> >
> >> > But de
Hello Krzysztof,
On 10/30/2014 01:30 PM, Krzysztof Kozlowski wrote:
tor_of_get_init_data() function?
>> >
>> > The regulator_of_get_init_data() searches from dev->of_node or its child
>> > node.
>> >
>> > But dev->of_node is NULL.
>> >
>> > That's why of_compatible is needed.
>>
>> Yes but reg
On 10/07/2014 02:01 PM, Andrzej Hajda wrote:
> Hi Inki,
>
> Many Exynos DRM drivers uses global variables to represent associated devices
> in Exynos DRM internal framework. It is quite confusing, it adds data
> duplication
> and finally it does not allow to handle more than one device in system.
On 09/10/2014 01:53 PM, Andrzej Hajda wrote:
> The patch replaces separate calls to driver (de)registration by
> loops over the array of drivers. As a result it significantly
> decreases number of ifdefs. Additionally it moves device registration
> related ifdefs to header file.
>
> Signed-off-by:
On czw, 2014-10-30 at 13:21 +0100, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 10/30/2014 01:10 PM, Krzysztof Kozlowski wrote:
> >>
> >> I may be missing something but I don't understand why a compatible string
> >> for the regulators sub-node is needed. Isn't enough to just fill th
On Thu 2014-10-30 13:02:49, Ulf Hansson wrote:
> Convert the prototype to return and int. This is just an initial step,
> needed to support error handling.
>
> Signed-off-by: Ulf Hansson
Acked-by: Pavel Machek
> ---
>
> This patch is intended as fix for 3.18 rc[n]. Why?
>
> There are other
Hello Krzysztof,
On 10/30/2014 01:10 PM, Krzysztof Kozlowski wrote:
>>
>> I may be missing something but I don't understand why a compatible string
>> for the regulators sub-node is needed. Isn't enough to just fill the
>> .regulators_node field in the struct regulator_desc? e.g:
>>
>> .regu
Sorry for late. I missed this patch a little bit for long time.
On 2014년 09월 15일 22:13, Vivek Gautam wrote:
> Now that we have moved to generic phy based bindings,
> we don't need to have any code related to older dptx-phy.
> Nobody is using this dptx-phy anymore, so removing the
> same.
>
> Si
On Thu, Oct 30, 2014 at 1:02 PM, Ulf Hansson wrote:
> Convert the prototype to return and int. This is just an initial step,
> needed to support error handling.
>
> Signed-off-by: Ulf Hansson
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven
On czw, 2014-10-30 at 12:50 +0100, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 10/30/2014 12:20 PM, Krzysztof Kozlowski wrote:
> > static int max77802_pmic_probe(struct platform_device *pdev)
> > {
> > struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent);
> > - stru
Convert the prototype to return and int. This is just an initial step,
needed to support error handling.
Signed-off-by: Ulf Hansson
---
This patch is intended as fix for 3.18 rc[n]. Why?
There are other SOC specific patches around that adds genpd support and which
implements the ->attach_dev()
Hello Krzysztof,
On 10/30/2014 12:20 PM, Krzysztof Kozlowski wrote:
> static int max77802_pmic_probe(struct platform_device *pdev)
> {
> struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent);
> - struct max77686_platform_data *pdata = dev_get_platdata(iodev->dev);
> stru
Hello Krzysztof,
On 10/30/2014 12:20 PM, Krzysztof Kozlowski wrote:
> The return value of regmap_read() of current opmode for regulator was
> silently ignored and whatever happened to be in 'val' variable was used
> as new opmode. This could lead to using bogus opmode.
>
> Don't ignore what regma
On 29 October 2014 22:10, Kevin Hilman wrote:
> Geert Uytterhoeven writes:
>
>> Hi Ulf, Rafael,
>>
>> On Tue, Oct 28, 2014 at 3:38 PM, Ulf Hansson wrote:
>>> Typically an ->attach_dev() callback would fetch some PM resourses.
>>>
>>> Those operations, like for example clk_get() may fail with dif
On 30 October 2014 00:53, Kevin Hilman wrote:
> Ulf Hansson writes:
>
>> To improve error handling while adding/removing devices from their PM
>> domains, we need to restructure the code a bit. Let's do this by moving
>> the device specific parts into a separate function.
>>
>> Signed-off-by: Ulf
The return value of regmap_read() of current opmode for regulator was
silently ignored and whatever happened to be in 'val' variable was used
as new opmode. This could lead to using bogus opmode.
Don't ignore what regmap_read() returns. If it fails just fall back to
normal opmode.
Signed-off-by:
On 30 October 2014 00:57, Kevin Hilman wrote:
> Ulf Hansson writes:
>
>> To improve error handling while adding/removing devices from their PM
>> domains, we need to restructure the code a bit. Let's do this by moving
>> the device specific parts into a separate function.
>>
>> Signed-off-by: Ulf
The driver is used only on Exynos based boards with DTS support.
Convert the driver to DTS-only version. Parse all regulators at once,
not one-by-one. Remove dependency on data provided by max77686 MFD
driver.
Use new DT style parsing method for regulators init data. The regulator
driver now shoul
The driver is used only on Exynos based boards with DTS support.
Convert the driver to DTS-only version. Parse all regulators at once,
not one-by-one. Remove dependency on data provided by max77686 MFD
driver.
Use new DT style parsing method for regulators init data. The regulator
driver now shoul
Minor nit: Initialize the opmode for each regulator to normal mode in a
readable explicit way.
Signed-off-by: Krzysztof Kozlowski
Suggested-by: Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas
---
drivers/regulator/max77686.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
The driver is used only on Exynos based boards with DTS support.
Convert the driver to DTS-only version. This simplifies a little the
code:
1. No dead (unused) entries in platform_data structure.
2. More code removed.
3. Regulator driver does not depend on allocated memory
from MFD driver.
4. It
Add of_compatible fields for max77686 and max77802 regulator drivers.
The driver's node should be the same as voltage-regulators node. This
simplifies parsing of regulators init data from DTS.
Signed-off-by: Krzysztof Kozlowski
---
drivers/mfd/max77686.c | 10 --
1 file changed, 8 insert
Document new required property for regulator driver: of_compatible. The
property allows MFD core to bind the driver to node with regulators and
this simplifies parsing regulators init data from DTS
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/mfd/max77686.txt | 7
Mixed indexes were used for array of opmodes in max77686_data structure:
id of regulator and index of regulator_desc array.
These indexes are exactly the same but the mixture may confuse. Use
consistently the id of regulator.
Signed-off-by: Krzysztof Kozlowski
---
drivers/regulator/max77686.c |
Document usage of gpio properties which turn on external/GPIO control
over regulator.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/mfd/max77686.txt | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ma
Document new required property for regulator driver: of_compatible.
The property allows MFD core to bind the driver to node with regulators
and this simplifies parsing regulators init data from DTS
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/regulator/max77802.txt |
Add enable control over GPIO for regulators supporting this: LDO20,
LDO21, LDO22, buck8 and buck9.
This is needed for proper (and full) configuration of the Maxim 77686
PMIC without creating redundant 'regulator-fixed' entries.
Signed-off-by: Krzysztof Kozlowski
---
drivers/regulator/max77686.c
Remove fixed regulators (duplicating what max77686 provides) and
add GPIO control to max77686 regulators. Add of_compatible to
voltage-regulators node.
This gives the system full control over those regulators. Previously
the state of such regulators was a mixture of what max77686 driver set
over I
Update to new bindings for max77802 regulator driver by adding proper
compatible field for regulators node.
Signed-off-by: Krzysztof Kozlowski
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/a
Update to new bindings for max77802 regulator driver by adding proper
compatible field for regulators node.
Signed-off-by: Krzysztof Kozlowski
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm
Hi,
Patches touching max77802 were not tested on hardware.
I am kindly asking for testing it because I don't have the board
with Maxim 77802.
Changes since v2
Re-work the board file support removal after Javier's comments: use
new DT style parsing. This imposes a lot of changes.
On 10/30/2014 08:36 AM, Krzysztof Kozlowski wrote:
> On śro, 2014-10-29 at 10:46 -0700, Kevin Hilman wrote:
>> Krzysztof Kozlowski writes:
>>
>>> When resuming the system the power domain has to be powered on early so
>>> any runtime PM aware devices could resume.
>>>
>>> This fixes following scen
On Thu, Oct 30, 2014 at 11:01:02AM +0100, Andrzej Hajda wrote:
> On 10/29/2014 10:14 AM, Thierry Reding wrote:
> > On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote:
> >> I think we nee try_get_module for the code and kref on the actual data
> >> structures.
> >
> > Agreed, that should
Hello Kukjin,
On Mon, Oct 20, 2014 at 11:05 PM, Javier Martinez Canillas
wrote:
> The regulator framework has a set of helpers functions to be used when
> the system is entering and leaving from suspend but these are not called
> on Exynos platforms. This means that the .set_suspend_* function ha
On 10/29/2014 10:14 AM, Thierry Reding wrote:
> On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote:
>> On Wed, Oct 29, 2014 at 09:38:23AM +0100, Thierry Reding wrote:
>>> On Wed, Oct 29, 2014 at 08:43:14AM +0100, Daniel Vetter wrote:
On Tue, Oct 28, 2014 at 03:35:50PM +0100, Thierry
As all these code has been moved into i2c driver, now we can
safely remove them from machine files.
CC: Russell King
Signed-off-by: Pankaj Dubey
---
arch/arm/mach-exynos/exynos.c | 39 ++-
arch/arm/mach-exynos/include/mach/map.h |3 ---
arch/arm/mach-
This patch series is moving i2c sys_cfg register configuration settings from
mach-exynos to i2c driver. It will help in removing soc_is_exynos kind of
macro usage from mach-exynos also it will help in removing static mapping of
SYS registers.
This series is based on latest kgene/for-next and on to
Let's handle i2c interrupt re-configuration in i2c driver. This will
help us in removing some soc specific checks from machine files and
will help in removing static iomapping of SYS register in exynos.c
Since only Exynos5250, and Exynos5420 has i2c nodes in DT, added syscon
based phandle to i2c d
On czw, 2014-10-30 at 00:41 +0100, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 10/29/2014 04:06 PM, Krzysztof Kozlowski wrote:
> >
> > static int max77802_pmic_probe(struct platform_device *pdev)
> > {
> > struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent);
> > -
On śro, 2014-10-29 at 10:46 -0700, Kevin Hilman wrote:
> Krzysztof Kozlowski writes:
>
> > When resuming the system the power domain has to be powered on early so
> > any runtime PM aware devices could resume.
> >
> > This fixes following scenario reproduced on Exynos DRM:
> > 1. Power domain is
56 matches
Mail list logo
