[PATCH] phy: exynos-mipi-video: Fixup the test for state->regmap

2015-02-25 Thread Axel Lin
syscon_regmap_lookup_by_phandle() returns ERR_PTR on error. Thus don't use null test against state->regmap. Signed-off-by: Axel Lin --- drivers/phy/phy-exynos-mipi-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-e

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Jaehoon Chung
Dear, Rob. On 02/25/2015 11:38 PM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> Implements HS400 mode support for exynos host driver. >> This also include some updates as new mode is added. >> >> Signed-off-by: Seungwon Jeon >> Signed-off

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Gwendal Grignou
Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal. On Wed, Feb 25, 2015 at 4:54 PM, Olof Johansson wrote: > On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: >> From: Bill Richardson >> >> This patch adds a device interface

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-25 Thread Olof Johansson
On Tue, Feb 17, 2015 at 07:26:50PM -0700, Simon Glass wrote: > Hi, > > On 16 February 2015 at 01:19, Javier Martinez Canillas > wrote: > > Hello Olof, > > > > On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: > >> Hello, > >> > >> The mainline ChromeOS Embedded Controller (EC) driver is sti

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-25 Thread Olof Johansson
On Mon, Feb 16, 2015 at 09:19:49AM +0100, Javier Martinez Canillas wrote: > Hello Olof, > > On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: > > Hello, > > > > The mainline ChromeOS Embedded Controller (EC) driver is still missing some > > features that are present in the downstream Chromi

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Olof Johansson
On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: > From: Bill Richardson > > This patch adds a device interface to access the > Chrome OS Embedded Controller from user-space. > > Signed-off-by: Bill Richardson > Reviewed-by: Simon Glass > Signed-off-by: Javier Martinez

Re: [RFC 1/3] i2c: Enhancement of i2c API to address circular lock dependency problem

2015-02-25 Thread Mike Turquette
Quoting Mark Brown (2015-01-18 05:41:24) > On Sun, Jan 18, 2015 at 11:54:56AM +0100, Krzysztof Kozlowski wrote: > > W dniu 18.01.2015 o 07:30, Tomasz Figa pisze: > > > >So, the question is, do we actually have hardware that _really_ > > >requires _actual_ preparation or all the clk_prepare_enable(

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 03:11:24PM -0400, Eduardo Valentin wrote: > On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: > > Explanation of several properties, which allow PWM fan working as a cooling > > device, have been embraced in this commit. > > > > Signed-off-by: Lukasz Majewski

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: > Explanation of several properties, which allow PWM fan working as a cooling > device, have been embraced in this commit. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename cooling-pwm-values to cooling-levels >

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 01:25:08PM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > Hi Lukasz, > > > > On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski > > wrote: > > > Hi Abhilash, > > > > > >> This patch fixes the wrong control of PD_DET_EN (power down > > >> detection mode) for Exynos7 becau

Re: [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:19PM +0100, Lukasz Majewski wrote: > With those bindings it is possible to use pwm-fan device available in > Odroid U3 as a cooling device. > > Signed-off-by: Lukasz Majewski Acked-by: Eduardo Valentin > --- > Changes for v2: > - Rename cooling-pwm-values property

Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Guenter Roeck
On Wed, Feb 25, 2015 at 02:29:18PM -0400, Eduardo Valentin wrote: > Guenter, > > On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote: > > On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote: > > > Presented patches add support for Odroid's U3 optional CPU FAN, which > > > us

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 02:28:15PM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: > > > With those bindings it is possible to use pwm-fan device available > > > in Odroid U3 as a cooling device. > > > > > > Signed-off-by: Lukasz

Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Eduardo Valentin
Guenter, On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote: > On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote: > > Presented patches add support for Odroid's U3 optional CPU FAN, which uses > > PWM > > subsystem for low level control. > > > > After successful probe it

Re: [PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
Hey Lukasz, On Wed, Feb 25, 2015 at 04:34:22PM +0100, Lukasz Majewski wrote: > The PWM FAN device can now be used as a thermal cooling device. Necessary > infrastructure has been added in this commit. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Replace pwm_fan_cooling_states w

Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Guenter Roeck
On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote: > Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM > subsystem for low level control. > > After successful probe it registers itself as a cooling device for thermal > subsystem. > > This driver also sup

Re: [v3] libdrm: improvements to userspace exynos component

2015-02-25 Thread Emil Velikov
On 24 February 2015 at 14:20, Tobias Jakobi wrote: > Hello, > > here are some miscellaneous improvements (small features, bugfixes, spelling > fixes, etc.) for the exynos component of libdrm. The general idea is to let > userspace use the G2D engine functionality more > efficiently. > > If someo

[PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-25 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski --- Changes for v2: - None Changes for v3: -

[PATCH] drm: exynos: clean up dma_addr_t use

2015-02-25 Thread Arnd Bergmann
dma_addr_t may be 32 or 64 bits long on 32-bit CPUs, so we cannot cast it to a pointer without getting a compiler warning: drivers/gpu/drm/exynos/exynos_drm_buf.c: In function 'lowlevel_buffer_allocate': drivers/gpu/drm/exynos/exynos_drm_buf.c:109:18: warning: cast from pointer to integer of diff

[PATCH v5 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-25 Thread Lukasz Majewski
From: Kamil Debski Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the "pwm" label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski Signed-off-by: Lukasz Majewski --- Changes since v1: - added pwm label to the

[PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove default-pulse-width property and stick to default hwmon policy Changes f

[PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Lukasz Majewski
Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM subsystem for low level control. After successful probe it registers itself as a cooling device for thermal subsystem. This driver also supports devices without DTS specified. To provide correct functionality, new pro

[PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3: - Change patch's topic to "ARM dts" - Reduce maximal cooling-level to 230

[PATCH v5 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-25 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz Ma

[PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-25 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski --- Changes for v2: - Replace pwm_fan_cooling_states with pwm_fan_cooling_levels - Update ctx->pwm_fan_state when correct data from device tree is

Re: [PATCH v4 2/8] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-02-25 Thread Arnd Bergmann
On Tuesday 24 February 2015 20:04:17 Chanwoo Choi wrote: > On 02/24/2015 06:48 PM, Arnd Bergmann wrote: > > On Tuesday 24 February 2015 17:52:01 Chanwoo Choi wrote: > >> > >> But, I have a question. > >> If we put the aliases into the board dts file instaed of SoC dtsi, > >> each board dts file may

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Rob Herring
On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > Implements HS400 mode support for exynos host driver. > This also include some updates as new mode is added. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > [Alim: addressed review comments] > --- > .

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, > On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: > > With those bindings it is possible to use pwm-fan device available > > in Odroid U3 as a cooling device. > > > > Signed-off-by: Lukasz Majewski > > --- > > Changes for v2: > > - Rename cooling-pwm-values property

Re: [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, > On Wed, Feb 18, 2015 at 11:07:29AM +0100, Lukasz Majewski wrote: > > Odroid U3 fan can work without being registered as OF cooling device > > (with CONFIG_THERMAL_OF disabled). > > In this situation it can be controlled via PWM entry at > > /sys/class/hwmon/hwmon0/pwm1. > > > > Ther

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, > Hi Lukasz, > > On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski > wrote: > > Hi Abhilash, > > > >> This patch fixes the wrong control of PD_DET_EN (power down > >> detection mode) for Exynos7 because exynos7_tmu_control() always > >> enables the power down detection mode regardless

Re: [PATCH v5 8/9] ARM: dts: exynos5250: add display power domain

2015-02-25 Thread Javier Martinez Canillas
Hello Kukjin, On 02/19/2015 03:44 AM, Andreas Färber wrote: > Am 02.02.2015 um 14:20 schrieb Marek Szyprowski: >> From: Andrzej Hajda >> >> The patch adds domain definition and references to it in appropriate devices. >> >> Signed-off-by: Andrzej Hajda >> [mszyprow: rebased onto generic power

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Abhilash Kesavan
Hi Lukasz, On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski wrote: > Hi Abhilash, > >> This patch fixes the wrong control of PD_DET_EN (power down detection >> mode) for Exynos7 because exynos7_tmu_control() always enables the >> power down detection mode regardless 'on' parameter. >> >> Cc: Zhan

Re: [PATCH] ARM: fix exynos randconfig build error

2015-02-25 Thread Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King : > The following error was observed with SMP=n in v4.0-rc1: > > arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr': > arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function > 'arch_send_wakeup_ipi_mask' [-Werror=implicit-funct

[PATCH] ARM: fix exynos randconfig build error

2015-02-25 Thread Russell King
The following error was observed with SMP=n in v4.0-rc1: arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr': arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration] As the code unconditionally calls

Re: [PATCH] clk: samsung: Add CLKOUT driver support for Exynos3250 SoC.

2015-02-25 Thread Inha Song
Hi, Tomasz, Thanks for you comment :) On Wed, 25 Feb 2015 09:54:02 +0900 Tomasz Figa wrote: > Hi Inha, > > Thanks for the patch. Please see my comments inline. > > 2015-02-24 18:22 GMT+09:00 Inha Song : > > This patch add CLKOUT driver support for Exynos3250 SoC. > > Could you please add a l

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Lukasz Majewski
Hi Abhilash, > This patch fixes the wrong control of PD_DET_EN (power down detection > mode) for Exynos7 because exynos7_tmu_control() always enables the > power down detection mode regardless 'on' parameter. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Chanwoo Choi > --- > drive

[PATCH 2/2] ARM: multi_v7_defconfig: Enable CPU idle for Exynos

2015-02-25 Thread Krzysztof Kozlowski
Current Exynos CPU idle driver supports entering AFTR (Arm Off, Top Running) mode on Exynos 4210 (coupled), Exynos 4x12 and Exynos 5250. Enable it in default configuration to reduce energy consumption. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file chang

[PATCH 1/2] ARM: exynos_defconfig: Enable CPU idle

2015-02-25 Thread Krzysztof Kozlowski
Current Exynos CPU idle driver supports entering AFTR (Arm Off, Top Running) mode on Exynos 4210 (coupled), Exynos 4x12 and Exynos 5250. Enable it in default configuration to reduce energy consumption. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file change

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Alim Akhtar
Thanks Jaehoon, On Wed, Feb 25, 2015 at 12:04 PM, Jaehoon Chung wrote: > Hi, Alim. > > Tested-by: Jaehoon Chung > Acked-by: Jaehoon Chung > > I will include this patch into my tree, and i will request pull to Ulf. > If any rebase is required, I won't be able to do so until march 9th, hope you c